139290 2014-12-04 22:03:31 -0800 Fix build warning in WebCore/platform/graphics module 2014-12-05 02:29:09 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shiva.jm webkit-unassigned cgarcia commit-queue darin gyuyoung.kim kling mmaxfield oldest_to_newest 1052674 0 shiva.jm 2014-12-04 22:03:31 -0800 fix build warning in: [3342/5071] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/JSRTCDataChannelEvent.cpp.o ../../Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp:115:15: warning: unused parameter ‘fontDescription’ [-Wunused-parameter] static String getFamilyNameStringFromFontDescriptionAndFamily(const FontDescription& fontDescription, const AtomicString& family) ^ 1052676 1 242617 shiva.jm 2014-12-04 22:07:46 -0800 Created attachment 242617 Patch Fix a build warning by removing parameter name from function. 1052677 2 shiva.jm 2014-12-04 22:16:42 -0800 Might be caused by patch from bug: https://bugs.webkit.org/show_bug.cgi?id=139207 1052684 3 242617 cgarcia 2014-12-04 23:26:21 -0800 Comment on attachment 242617 Patch getFamilyNameStringFromFontDescriptionAndFamily() is a private function, we should change it instead. If the font description is no longer used, the name is not true. So, I think it would be better to rename the function as something like getFamilyNameStringFromFamily() and remove the FontDescription parameter. 1052696 4 242623 shiva.jm 2014-12-05 01:05:29 -0800 Created attachment 242623 Patch-Updated-Review1 updated the patch as per comments 1052698 5 242623 commit-queue 2014-12-05 02:29:03 -0800 Comment on attachment 242623 Patch-Updated-Review1 Clearing flags on attachment: 242623 Committed r176840: <http://trac.webkit.org/changeset/176840> 1052699 6 commit-queue 2014-12-05 02:29:09 -0800 All reviewed patches have been landed. Closing bug. 242617 2014-12-04 22:07:46 -0800 2014-12-05 01:05:29 -0800 Patch bug-139290.patch text/plain 1601 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjgzNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTEyLTA0ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IGJ1aWxkIHdhcm5p bmcgaW4gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcyBtb2R1bGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTI5MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhIGJ1aWxkIHdhcm5pbmcgYnkgcmVt b3ZpbmcgcGFyYW1ldGVyIG5hbWUgZnJvbSBmdW5jdGlvbi4KKworICAgICAgICBObyBuZXcgdGVz dHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Zy ZWV0eXBlL0ZvbnRDYWNoZUZyZWVUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmdldEZhbWls eU5hbWVTdHJpbmdGcm9tRm9udERlc2NyaXB0aW9uQW5kRmFtaWx5KToKKwogMjAxNC0xMi0wMiAg QnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rvbi5lZHU+CiAKICAgICAgICAgV2ViIElu c3BlY3RvcjogdGltZWxpbmUgcHJvYmUgcmVjb3JkcyBoYXZlIGluYWNjdXJhdGUgcGVyLXByb2Jl IGhpdCBjb3VudHMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0 eXBlL0ZvbnRDYWNoZUZyZWVUeXBlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9Gb250Q2FjaGVGcmVlVHlwZS5jcHAJKHJldmlzaW9u IDE3NjgzMSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0Zv bnRDYWNoZUZyZWVUeXBlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEyLDcgKzExMiw3IEBAIHZv aWQgRm9udENhY2hlOjpnZXRUcmFpdHNJbkZhbWlseShjb25zdAogewogfQogCi1zdGF0aWMgU3Ry aW5nIGdldEZhbWlseU5hbWVTdHJpbmdGcm9tRm9udERlc2NyaXB0aW9uQW5kRmFtaWx5KGNvbnN0 IEZvbnREZXNjcmlwdGlvbiYgZm9udERlc2NyaXB0aW9uLCBjb25zdCBBdG9taWNTdHJpbmcmIGZh bWlseSkKK3N0YXRpYyBTdHJpbmcgZ2V0RmFtaWx5TmFtZVN0cmluZ0Zyb21Gb250RGVzY3JpcHRp b25BbmRGYW1pbHkoY29uc3QgRm9udERlc2NyaXB0aW9uJiwgY29uc3QgQXRvbWljU3RyaW5nJiBm YW1pbHkpCiB7CiAgICAgLy8gSWYgd2UncmUgY3JlYXRpbmcgYSBmYWxsYmFjayBmb250IChlLmcu ICItd2Via2l0LW1vbm9zcGFjZSIpLCBjb252ZXJ0IHRoZSBuYW1lIGludG8KICAgICAvLyB0aGUg ZmFsbGJhY2sgbmFtZSAobGlrZSAibW9ub3NwYWNlIikgdGhhdCBmb250Y29uZmlnIHVuZGVyc3Rh bmRzLgo= 242623 2014-12-05 01:05:29 -0800 2014-12-05 02:29:03 -0800 Patch-Updated-Review1 bug-139290-updated.patch text/plain 2165 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjgzNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTEyLTA0ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IGJ1aWxkIHdhcm5p bmcgaW4gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcyBtb2R1bGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTI5MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhIGJ1aWxkIHdhcm5pbmcgYnkgcmVt b3ZpbmcgcGFyYW1ldGVyIG5hbWUgZnJvbSBmdW5jdGlvbi4KKworICAgICAgICBObyBuZXcgdGVz dHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Zy ZWV0eXBlL0ZvbnRDYWNoZUZyZWVUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmdldEZhbWls eU5hbWVTdHJpbmdGcm9tRm9udERlc2NyaXB0aW9uQW5kRmFtaWx5KToKKwogMjAxNC0xMi0wMiAg QnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rvbi5lZHU+CiAKICAgICAgICAgV2ViIElu c3BlY3RvcjogdGltZWxpbmUgcHJvYmUgcmVjb3JkcyBoYXZlIGluYWNjdXJhdGUgcGVyLXByb2Jl IGhpdCBjb3VudHMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0 eXBlL0ZvbnRDYWNoZUZyZWVUeXBlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9Gb250Q2FjaGVGcmVlVHlwZS5jcHAJKHJldmlzaW9u IDE3NjgzMSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0Zv bnRDYWNoZUZyZWVUeXBlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEyLDcgKzExMiw3IEBAIHZv aWQgRm9udENhY2hlOjpnZXRUcmFpdHNJbkZhbWlseShjb25zdAogewogfQogCi1zdGF0aWMgU3Ry aW5nIGdldEZhbWlseU5hbWVTdHJpbmdGcm9tRm9udERlc2NyaXB0aW9uQW5kRmFtaWx5KGNvbnN0 IEZvbnREZXNjcmlwdGlvbiYgZm9udERlc2NyaXB0aW9uLCBjb25zdCBBdG9taWNTdHJpbmcmIGZh bWlseSkKK3N0YXRpYyBTdHJpbmcgZ2V0RmFtaWx5TmFtZVN0cmluZ0Zyb21GYW1pbHkoY29uc3Qg QXRvbWljU3RyaW5nJiBmYW1pbHkpCiB7CiAgICAgLy8gSWYgd2UncmUgY3JlYXRpbmcgYSBmYWxs YmFjayBmb250IChlLmcuICItd2Via2l0LW1vbm9zcGFjZSIpLCBjb252ZXJ0IHRoZSBuYW1lIGlu dG8KICAgICAvLyB0aGUgZmFsbGJhY2sgbmFtZSAobGlrZSAibW9ub3NwYWNlIikgdGhhdCBmb250 Y29uZmlnIHVuZGVyc3RhbmRzLgpAQCAtMTY1LDcgKzE2NSw3IEBAIHN0ZDo6dW5pcXVlX3B0cjxG b250UGxhdGZvcm1EYXRhPiBGb250Q2EKICAgICAvLyBzYXlzIHRoYXQgd2UgbXVzdCBmaW5kIGFu IGV4YWN0IG1hdGNoIGZvciBmb250IGZhbWlseSwgc2xhbnQgKGl0YWxpYyBvciBvYmxpcXVlIGNh biBiZSB1c2VkKQogICAgIC8vIGFuZCBmb250IHdlaWdodCAod2Ugb25seSBtYXRjaCBib2xkL25v bi1ib2xkIGhlcmUpLgogICAgIFJlZlB0cjxGY1BhdHRlcm4+IHBhdHRlcm4gPSBhZG9wdFJlZihG Y1BhdHRlcm5DcmVhdGUoKSk7Ci0gICAgU3RyaW5nIGZhbWlseU5hbWVTdHJpbmcoZ2V0RmFtaWx5 TmFtZVN0cmluZ0Zyb21Gb250RGVzY3JpcHRpb25BbmRGYW1pbHkoZm9udERlc2NyaXB0aW9uLCBm YW1pbHkpKTsKKyAgICBTdHJpbmcgZmFtaWx5TmFtZVN0cmluZyhnZXRGYW1pbHlOYW1lU3RyaW5n RnJvbUZhbWlseShmYW1pbHkpKTsKICAgICBpZiAoIUZjUGF0dGVybkFkZFN0cmluZyhwYXR0ZXJu LmdldCgpLCBGQ19GQU1JTFksIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgRmNDaGFyOCo+KGZhbWls eU5hbWVTdHJpbmcudXRmOCgpLmRhdGEoKSkpKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAo=