139286 2014-12-04 21:13:08 -0800 FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY 2014-12-05 09:55:06 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.8 RESOLVED FIXED P2 Normal --- 138813 1 ddkilzer ddkilzer burg commit-queue dbates ddkilzer dino mrowe thorton oldest_to_newest 1052665 0 ddkilzer 2014-12-04 21:13:08 -0800 Xcode 5.1.1 has a bug where using an SDK selector ([sdk=macosx*]) on the LHS of a variable definition and a sub-variable expression on the RHS causes the entire expression to be ignored. In other words, when building with Xcode 5.1.1 on 10.8, this line in FeatureDefines.xcconfig is completely ignored: ENABLE_WEB_REPLAY[sdk=macosx*] = $(ENABLE_WEB_REPLAY_macosx_$(CONFIGURATION)); The workaround is to switch back to using PLATFORM_NAME and remove the SDK selector as long as 10.8 is supported. 1052668 1 242615 ddkilzer 2014-12-04 21:19:14 -0800 Created attachment 242615 Patch v1 1052750 2 242615 commit-queue 2014-12-05 09:55:03 -0800 Comment on attachment 242615 Patch v1 Clearing flags on attachment: 242615 Committed r176846: <http://trac.webkit.org/changeset/176846> 1052751 3 commit-queue 2014-12-05 09:55:06 -0800 All reviewed patches have been landed. Closing bug. 242615 2014-12-04 21:19:14 -0800 2014-12-05 09:55:03 -0800 Patch v1 bug-139286-20141204211948.patch text/plain 6692 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2ODMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj N2Y4YTlhNzQ0OWUwMmVhY2JiNmQ5NzIwYjE1YjQyNzJiNzkxMWUxLi5mYWU4YWIzOGZiNjg5MGYy YjlmNTYyMTkyOGExZGVhZDBhZTc4NDE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNC0xMi0wNCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIEZlYXR1cmVEZWZpbmVzLnhjY29uZmlnOiBXb3JrYXJvdW5kIGJ1ZyBpbiBY Y29kZSA1LjEuMSB3aGVuIGRlZmluaW5nIEVOQUJMRV9XRUJfUkVQTEFZCisgICAgICAgIDxodHRw Oi8vd2Via2l0Lm9yZy9iLzEzOTI4Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmln OiBTd2l0Y2ggYmFjayB0byB1c2luZworICAgICAgICBQTEFURk9STV9OQU1FIHRvIHdvcmthcm91 bmQgYSBidWcgaW4gWGNvZGUgNS4xLjEgb24gMTAuOC4KKwogMjAxNC0xMi0wNCAgRmlsaXAgUGl6 bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIHByaW50SW50ZXJuYWwoUHJpbnRTdHJl YW0mIG91dCwgSlNDOjpKSVRDb2RlOjpKSVRUeXBlIHR5cGUpIGVuZHMgdXAgZHVtcGluZyBhIGxp dGVyYWwgJXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2N2ExYWE5NjQ5ZTY3ZGRiYzY3MmVjZWE1OGQ0ZDJjNDll ZWMzZDQxLi5iMDk5MDkzN2VkMTNjZjBhYzllNmVkNjFhMzE2MWViNjEyMWRjZTI3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMTItMDQgIERhdmlkIEtpbHplciAgPGRka2lsemVy QGFwcGxlLmNvbT4KKworICAgICAgICBGZWF0dXJlRGVmaW5lcy54Y2NvbmZpZzogV29ya2Fyb3Vu ZCBidWcgaW4gWGNvZGUgNS4xLjEgd2hlbiBkZWZpbmluZyBFTkFCTEVfV0VCX1JFUExBWQorICAg ICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMzkyODY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9GZWF0dXJlRGVmaW5l cy54Y2NvbmZpZzogU3dpdGNoIGJhY2sgdG8gdXNpbmcKKyAgICAgICAgUExBVEZPUk1fTkFNRSB0 byB3b3JrYXJvdW5kIGEgYnVnIGluIFhjb2RlIDUuMS4xIG9uIDEwLjguCisKIDIwMTQtMTItMDIg IEJyaWFuIEouIEJ1cmcgIDxidXJnQGNzLndhc2hpbmd0b24uZWR1PgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IHRpbWVsaW5lIHByb2JlIHJlY29yZHMgaGF2ZSBpbmFjY3VyYXRlIHBlci1wcm9i ZSBoaXQgY291bnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggZmI3MjNlMjdhNmY4NDY2ZGQ1Yjc0ZWY3 YzI4OGNmMDlmMTM1NWFhYi4uMWEzNDIxN2MyNDdkZTQyY2YyMGZhNzAxZjQwMzMxYTllYWY4ZWQ5 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTEyLTA0ICBEYXZpZCBL aWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgRmVhdHVyZURlZmluZXMueGNj b25maWc6IFdvcmthcm91bmQgYnVnIGluIFhjb2RlIDUuMS4xIHdoZW4gZGVmaW5pbmcgRU5BQkxF X1dFQl9SRVBMQVkKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTM5Mjg2PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ29uZmlndXJhdGlv bnMvRmVhdHVyZURlZmluZXMueGNjb25maWc6IFN3aXRjaCBiYWNrIHRvIHVzaW5nCisgICAgICAg IFBMQVRGT1JNX05BTUUgdG8gd29ya2Fyb3VuZCBhIGJ1ZyBpbiBYY29kZSA1LjEuMSBvbiAxMC44 LgorCiAyMDE0LTEyLTA0ICBUaW1vdGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNv bT4KIAogICAgICAgICBGaXggdGhlIDMyLWJpdCBidWlsZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBkYjYxZjUx YWM0NDNiOThkZjFlMDM0YmNhZTVmMjBjYTU5YmQ0MGU4Li5mNDRjZTdmYzM3ODFkMmYzZjY2NjBh MDQxZDFlMDAzNGM4OTg4ZDMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMTIt MDQgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBGZWF0dXJl RGVmaW5lcy54Y2NvbmZpZzogV29ya2Fyb3VuZCBidWcgaW4gWGNvZGUgNS4xLjEgd2hlbiBkZWZp bmluZyBFTkFCTEVfV0VCX1JFUExBWQorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMzky ODY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBD b25maWd1cmF0aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2NvbmZpZzogU3dpdGNoIGJhY2sgdG8gdXNp bmcKKyAgICAgICAgUExBVEZPUk1fTkFNRSB0byB3b3JrYXJvdW5kIGEgYnVnIGluIFhjb2RlIDUu MS4xIG9uIDEwLjguCisKIDIwMTQtMTItMDQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgbWlzc2luZyBpbmNsdWRlcyBpbiBwcmVwYXJhdGlvbiBm b3IgbWFraW5nIHRvQVBJIHJlcXVpcmUgdGhhdCBpdCdzIHBhc3NlZCBhbiBBUEk6Ok9iamVjdApk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL0ZlYXR1cmVE ZWZpbmVzLnhjY29uZmlnIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL0Zl YXR1cmVEZWZpbmVzLnhjY29uZmlnCmluZGV4IGMzN2EzMzYzOTcwMzdmNjJlZDJjYjg1YWQ1NDEy NzQ4ZTg0ZjZjYmYuLmY0NDFhODllZDgwOGI1ZWE0OWM5MmU3NTAwNmE1OTVhMDRlNjNmNjUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9GZWF0dXJlRGVm aW5lcy54Y2NvbmZpZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMv RmVhdHVyZURlZmluZXMueGNjb25maWcKQEAgLTE5OCwxMCArMTk4LDkgQEAgRU5BQkxFX0RBVEFD VUVfVkFMVUUgPSBFTkFCTEVfREFUQUNVRV9WQUxVRTsKIEVOQUJMRV9WSUVXX01PREVfQ1NTX01F RElBID0gOwogRU5BQkxFX1dFQkdMID0gRU5BQkxFX1dFQkdMOwogRU5BQkxFX1dFQl9BVURJTyA9 IEVOQUJMRV9XRUJfQVVESU87Ci1FTkFCTEVfV0VCX1JFUExBWVtzZGs9bWFjb3N4Kl0gPSAkKEVO QUJMRV9XRUJfUkVQTEFZX21hY29zeF8kKENPTkZJR1VSQVRJT04pKTsKK0VOQUJMRV9XRUJfUkVQ TEFZID0gJChFTkFCTEVfV0VCX1JFUExBWV8kKFBMQVRGT1JNX05BTUUpXyQoQ09ORklHVVJBVElP TikpOwogRU5BQkxFX1dFQl9SRVBMQVlfbWFjb3N4X0RlYnVnID0gRU5BQkxFX1dFQl9SRVBMQVk7 CiBFTkFCTEVfV0VCX1JFUExBWV9tYWNvc3hfUmVsZWFzZSA9IEVOQUJMRV9XRUJfUkVQTEFZOwot RU5BQkxFX1dFQl9SRVBMQVlfbWFjb3N4X1Byb2R1Y3Rpb24gPSA7CiBFTkFCTEVfV0VCX1NPQ0tF VFMgPSBFTkFCTEVfV0VCX1NPQ0tFVFM7CiAKIEVOQUJMRV9XRUJfVElNSU5HW3Nkaz1pcGhvbmUq XSA9IEVOQUJMRV9XRUJfVElNSU5HOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ29uZmln dXJhdGlvbnMvRmVhdHVyZURlZmluZXMueGNjb25maWcgYi9Tb3VyY2UvV2ViQ29yZS9Db25maWd1 cmF0aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwppbmRleCBjMzdhMzM2Mzk3MDM3ZjYyZWQy Y2I4NWFkNTQxMjc0OGU4NGY2Y2JmLi5mNDQxYTg5ZWQ4MDhiNWVhNDljOTJlNzUwMDZhNTk1YTA0 ZTYzZjY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9GZWF0dXJl RGVmaW5lcy54Y2NvbmZpZworKysgYi9Tb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9GZWF0 dXJlRGVmaW5lcy54Y2NvbmZpZwpAQCAtMTk4LDEwICsxOTgsOSBAQCBFTkFCTEVfREFUQUNVRV9W QUxVRSA9IEVOQUJMRV9EQVRBQ1VFX1ZBTFVFOwogRU5BQkxFX1ZJRVdfTU9ERV9DU1NfTUVESUEg PSA7CiBFTkFCTEVfV0VCR0wgPSBFTkFCTEVfV0VCR0w7CiBFTkFCTEVfV0VCX0FVRElPID0gRU5B QkxFX1dFQl9BVURJTzsKLUVOQUJMRV9XRUJfUkVQTEFZW3Nkaz1tYWNvc3gqXSA9ICQoRU5BQkxF X1dFQl9SRVBMQVlfbWFjb3N4XyQoQ09ORklHVVJBVElPTikpOworRU5BQkxFX1dFQl9SRVBMQVkg PSAkKEVOQUJMRV9XRUJfUkVQTEFZXyQoUExBVEZPUk1fTkFNRSlfJChDT05GSUdVUkFUSU9OKSk7 CiBFTkFCTEVfV0VCX1JFUExBWV9tYWNvc3hfRGVidWcgPSBFTkFCTEVfV0VCX1JFUExBWTsKIEVO QUJMRV9XRUJfUkVQTEFZX21hY29zeF9SZWxlYXNlID0gRU5BQkxFX1dFQl9SRVBMQVk7Ci1FTkFC TEVfV0VCX1JFUExBWV9tYWNvc3hfUHJvZHVjdGlvbiA9IDsKIEVOQUJMRV9XRUJfU09DS0VUUyA9 IEVOQUJMRV9XRUJfU09DS0VUUzsKIAogRU5BQkxFX1dFQl9USU1JTkdbc2RrPWlwaG9uZSpdID0g RU5BQkxFX1dFQl9USU1JTkc7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9Db25maWd1 cmF0aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2NvbmZpZyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NvbmZp Z3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmlnCmluZGV4IGMzN2EzMzYzOTcwMzdmNjJl ZDJjYjg1YWQ1NDEyNzQ4ZTg0ZjZjYmYuLmY0NDFhODllZDgwOGI1ZWE0OWM5MmU3NTAwNmE1OTVh MDRlNjNmNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL0NvbmZpZ3VyYXRpb25zL0Zl YXR1cmVEZWZpbmVzLnhjY29uZmlnCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NvbmZpZ3VyYXRp b25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmlnCkBAIC0xOTgsMTAgKzE5OCw5IEBAIEVOQUJMRV9E QVRBQ1VFX1ZBTFVFID0gRU5BQkxFX0RBVEFDVUVfVkFMVUU7CiBFTkFCTEVfVklFV19NT0RFX0NT U19NRURJQSA9IDsKIEVOQUJMRV9XRUJHTCA9IEVOQUJMRV9XRUJHTDsKIEVOQUJMRV9XRUJfQVVE SU8gPSBFTkFCTEVfV0VCX0FVRElPOwotRU5BQkxFX1dFQl9SRVBMQVlbc2RrPW1hY29zeCpdID0g JChFTkFCTEVfV0VCX1JFUExBWV9tYWNvc3hfJChDT05GSUdVUkFUSU9OKSk7CitFTkFCTEVfV0VC X1JFUExBWSA9ICQoRU5BQkxFX1dFQl9SRVBMQVlfJChQTEFURk9STV9OQU1FKV8kKENPTkZJR1VS QVRJT04pKTsKIEVOQUJMRV9XRUJfUkVQTEFZX21hY29zeF9EZWJ1ZyA9IEVOQUJMRV9XRUJfUkVQ TEFZOwogRU5BQkxFX1dFQl9SRVBMQVlfbWFjb3N4X1JlbGVhc2UgPSBFTkFCTEVfV0VCX1JFUExB WTsKLUVOQUJMRV9XRUJfUkVQTEFZX21hY29zeF9Qcm9kdWN0aW9uID0gOwogRU5BQkxFX1dFQl9T T0NLRVRTID0gRU5BQkxFX1dFQl9TT0NLRVRTOwogCiBFTkFCTEVfV0VCX1RJTUlOR1tzZGs9aXBo b25lKl0gPSBFTkFCTEVfV0VCX1RJTUlORzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0Nv bmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmlnIGIvU291cmNlL1dlYktpdDIvQ29u ZmlndXJhdGlvbnMvRmVhdHVyZURlZmluZXMueGNjb25maWcKaW5kZXggYzM3YTMzNjM5NzAzN2Y2 MmVkMmNiODVhZDU0MTI3NDhlODRmNmNiZi4uZjQ0MWE4OWVkODA4YjVlYTQ5YzkyZTc1MDA2YTU5 NWEwNGU2M2Y2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ29uZmlndXJhdGlvbnMvRmVh dHVyZURlZmluZXMueGNjb25maWcKKysrIGIvU291cmNlL1dlYktpdDIvQ29uZmlndXJhdGlvbnMv RmVhdHVyZURlZmluZXMueGNjb25maWcKQEAgLTE5OCwxMCArMTk4LDkgQEAgRU5BQkxFX0RBVEFD VUVfVkFMVUUgPSBFTkFCTEVfREFUQUNVRV9WQUxVRTsKIEVOQUJMRV9WSUVXX01PREVfQ1NTX01F RElBID0gOwogRU5BQkxFX1dFQkdMID0gRU5BQkxFX1dFQkdMOwogRU5BQkxFX1dFQl9BVURJTyA9 IEVOQUJMRV9XRUJfQVVESU87Ci1FTkFCTEVfV0VCX1JFUExBWVtzZGs9bWFjb3N4Kl0gPSAkKEVO QUJMRV9XRUJfUkVQTEFZX21hY29zeF8kKENPTkZJR1VSQVRJT04pKTsKK0VOQUJMRV9XRUJfUkVQ TEFZID0gJChFTkFCTEVfV0VCX1JFUExBWV8kKFBMQVRGT1JNX05BTUUpXyQoQ09ORklHVVJBVElP TikpOwogRU5BQkxFX1dFQl9SRVBMQVlfbWFjb3N4X0RlYnVnID0gRU5BQkxFX1dFQl9SRVBMQVk7 CiBFTkFCTEVfV0VCX1JFUExBWV9tYWNvc3hfUmVsZWFzZSA9IEVOQUJMRV9XRUJfUkVQTEFZOwot RU5BQkxFX1dFQl9SRVBMQVlfbWFjb3N4X1Byb2R1Y3Rpb24gPSA7CiBFTkFCTEVfV0VCX1NPQ0tF VFMgPSBFTkFCTEVfV0VCX1NPQ0tFVFM7CiAKIEVOQUJMRV9XRUJfVElNSU5HW3Nkaz1pcGhvbmUq XSA9IEVOQUJMRV9XRUJfVElNSU5HOwo=