139276 2014-12-04 16:13:10 -0800 Web Inspector: Uncaught Exceptions when attempting to show Content Flow 2014-12-05 10:57:38 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 burg joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1052608 0 burg 2014-12-04 16:13:10 -0800 Test case: <!DOCTYPE html> <html> <body> <script> function test() { setTimeout(function() {}, 100); } eval(test.toString() + "\n//@ sourceURL= foo.js"); test(); </script> </body> </html> 1. Open the inspector 2. Resources 3. See test.html in the content view (Source Code or DOM) 4. Click "test.html" in the navigation area, and select "Extra Scripts" file:///Users/burg/repos/webkit/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/ContentView.js:130:38: CONSOLE ERROR TypeError: undefined is not a valid argument for 'instanceof' (evaluating 'representedObject instanceof WebInspector.LegacyJavaScriptProfileObject') 1052609 1 webkit-bug-importer 2014-12-04 16:13:27 -0800 <rdar://problem/19150581> 1052630 2 joepeck 2014-12-04 17:18:03 -0800 That doesn't sound like an assertion, that sounds like an uncaught exception! WebInspector.LegacyJavaScriptProfileObject doesn't exist. This is blocking creating content views for anything later on (like ContentFlow). Should be easy to fix. 1052632 3 joepeck 2014-12-04 17:23:29 -0800 Hmm, I don't know how you hit the exception with those steps to reproduce, but this patch should fix the issue. 1052633 4 242602 joepeck 2014-12-04 17:23:46 -0800 Created attachment 242602 [PATCH] Proposed Fix 1052634 5 joepeck 2014-12-04 17:27:08 -0800 * STEPS TO REPRODUCE 1. Inspect <http://umaar.github.io/css-region-demo/> 2. Select the "example-1" Content Flow in the sidebar => nothing happens, uncaught exception 1052635 6 242602 joepeck 2014-12-04 17:29:08 -0800 Comment on attachment 242602 [PATCH] Proposed Fix Better fix coming that will actually allow us to show content flows. 1052638 7 242603 joepeck 2014-12-04 17:37:07 -0800 Created attachment 242603 [PATCH] Proposed Fix Fixes all the uncaught exceptions. Unfortunately there are issues showing the DOM Tree of some of these Content Flows, so more bugs are in order. 1052640 8 242604 joepeck 2014-12-04 17:43:28 -0800 Created attachment 242604 [PATCH] Proposed Fix - Better ChangeLog 1052755 9 242604 burg 2014-12-05 10:06:18 -0800 Comment on attachment 242604 [PATCH] Proposed Fix - Better ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=242604&action=review > Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js:240 > + parentTreeElement.insertChild(childTreeElement, insertionIndexForObjectInListSortedByFunction(childTreeElement, parentTreeElement.children, this.compareChildTreeElements.bind(this))); Is there an eslint rule that can figure out this was missing, if the callback is not defined inline? (In this case it seems like it might be harder, and certainly not possible for arbitrary property bindings. But we don't do too much in the way of dynamically binding functions to properties) 1052770 10 242604 commit-queue 2014-12-05 10:47:37 -0800 Comment on attachment 242604 [PATCH] Proposed Fix - Better ChangeLog Clearing flags on attachment: 242604 Committed r176853: <http://trac.webkit.org/changeset/176853> 1052771 11 commit-queue 2014-12-05 10:47:41 -0800 All reviewed patches have been landed. Closing bug. 1052775 12 joepeck 2014-12-05 10:57:38 -0800 (In reply to comment #9) > Comment on attachment 242604 [details] > [PATCH] Proposed Fix - Better ChangeLog > > View in context: > https://bugs.webkit.org/attachment.cgi?id=242604&action=review > > > Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js:240 > > + parentTreeElement.insertChild(childTreeElement, insertionIndexForObjectInListSortedByFunction(childTreeElement, parentTreeElement.children, this.compareChildTreeElements.bind(this))); > > Is there an eslint rule that can figure out this was missing, if the > callback is not defined inline? (In this case it seems like it might be > harder, and certainly not possible for arbitrary property bindings. But we > don't do too much in the way of dynamically binding functions to properties) Hmm, I'm not sure. If ESLint can jump from the token "compareChildTreeElements" to the definition of it then yes it could. But I don't think ESLint can do that right now. The rules I see it having "no-extra-bind" work on FunctionExpressions, it doesn't check for Properties and jump to analyzing the AST where that property was assigned / declared. 242602 2014-12-04 17:23:46 -0800 2014-12-04 17:37:07 -0800 [PATCH] Proposed Fix fix-exception.patch text/plain 2189 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdkYjU1NGIuLjA2YzBkYTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE0LTEyLTA0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogdW5jYXVn aHQgZXhjZXB0aW9uIHdoZW4gc3dpdGNoaW5nIHRvICJFeHRyYSBTY3JpcHRzIiBuYXZpZ2F0aW9u IGl0ZW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz OTI3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5Db250ZW50Vmlldyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29udGVudFZpZXcuaXNWaWV3 YWJsZSk6CisgICAgICAgIExlZ2FjeUphdmFTY3JpcHRQcm9maWxlT2JqZWN0IG5vIGxvbmdlciBl eGlzdHMsIHRoZXNlIHJlZmVyZW5jZXMgc2hvdWxkIGJlIHJlbW92ZWQuCisKKzIwMTQtMTItMDQg IEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5z cGVjdG9yOiBzZWxlY3RpbmcgUGFpbnQgdGltZWxpbmUgcmVjb3JkcyBmcm9tIHNpZGViYXIgZG9l cyBub3QgdHJpZ2dlciBwcmV2aWV3IG9mIHBhaW50IHF1YWQKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTE1MQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50Vmlldy5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRWaWV3LmpzCmluZGV4 IDY5MWY4M2EuLjZkNzg0YTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRWaWV3LmpzCkBAIC02OSw5ICs2OSw2IEBAIFdl Ykluc3BlY3Rvci5Db250ZW50VmlldyA9IGZ1bmN0aW9uKHJlcHJlc2VudGVkT2JqZWN0KQogICAg ICAgICBpZiAocmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuTG9nT2Jq ZWN0KQogICAgICAgICAgICAgcmV0dXJuIG5ldyBXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXco cmVwcmVzZW50ZWRPYmplY3QpOwogCi0gICAgICAgIGlmIChyZXByZXNlbnRlZE9iamVjdCBpbnN0 YW5jZW9mIFdlYkluc3BlY3Rvci5MZWdhY3lKYXZhU2NyaXB0UHJvZmlsZU9iamVjdCkKLSAgICAg ICAgICAgIHJldHVybiBuZXcgV2ViSW5zcGVjdG9yLkxlZ2FjeUphdmFTY3JpcHRQcm9maWxlVmll dyhyZXByZXNlbnRlZE9iamVjdCk7Ci0KICAgICAgICAgaWYgKHJlcHJlc2VudGVkT2JqZWN0IGlu c3RhbmNlb2YgV2ViSW5zcGVjdG9yLkNvbnRlbnRGbG93KQogICAgICAgICAgICAgcmV0dXJuIG5l dyBXZWJJbnNwZWN0b3IuQ29udGVudEZsb3dET01UcmVlQ29udGVudFZpZXcocmVwcmVzZW50ZWRP YmplY3QpOwogCkBAIC0xMjcsOCArMTI0LDYgQEAgV2ViSW5zcGVjdG9yLkNvbnRlbnRWaWV3Lmlz Vmlld2FibGUgPSBmdW5jdGlvbihyZXByZXNlbnRlZE9iamVjdCkKICAgICAgICAgcmV0dXJuIHRy dWU7CiAgICAgaWYgKHJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkxv Z09iamVjdCkKICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgaWYgKHJlcHJlc2VudGVkT2JqZWN0 IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkxlZ2FjeUphdmFTY3JpcHRQcm9maWxlT2JqZWN0KQot ICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICBpZiAocmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2Vv ZiBXZWJJbnNwZWN0b3IuQ29udGVudEZsb3cpCiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIGlm ICh0eXBlb2YgcmVwcmVzZW50ZWRPYmplY3QgPT09ICJzdHJpbmciIHx8IHJlcHJlc2VudGVkT2Jq ZWN0IGluc3RhbmNlb2YgU3RyaW5nKQo= 242603 2014-12-04 17:37:07 -0800 2014-12-04 17:43:28 -0800 [PATCH] Proposed Fix content-flow.patch text/plain 3476 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdkYjU1NGIuLjk4MmUyZjggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE0LTEyLTA0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgRXhjZXB0aW9ucyB3aGVuIGF0dGVtcHRpbmcgdG8gc2hvdyBDb250ZW50IEZsb3cKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTI3NgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9WaWV3cy9Db250ZW50Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db250ZW50Vmll dyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29udGVudFZpZXcuaXNWaWV3YWJsZSk6CisgICAg ICAgIExlZ2FjeUphdmFTY3JpcHRQcm9maWxlT2JqZWN0IG5vIGxvbmdlciBleGlzdHMsIHRoZXNl IHJlZmVyZW5jZXMgc2hvdWxkIGJlIHJlbW92ZWQuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL0ZvbGRlcml6ZWRUcmVlRWxlbWVudC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5G b2xkZXJpemVkVHJlZUVsZW1lbnQucHJvdG90eXBlLl9pbnNlcnRGb2xkZXJUcmVlRWxlbWVudCk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuRm9sZGVyaXplZFRyZWVFbGVtZW50LnByb3RvdHlwZS5f aW5zZXJ0Q2hpbGRUcmVlRWxlbWVudCk6CisgICAgICAgIFNvcnQgZnVuY3Rpb25zIG1heSByZWZl cmVuY2UgInRoaXMiIGFuZCBuZWVkZWQgdG8gYmUgYm91bmQuCisKKzIwMTQtMTItMDQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9y OiBzZWxlY3RpbmcgUGFpbnQgdGltZWxpbmUgcmVjb3JkcyBmcm9tIHNpZGViYXIgZG9lcyBub3Qg dHJpZ2dlciBwcmV2aWV3IG9mIHBhaW50IHF1YWQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTE1MQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRWaWV3LmpzCmluZGV4IDY5MWY4 M2EuLjZkNzg0YTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRWaWV3LmpzCkBAIC02OSw5ICs2OSw2IEBAIFdlYkluc3Bl Y3Rvci5Db250ZW50VmlldyA9IGZ1bmN0aW9uKHJlcHJlc2VudGVkT2JqZWN0KQogICAgICAgICBp ZiAocmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuTG9nT2JqZWN0KQog ICAgICAgICAgICAgcmV0dXJuIG5ldyBXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcocmVwcmVz ZW50ZWRPYmplY3QpOwogCi0gICAgICAgIGlmIChyZXByZXNlbnRlZE9iamVjdCBpbnN0YW5jZW9m IFdlYkluc3BlY3Rvci5MZWdhY3lKYXZhU2NyaXB0UHJvZmlsZU9iamVjdCkKLSAgICAgICAgICAg IHJldHVybiBuZXcgV2ViSW5zcGVjdG9yLkxlZ2FjeUphdmFTY3JpcHRQcm9maWxlVmlldyhyZXBy ZXNlbnRlZE9iamVjdCk7Ci0KICAgICAgICAgaWYgKHJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNl b2YgV2ViSW5zcGVjdG9yLkNvbnRlbnRGbG93KQogICAgICAgICAgICAgcmV0dXJuIG5ldyBXZWJJ bnNwZWN0b3IuQ29udGVudEZsb3dET01UcmVlQ29udGVudFZpZXcocmVwcmVzZW50ZWRPYmplY3Qp OwogCkBAIC0xMjcsOCArMTI0LDYgQEAgV2ViSW5zcGVjdG9yLkNvbnRlbnRWaWV3LmlzVmlld2Fi bGUgPSBmdW5jdGlvbihyZXByZXNlbnRlZE9iamVjdCkKICAgICAgICAgcmV0dXJuIHRydWU7CiAg ICAgaWYgKHJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkxvZ09iamVj dCkKICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgaWYgKHJlcHJlc2VudGVkT2JqZWN0IGluc3Rh bmNlb2YgV2ViSW5zcGVjdG9yLkxlZ2FjeUphdmFTY3JpcHRQcm9maWxlT2JqZWN0KQotICAgICAg ICByZXR1cm4gdHJ1ZTsKICAgICBpZiAocmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2VvZiBXZWJJ bnNwZWN0b3IuQ29udGVudEZsb3cpCiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIGlmICh0eXBl b2YgcmVwcmVzZW50ZWRPYmplY3QgPT09ICJzdHJpbmciIHx8IHJlcHJlc2VudGVkT2JqZWN0IGlu c3RhbmNlb2YgU3RyaW5nKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvRm9sZGVyaXplZFRyZWVFbGVtZW50LmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRm9sZGVyaXplZFRyZWVFbGVtZW50LmpzCmluZGV4 IDJkYWMxZGMuLjBmZTYyYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0ZvbGRlcml6ZWRUcmVlRWxlbWVudC5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Gb2xkZXJpemVkVHJlZUVsZW1lbnQuanMK QEAgLTIzNyw3ICsyMzcsNyBAQCBXZWJJbnNwZWN0b3IuRm9sZGVyaXplZFRyZWVFbGVtZW50LnBy b3RvdHlwZSA9IHsKICAgICBfaW5zZXJ0Q2hpbGRUcmVlRWxlbWVudDogZnVuY3Rpb24ocGFyZW50 VHJlZUVsZW1lbnQsIGNoaWxkVHJlZUVsZW1lbnQpCiAgICAgewogICAgICAgICBjb25zb2xlLmFz c2VydCghY2hpbGRUcmVlRWxlbWVudC5wYXJlbnQpOwotICAgICAgICBwYXJlbnRUcmVlRWxlbWVu dC5pbnNlcnRDaGlsZChjaGlsZFRyZWVFbGVtZW50LCBpbnNlcnRpb25JbmRleEZvck9iamVjdElu TGlzdFNvcnRlZEJ5RnVuY3Rpb24oY2hpbGRUcmVlRWxlbWVudCwgcGFyZW50VHJlZUVsZW1lbnQu Y2hpbGRyZW4sIHRoaXMuY29tcGFyZUNoaWxkVHJlZUVsZW1lbnRzKSk7CisgICAgICAgIHBhcmVu dFRyZWVFbGVtZW50Lmluc2VydENoaWxkKGNoaWxkVHJlZUVsZW1lbnQsIGluc2VydGlvbkluZGV4 Rm9yT2JqZWN0SW5MaXN0U29ydGVkQnlGdW5jdGlvbihjaGlsZFRyZWVFbGVtZW50LCBwYXJlbnRU cmVlRWxlbWVudC5jaGlsZHJlbiwgdGhpcy5jb21wYXJlQ2hpbGRUcmVlRWxlbWVudHMuYmluZCh0 aGlzKSkpOwogICAgIH0sCiAKICAgICBfcmVtb3ZlVHJlZUVsZW1lbnQ6IGZ1bmN0aW9uKGNoaWxk VHJlZUVsZW1lbnQsIHN1cHByZXNzT25EZXNlbGVjdCwgc3VwcHJlc3NTZWxlY3RTaWJsaW5nKQo= 242604 2014-12-04 17:43:28 -0800 2014-12-05 10:47:37 -0800 [PATCH] Proposed Fix - Better ChangeLog better-changelog.patch text/plain 3395 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdkYjU1NGIuLjIyYTQ4OTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE0LTEyLTA0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgRXhjZXB0aW9ucyB3aGVuIGF0dGVtcHRpbmcgdG8gc2hvdyBDb250ZW50IEZsb3cKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTI3NgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9WaWV3cy9Db250ZW50Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db250ZW50Vmll dyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29udGVudFZpZXcuaXNWaWV3YWJsZSk6CisgICAg ICAgIExlZ2FjeUphdmFTY3JpcHRQcm9maWxlT2JqZWN0IG5vIGxvbmdlciBleGlzdHMsIHRoZXNl IHJlZmVyZW5jZXMgc2hvdWxkIGJlIHJlbW92ZWQuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL0ZvbGRlcml6ZWRUcmVlRWxlbWVudC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5G b2xkZXJpemVkVHJlZUVsZW1lbnQucHJvdG90eXBlLl9pbnNlcnRDaGlsZFRyZWVFbGVtZW50KToK KyAgICAgICAgVGhpcyBzb3J0IGZ1bmN0aW9uIHJlZmVyZW5jZXMgInRoaXMiIGFuZCBuZWVkZWQg dG8gYmUgYm91bmQuCisKKzIwMTQtMTItMDQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBzZWxlY3RpbmcgUGFpbnQgdGltZWxp bmUgcmVjb3JkcyBmcm9tIHNpZGViYXIgZG9lcyBub3QgdHJpZ2dlciBwcmV2aWV3IG9mIHBhaW50 IHF1YWQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz OTE1MQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9Db250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0NvbnRlbnRWaWV3LmpzCmluZGV4IDY5MWY4M2EuLjZkNzg0YTggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRWaWV3Lmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRW aWV3LmpzCkBAIC02OSw5ICs2OSw2IEBAIFdlYkluc3BlY3Rvci5Db250ZW50VmlldyA9IGZ1bmN0 aW9uKHJlcHJlc2VudGVkT2JqZWN0KQogICAgICAgICBpZiAocmVwcmVzZW50ZWRPYmplY3QgaW5z dGFuY2VvZiBXZWJJbnNwZWN0b3IuTG9nT2JqZWN0KQogICAgICAgICAgICAgcmV0dXJuIG5ldyBX ZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcocmVwcmVzZW50ZWRPYmplY3QpOwogCi0gICAgICAg IGlmIChyZXByZXNlbnRlZE9iamVjdCBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5MZWdhY3lKYXZh U2NyaXB0UHJvZmlsZU9iamVjdCkKLSAgICAgICAgICAgIHJldHVybiBuZXcgV2ViSW5zcGVjdG9y LkxlZ2FjeUphdmFTY3JpcHRQcm9maWxlVmlldyhyZXByZXNlbnRlZE9iamVjdCk7Ci0KICAgICAg ICAgaWYgKHJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkNvbnRlbnRG bG93KQogICAgICAgICAgICAgcmV0dXJuIG5ldyBXZWJJbnNwZWN0b3IuQ29udGVudEZsb3dET01U cmVlQ29udGVudFZpZXcocmVwcmVzZW50ZWRPYmplY3QpOwogCkBAIC0xMjcsOCArMTI0LDYgQEAg V2ViSW5zcGVjdG9yLkNvbnRlbnRWaWV3LmlzVmlld2FibGUgPSBmdW5jdGlvbihyZXByZXNlbnRl ZE9iamVjdCkKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgaWYgKHJlcHJlc2VudGVkT2JqZWN0 IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkxvZ09iamVjdCkKICAgICAgICAgcmV0dXJuIHRydWU7 Ci0gICAgaWYgKHJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkxlZ2Fj eUphdmFTY3JpcHRQcm9maWxlT2JqZWN0KQotICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICBpZiAo cmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuQ29udGVudEZsb3cpCiAg ICAgICAgIHJldHVybiB0cnVlOwogICAgIGlmICh0eXBlb2YgcmVwcmVzZW50ZWRPYmplY3QgPT09 ICJzdHJpbmciIHx8IHJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2YgU3RyaW5nKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRm9sZGVyaXpl ZFRyZWVFbGVtZW50LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvRm9sZGVyaXplZFRyZWVFbGVtZW50LmpzCmluZGV4IDJkYWMxZGMuLjBmZTYyYTggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0ZvbGRlcml6 ZWRUcmVlRWxlbWVudC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9Gb2xkZXJpemVkVHJlZUVsZW1lbnQuanMKQEAgLTIzNyw3ICsyMzcsNyBAQCBXZWJJ bnNwZWN0b3IuRm9sZGVyaXplZFRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICBfaW5zZXJ0 Q2hpbGRUcmVlRWxlbWVudDogZnVuY3Rpb24ocGFyZW50VHJlZUVsZW1lbnQsIGNoaWxkVHJlZUVs ZW1lbnQpCiAgICAgewogICAgICAgICBjb25zb2xlLmFzc2VydCghY2hpbGRUcmVlRWxlbWVudC5w YXJlbnQpOwotICAgICAgICBwYXJlbnRUcmVlRWxlbWVudC5pbnNlcnRDaGlsZChjaGlsZFRyZWVF bGVtZW50LCBpbnNlcnRpb25JbmRleEZvck9iamVjdEluTGlzdFNvcnRlZEJ5RnVuY3Rpb24oY2hp bGRUcmVlRWxlbWVudCwgcGFyZW50VHJlZUVsZW1lbnQuY2hpbGRyZW4sIHRoaXMuY29tcGFyZUNo aWxkVHJlZUVsZW1lbnRzKSk7CisgICAgICAgIHBhcmVudFRyZWVFbGVtZW50Lmluc2VydENoaWxk KGNoaWxkVHJlZUVsZW1lbnQsIGluc2VydGlvbkluZGV4Rm9yT2JqZWN0SW5MaXN0U29ydGVkQnlG dW5jdGlvbihjaGlsZFRyZWVFbGVtZW50LCBwYXJlbnRUcmVlRWxlbWVudC5jaGlsZHJlbiwgdGhp cy5jb21wYXJlQ2hpbGRUcmVlRWxlbWVudHMuYmluZCh0aGlzKSkpOwogICAgIH0sCiAKICAgICBf cmVtb3ZlVHJlZUVsZW1lbnQ6IGZ1bmN0aW9uKGNoaWxkVHJlZUVsZW1lbnQsIHN1cHByZXNzT25E ZXNlbGVjdCwgc3VwcHJlc3NTZWxlY3RTaWJsaW5nKQo=