139268 2014-12-04 14:06:47 -0800 Web Inspector: Network Timeline Filter Bar only has "All", missing Resource Type filters 2014-12-04 14:55:36 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck mattbaker timothy webkit-bug-importer oldest_to_newest 1052561 0 joepeck 2014-12-04 14:06:47 -0800 * SUMMARY Network Timeline Filter Bar only has "All", missing Resource Type filters. * STEPS TO REPRODUCE 1. Inspect http://bogojoker.com/shell/ 2. Reload 3. Select a reasonable range in Timeline 4. Select Network Timeline 5. Mouse over Network Table => Filter bar only shows "All" * NOTES - Regressed with r175784 when a dictionary object changed to a map. 1052562 1 webkit-bug-importer 2014-12-04 14:07:08 -0800 <rdar://problem/19148493> 1052564 2 242586 joepeck 2014-12-04 14:08:12 -0800 Created attachment 242586 [PATCH] Proposed Fix 1052566 3 joepeck 2014-12-04 14:10:06 -0800 Actually... Why even make these a Map just for the purpose of this? I'll just revert it back to what it was using. 1052567 4 242586 joepeck 2014-12-04 14:12:00 -0800 Comment on attachment 242586 [PATCH] Proposed Fix Nevermind, I see the reason why. The values are not straight values, they use displayNameForEventType. Back to r?. 1052581 5 242586 commit-queue 2014-12-04 14:55:32 -0800 Comment on attachment 242586 [PATCH] Proposed Fix Clearing flags on attachment: 242586 Committed r176819: <http://trac.webkit.org/changeset/176819> 1052582 6 commit-queue 2014-12-04 14:55:36 -0800 All reviewed patches have been landed. Closing bug. 242586 2014-12-04 14:08:12 -0800 2014-12-04 14:55:32 -0800 [PATCH] Proposed Fix fix-scope-bar.patch text/plain 2109 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDM3YzJhNjguLmQ5NzExOGMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE0LTEyLTA0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTmV0d29y ayBUaW1lbGluZSBGaWx0ZXIgQmFyIG9ubHkgaGFzICJBbGwiLCBtaXNzaW5nIFJlc291cmNlIFR5 cGUgZmlsdGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM5MjY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lRGF0YUdyaWQuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuVGltZWxpbmVEYXRhR3JpZC5jcmVhdGVDb2x1bW5TY29wZUJhcik6CisgICAg ICAgIFVzZXJzIG9mIGNyZWF0ZUNvbHVtblNjb3BlQmFyIHBhc3MgYSBNYXAgb2JqZWN0IG5vdyBp bnN0ZWFkIG9mIGEgZGljdGlvbmFyeS4KKyAgICAgICAgSXRlcmF0ZSBvdmVyIHRoZSBtYXAgYXBw cm9wcmlhdGVseS4KKworMjAxNC0xMi0wNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBw bGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IExheW91dFRlc3RzL2luc3BlY3RvciB0 ZXN0cyBmYWlsIGluIFByb2R1Y3Rpb24gYnVpbGRzIGR1ZSB0byBtaXNzaW5nIHRlc3QgcmVzb3Vy Y2VzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg4 OTgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVGltZWxpbmVEYXRhR3JpZC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1RpbWVsaW5lRGF0YUdyaWQuanMKaW5kZXggMDgzYjdiYi4uMjdmMmNmMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxp bmVEYXRhR3JpZC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9UaW1lbGluZURhdGFHcmlkLmpzCkBAIC03MywxNyArNzMsMTcgQEAgV2ViSW5zcGVjdG9y LlRpbWVsaW5lRGF0YUdyaWQuRXZlbnQgPSB7CiAgICAgRmlsdGVyc0RpZENoYW5nZTogInRpbWVs aW5lZGF0YWdyaWQtZmlsdGVycy1kaWQtY2hhbmdlIgogfTsKIAotV2ViSW5zcGVjdG9yLlRpbWVs aW5lRGF0YUdyaWQuY3JlYXRlQ29sdW1uU2NvcGVCYXIgPSBmdW5jdGlvbihwcmVmaXgsIGRpY3Rp b25hcnkpCitXZWJJbnNwZWN0b3IuVGltZWxpbmVEYXRhR3JpZC5jcmVhdGVDb2x1bW5TY29wZUJh ciA9IGZ1bmN0aW9uKHByZWZpeCwgbWFwKQogewogICAgIHByZWZpeCA9IHByZWZpeCArICItdGlt ZWxpbmUtZGF0YS1ncmlkLSI7CiAKLSAgICB2YXIgc2NvcGVCYXJJdGVtcyA9IE9iamVjdC5rZXlz KGRpY3Rpb25hcnkpLm1hcChmdW5jdGlvbihrZXkpIHsKKyAgICB2YXIgc2NvcGVCYXJJdGVtcyA9 IFtdOworICAgIGZvciAodmFyIFtrZXksIHZhbHVlXSBvZiBtYXApIHsKICAgICAgICAgdmFyIGlk ID0gcHJlZml4ICsga2V5OwotICAgICAgICB2YXIgbGFiZWwgPSBkaWN0aW9uYXJ5W2tleV07Ci0g ICAgICAgIHZhciBpdGVtID0gbmV3IFdlYkluc3BlY3Rvci5TY29wZUJhckl0ZW0oaWQsIGxhYmVs KTsKKyAgICAgICAgdmFyIGl0ZW0gPSBuZXcgV2ViSW5zcGVjdG9yLlNjb3BlQmFySXRlbShpZCwg dmFsdWUpOwogICAgICAgICBpdGVtLnZhbHVlID0ga2V5OwotICAgICAgICByZXR1cm4gaXRlbTsK LSAgICB9KTsKKyAgICAgICAgc2NvcGVCYXJJdGVtcy5wdXNoKGl0ZW0pOworICAgIH0KIAogICAg IHNjb3BlQmFySXRlbXMudW5zaGlmdChuZXcgV2ViSW5zcGVjdG9yLlNjb3BlQmFySXRlbShwcmVm aXggKyAidHlwZS1hbGwiLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkFsbCIpLCB0cnVlKSk7CiAK