139228 2014-12-03 11:15:22 -0800 Web Inspector: Missing getter, clients never see DragToAdjustController is enabled 2014-12-03 17:39:57 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck msaboff simon.fraser timothy webkit-bug-importer oldest_to_newest 1052218 0 joepeck 2014-12-03 11:15:22 -0800 * SUMMARY DragToAdjustController has a setter but no getter for "enabled", yet CodeMirrorDragToAdjustNumberController tries to use it. The result is always undefined and can cause unnecessary duplicated work. 1052219 1 webkit-bug-importer 2014-12-03 11:15:47 -0800 <rdar://problem/19131615> 1052220 2 webkit-bug-importer 2014-12-03 11:15:47 -0800 <rdar://problem/19131616> 1052221 3 242507 joepeck 2014-12-03 11:16:12 -0800 Created attachment 242507 [PATCH] Proposed Fix 1052227 4 242507 msaboff 2014-12-03 11:21:24 -0800 Comment on attachment 242507 [PATCH] Proposed Fix r=me 1052352 5 joepeck 2014-12-03 16:57:06 -0800 Could you flip the r+ flag? That'll get this landing =) 1052373 6 242507 commit-queue 2014-12-03 17:39:53 -0800 Comment on attachment 242507 [PATCH] Proposed Fix Clearing flags on attachment: 242507 Committed r176770: <http://trac.webkit.org/changeset/176770> 1052374 7 commit-queue 2014-12-03 17:39:57 -0800 All reviewed patches have been landed. Closing bug. 242507 2014-12-03 11:16:12 -0800 2014-12-03 17:39:53 -0800 [PATCH] Proposed Fix fix.patch text/plain 1347 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDVmNzBiNDguLmQ3ZGZmMGIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTEyLTAzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTWlzc2lu ZyBnZXR0ZXIsIGNsaWVudHMgbmV2ZXIgc2VlIERyYWdUb0FkanVzdENvbnRyb2xsZXIgaXMgZW5h YmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5 MjI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RyYWdUb0FkanVzdENvbnRyb2xsZXIuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuRHJhZ1RvQWRqdXN0Q29udHJvbGxlci5wcm90b3R5cGUuZ2V0IGVu YWJsZWQpOgorCiAyMDE0LTEyLTAyICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5j b20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUGF1c2UgUmVhc29uIEltcHJvdmVtZW50cyAo QnJlYWtwb2ludCwgRGVidWdnZXIgU3RhdGVtZW50LCBQYXVzZSBvbiBOZXh0IFN0YXRlbWVudCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xs ZXJzL0RyYWdUb0FkanVzdENvbnRyb2xsZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Db250cm9sbGVycy9EcmFnVG9BZGp1c3RDb250cm9sbGVyLmpzCmluZGV4IDNm YjNiNDcuLmExZDkwNDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL0RyYWdUb0FkanVzdENvbnRyb2xsZXIuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRHJhZ1RvQWRqdXN0Q29u dHJvbGxlci5qcwpAQCAtNTEsNiArNTEsMTEgQEAgV2ViSW5zcGVjdG9yLkRyYWdUb0FkanVzdENv bnRyb2xsZXIucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLl9lbGVtZW50ID0gZWxlbWVudDsK ICAgICB9LAogCisgICAgZ2V0IGVuYWJsZWQoKQorICAgIHsKKyAgICAgICAgcmV0dXJuIHRoaXMu X2VuYWJsZWQ7CisgICAgfSwKKwogICAgIHNldCBlbmFibGVkKGVuYWJsZWQpCiAgICAgewogICAg ICAgICBpZiAodGhpcy5fZW5hYmxlZCA9PT0gZW5hYmxlZCkK