139222 2014-12-03 07:14:55 -0800 Fix cast-align warning in StringImpl.h 2014-12-04 11:22:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy andersca benjamin cmarcelo commit-queue kling ossy oldest_to_newest 1052145 0 ossy 2014-12-03 07:14:55 -0800 Fix cast-align warning in StringImpl.h 1052146 1 ossy 2014-12-03 07:16:40 -0800 warning log on ARM Linux build: ../../Source/WTF/wtf/text/StringImpl.h: In instantiation of ‘T* WTF::StringImpl::tailPointer() [with T = short unsigned int]’: ../../Source/WTF/wtf/text/StringImpl.h:182:39: required from here ../../Source/WTF/wtf/text/StringImpl.h:749:87: warning: cast from ‘uint8_t* {aka unsigned char*}’ to ‘short unsigned int*’ increases required alignment of target type [-Wcast-align] return reinterpret_cast_ptr<T*>(reinterpret_cast<uint8_t*>(this) + tailOffset<T>()); ^ ../../Source/WTF/wtf/text/StringImpl.h: In instantiation of ‘const T* WTF::StringImpl::tailPointer() const [with T = short unsigned int]’: ../../Source/WTF/wtf/text/StringImpl.h:720:47: required from here ../../Source/WTF/wtf/text/StringImpl.h:743:99: warning: cast from ‘const uint8_t* {aka const unsigned char*}’ to ‘const short unsigned int*’ increases required alignment of target type [-Wcast-align] return reinterpret_cast_ptr<const T*>(reinterpret_cast<const uint8_t*>(this) + tailOffset<T>()); ^ ../../Source/WTF/wtf/text/StringImpl.h: In instantiation of ‘const T* WTF::StringImpl::tailPointer() const [with T = WTF::StringImpl*]’: ../../Source/WTF/wtf/text/StringImpl.h:756:42: required from here ../../Source/WTF/wtf/text/StringImpl.h:743:99: warning: cast from ‘const uint8_t* {aka const unsigned char*}’ to ‘WTF::StringImpl* const*’ increases required alignment of target type [-Wcast-align] ../../Source/WTF/wtf/text/StringImpl.h: In instantiation of ‘T* WTF::StringImpl::tailPointer() [with T = WTF::StringImpl*]’: ../../Source/WTF/wtf/text/StringImpl.h:763:42: required from here ../../Source/WTF/wtf/text/StringImpl.h:749:87: warning: cast from ‘uint8_t* {aka unsigned char*}’ to ‘WTF::StringImpl**’ increases required alignment of target type [-Wcast-align] return reinterpret_cast_ptr<T*>(reinterpret_cast<uint8_t*>(this) + tailOffset<T>()); ^ These casts are safe, tailOffset guarantees the alignment. 1052148 2 ossy 2014-12-03 07:18:07 -0800 cc-ing Anders and Andreas, because https://trac.webkit.org/changeset/163341 touched these lines last time. 1052149 3 242490 ossy 2014-12-03 07:18:14 -0800 Created attachment 242490 Patch 1052517 4 242490 commit-queue 2014-12-04 11:22:10 -0800 Comment on attachment 242490 Patch Clearing flags on attachment: 242490 Committed r176805: <http://trac.webkit.org/changeset/176805> 1052518 5 commit-queue 2014-12-04 11:22:14 -0800 All reviewed patches have been landed. Closing bug. 242490 2014-12-03 07:18:14 -0800 2014-12-04 11:22:10 -0800 Patch bug-139222-20141203161951.patch text/plain 1541 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2NzIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDM0YTc0MzE3YmIwZjE3YzFjZTVmNDQz ZTIxMGE2YmRiZDcxZThiMGEuLjdhNTUzNjQwMzYxMWVmYzYwZGVjYTM5NTNmNDM4OTgzMjFlNGRi Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMTItMDMgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBGaXggY2FzdC1hbGlnbiB3YXJuaW5nIGluIFN0 cmluZ0ltcGwuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM5MjIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiB3dGYvdGV4dC9TdHJpbmdJbXBsLmg6CisgICAgICAgIChXVEY6OlN0cmluZ0ltcGw6OnRh aWxQb2ludGVyKToKKwogMjAxNC0xMi0wMiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+ CiAKICAgICAgICAgUm9sbGluZyBvdXQgcjE3NjU5MiwgcjE3NjYwMywgcjE3NjYxNiwgYW5kIHIx NzY3MDUgdW50aWwgYnVpbGQgYW5kIHBlcmYgaXNzdWVzIGFyZSByZXNvbHZlZC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oIGIvU291cmNlL1dURi93dGYvdGV4 dC9TdHJpbmdJbXBsLmgKaW5kZXggM2UwMDJlMGQzNmJmOTE5YmM4Njk1ZmEwYjQwYjA1N2I4N2Ri ODM3MS4uZWI1ZWE3ZDMyYWE0Yjk1NDIxOTA0OGZhZDE3ODQyYjk2ZmNhNDdjOSAxMDA2NDQKLS0t IGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmgKKysrIGIvU291cmNlL1dURi93dGYv dGV4dC9TdHJpbmdJbXBsLmgKQEAgLTc0MCwxMyArNzQwLDEzIEBAIHByaXZhdGU6CiAgICAgdGVt cGxhdGU8dHlwZW5hbWUgVD4KICAgICBjb25zdCBUKiB0YWlsUG9pbnRlcigpIGNvbnN0CiAgICAg ewotICAgICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxjb25zdCBUKj4ocmVpbnRlcnByZXRf Y2FzdDxjb25zdCB1aW50OF90Kj4odGhpcykgKyB0YWlsT2Zmc2V0PFQ+KCkpOworICAgICAgICBy ZXR1cm4gcmVpbnRlcnByZXRfY2FzdF9wdHI8Y29uc3QgVCo+KHJlaW50ZXJwcmV0X2Nhc3Q8Y29u c3QgdWludDhfdCo+KHRoaXMpICsgdGFpbE9mZnNldDxUPigpKTsKICAgICB9CiAKICAgICB0ZW1w bGF0ZTx0eXBlbmFtZSBUPgogICAgIFQqIHRhaWxQb2ludGVyKCkKICAgICB7Ci0gICAgICAgIHJl dHVybiByZWludGVycHJldF9jYXN0PFQqPihyZWludGVycHJldF9jYXN0PHVpbnQ4X3QqPih0aGlz KSArIHRhaWxPZmZzZXQ8VD4oKSk7CisgICAgICAgIHJldHVybiByZWludGVycHJldF9jYXN0X3B0 cjxUKj4ocmVpbnRlcnByZXRfY2FzdDx1aW50OF90Kj4odGhpcykgKyB0YWlsT2Zmc2V0PFQ+KCkp OwogICAgIH0KIAogICAgIFN0cmluZ0ltcGwqIGNvbnN0JiBzdWJzdHJpbmdCdWZmZXIoKSBjb25z dAo=