139206 2014-12-02 15:44:25 -0800 Web Inspector: CSS Minification breaks some selectors with colons 2014-12-02 16:39:13 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned benjamin commit-queue graouts joepeck simon.fraser timothy webkit-bug-importer oldest_to_newest 1051993 0 joepeck 2014-12-02 15:44:25 -0800 * SUMMARY Production builds have broken styles. Selectors with colons that may be preceded by a space (e.g. :matches, :not, :focus) are broken by magnification which removes the leading space, and changes the semantics. ".a :matches(...)" !== ".a:matches(...)" ".a :not(.b)" !== ".a:not(.b)" * NOTES - This has been breaking some edge cases for a while, and a lot more as we start using :matches and :not more frequently. UserInterface/Views/DebuggerDashboardView.css:106:.toolbar:not(.small-size) .dashboard.debugger > .location :not(:first-child) { UserInterface/Views/TimelineSidebarPanel.css:221:.sidebar > .panel.navigation.timeline > .timelines-content :focus li.item.selected + li.item { 1051994 1 webkit-bug-importer 2014-12-02 15:44:48 -0800 <rdar://problem/19121083> 1051996 2 242458 joepeck 2014-12-02 15:53:40 -0800 Created attachment 242458 [PATCH] Proposed Fix Fixes ~16 colon issues adding back 16 spaces. Remove 74 spaces preceding "!important"s. Overall we save 58 bytes! 1051997 3 242459 joepeck 2014-12-02 15:56:21 -0800 Created attachment 242459 [PATCH] Proposed Fix 1051999 4 242460 joepeck 2014-12-02 15:57:54 -0800 Created attachment 242460 [PATCH] Proposed Fix - Fixed typos 1052001 5 commit-queue 2014-12-02 16:01:04 -0800 Attachment 242460 did not pass style-queue: ERROR: Source/WebInspectorUI/Scripts/cssmin.py:33: at least two spaces before inline comment [pep8/E261] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1052019 6 242460 commit-queue 2014-12-02 16:39:08 -0800 Comment on attachment 242460 [PATCH] Proposed Fix - Fixed typos Clearing flags on attachment: 242460 Committed r176699: <http://trac.webkit.org/changeset/176699> 1052020 7 commit-queue 2014-12-02 16:39:13 -0800 All reviewed patches have been landed. Closing bug. 242458 2014-12-02 15:53:40 -0800 2014-12-02 15:56:21 -0800 [PATCH] Proposed Fix minification.patch text/plain 2040 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDIwOWJlNjMuLmI3MjY2MmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTEyLTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ1NTIE1p bmlmaWNhdGlvbiBicmVha3Mgc2VsZWN0b3JzIHNvbWUgc2VsZWN0b3JzIHdpdGggY29sb25zCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzkyMDYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3QgcmVt b3ZlIHNwYWNlcyBwcmVjZWVkaW5nIGNvbG9ucywgYXMgdGhleSBtYXkgY2hhbmdlIHRoZSBzZW1h bnRpY3MKKyAgICAgICAgb2Ygc2VsZWN0b3JzIHdpdGggY29sb24gcHJlZml4ZXMgKGUuZy4gImEg Om5vdChiKSIpLgorCisgICAgICAgIEF0IHRoZSBzYW1lIHRpbWUsIHdlIGNhbiBzdHJpcCBzcGFj ZXMgYXJvdW5kICIhIiBjaGFyYWN0ZXJzLCBmb3IgZXhhbXBsZQorICAgICAgICBhIHNwYWNlIGlz IG5vdCByZXF1aXJlZCBiZWZvcmUgIiFpbXBvcnRhbnQiIHByb3Blcml0eS4KKworICAgICAgICAq IFNjcmlwdHMvY3NzbWluLnB5OgorICAgICAgICAoY3NzbWluaWZ5KToKKwogMjAxNC0xMi0wMSAg Sm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IEkgZG8gbm90IGV4cGVjdCB0byBzZWUgdGhlIHNhbWUgcnVsZSBtdWx0aXBsZSB0aW1l cyBpbiBzdHlsZXMgc2lkZWJhcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Nj cmlwdHMvY3NzbWluLnB5IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMvY3NzbWluLnB5 CmluZGV4IDdmNDMxMjIuLjU0OGMyMDAgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9TY3JpcHRzL2Nzc21pbi5weQorKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvU2NyaXB0cy9j c3NtaW4ucHkKQEAgLTMwLDcgKzMwLDggQEAgZGVmIGNzc21pbmlmeShjc3MpOgogICAgICAgICAo ciJcL1wqLio/XCpcLyIsICIiKSwgICAgICAgICAgIyBkZWxldGUgY29tbWVudHMKICAgICAgICAg KHIiXG4iLCAiIiksICAgICAgICAgICAgICAgICAgICMgZGVsZXRlIG5ldyBsaW5lcwogICAgICAg ICAociJccysiLCAiICIpLCAgICAgICAgICAgICAgICAgIyBjaGFuZ2UgbXVsdGlwbGUgc3BhY2Vz IHRvIG9uZSBzcGFjZQotICAgICAgICAociJccz8oWzs6e30sfj5dKVxzPyIsIHIiXDEiKSwgIyBk ZWxldGUgc3BhY2Ugd2hlcmUgaXQgaXMgbm90IG5lZWRlZAorICAgICAgICAociJccz8oWzt7fSx+ PiFdKVxzPyIsIHIiXDEiKSwgIyBkZWxldGUgc3BhY2Ugd2hlcmUgaXQgaXMgbm90IG5lZWRlZAor ICAgICAgICAociI6XHMiLCAiOiIpLCAgICAgICAgICAgICAgICAgIyBkZWxldGUgc3BhY2VzIGFm dGVyIGNvbG9ucywgYnV0IG5vdCBiZWZvcmUuIEUuZy4gZG8gbm90IGJyZWFrIHNlbGVjdG9ycyAi YSA6Zm9jdXMiLCAiYiA6bWF0Y2hlcyguLi4pIiwgImMgOm5vdCguLi4pIiB3aGVyZSB0aGUgbGVh ZGluZyBzcGFjZSBpcyBzaWduaWZpY2FudAogICAgICAgICAociJccz8oWy0rXSkoPzpccyg/IVsw LTkoXSkpIiwgciJcMSIpLCAjIGRlbGV0ZSB3aGl0ZXNwYWNlIGFyb3VuZCArIGFuZCAtIHdoZW4g bm90IGZvbGxvd2VkIGJ5IGEgbnVtYmVyIG9yIHBhcmVuLiBFLmcuIHN0cmlwIGZvciBzZWxlY3Rv ciAiYSArIGIiIGJ1dCBub3QgImNhbGMoYSArIGIpIiB3aGljaCByZXF1aXJlcyBzcGFjZXMuCiAg ICAgICAgIChyIjt9IiwgIn0iKSAgICAgICAgICAgICAgICAgICAjIGNoYW5nZSAnO30nIHRvICd9 JyBiZWNhdXNlIHRoZSBzZW1pY29sb24gaXMgbm90IG5lZWRlZAogICAgICkK 242459 2014-12-02 15:56:21 -0800 2014-12-02 15:57:54 -0800 [PATCH] Proposed Fix min2.patch text/plain 2030 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDIwOWJlNjMuLjJhM2QyZDQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTEyLTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ1NTIE1p bmlmaWNhdGlvbiBicmVha3Mgc29tZSBzZWxlY3RvcnMgd2l0aCBjb2xvbnMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTIwNgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCByZW1vdmUgc3BhY2Vz IHByZWNlZWRpbmcgY29sb25zLCBhcyB0aGV5IG1heSBjaGFuZ2UgdGhlIHNlbWFudGljcworICAg ICAgICBvZiBzZWxlY3RvcnMgd2l0aCBjb2xvbiBwcmVmaXhlcyAoZS5nLiAiYSA6bm90KGIpIiku CisKKyAgICAgICAgQXQgdGhlIHNhbWUgdGltZSwgd2UgY2FuIHN0cmlwIHNwYWNlcyBhcm91bmQg IiEiIGNoYXJhY3RlcnMsIGZvciBleGFtcGxlCisgICAgICAgIGEgc3BhY2UgaXMgbm90IHJlcXVp cmVkIGJlZm9yZSAiIWltcG9ydGFudCIgcHJvcGVyaXR5LgorCisgICAgICAgICogU2NyaXB0cy9j c3NtaW4ucHk6CisgICAgICAgIChjc3NtaW5pZnkpOgorCiAyMDE0LTEyLTAxICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSSBk byBub3QgZXhwZWN0IHRvIHNlZSB0aGUgc2FtZSBydWxlIG11bHRpcGxlIHRpbWVzIGluIHN0eWxl cyBzaWRlYmFyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvU2NyaXB0cy9jc3Nt aW4ucHkgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvU2NyaXB0cy9jc3NtaW4ucHkKaW5kZXggN2Y0 MzEyMi4uNTQ4YzIwMCAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMv Y3NzbWluLnB5CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL2Nzc21pbi5weQpA QCAtMzAsNyArMzAsOCBAQCBkZWYgY3NzbWluaWZ5KGNzcyk6CiAgICAgICAgIChyIlwvXCouKj9c KlwvIiwgIiIpLCAgICAgICAgICAjIGRlbGV0ZSBjb21tZW50cwogICAgICAgICAociJcbiIsICIi KSwgICAgICAgICAgICAgICAgICAgIyBkZWxldGUgbmV3IGxpbmVzCiAgICAgICAgIChyIlxzKyIs ICIgIiksICAgICAgICAgICAgICAgICAjIGNoYW5nZSBtdWx0aXBsZSBzcGFjZXMgdG8gb25lIHNw YWNlCi0gICAgICAgIChyIlxzPyhbOzp7fSx+Pl0pXHM/IiwgciJcMSIpLCAjIGRlbGV0ZSBzcGFj ZSB3aGVyZSBpdCBpcyBub3QgbmVlZGVkCisgICAgICAgIChyIlxzPyhbO3t9LH4+IV0pXHM/Iiwg ciJcMSIpLCAjIGRlbGV0ZSBzcGFjZSB3aGVyZSBpdCBpcyBub3QgbmVlZGVkCisgICAgICAgIChy IjpccyIsICI6IiksICAgICAgICAgICAgICAgICAjIGRlbGV0ZSBzcGFjZXMgYWZ0ZXIgY29sb25z LCBidXQgbm90IGJlZm9yZS4gRS5nLiBkbyBub3QgYnJlYWsgc2VsZWN0b3JzICJhIDpmb2N1cyIs ICJiIDptYXRjaGVzKC4uLikiLCAiYyA6bm90KC4uLikiIHdoZXJlIHRoZSBsZWFkaW5nIHNwYWNl IGlzIHNpZ25pZmljYW50CiAgICAgICAgIChyIlxzPyhbLStdKSg/OlxzKD8hWzAtOShdKSkiLCBy IlwxIiksICMgZGVsZXRlIHdoaXRlc3BhY2UgYXJvdW5kICsgYW5kIC0gd2hlbiBub3QgZm9sbG93 ZWQgYnkgYSBudW1iZXIgb3IgcGFyZW4uIEUuZy4gc3RyaXAgZm9yIHNlbGVjdG9yICJhICsgYiIg YnV0IG5vdCAiY2FsYyhhICsgYikiIHdoaWNoIHJlcXVpcmVzIHNwYWNlcy4KICAgICAgICAgKHIi O30iLCAifSIpICAgICAgICAgICAgICAgICAgICMgY2hhbmdlICc7fScgdG8gJ30nIGJlY2F1c2Ug dGhlIHNlbWljb2xvbiBpcyBub3QgbmVlZGVkCiAgICAgKQo= 242460 2014-12-02 15:57:54 -0800 2014-12-02 16:39:08 -0800 [PATCH] Proposed Fix - Fixed typos min3.patch text/plain 2029 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDIwOWJlNjMuLjJlYzdhYTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTEyLTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ1NTIE1p bmlmaWNhdGlvbiBicmVha3Mgc29tZSBzZWxlY3RvcnMgd2l0aCBjb2xvbnMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTIwNgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCByZW1vdmUgc3BhY2Vz IHByZWNlZWRpbmcgY29sb25zLCBhcyB0aGV5IG1heSBjaGFuZ2UgdGhlIHNlbWFudGljcworICAg ICAgICBvZiBzZWxlY3RvcnMgd2l0aCBjb2xvbiBwcmVmaXhlcyAoZS5nLiAiYSA6bm90KGIpIiku CisKKyAgICAgICAgQXQgdGhlIHNhbWUgdGltZSwgd2UgY2FuIHN0cmlwIHNwYWNlcyBhcm91bmQg IiEiIGNoYXJhY3RlcnMsIGZvciBleGFtcGxlCisgICAgICAgIGEgc3BhY2UgaXMgbm90IHJlcXVp cmVkIGJlZm9yZSAiIWltcG9ydGFudCIgcHJpb3JpdHkuCisKKyAgICAgICAgKiBTY3JpcHRzL2Nz c21pbi5weToKKyAgICAgICAgKGNzc21pbmlmeSk6CisKIDIwMTQtMTItMDEgIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJIGRv IG5vdCBleHBlY3QgdG8gc2VlIHRoZSBzYW1lIHJ1bGUgbXVsdGlwbGUgdGltZXMgaW4gc3R5bGVz IHNpZGViYXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL2Nzc21p bi5weSBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL2Nzc21pbi5weQppbmRleCA3ZjQz MTIyLi41NDhjMjAwIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvU2NyaXB0cy9j c3NtaW4ucHkKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMvY3NzbWluLnB5CkBA IC0zMCw3ICszMCw4IEBAIGRlZiBjc3NtaW5pZnkoY3NzKToKICAgICAgICAgKHIiXC9cKi4qP1wq XC8iLCAiIiksICAgICAgICAgICMgZGVsZXRlIGNvbW1lbnRzCiAgICAgICAgIChyIlxuIiwgIiIp LCAgICAgICAgICAgICAgICAgICAjIGRlbGV0ZSBuZXcgbGluZXMKICAgICAgICAgKHIiXHMrIiwg IiAiKSwgICAgICAgICAgICAgICAgICMgY2hhbmdlIG11bHRpcGxlIHNwYWNlcyB0byBvbmUgc3Bh Y2UKLSAgICAgICAgKHIiXHM/KFs7Ont9LH4+XSlccz8iLCByIlwxIiksICMgZGVsZXRlIHNwYWNl IHdoZXJlIGl0IGlzIG5vdCBuZWVkZWQKKyAgICAgICAgKHIiXHM/KFs7e30sfj4hXSlccz8iLCBy IlwxIiksICMgZGVsZXRlIHNwYWNlIHdoZXJlIGl0IGlzIG5vdCBuZWVkZWQKKyAgICAgICAgKHIi OlxzIiwgIjoiKSwgICAgICAgICAgICAgICAgICMgZGVsZXRlIHNwYWNlcyBhZnRlciBjb2xvbnMs IGJ1dCBub3QgYmVmb3JlLiBFLmcuIGRvIG5vdCBicmVhayBzZWxlY3RvcnMgImEgOmZvY3VzIiwg ImIgOm1hdGNoZXMoLi4uKSIsICJjIDpub3QoLi4uKSIgd2hlcmUgdGhlIGxlYWRpbmcgc3BhY2Ug aXMgc2lnbmlmaWNhbnQKICAgICAgICAgKHIiXHM/KFstK10pKD86XHMoPyFbMC05KF0pKSIsIHIi XDEiKSwgIyBkZWxldGUgd2hpdGVzcGFjZSBhcm91bmQgKyBhbmQgLSB3aGVuIG5vdCBmb2xsb3dl ZCBieSBhIG51bWJlciBvciBwYXJlbi4gRS5nLiBzdHJpcCBmb3Igc2VsZWN0b3IgImEgKyBiIiBi dXQgbm90ICJjYWxjKGEgKyBiKSIgd2hpY2ggcmVxdWlyZXMgc3BhY2VzLgogICAgICAgICAociI7 fSIsICJ9IikgICAgICAgICAgICAgICAgICAgIyBjaGFuZ2UgJzt9JyB0byAnfScgYmVjYXVzZSB0 aGUgc2VtaWNvbG9uIGlzIG5vdCBuZWVkZWQKICAgICApCg==