<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>139200</bug_id>
          
          <creation_ts>2014-12-02 14:41:30 -0800</creation_ts>
          <short_desc>[Media] Audio content shouldn&apos;t have fullscreen buttons, even if in a video element</short_desc>
          <delta_ts>2014-12-05 11:06:43 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dean Jackson">dino</reporter>
          <assigned_to name="Dean Jackson">dino</assigned_to>
          <cc>calvaris</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>glenn</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>jer.noble</cc>
    
    <cc>kangil.han</cc>
    
    <cc>philipj</cc>
    
    <cc>sergio</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1051973</commentid>
    <comment_count>0</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2014-12-02 14:41:30 -0800</bug_when>
    <thetext>[Media] Audio content shouldn&apos;t have fullscreen buttons, even if in a video element</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1052038</commentid>
    <comment_count>1</comment_count>
      <attachid>242467</attachid>
    <who name="Dean Jackson">dino</who>
    <bug_when>2014-12-02 17:27:38 -0800</bug_when>
    <thetext>Created attachment 242467
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1052039</commentid>
    <comment_count>2</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2014-12-02 17:27:48 -0800</bug_when>
    <thetext>        &lt;rdar://problem/18914506&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1052050</commentid>
    <comment_count>3</comment_count>
      <attachid>242467</attachid>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2014-12-02 17:53:52 -0800</bug_when>
    <thetext>Comment on attachment 242467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242467&amp;action=review

&gt; Source/WebCore/ChangeLog:36
&gt; +2014-12-02  Dean Jackson  &lt;dino@apple.com&gt;
&gt; +
&gt; +        Missing support for innerHTML on SVGElement
&gt; +        https://bugs.webkit.org/show_bug.cgi?id=136903
&gt; +
&gt; +        Unreviewed followup from r176630. Minor style nits that I missed in my review.
&gt; +
&gt; +        * dom/Element.h: Remove unnecessary parameter name.
&gt; +        * html/parser/HTMLTreeBuilder.cpp: Whitespace cleanup.
&gt; +        (WebCore::HTMLTreeBuilder::adjustedCurrentStackItem):

Double ChangeLog :-O

&gt; Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:559
&gt; +        if (this.video.videoTracks &amp;&amp; this.video.videoTracks.length &gt; 0)
&gt; +            this.hasVisualMedia = true;

Is there any reason to not do this as &quot;this.hasVisualMedia = this.video.videoTracks &amp;&amp; this.video.videoTracks.length &gt; 0&quot;?

&gt; Source/WebCore/Modules/mediacontrols/mediaControlsBase.js:559
&gt; +        if (this.video.videoTracks &amp;&amp; this.video.videoTracks.length &gt; 0)
&gt; +            this.hasVisualMedia = true;

Ditto.

&gt; Source/WebCore/dom/Element.h:569
&gt; -    void clearTabIndexExplicitlyIfNeeded();    
&gt; +    void clearTabIndexExplicitlyIfNeeded();

You probably don&apos;t want these changes in this patch.

&gt; Source/WebCore/dom/Element.h:580
&gt; -    
&gt; -    static void mergeWithNextTextNode(Text&amp; node, ExceptionCode&amp; ec);
&gt; +
&gt; +    static void mergeWithNextTextNode(Text&amp; node, ExceptionCode&amp;);

Ditto.

&gt; Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2842
&gt; -    
&gt; +

Ditto

&gt; Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2849
&gt; -        
&gt; +

Ditto</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1052092</commentid>
    <comment_count>4</comment_count>
      <attachid>242467</attachid>
    <who name="Dean Jackson">dino</who>
    <bug_when>2014-12-03 02:04:15 -0800</bug_when>
    <thetext>Comment on attachment 242467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242467&amp;action=review

&gt;&gt; Source/WebCore/ChangeLog:36
&gt;&gt; +        (WebCore::HTMLTreeBuilder::adjustedCurrentStackItem):
&gt; 
&gt; Double ChangeLog :-O

Oops. I&apos;m not sure why that was included in the patch. It&apos;s already landed, I hope.

&gt;&gt; Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:559
&gt;&gt; +            this.hasVisualMedia = true;
&gt; 
&gt; Is there any reason to not do this as &quot;this.hasVisualMedia = this.video.videoTracks &amp;&amp; this.video.videoTracks.length &gt; 0&quot;?

Because I&apos;m a moron!! :)

&gt;&gt; Source/WebCore/dom/Element.h:569
&gt;&gt; +    void clearTabIndexExplicitlyIfNeeded();
&gt; 
&gt; You probably don&apos;t want these changes in this patch.

Yeah, that&apos;s the patch for another bug that should already be landed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1052094</commentid>
    <comment_count>5</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2014-12-03 02:05:00 -0800</bug_when>
    <thetext>Ah, I didn&apos;t actually commit those other changes. Ignore them, they&apos;ll land separately (and are a completely different bug).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1052095</commentid>
    <comment_count>6</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2014-12-03 02:08:57 -0800</bug_when>
    <thetext>Committed r176714: &lt;http://trac.webkit.org/changeset/176714&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1052777</commentid>
    <comment_count>7</comment_count>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2014-12-05 11:06:43 -0800</bug_when>
    <thetext>Thanks for considering the Base.js also to fix this!</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>242467</attachid>
            <date>2014-12-02 17:27:38 -0800</date>
            <delta_ts>2014-12-02 17:53:52 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-139200-20141203122807.patch</filename>
            <type>text/plain</type>
            <size>10741</size>
            <attacher name="Dean Jackson">dino</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2Njk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWY0NWJmNWFiMmZlZWRl
OGNjY2QwMmUwMTg1NmE3NWEwMjQzZjg2MS4uZDdmOGI1NTFjODIyNGVmY2FjZDJiNDIwMjk5Nzc1
ZDhhYmI0M2QxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQwIEBACisyMDE0LTEyLTAyICBEZWFu
IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbTWVkaWFdIEF1ZGlvIGNvbnRl
bnQgc2hvdWxkbid0IGhhdmUgZnVsbHNjcmVlbiBidXR0b25zLCBldmVuIGlmIGluIGEgdmlkZW8g
ZWxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTM5MjAwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xODkxNDUwNj4KKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbiBhdWRpby1vbmx5IHJlc291cmNl
LCBldmVuIGlmIGxvYWRlZCBpbnRvIGEgPHZpZGVvPiBlbGVtZW50LCBzaG91bGQgbm90CisgICAg
ICAgIHByZXNlbnQgdGhlIGZ1bGxzY3JlZW4gb3Igb3B0aW1pc2VkIGZ1bGxzY3JlZW4gY29udHJv
bHMuIFRoaXMgaW5jbHVkZXMgYQorICAgICAgICBNZWRpYURvY3VtZW50LCB3aGljaCBpcyBhbHdh
eXMgYSA8dmlkZW8+IGVsZW1lbnQuIFdlIGNhbiBkZXRlY3QgdGhpcyBieQorICAgICAgICBleGFt
aW5pbmcgdGhlIGxlbmd0aCBvZiB0aGUgdmlkZW9UcmFja3MgcHJvcGVydHkgYXMgb3VyIGNvbnRl
bnQgbG9hZHMuCisKKyAgICAgICAgVGVzdDogbWVkaWEvYXVkaW8tYXMtdmlkZW8tZnVsbHNjcmVl
bi5odG1sCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0Fw
cGxlLmpzOgorICAgICAgICAoQ29udHJvbGxlcik6IEluaXRpYWxpemUgYSBoYXNWaXN1YWxNZWRp
YSB0byBmYWxzZS4KKyAgICAgICAgKENvbnRyb2xsZXIucHJvdG90eXBlLmhhbmRsZVJlYWR5U3Rh
dGVDaGFuZ2UpOiBJZiB3ZSBzZWUgYSB2aWRlb1RyYWNrLCBoYXNWaXN1YWxNZWRpYSBpcyBub3cg
dHJ1ZS4KKyAgICAgICAgKENvbnRyb2xsZXIucHJvdG90eXBlLnVwZGF0ZUZ1bGxzY3JlZW5CdXR0
b25zKTogTWVyZ2UgdGhlIHVwZGF0ZUZ1bGxzY3JlZW5CdXR0b24gYW5kCisgICAgICAgIHVwZGF0
ZU9wdGltaXplZEZ1bGxzY3JlZW5CdXR0b24gbWV0aG9kcyBpbnRvIHRoaXMgc2luZ2xlIHNwb3Qs
IGFuZCBjaGVjayBmb3IKKyAgICAgICAgaGFzVmlzdWFsTWVkaWEuCisgICAgICAgIChDb250cm9s
bGVyLnByb3RvdHlwZS51cGRhdGVGdWxsc2NyZWVuQnV0dG9uKTogRGVsZXRlZC4KKyAgICAgICAg
KENvbnRyb2xsZXIucHJvdG90eXBlLnVwZGF0ZU9wdGltaXplZEZ1bGxzY3JlZW5CdXR0b24pOiBE
ZWxldGVkLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNC
YXNlLmpzOiBEbyB0aGUgc2FtZSBmb3IgdGhlIG90aGVyIHBvcnRzLgorCisyMDE0LTEyLTAyICBE
ZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBNaXNzaW5nIHN1cHBvcnQg
Zm9yIGlubmVySFRNTCBvbiBTVkdFbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY5MDMKKworICAgICAgICBVbnJldmlld2VkIGZvbGxvd3Vw
IGZyb20gcjE3NjYzMC4gTWlub3Igc3R5bGUgbml0cyB0aGF0IEkgbWlzc2VkIGluIG15IHJldmll
dy4KKworICAgICAgICAqIGRvbS9FbGVtZW50Lmg6IFJlbW92ZSB1bm5lY2Vzc2FyeSBwYXJhbWV0
ZXIgbmFtZS4KKyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuY3BwOiBXaGl0
ZXNwYWNlIGNsZWFudXAuCisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OmFkanVz
dGVkQ3VycmVudFN0YWNrSXRlbSk6CisKIDIwMTQtMTItMDIgIEJldGggRGFraW4gIDxiZGFraW5A
YXBwbGUuY29tPgogCiAgICAgICAgIE1vcmUgYnVpbGQgZml4aW5nLgpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcyBi
L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUu
anMKaW5kZXggNDQ4NjU4ZDU0NWEzNWRiNDJmYmU0MDhhZjY4ZmQwNDFjZTBjOGY5NC4uYWZkYjg4
NmVhNjEzNzY2ZTg2NDdjZGFmZWI1YTA5YTEzZGY5MjI3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcworKysgYi9T
b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpz
CkBAIC0xMiw2ICsxMiw3IEBAIGZ1bmN0aW9uIENvbnRyb2xsZXIocm9vdCwgdmlkZW8sIGhvc3Qp
CiAgICAgdGhpcy5saXN0ZW5lcnMgPSB7fTsKICAgICB0aGlzLmlzTGl2ZSA9IGZhbHNlOwogICAg
IHRoaXMuc3RhdHVzSGlkZGVuID0gdHJ1ZTsKKyAgICB0aGlzLmhhc1Zpc3VhbE1lZGlhID0gZmFs
c2U7CiAKICAgICB0aGlzLmFkZFZpZGVvTGlzdGVuZXJzKCk7CiAgICAgdGhpcy5jcmVhdGVCYXNl
KCk7CkBAIC0yNiw3ICsyNyw3IEBAIGZ1bmN0aW9uIENvbnRyb2xsZXIocm9vdCwgdmlkZW8sIGhv
c3QpCiAgICAgdGhpcy51cGRhdGVUaHVtYm5haWwoKTsKICAgICB0aGlzLnVwZGF0ZUNhcHRpb25C
dXR0b24oKTsKICAgICB0aGlzLnVwZGF0ZUNhcHRpb25Db250YWluZXIoKTsKLSAgICB0aGlzLnVw
ZGF0ZUZ1bGxzY3JlZW5CdXR0b24oKTsKKyAgICB0aGlzLnVwZGF0ZUZ1bGxzY3JlZW5CdXR0b25z
KCk7CiAgICAgdGhpcy51cGRhdGVWb2x1bWUoKTsKICAgICB0aGlzLnVwZGF0ZUhhc0F1ZGlvKCk7
CiAgICAgdGhpcy51cGRhdGVIYXNWaWRlbygpOwpAQCAtNTU0LDEyICs1NTUsMTMgQEAgQ29udHJv
bGxlci5wcm90b3R5cGUgPSB7CiAKICAgICBoYW5kbGVSZWFkeVN0YXRlQ2hhbmdlOiBmdW5jdGlv
bihldmVudCkKICAgICB7CisgICAgICAgIGlmICh0aGlzLnZpZGVvLnZpZGVvVHJhY2tzICYmIHRo
aXMudmlkZW8udmlkZW9UcmFja3MubGVuZ3RoID4gMCkKKyAgICAgICAgICAgIHRoaXMuaGFzVmlz
dWFsTWVkaWEgPSB0cnVlOwogICAgICAgICB0aGlzLnVwZGF0ZVJlYWR5U3RhdGUoKTsKICAgICAg
ICAgdGhpcy51cGRhdGVEdXJhdGlvbigpOwogICAgICAgICB0aGlzLnVwZGF0ZUNhcHRpb25CdXR0
b24oKTsKICAgICAgICAgdGhpcy51cGRhdGVDYXB0aW9uQ29udGFpbmVyKCk7Ci0gICAgICAgIHRo
aXMudXBkYXRlRnVsbHNjcmVlbkJ1dHRvbigpOwotICAgICAgICB0aGlzLnVwZGF0ZU9wdGltaXpl
ZEZ1bGxzY3JlZW5CdXR0b24oKTsKKyAgICAgICAgdGhpcy51cGRhdGVGdWxsc2NyZWVuQnV0dG9u
cygpOwogICAgICAgICB0aGlzLnVwZGF0ZVByb2dyZXNzKCk7CiAgICAgfSwKIApAQCAtODYwLDE2
ICs4NjIsMTMgQEAgQ29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAgICAgICAgIHJldHVybiB0cnVl
OwogICAgIH0sCiAKLSAgICB1cGRhdGVGdWxsc2NyZWVuQnV0dG9uOiBmdW5jdGlvbigpCisgICAg
dXBkYXRlRnVsbHNjcmVlbkJ1dHRvbnM6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIHRoaXMu
Y29udHJvbHMuZnVsbHNjcmVlbkJ1dHRvbi5jbGFzc0xpc3QudG9nZ2xlKHRoaXMuQ2xhc3NOYW1l
cy5oaWRkZW4sICF0aGlzLnZpZGVvLndlYmtpdFN1cHBvcnRzRnVsbHNjcmVlbik7CisgICAgICAg
IHZhciBzaG91bGRCZUhpZGRlbiA9ICF0aGlzLnZpZGVvLndlYmtpdFN1cHBvcnRzRnVsbHNjcmVl
biB8fCAhdGhpcy5oYXNWaXN1YWxNZWRpYTsKKyAgICAgICAgdGhpcy5jb250cm9scy5mdWxsc2Ny
ZWVuQnV0dG9uLmNsYXNzTGlzdC50b2dnbGUodGhpcy5DbGFzc05hbWVzLmhpZGRlbiwgc2hvdWxk
QmVIaWRkZW4pOworICAgICAgICB0aGlzLmNvbnRyb2xzLm9wdGltaXplZEZ1bGxzY3JlZW5CdXR0
b24uY2xhc3NMaXN0LnRvZ2dsZSh0aGlzLkNsYXNzTmFtZXMuaGlkZGVuLCBzaG91bGRCZUhpZGRl
bik7CiAgICAgfSwKIAotICAgIHVwZGF0ZU9wdGltaXplZEZ1bGxzY3JlZW5CdXR0b246IGZ1bmN0
aW9uKCkKLSAgICB7Ci0gICAgICAgIHRoaXMuY29udHJvbHMub3B0aW1pemVkRnVsbHNjcmVlbkJ1
dHRvbi5jbGFzc0xpc3QudG9nZ2xlKHRoaXMuQ2xhc3NOYW1lcy5oaWRkZW4sICF0aGlzLnZpZGVv
LndlYmtpdFN1cHBvcnRzRnVsbHNjcmVlbik7Ci0gICAgfSwKLSAgICAKICAgICBoYW5kbGVGdWxs
c2NyZWVuQnV0dG9uQ2xpY2tlZDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewogICAgICAgICBpZiAo
dGhpcy5pc0Z1bGxTY3JlZW4oKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv
bWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQmFzZS5qcyBiL1NvdXJjZS9XZWJDb3JlL01vZHVs
ZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQmFzZS5qcwppbmRleCAzMDgxYTA2YmYwMTdi
ODdiYzVlNjA2YTE3ZGVlOGU2ZTViOGQ4NDFjLi41ZWMxNWRjNGJmNWYxYWJjNTAzNjI1ODk3NzA4
MmE5MDBhOTZhMjQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29u
dHJvbHMvbWVkaWFDb250cm9sc0Jhc2UuanMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t
ZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNCYXNlLmpzCkBAIC0xMiw2ICsxMiw3IEBAIGZ1bmN0
aW9uIENvbnRyb2xsZXIocm9vdCwgdmlkZW8sIGhvc3QpCiAgICAgdGhpcy5saXN0ZW5lcnMgPSB7
fTsKICAgICB0aGlzLmlzTGl2ZSA9IGZhbHNlOwogICAgIHRoaXMuc3RhdHVzSGlkZGVuID0gdHJ1
ZTsKKyAgICB0aGlzLmhhc1Zpc3VhbE1lZGlhID0gZmFsc2U7CiAKICAgICB0aGlzLmFkZFZpZGVv
TGlzdGVuZXJzKCk7CiAgICAgdGhpcy5jcmVhdGVCYXNlKCk7CkBAIC01NTQsNiArNTU1LDggQEAg
Q29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAKICAgICBoYW5kbGVSZWFkeVN0YXRlQ2hhbmdlOiBm
dW5jdGlvbihldmVudCkKICAgICB7CisgICAgICAgIGlmICh0aGlzLnZpZGVvLnZpZGVvVHJhY2tz
ICYmIHRoaXMudmlkZW8udmlkZW9UcmFja3MubGVuZ3RoID4gMCkKKyAgICAgICAgICAgIHRoaXMu
aGFzVmlzdWFsTWVkaWEgPSB0cnVlOwogICAgICAgICB0aGlzLnVwZGF0ZVJlYWR5U3RhdGUoKTsK
ICAgICAgICAgdGhpcy51cGRhdGVEdXJhdGlvbigpOwogICAgICAgICB0aGlzLnVwZGF0ZUNhcHRp
b25CdXR0b24oKTsKQEAgLTgzNiw3ICs4MzksNyBAQCBDb250cm9sbGVyLnByb3RvdHlwZSA9IHsK
IAogICAgIHVwZGF0ZUZ1bGxzY3JlZW5CdXR0b246IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAg
IHRoaXMuY29udHJvbHMuZnVsbHNjcmVlbkJ1dHRvbi5jbGFzc0xpc3QudG9nZ2xlKHRoaXMuQ2xh
c3NOYW1lcy5oaWRkZW4sICF0aGlzLnZpZGVvLndlYmtpdFN1cHBvcnRzRnVsbHNjcmVlbik7Cisg
ICAgICAgIHRoaXMuY29udHJvbHMuZnVsbHNjcmVlbkJ1dHRvbi5jbGFzc0xpc3QudG9nZ2xlKHRo
aXMuQ2xhc3NOYW1lcy5oaWRkZW4sICghdGhpcy52aWRlby53ZWJraXRTdXBwb3J0c0Z1bGxzY3Jl
ZW4gfHwgIXRoaXMuaGFzVmlzdWFsTWVkaWEpKTsKICAgICB9LAogCiAgICAgaGFuZGxlRnVsbHNj
cmVlbkJ1dHRvbkNsaWNrZWQ6IGZ1bmN0aW9uKGV2ZW50KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvZG9tL0VsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKaW5kZXgg
MGIwMTM3NjA5Nzc1YzM2ZTdlY2VhODEyZGM5MTIzNjFmY2E0NmFlMi4uN2U4MTIzMTdhNzY5YTA5
MDU2NTljOWU3MDI5NGI4MzhiYzU2N2NkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t
L0VsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCkBAIC01NjYsNyAr
NTY2LDcgQEAgcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgdm9pZCByZW1vdmVBbGxFdmVudExpc3Rl
bmVycygpIG92ZXJyaWRlIGZpbmFsOwogICAgIHZpcnR1YWwgdm9pZCBwYXJzZXJEaWRTZXRBdHRy
aWJ1dGVzKCk7CiAKLSAgICB2b2lkIGNsZWFyVGFiSW5kZXhFeHBsaWNpdGx5SWZOZWVkZWQoKTsg
ICAgCisgICAgdm9pZCBjbGVhclRhYkluZGV4RXhwbGljaXRseUlmTmVlZGVkKCk7CiAgICAgdm9p
ZCBzZXRUYWJJbmRleEV4cGxpY2l0bHkoc2hvcnQpOwogCiAgICAgUmVmUHRyPEhUTUxDb2xsZWN0
aW9uPiBlbnN1cmVDYWNoZWRIVE1MQ29sbGVjdGlvbihDb2xsZWN0aW9uVHlwZSk7CkBAIC01NzYs
OCArNTc2LDggQEAgcHJvdGVjdGVkOgogICAgIC8vIHBhcnNlQXR0cmlidXRlIChjYWxsZWQgdmlh
IHNldEF0dHJpYnV0ZSgpKSBhbmQKICAgICAvLyBzdmdBdHRyaWJ1dGVDaGFuZ2VkIChjYWxsZWQg
d2hlbiBlbGVtZW50LmNsYXNzTmFtZS5iYXNlVmFsdWUgaXMgc2V0KQogICAgIHZvaWQgY2xhc3NB
dHRyaWJ1dGVDaGFuZ2VkKGNvbnN0IEF0b21pY1N0cmluZyYgbmV3Q2xhc3NTdHJpbmcpOwotICAg
IAotICAgIHN0YXRpYyB2b2lkIG1lcmdlV2l0aE5leHRUZXh0Tm9kZShUZXh0JiBub2RlLCBFeGNl
cHRpb25Db2RlJiBlYyk7CisKKyAgICBzdGF0aWMgdm9pZCBtZXJnZVdpdGhOZXh0VGV4dE5vZGUo
VGV4dCYgbm9kZSwgRXhjZXB0aW9uQ29kZSYpOwogCiBwcml2YXRlOgogICAgIGJvb2wgaXNUZXh0
Tm9kZSgpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRN
TFRyZWVCdWlsZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUcmVlQnVp
bGRlci5jcHAKaW5kZXggOTY1N2I2OTUzZWViMzQ5YTcwZTAzYjBmOWNhNjc5NTIwYWM3ODdlYi4u
MTk1ODhhZTdjYjEwZDUyNTllYTdlNzE5ZDljMjdmMDVlZjMwYTVkNSAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuY3BwCkBAIC0yODM5LDE4ICsyODM5
LDE3IEBAIHZvaWQgSFRNTFRyZWVCdWlsZGVyOjpwcm9jZXNzU2NyaXB0U3RhcnRUYWcoQXRvbWlj
SFRNTFRva2VuKiB0b2tlbikKIAogICAgIHNldEluc2VydGlvbk1vZGUoSW5zZXJ0aW9uTW9kZTo6
VGV4dCk7CiB9Ci0gICAgCisKIC8vIGh0dHA6Ly93d3cud2hhdHdnLm9yZy9zcGVjcy93ZWItYXBw
cy9jdXJyZW50LXdvcmsvI2FkanVzdGVkLWN1cnJlbnQtbm9kZQogSFRNTFN0YWNrSXRlbSogSFRN
TFRyZWVCdWlsZGVyOjphZGp1c3RlZEN1cnJlbnRTdGFja0l0ZW0oKSBjb25zdAogewogICAgIEFT
U0VSVCghbV90cmVlLmlzRW1wdHkoKSk7CiAgICAgaWYgKGlzUGFyc2luZ0ZyYWdtZW50KCkgJiYg
bV90cmVlLm9wZW5FbGVtZW50cygpLT5oYXNPbmx5T25lRWxlbWVudCgpKQogICAgICAgICByZXR1
cm4gbV9mcmFnbWVudENvbnRleHQuY29udGV4dEVsZW1lbnRTdGFja0l0ZW0oKTsKLSAgICAgICAg
CisKICAgICByZXR1cm4gbV90cmVlLmN1cnJlbnRTdGFja0l0ZW0oKTsKIH0KIAotCiAvLyBodHRw
Oi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2ViLWFwcHMvY3VycmVudC13b3JrL211bHRpcGFnZS90
cmVlLWNvbnN0cnVjdGlvbi5odG1sI3RyZWUtY29uc3RydWN0aW9uCiBib29sIEhUTUxUcmVlQnVp
bGRlcjo6c2hvdWxkUHJvY2Vzc1Rva2VuSW5Gb3JlaWduQ29udGVudChBdG9taWNIVE1MVG9rZW4q
IHRva2VuKQogewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVz
dHMvQ2hhbmdlTG9nCmluZGV4IGM3NGJlM2E2MGMxZTQ4MGNlYmY2NGNmNTkzM2I1MjRiNzI0MDc0
Y2IuLjFjN2JkNTVjNzk0ZTA5ZWVkNzVkYzkwMTJiNjllNGJhYjAzMTk4NmYgMTAwNjQ0Ci0tLSBh
L0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNyBAQAorMjAxNC0xMi0wMiAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CisK
KyAgICAgICAgW01lZGlhXSBBdWRpbyBjb250ZW50IHNob3VsZG4ndCBoYXZlIGZ1bGxzY3JlZW4g
YnV0dG9ucywgZXZlbiBpZiBpbiBhIHZpZGVvIGVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTIwMAorICAgICAgICA8cmRhcjovL3Byb2Js
ZW0vMTg5MTQ1MDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgTG9hZHMgYW4gYXVkaW8gZmlsZSB2aWEgdGhlIHZpZGVvIGVsZW1lbnQgYW5kIGNoZWNr
cyBpZiB0aGUKKyAgICAgICAgZnVsbHNjcmVlbiBidXR0b24gaXMgdmlzaWJsZS4KKworICAgICAg
ICAqIG1lZGlhL2F1ZGlvLWFzLXZpZGVvLWZ1bGxzY3JlZW4tZXhwZWN0ZWQudHh0OiBBZGRlZC4K
KyAgICAgICAgKiBtZWRpYS9hdWRpby1hcy12aWRlby1mdWxsc2NyZWVuLmh0bWw6IEFkZGVkLgor
CiAyMDE0LTEyLTAyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg
Q3Jhc2ggd2hlbiBzZXR0aW5nICdmbGV4JyBDU1MgcHJvcGVydHkgdG8gJ2NhbGMoMiAqIDMpIGNh
bGMoMiAqIDMpJwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvYXVkaW8tYXMtdmlkZW8t
ZnVsbHNjcmVlbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS9hdWRpby1hcy12aWRl
by1mdWxsc2NyZWVuLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42MzNlYzk4NWMyMDljY2IxOTBi
NzUzYzNmOGNhNmNkYTRiMzE0YzllCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVk
aWEvYXVkaW8tYXMtdmlkZW8tZnVsbHNjcmVlbi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw4IEBA
CitUZXN0cyB0aGF0IGFuIGF1ZGlvIGZpbGUgaW4gYSB2aWRlbyBlbGVtZW50IHNob3VsZCBub3Qg
aGF2ZSBhIGZ1bGxzY3JlZW4gYnV0dG9uCisKKworKiogUGxheWluZyB0aGUgdmlkZW8gKioKK1JV
Tih2aWRlby5wbGF5KCkpCisqKiBUZXN0aW5nIGlmIHRoZSBmdWxsc2NyZWVuIGJ1dHRvbiBpcyBo
aWRkZW4gKioKK0VYUEVDVEVEIChmdWxsc2NyZWVuQnV0dG9uLmNsYXNzTGlzdC5jb250YWlucygn
aGlkZGVuJykgPT0gJ3RydWUnKSBPSworCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9h
dWRpby1hcy12aWRlby1mdWxsc2NyZWVuLmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS9hdWRpby1h
cy12aWRlby1mdWxsc2NyZWVuLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uODNiMWE2MTYyOWVhN2JmOGQ4NmQz
YzQ3NWZjYzU3ZGI0OWQ4OTA0NAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlh
L2F1ZGlvLWFzLXZpZGVvLWZ1bGxzY3JlZW4uaHRtbApAQCAtMCwwICsxLDM3IEBACis8aHRtbD4K
KzxoZWFkPgorICAgIDx0aXRsZT5UZXN0IHRoYXQgYW4gYXVkaW8gZmlsZSBpbiBhIHZpZGVvIGVs
ZW1lbnQgc2hvdWxkIG5vdCBoYXZlIGEgZnVsbHNjcmVlbiBidXR0b248L3RpdGxlPgorICAgIDxz
Y3JpcHQgc3JjPW1lZGlhLWZpbGUuanM+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9bWVkaWEt
Y29udHJvbHMuanM+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9dmlkZW8tdGVzdC5qcz48L3Nj
cmlwdD4KKyAgICA8c2NyaXB0PgorICAgICAgICB2YXIgdmlkZW87CisgICAgICAgIHZhciBwYW5l
bDsKKyAgICAgICAgdmFyIGZ1bGxzY3JlZW5CdXR0b247CisKKyAgICAgICAgZnVuY3Rpb24gaW5p
dCgpCisgICAgICAgIHsKKyAgICAgICAgICAgIHZpZGVvID0gZG9jdW1lbnQucXVlcnlTZWxlY3Rv
cigidmlkZW8iKTsKKworICAgICAgICAgICAgY29uc29sZVdyaXRlKCIiKTsKKyAgICAgICAgICAg
IGNvbnNvbGVXcml0ZSgiKiogUGxheWluZyB0aGUgdmlkZW8gKioiKTsKKyAgICAgICAgICAgIHJ1
bigidmlkZW8ucGxheSgpIik7CisgICAgICAgIH0KKworICAgICAgICBmdW5jdGlvbiB0ZXN0KCkK
KyAgICAgICAgeworICAgICAgICAgICAgY29uc29sZVdyaXRlKCIqKiBUZXN0aW5nIGlmIHRoZSBm
dWxsc2NyZWVuIGJ1dHRvbiBpcyBoaWRkZW4gKioiKTsKKyAgICAgICAgICAgIGlmICh3aW5kb3cu
aW50ZXJuYWxzKSB7CisgICAgICAgICAgICAgICAgZnVsbHNjcmVlbkJ1dHRvbiA9IG1lZGlhQ29u
dHJvbHNFbGVtZW50KGludGVybmFscy5zaGFkb3dSb290KHZpZGVvKS5maXJzdENoaWxkLCAiLXdl
YmtpdC1tZWRpYS1jb250cm9scy1mdWxsc2NyZWVuLWJ1dHRvbiIpOworICAgICAgICAgICAgICAg
IHRlc3RFeHBlY3RlZCgiZnVsbHNjcmVlbkJ1dHRvbi5jbGFzc0xpc3QuY29udGFpbnMoJ2hpZGRl
bicpIiwgdHJ1ZSk7CisgICAgICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Cisg
ICAgICAgICAgICB9CisgICAgICAgIH0KKworICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkg
b25sb2FkPSJpbml0KCkiPgorICAgIFRlc3RzIHRoYXQgYW4gYXVkaW8gZmlsZSBpbiBhIHZpZGVv
IGVsZW1lbnQgc2hvdWxkIG5vdCBoYXZlIGEgZnVsbHNjcmVlbiBidXR0b248YnI+CisgICAgPHZp
ZGVvIHNyYz0iY29udGVudC9zaWxlbmNlLndhdiIgb25wbGF5PSJ0ZXN0KCkiIGNvbnRyb2xzPjwv
dmlkZW8+Cis8L2JvZHk+Cis8L2h0bWw+Cg==
</data>
<flag name="review"
          id="267340"
          type_id="1"
          status="+"
          setter="eric.carlson"
    />
          </attachment>
      

    </bug>

</bugzilla>