139181 2014-12-02 04:57:12 -0800 [GStreamer] Media Source sending seek event fails. 2014-12-02 09:07:11 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 b.gajda webkit-unassigned commit-queue pnormand oldest_to_newest 1051799 0 b.gajda 2014-12-02 04:57:12 -0800 There were callbacks connected to app_src on 'seek', but if stream type was not seekable, they would never launch. 1051801 1 242401 b.gajda 2014-12-02 05:00:13 -0800 Created attachment 242401 sets the app_src stream type in WebKitMediaSourceGStreamer to seekable. this will fix it. 1051808 2 242401 pnormand 2014-12-02 05:23:55 -0800 Comment on attachment 242401 sets the app_src stream type in WebKitMediaSourceGStreamer to seekable. View in context: https://bugs.webkit.org/attachment.cgi?id=242401&action=review > Source/WebCore/ChangeLog:3 > + [GStreamer] To receive seek signal, we need to set app_src stream type to seekable. This bug title could be improved I think... How about [GStreamer] MediaSource seeking fails ... ? That's the symptom, right? 1051831 3 b.gajda 2014-12-02 08:07:22 -0800 Does [GStreamer] Media Source sending seek event fails. sounds better? I'm not sure will everything work since this, but without it MediaPlayerPrivateGStreamer::doSeek() will fail. 1051832 4 242408 b.gajda 2014-12-02 08:12:53 -0800 Created attachment 242408 sets the stream type to seekable, changed patch name Changed name accordingly. 1051850 5 242408 commit-queue 2014-12-02 09:07:07 -0800 Comment on attachment 242408 sets the stream type to seekable, changed patch name Clearing flags on attachment: 242408 Committed r176664: <http://trac.webkit.org/changeset/176664> 1051851 6 commit-queue 2014-12-02 09:07:11 -0800 All reviewed patches have been landed. Closing bug. 242401 2014-12-02 05:00:13 -0800 2014-12-02 08:12:53 -0800 sets the app_src stream type in WebKitMediaSourceGStreamer to seekable. patch_appsrc_v1 text/plain 1921 b.gajda ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1MDY0NDg2Li45NjgwOWRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMTItMDIgIEJhcnRsb21pZWogR2FqZGEgIDxiLmdhamRhQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtHU3RyZWFtZXJdIFRvIHJlY2VpdmUgc2VlayBzaWduYWwsIHdlIG5lZWQgdG8g c2V0IGFwcF9zcmMgc3RyZWFtIHR5cGUgdG8gc2Vla2FibGUuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzkxODEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSB3ZXJlIGNhbGxiYWNrcyBjb25uZWN0 ZWQgdG8gYXBwX3NyYyBvbiAnc2VlaycsIGJ1dCBpZiBzdHJlYW0gdHlwZSBpcyBub3Qgc2Vla2Fi bGUsIHRoZXkgd291bGQgbmV2ZXIgbGF1bmNoLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVk ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0TWVkaWFT b3VyY2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAod2Via2l0X21lZGlhX3NyY19pbml0KToKKwog MjAxNC0xMi0wMiAgU3lsdmFpbiBHYWxpbmVhdSAgPGdhbGluZWF1QGFkb2JlLmNvbT4KIAogICAg ICAgICBNaXNzaW5nIHN1cHBvcnQgZm9yIGlubmVySFRNTCBvbiBTVkdFbGVtZW50CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0TWVk aWFTb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL1dlYktpdE1lZGlhU291cmNlR1N0cmVhbWVyLmNwcAppbmRleCA4MjBmNjFjLi5i OWE1NDI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvV2ViS2l0TWVkaWFTb3VyY2VHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRNZWRpYVNvdXJjZUdTdHJlYW1lci5j cHAKQEAgLTE3NywxMCArMTc3LDEyIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9tZWRpYV9zcmNfaW5p dChXZWJLaXRNZWRpYVNyYyogc3JjKQogCiAgICAgcHJpdi0+c291cmNlVmlkZW8uYXBwc3JjID0g Z3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJhcHBzcmMiLCAidmlkZW9hcHBzcmMiKTsKICAgICBn c3RfYXBwX3NyY19zZXRfY2FsbGJhY2tzKEdTVF9BUFBfU1JDKHByaXYtPnNvdXJjZVZpZGVvLmFw cHNyYyksICZhcHBzcmNDYWxsYmFja3NWaWRlbywgc3JjLCAwKTsKKyAgICBnc3RfYXBwX3NyY19z ZXRfc3RyZWFtX3R5cGUoR1NUX0FQUF9TUkMocHJpdi0+c291cmNlVmlkZW8uYXBwc3JjKSwgR1NU X0FQUF9TVFJFQU1fVFlQRV9TRUVLQUJMRSk7CiAgICAgd2ViS2l0TWVkaWFTcmNBZGRTcmMoc3Jj LCBwcml2LT5zb3VyY2VWaWRlby5hcHBzcmMpOwogCiAgICAgcHJpdi0+c291cmNlQXVkaW8uYXBw c3JjID0gZ3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJhcHBzcmMiLCAiYXVkaW9hcHBzcmMiKTsK ICAgICBnc3RfYXBwX3NyY19zZXRfY2FsbGJhY2tzKEdTVF9BUFBfU1JDKHByaXYtPnNvdXJjZUF1 ZGlvLmFwcHNyYyksICZhcHBzcmNDYWxsYmFja3NBdWRpbywgc3JjLCAwKTsKKyAgICBnc3RfYXBw X3NyY19zZXRfc3RyZWFtX3R5cGUoR1NUX0FQUF9TUkMocHJpdi0+c291cmNlQXVkaW8uYXBwc3Jj KSwgR1NUX0FQUF9TVFJFQU1fVFlQRV9TRUVLQUJMRSk7CiAgICAgd2ViS2l0TWVkaWFTcmNBZGRT cmMoc3JjLCBwcml2LT5zb3VyY2VBdWRpby5hcHBzcmMpOwogfQogCg== 242408 2014-12-02 08:12:53 -0800 2014-12-02 09:07:07 -0800 sets the stream type to seekable, changed patch name patch_diff_v2 text/plain 1960 b.gajda ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1MDY0NDg2Li43ZmMwNDc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTQtMTItMDIgIEJhcnRsb21pZWogR2FqZGEgIDxiLmdhamRhQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtHU3RyZWFtZXJdIE1lZGlhIFNvdXJjZSBzZW5kaW5nIHNlZWsgZXZlbnQgZmFp bHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzkx ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVy ZSB3ZXJlIGNhbGxiYWNrcyBjb25uZWN0ZWQgdG8gYXBwX3NyYyBvbiAnc2VlaycsIGJ1dCBpZiBz dHJlYW0gdHlwZSBpcyBub3Qgc2Vla2FibGUsIHRoZXkgd291bGQgbmV2ZXIgbGF1bmNoLAorICAg ICAgICBhbmQgc2Vla2luZyAoYXMgaW4gTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpkb1Nl ZWspIGZhaWxzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0TWVkaWFTb3VyY2VHU3RyZWFtZXIuY3Bw OgorICAgICAgICAod2Via2l0X21lZGlhX3NyY19pbml0KToKKwogMjAxNC0xMi0wMiAgU3lsdmFp biBHYWxpbmVhdSAgPGdhbGluZWF1QGFkb2JlLmNvbT4KIAogICAgICAgICBNaXNzaW5nIHN1cHBv cnQgZm9yIGlubmVySFRNTCBvbiBTVkdFbGVtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0TWVkaWFTb3VyY2VHU3RyZWFtZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdE1l ZGlhU291cmNlR1N0cmVhbWVyLmNwcAppbmRleCA4MjBmNjFjLi5iOWE1NDI4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0TWVkaWFT b3VyY2VHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9XZWJLaXRNZWRpYVNvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTE3NywxMCArMTc3 LDEyIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9tZWRpYV9zcmNfaW5pdChXZWJLaXRNZWRpYVNyYyog c3JjKQogCiAgICAgcHJpdi0+c291cmNlVmlkZW8uYXBwc3JjID0gZ3N0X2VsZW1lbnRfZmFjdG9y eV9tYWtlKCJhcHBzcmMiLCAidmlkZW9hcHBzcmMiKTsKICAgICBnc3RfYXBwX3NyY19zZXRfY2Fs bGJhY2tzKEdTVF9BUFBfU1JDKHByaXYtPnNvdXJjZVZpZGVvLmFwcHNyYyksICZhcHBzcmNDYWxs YmFja3NWaWRlbywgc3JjLCAwKTsKKyAgICBnc3RfYXBwX3NyY19zZXRfc3RyZWFtX3R5cGUoR1NU X0FQUF9TUkMocHJpdi0+c291cmNlVmlkZW8uYXBwc3JjKSwgR1NUX0FQUF9TVFJFQU1fVFlQRV9T RUVLQUJMRSk7CiAgICAgd2ViS2l0TWVkaWFTcmNBZGRTcmMoc3JjLCBwcml2LT5zb3VyY2VWaWRl by5hcHBzcmMpOwogCiAgICAgcHJpdi0+c291cmNlQXVkaW8uYXBwc3JjID0gZ3N0X2VsZW1lbnRf ZmFjdG9yeV9tYWtlKCJhcHBzcmMiLCAiYXVkaW9hcHBzcmMiKTsKICAgICBnc3RfYXBwX3NyY19z ZXRfY2FsbGJhY2tzKEdTVF9BUFBfU1JDKHByaXYtPnNvdXJjZUF1ZGlvLmFwcHNyYyksICZhcHBz cmNDYWxsYmFja3NBdWRpbywgc3JjLCAwKTsKKyAgICBnc3RfYXBwX3NyY19zZXRfc3RyZWFtX3R5 cGUoR1NUX0FQUF9TUkMocHJpdi0+c291cmNlQXVkaW8uYXBwc3JjKSwgR1NUX0FQUF9TVFJFQU1f VFlQRV9TRUVLQUJMRSk7CiAgICAgd2ViS2l0TWVkaWFTcmNBZGRTcmMoc3JjLCBwcml2LT5zb3Vy Y2VBdWRpby5hcHBzcmMpOwogfQogCg==