139157 2014-12-01 15:04:55 -0800 Optimize constructing JSC::Identifier from AtomicString. 2014-12-03 03:19:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling benjamin cmarcelo commit-queue ddkilzer ggaren kling oldest_to_newest 1051627 0 kling 2014-12-01 15:04:55 -0800 Constructing a Identifier from an AtomicString or an AtomicStringImpl would be more efficient if we stopped branching on the StringImpl's "isAtomic" flag. 1051628 1 242352 kling 2014-12-01 15:05:41 -0800 Created attachment 242352 Patch 1051629 2 commit-queue 2014-12-01 15:07:11 -0800 Attachment 242352 did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/Identifier.h:51: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 1051636 3 242352 msaboff 2014-12-01 15:28:49 -0800 Comment on attachment 242352 Patch r=me 1051706 4 242352 kling 2014-12-01 18:20:49 -0800 Comment on attachment 242352 Patch Clearing flags on attachment: 242352 Committed r176622: <http://trac.webkit.org/changeset/176622> 1051707 5 kling 2014-12-01 18:20:53 -0800 All reviewed patches have been landed. Closing bug. 1052106 6 ddkilzer 2014-12-03 03:19:26 -0800 (In reply to comment #5) > All reviewed patches have been landed. Closing bug. Follow-up build fix for iOS: <http://trac.webkit.org/r176715> 242352 2014-12-01 15:05:41 -0800 2014-12-01 18:20:49 -0800 Patch bug-139157.diff text/plain 5583 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDZhMTM3OTguLjExZTM5MWEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE0LTEyLTAxICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBPcHRpbWl6ZSBjb25zdHJ1Y3RpbmcgSlND OjpJZGVudGlmaWVyIGZyb20gQXRvbWljU3RyaW5nLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQu b3JnL2IvMTM5MTU3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCBjb25zdHJ1Y3RvcnMgZm9yIElkZW50aWZpZXIgdGFraW5nIEF0b21pY1N0cmlu ZyBhbmQgQXRvbWljU3RyaW5nSW1wbC4KKyAgICAgICAgVGhpcyBhdm9pZHMgYnJhbmNoaW5nIG9u IHRoZSBzdHJpbmcncyBpc0F0b21pYyBmbGFnLCB3aGljaCBpcyBvYnZpb3VzbHkKKyAgICAgICAg YWx3YXlzIHRydWUgZm9yIEF0b21pY1N0cmluZyAmIEF0b21pY1N0cmluZ0ltcGwuCisKKyAgICAg ICAgSGFkIHRvIGFkZCBhIElkZW50aWZpZXIoY29uc3QgY2hhciopIGNvbnN0cnVjdG9yIHRvIHJl c29sdmUgaW1wbGljaXQKKyAgICAgICAgYW1iaWd1aXR5IGJldHdlZW4gU3RyaW5nIC8gQXRvbWlj U3RyaW5nLgorCisgICAgICAgIEFsc28gbWFkZSBQcml2YXRlTmFtZTo6dWlkKCkgcmV0dXJuIEF0 b21pY1N0cmluZ0ltcGwqIHRvIHRha2UgYWR2YW50YWdlCisgICAgICAgIG9mIHRoZSBuZXcgY29u c3RydWN0b3IgaW4gYSBmZXcgcGxhY2VzLgorCisgICAgICAgICogcnVudGltZS9JZGVudGlmaWVy Lmg6CisgICAgICAgIChKU0M6OklkZW50aWZpZXI6OklkZW50aWZpZXIpOgorICAgICAgICAqIHJ1 bnRpbWUvSWRlbnRpZmllcklubGluZXMuaDoKKyAgICAgICAgKEpTQzo6SWRlbnRpZmllcjo6SWRl bnRpZmllcik6CisgICAgICAgICogcnVudGltZS9Qcml2YXRlTmFtZS5oOgorICAgICAgICAoSlND OjpQcml2YXRlTmFtZTo6dWlkKToKKwogMjAxNC0xMS0yOSAgQW5kcmVhcyBLbGluZyAgPGFrbGlu Z0BhcHBsZS5jb20+CiAKICAgICAgICAgUHJvcGVydHlUYWJsZSBrZXlzIHNob3VsZCBiZSBBdG9t aWNTdHJpbmdJbXBsLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SWRlbnRpZmllci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSWRlbnRpZmllci5o CmluZGV4IDIzMWFiMTAuLmQ5ZmUyMGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0lkZW50aWZpZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9JZGVudGlmaWVyLmgKQEAgLTQ0LDggKzQ0LDExIEBAIHB1YmxpYzoKICAgICB0ZW1wbGF0ZTx1 bnNpZ25lZCBjaGFyYWN0ZXJzQ291bnQ+CiAgICAgSWRlbnRpZmllcihWTSogdm0sIGNvbnN0IGNo YXIgKCZjaGFyYWN0ZXJzKVtjaGFyYWN0ZXJzQ291bnRdKSA6IG1fc3RyaW5nKGFkZCh2bSwgY2hh cmFjdGVycykpIHsgQVNTRVJUKG1fc3RyaW5nLmltcGwoKS0+aXNBdG9taWMoKSk7IH0KIAorICAg IElkZW50aWZpZXIoRXhlY1N0YXRlKiwgQXRvbWljU3RyaW5nSW1wbCopOworICAgIElkZW50aWZp ZXIoRXhlY1N0YXRlKiwgY29uc3QgQXRvbWljU3RyaW5nJik7CiAgICAgSWRlbnRpZmllcihFeGVj U3RhdGUqIGV4ZWMsIFN0cmluZ0ltcGwqIHJlcCkgOiBtX3N0cmluZyhhZGQoZXhlYywgcmVwKSkg eyBBU1NFUlQobV9zdHJpbmcuaW1wbCgpLT5pc0F0b21pYygpKTsgfQogICAgIElkZW50aWZpZXIo RXhlY1N0YXRlKiBleGVjLCBjb25zdCBTdHJpbmcmIHMpIDogbV9zdHJpbmcoYWRkKGV4ZWMsIHMu aW1wbCgpKSkgeyBBU1NFUlQobV9zdHJpbmcuaW1wbCgpLT5pc0F0b21pYygpKTsgfQorICAgIElk ZW50aWZpZXIoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBjaGFyKiBzKSA6IElkZW50aWZpZXIoZXhl YywgQXRvbWljU3RyaW5nKHMpKSB7IH0KIAogICAgIElkZW50aWZpZXIoVk0qIHZtLCBjb25zdCBM Q2hhciogcywgaW50IGxlbmd0aCkgOiBtX3N0cmluZyhhZGQodm0sIHMsIGxlbmd0aCkpIHsgQVNT RVJUKG1fc3RyaW5nLmltcGwoKS0+aXNBdG9taWMoKSk7IH0KICAgICBJZGVudGlmaWVyKFZNKiB2 bSwgY29uc3QgVUNoYXIqIHMsIGludCBsZW5ndGgpIDogbV9zdHJpbmcoYWRkKHZtLCBzLCBsZW5n dGgpKSB7IEFTU0VSVChtX3N0cmluZy5pbXBsKCktPmlzQXRvbWljKCkpOyB9CmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JZGVudGlmaWVySW5saW5lcy5oIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSWRlbnRpZmllcklubGluZXMuaAppbmRleCAzYTdl MjBiLi5lZmMzZDNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9J ZGVudGlmaWVySW5saW5lcy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0lk ZW50aWZpZXJJbmxpbmVzLmgKQEAgLTMxLDYgKzMxLDMwIEBACiAKIG5hbWVzcGFjZSBKU0MgIHsK IAoraW5saW5lIElkZW50aWZpZXI6OklkZW50aWZpZXIoRXhlY1N0YXRlKiBleGVjLCBBdG9taWNT dHJpbmdJbXBsKiBzdHJpbmcpCisgICAgOiBtX3N0cmluZyhzdHJpbmcpCit7CisjaWZuZGVmIE5E RUJVRworICAgIGNoZWNrQ3VycmVudEF0b21pY1N0cmluZ1RhYmxlKGV4ZWMpOworICAgIGlmIChz dHJpbmcpCisgICAgICAgIEFTU0VSVF9XSVRIX01FU1NBR0UoIXN0cmluZy0+bGVuZ3RoKCkgfHwg QXRvbWljU3RyaW5nOjppc0luQXRvbWljU3RyaW5nVGFibGUoc3RyaW5nKSwgIlRoZSBhdG9taWMg c3RyaW5nIGNvbWVzIGZyb20gYW4gb3RoZXIgdGhyZWFkISIpOworI2Vsc2UKKyAgICBVTlVTRURf UEFSQU0oZXhlYyk7CisjZW5kaWYKK30KKworaW5saW5lIElkZW50aWZpZXI6OklkZW50aWZpZXIo RXhlY1N0YXRlKiBleGVjLCBjb25zdCBBdG9taWNTdHJpbmcmIHN0cmluZykKKyAgICA6IG1fc3Ry aW5nKHN0cmluZy5zdHJpbmcoKSkKK3sKKyNpZm5kZWYgTkRFQlVHCisgICAgY2hlY2tDdXJyZW50 QXRvbWljU3RyaW5nVGFibGUoZXhlYyk7CisgICAgaWYgKCFzdHJpbmcuaXNOdWxsKCkpCisgICAg ICAgIEFTU0VSVF9XSVRIX01FU1NBR0UoIXN0cmluZy5sZW5ndGgoKSB8fCBBdG9taWNTdHJpbmc6 OmlzSW5BdG9taWNTdHJpbmdUYWJsZShzdHJpbmcuaW1wbCgpKSwgIlRoZSBhdG9taWMgc3RyaW5n IGNvbWVzIGZyb20gYW4gb3RoZXIgdGhyZWFkISIpOworI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0o ZXhlYyk7CisjZW5kaWYKK30KKwogaW5saW5lIFBhc3NSZWY8U3RyaW5nSW1wbD4gSWRlbnRpZmll cjo6YWRkKEV4ZWNTdGF0ZSogZXhlYywgU3RyaW5nSW1wbCogcikKIHsKICNpZm5kZWYgTkRFQlVH CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Qcml2YXRlTmFtZS5o IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUHJpdmF0ZU5hbWUuaAppbmRleCA1ZDI3 NzRhLi41NWVlNjM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Q cml2YXRlTmFtZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ByaXZhdGVO YW1lLmgKQEAgLTQyLDcgKzQyLDcgQEAgcHVibGljOgogICAgICAgICBBU1NFUlQobV9pbXBsLT5p c0VtcHR5VW5pcXVlKCkpOwogICAgIH0KIAotICAgIFN0cmluZ0ltcGwqIHVpZCgpIGNvbnN0IHsg cmV0dXJuIG1faW1wbC5nZXQoKTsgfQorICAgIEF0b21pY1N0cmluZ0ltcGwqIHVpZCgpIGNvbnN0 IHsgcmV0dXJuIHN0YXRpY19jYXN0PEF0b21pY1N0cmluZ0ltcGwqPihtX2ltcGwuZ2V0KCkpOyB9 CiAKIHByaXZhdGU6CiAgICAgUmVmUHRyPFN0cmluZ0ltcGw+IG1faW1wbDsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXggZWQ4MDgx MC4uYTNkODc5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNC0xMi0wMSAgQW5kcmVhcyBLbGlu ZyAgPGFrbGluZ0BhcHBsZS5jb20+CisKKyAgICAgICAgT3B0aW1pemUgY29uc3RydWN0aW5nIEpT Qzo6SWRlbnRpZmllciBmcm9tIEF0b21pY1N0cmluZy4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0 Lm9yZy9iLzEzOTE1Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBNYWtlIEF0b21pY1N0cmluZzo6aXNJbkF0b21pY1N0cmluZ1RhYmxlKCkgcHVibGlj IHNvIGl0IGNhbiBiZSB1c2VkCisgICAgICAgIGluIHNvbWUgSWRlbnRpZmllciBhc3NlcnRpb25z LgorCisgICAgICAgICogd3RmL3RleHQvQXRvbWljU3RyaW5nLmg6CisKIDIwMTQtMTEtMjEgIEFu ZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdGhl IFRpbWVyIHBhcmFtZXRlcnMgZnJvbSB0aW1lciBjYWxsYmFja3MKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmggYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21p Y1N0cmluZy5oCmluZGV4IDVmNWQyYzAuLjM4NjJhZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv d3RmL3RleHQvQXRvbWljU3RyaW5nLmgKKysrIGIvU291cmNlL1dURi93dGYvdGV4dC9BdG9taWNT dHJpbmcuaApAQCAtMjA0LDYgKzIwNCwxMCBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBhZGRT bG93Q2FzZSgqc3RyaW5nVGFibGVQcm92aWRlci5hdG9taWNTdHJpbmdUYWJsZSgpLCAqc3RyaW5n KTsKICAgICB9CiAKKyNpZiAhQVNTRVJUX0RJU0FCTEVECisgICAgV1RGX0VYUE9SVF9TVFJJTkdf QVBJIHN0YXRpYyBib29sIGlzSW5BdG9taWNTdHJpbmdUYWJsZShTdHJpbmdJbXBsKik7CisjZW5k aWYKKwogcHJpdmF0ZToKICAgICAvLyBUaGUgZXhwbGljaXQgY29uc3RydWN0b3JzIHdpdGggQXRv bWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCBtdXN0IGJlIHVzZWQgZm9yIGxpdGVyYWxz LgogICAgIEF0b21pY1N0cmluZyhBU0NJSUxpdGVyYWwpOwpAQCAtMjE1LDEwICsyMTksNiBAQCBw cml2YXRlOgogCiAgICAgV1RGX0VYUE9SVF9TVFJJTkdfQVBJIHN0YXRpYyBBdG9taWNTdHJpbmdJ bXBsKiBmaW5kU2xvd0Nhc2UoU3RyaW5nSW1wbCYpOwogICAgIFdURl9FWFBPUlRfU1RSSU5HX0FQ SSBzdGF0aWMgQXRvbWljU3RyaW5nIGZyb21VVEY4SW50ZXJuYWwoY29uc3QgY2hhciosIGNvbnN0 IGNoYXIqKTsKLQotI2lmICFBU1NFUlRfRElTQUJMRUQKLSAgICBXVEZfRVhQT1JUX1NUUklOR19B UEkgc3RhdGljIGJvb2wgaXNJbkF0b21pY1N0cmluZ1RhYmxlKFN0cmluZ0ltcGwqKTsKLSNlbmRp ZgogfTsKIAogaW5saW5lIGJvb2wgb3BlcmF0b3I9PShjb25zdCBBdG9taWNTdHJpbmcmIGEsIGNv bnN0IEF0b21pY1N0cmluZyYgYikgeyByZXR1cm4gYS5pbXBsKCkgPT0gYi5pbXBsKCk7IH0K