139148 2014-12-01 13:21:27 -0800 Implement renderbufferStorageMultisample as WebGL1 extension 2015-09-14 10:50:36 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 roger_fong webkit-unassigned bfulgham dino roger_fong oldest_to_newest 1051554 0 roger_fong 2014-12-01 13:21:27 -0800 rdar://problem/15949546 Most of the work here is just validation. I assume that the 1.0.3 conformance suite will have a test for this call. 1051563 1 242341 roger_fong 2014-12-01 13:37:55 -0800 Created attachment 242341 patch 1051566 2 roger_fong 2014-12-01 13:39:52 -0800 Some hand testing of this patch shows that the validation is working correctly. However, I am having some issues getting the actual call to work properly when I have more than 0 samples. I suspect my test case is incorrect since I don't specify anywhere to render a multisample texture. (texImage2DMultisample) I suspect that without this call the mismatch between a nonmultisampled texture and a render buffer with enough storage for a multisampled frame buffer is causing issues, but I could be wrong. 1051567 3 roger_fong 2014-12-01 13:40:27 -0800 I have indeed confirmed that the OpenGL call to ::glRenderBufferStorageMultisample is getting called as intended however. 1051881 4 roger_fong 2014-12-02 10:38:34 -0800 After emailing the Khronos group I got the following response from Kenneth Russel: I don't mean to discourage your work but this is no small task either from a specification or implementation standpoint. It would be necessary to spec out a WebGL 1 extension combining the semantics of both the ANGLE_framebuffer_blit and ANGLE_framebuffer_multisample extensions. Users' code also has to be modified to take advantage of multisampled renderbuffers. I think the effort would be better spent getting a WebGL 2 implementation ready, which will include this functionality in the core API. Indeed renderBufferStorageMultisample has not been specced out and there are no 1.0.x conformance tests testing it. TLDR: I don't think we should do this because it never made it into the WebGL spec in the first place. 1125619 5 242341 ossy 2015-09-14 10:50:36 -0700 Comment on attachment 242341 patch Cleared review? from attachment 242341 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 242341 2014-12-01 13:37:55 -0800 2015-09-14 10:50:36 -0700 patch ExtensionPatch.patch text/plain 6061 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjYwMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE0LTEyLTAxICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgSW1wbGVtZW50IHJlbmRlcmJ1 ZmZlclN0b3JhZ2VNdWx0aXNhbXBsZSBhcyBXZWJHTDEgZXh0ZW5zaW9uLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5MTQ4LgorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMTU5NDk1NDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGVzdCBub3QgeWV0IHdyaXR0ZW4uIAorICAgICAgICBJdCB3aWxsIGJl IGFkZGVkIHRvIGEgZnV0dXJlIGNvbmZvcm1hbmNlIHRlc3Qgc3VpdGUuCisKKyAgICAgICAgKiBo dG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 V2ViR0xSZW5kZXJpbmdDb250ZXh0OjpyZW5kZXJidWZmZXJTdG9yYWdlTXVsdGlzYW1wbGUpOgor ICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0Ojp2YWxpZGF0ZVNpemUpOgor ICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5oOgorICAgICAgICAq IGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5pZGw6CisKIDIwMTQtMTItMDEgIFRp bSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50 IHllbGxvdyBoaWdobGlnaHQgZm9yIFdlYktpdDEgZGF0YSBkZXRlY3RvcnMKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNw cAkocmV2aXNpb24gMTc1NzMxKQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xS ZW5kZXJpbmdDb250ZXh0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzY0NSw2ICszNjQ1LDU3IEBA IHZvaWQgV2ViR0xSZW5kZXJpbmdDb250ZXh0OjpyZW5kZXJidWZmZXIKICAgICBhcHBseVN0ZW5j aWxUZXN0KCk7CiB9CiAKK3ZvaWQgV2ViR0xSZW5kZXJpbmdDb250ZXh0OjpyZW5kZXJidWZmZXJT dG9yYWdlTXVsdGlzYW1wbGUoR0MzRGVudW0gdGFyZ2V0LCBHQzNEc2l6ZWkgc2FtcGxlQ291bnQs IEdDM0RlbnVtIGludGVybmFsZm9ybWF0LCBHQzNEc2l6ZWkgd2lkdGgsIEdDM0RzaXplaSBoZWln aHQpCit7CisgICAgaWYgKGlzQ29udGV4dExvc3RPclBlbmRpbmcoKSkKKyAgICAgICAgcmV0dXJu OworICAgIGlmICh0YXJnZXQgIT0gR3JhcGhpY3NDb250ZXh0M0Q6OlJFTkRFUkJVRkZFUikgewor ICAgICAgICBzeW50aGVzaXplR0xFcnJvcihHcmFwaGljc0NvbnRleHQzRDo6SU5WQUxJRF9FTlVN LCAicmVuZGVyYnVmZmVyU3RvcmFnZU11bHRpc2FtcGxlIiwgImludmFsaWQgdGFyZ2V0Iik7Cisg ICAgICAgIHJldHVybjsKKyAgICB9CisgICAgaWYgKCFtX3JlbmRlcmJ1ZmZlckJpbmRpbmcgfHwg IW1fcmVuZGVyYnVmZmVyQmluZGluZy0+b2JqZWN0KCkpIHsKKyAgICAgICAgc3ludGhlc2l6ZUdM RXJyb3IoR3JhcGhpY3NDb250ZXh0M0Q6OklOVkFMSURfT1BFUkFUSU9OLCAicmVuZGVyYnVmZmVy U3RvcmFnZU11bHRpc2FtcGxlIiwgIm5vIGJvdW5kIHJlbmRlcmJ1ZmZlciIpOworICAgICAgICBy ZXR1cm47CisgICAgfQorCisgICAgaWYgKCF2YWxpZGF0ZVNpemUoInJlbmRlcmJ1ZmZlclN0b3Jh Z2VNdWx0aXNhbXBsZSIsIHdpZHRoLCBoZWlnaHQpKQorICAgICAgICByZXR1cm47CisKKyAgICBp bnQgbWF4U2FtcGxlQ291bnQgPSAwOworICAgIG1fY29udGV4dC0+Z2V0SW50ZWdlcnYoRXh0ZW5z aW9uczNEOjpNQVhfU0FNUExFUywgJm1heFNhbXBsZUNvdW50KTsKKyAgICBpZiAoc2FtcGxlQ291 bnQgPiBtYXhTYW1wbGVDb3VudCkgeworICAgICAgICBzeW50aGVzaXplR0xFcnJvcihHcmFwaGlj c0NvbnRleHQzRDo6SU5WQUxJRF9PUEVSQVRJT04sICJyZW5kZXJidWZmZXJTdG9yYWdlTXVsdGlz YW1wbGUiLCAibWF4IG51bWJlciBvZiBzYW1wbGVzIGV4Y2VlZGVkIik7CisgICAgICAgIHJldHVy bjsKKyAgICB9CisKKyAgICBzd2l0Y2ggKGludGVybmFsZm9ybWF0KSB7CisgICAgY2FzZSBHcmFw aGljc0NvbnRleHQzRDo6REVQVEhfQ09NUE9ORU5UMTY6CisgICAgY2FzZSBHcmFwaGljc0NvbnRl eHQzRDo6UkdCQTQ6CisgICAgY2FzZSBHcmFwaGljc0NvbnRleHQzRDo6UkdCNV9BMToKKyAgICBj YXNlIEdyYXBoaWNzQ29udGV4dDNEOjpSR0I1NjU6CisgICAgY2FzZSBHcmFwaGljc0NvbnRleHQz RDo6U1RFTkNJTF9JTkRFWDg6CisgICAgY2FzZSBHcmFwaGljc0NvbnRleHQzRDo6REVQVEgyNF9T VEVOQ0lMODoKKyAgICBjYXNlIEV4dGVuc2lvbnMzRDo6UkdCOF9PRVM6CisgICAgY2FzZSBFeHRl bnNpb25zM0Q6OlJHQkE4X09FUzoKKyAgICAgICAgbV9jb250ZXh0LT5nZXRFeHRlbnNpb25zKCkt PnJlbmRlcmJ1ZmZlclN0b3JhZ2VNdWx0aXNhbXBsZSh0YXJnZXQsIHNhbXBsZUNvdW50LCBpbnRl cm5hbGZvcm1hdCwgd2lkdGgsIGhlaWdodCk7CisgICAgICAgIG1fcmVuZGVyYnVmZmVyQmluZGlu Zy0+c2V0SW50ZXJuYWxGb3JtYXQoaW50ZXJuYWxmb3JtYXQpOworICAgICAgICBtX3JlbmRlcmJ1 ZmZlckJpbmRpbmctPnNldElzVmFsaWQodHJ1ZSk7CisgICAgICAgIG1fcmVuZGVyYnVmZmVyQmlu ZGluZy0+c2V0U2l6ZSh3aWR0aCwgaGVpZ2h0KTsKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBH cmFwaGljc0NvbnRleHQzRDo6REVQVEhfU1RFTkNJTDoKKyAgICAgICAgaWYgKGlzRGVwdGhTdGVu Y2lsU3VwcG9ydGVkKCkpCisgICAgICAgICAgICBtX2NvbnRleHQtPmdldEV4dGVuc2lvbnMoKS0+ cmVuZGVyYnVmZmVyU3RvcmFnZU11bHRpc2FtcGxlKHRhcmdldCwgc2FtcGxlQ291bnQsIEV4dGVu c2lvbnMzRDo6REVQVEgyNF9TVEVOQ0lMOCwgd2lkdGgsIGhlaWdodCk7CisgICAgICAgIG1fcmVu ZGVyYnVmZmVyQmluZGluZy0+c2V0U2l6ZSh3aWR0aCwgaGVpZ2h0KTsKKyAgICAgICAgbV9yZW5k ZXJidWZmZXJCaW5kaW5nLT5zZXRJc1ZhbGlkKGlzRGVwdGhTdGVuY2lsU3VwcG9ydGVkKCkpOwor ICAgICAgICBtX3JlbmRlcmJ1ZmZlckJpbmRpbmctPnNldEludGVybmFsRm9ybWF0KGludGVybmFs Zm9ybWF0KTsKKyAgICAgICAgYnJlYWs7CisgICAgZGVmYXVsdDoKKyAgICAgICAgc3ludGhlc2l6 ZUdMRXJyb3IoR3JhcGhpY3NDb250ZXh0M0Q6OklOVkFMSURfRU5VTSwgInJlbmRlcmJ1ZmZlclN0 b3JhZ2VNdWx0aXNhbXBsZSIsICJpbnZhbGlkIGludGVybmFsZm9ybWF0Iik7CisgICAgICAgIHJl dHVybjsKKyAgICB9CisgICAgYXBwbHlTdGVuY2lsVGVzdCgpOworfQorCiB2b2lkIFdlYkdMUmVu ZGVyaW5nQ29udGV4dDo6c2FtcGxlQ292ZXJhZ2UoR0MzRGZsb2F0IHZhbHVlLCBHQzNEYm9vbGVh biBpbnZlcnQpCiB7CiAgICAgaWYgKGlzQ29udGV4dExvc3RPclBlbmRpbmcoKSkKQEAgLTUwNTUs NyArNTEwNiw3IEBAIGJvb2wgV2ViR0xSZW5kZXJpbmdDb250ZXh0Ojp2YWxpZGF0ZUxvY2EKIAog Ym9vbCBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnZhbGlkYXRlU2l6ZShjb25zdCBjaGFyKiBmdW5j dGlvbk5hbWUsIEdDM0RpbnQgeCwgR0MzRGludCB5KQogewotICAgIGlmICh4IDwgMCB8fCB5IDwg MCkgeworICAgIGlmICh4IDwgMCB8fCB5IDwgMCB8fCB4ID4gbV9tYXhSZW5kZXJidWZmZXJTaXpl IHx8IHkgPiBtX21heFJlbmRlcmJ1ZmZlclNpemUpIHsKICAgICAgICAgc3ludGhlc2l6ZUdMRXJy b3IoR3JhcGhpY3NDb250ZXh0M0Q6OklOVkFMSURfVkFMVUUsIGZ1bmN0aW9uTmFtZSwgInNpemUg PCAwIik7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuaAkocmV2aXNpb24g MTc1NzMxKQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250 ZXh0LmgJKHdvcmtpbmcgY29weSkKQEAgLTIwOCw2ICsyMDgsNyBAQCBwdWJsaWM6CiAgICAgdm9p ZCByZWFkUGl4ZWxzKEdDM0RpbnQgeCwgR0MzRGludCB5LCBHQzNEc2l6ZWkgd2lkdGgsIEdDM0Rz aXplaSBoZWlnaHQsIEdDM0RlbnVtIGZvcm1hdCwgR0MzRGVudW0gdHlwZSwgQXJyYXlCdWZmZXJW aWV3KiBwaXhlbHMsIEV4Y2VwdGlvbkNvZGUmKTsKICAgICB2b2lkIHJlbGVhc2VTaGFkZXJDb21w aWxlcigpOwogICAgIHZvaWQgcmVuZGVyYnVmZmVyU3RvcmFnZShHQzNEZW51bSB0YXJnZXQsIEdD M0RlbnVtIGludGVybmFsZm9ybWF0LCBHQzNEc2l6ZWkgd2lkdGgsIEdDM0RzaXplaSBoZWlnaHQp OworICAgIHZvaWQgcmVuZGVyYnVmZmVyU3RvcmFnZU11bHRpc2FtcGxlKEdDM0RlbnVtIHRhcmdl dCwgR0MzRHNpemVpIHNhbXBsZXMsIEdDM0RlbnVtIGludGVybmFsZm9ybWF0LCBHQzNEc2l6ZWkg d2lkdGgsIEdDM0RzaXplaSBoZWlnaHQpOwogICAgIHZvaWQgc2FtcGxlQ292ZXJhZ2UoR0MzRGZs b2F0IHZhbHVlLCBHQzNEYm9vbGVhbiBpbnZlcnQpOwogICAgIHZvaWQgc2Npc3NvcihHQzNEaW50 IHgsIEdDM0RpbnQgeSwgR0MzRHNpemVpIHdpZHRoLCBHQzNEc2l6ZWkgaGVpZ2h0KTsKICAgICB2 b2lkIHNoYWRlclNvdXJjZShXZWJHTFNoYWRlciosIGNvbnN0IFN0cmluZyYsIEV4Y2VwdGlvbkNv ZGUmKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29u dGV4dC5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xS ZW5kZXJpbmdDb250ZXh0LmlkbAkocmV2aXNpb24gMTc1NzMxKQorKysgU291cmNlL1dlYkNvcmUv aHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmlkbAkod29ya2luZyBjb3B5KQpAQCAt NTg5LDYgKzU4OSw3IEBAIHR5cGVkZWYgdW5yZXN0cmljdGVkIGZsb2F0IEdMY2xhbXBmOwogICAg IAogICAgIFtTdHJpY3RUeXBlQ2hlY2tpbmddIHZvaWQgICAgICAgICByZWxlYXNlU2hhZGVyQ29t cGlsZXIoKTsKICAgICBbU3RyaWN0VHlwZUNoZWNraW5nXSB2b2lkICAgICAgICAgcmVuZGVyYnVm ZmVyU3RvcmFnZShHTGVudW0gdGFyZ2V0LCBHTGVudW0gaW50ZXJuYWxmb3JtYXQsIEdMc2l6ZWkg d2lkdGgsIEdMc2l6ZWkgaGVpZ2h0KTsKKyAgICBbU3RyaWN0VHlwZUNoZWNraW5nXSB2b2lkICAg ICAgICAgcmVuZGVyYnVmZmVyU3RvcmFnZU11bHRpc2FtcGxlKEdMZW51bSB0YXJnZXQsIEdMc2l6 ZWkgc2FtcGxlcywgR0xlbnVtIGludGVybmFsZm9ybWF0LCBHTHNpemVpIHdpZHRoLCBHTHNpemVp IGhlaWdodCk7CiAgICAgW1N0cmljdFR5cGVDaGVja2luZ10gdm9pZCAgICAgICAgIHNhbXBsZUNv dmVyYWdlKEdMY2xhbXBmIHZhbHVlLCBHTGJvb2xlYW4gaW52ZXJ0KTsKICAgICBbU3RyaWN0VHlw ZUNoZWNraW5nXSB2b2lkICAgICAgICAgc2Npc3NvcihHTGludCB4LCBHTGludCB5LCBHTHNpemVp IHdpZHRoLCBHTHNpemVpIGhlaWdodCk7CiAgICAgW1N0cmljdFR5cGVDaGVja2luZywgUmFpc2Vz RXhjZXB0aW9uXSB2b2lkICAgICAgICAgc2hhZGVyU291cmNlKFdlYkdMU2hhZGVyIHNoYWRlciwg RE9NU3RyaW5nIHN0cmluZyk7Cg==