139139 2014-12-01 11:28:45 -0800 [MSE] Fix not always calling mediaPlayer seek. 2014-12-02 01:42:27 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 b.gajda webkit-unassigned calvaris commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble ltilve philipj sergio oldest_to_newest 1051505 0 b.gajda 2014-12-01 11:28:45 -0800 Change : https://bugs.webkit.org/show_bug.cgi?id=118752 unrightfully changed : - if (m_mediaSource && m_mediaSource->readyState() != MediaSource::closedKeyword()) + if (m_mediaSource && m_mediaSource->isClosed()) but the whole sense of this is that if media source is not closed, then it should always call m_player->seek, and so on. (even comment says so) Second expression should be negated. 1051509 1 242323 b.gajda 2014-12-01 11:31:15 -0800 Created attachment 242323 always notifying of seek with mse Not sure can this behavior be tested using MockMediaSource, as events are going in (but it we would printf() in middle of seek function, and seek to currentTime(), it would not go) 1051578 2 242323 commit-queue 2014-12-01 14:04:10 -0800 Comment on attachment 242323 always notifying of seek with mse Clearing flags on attachment: 242323 Committed r176604: <http://trac.webkit.org/changeset/176604> 1051579 3 commit-queue 2014-12-01 14:04:15 -0800 All reviewed patches have been landed. Closing bug. 242323 2014-12-01 11:31:15 -0800 2014-12-01 14:04:10 -0800 always notifying of seek with mse patch_not_always_seek_v1 text/plain 1366 b.gajda ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwOTlkZDViLi4wYWU5YzA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMTItMDEgIEJhcnRsb21pZWogR2FqZGEgIDxiLmdhamRhQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtNU0VdIEZpeCBub3QgYWx3YXlzIGNhbGxpbmcgbWVkaWFQbGF5ZXIgc2Vlay4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTEzOQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9yaWdpbmFs IGNvbW1lbnQgc3RhdGVzIHRoYXQgbWVkaWEgc291cmNlIHNoYWxsIGFsd2F5cyBiZSBub3RpZmll ZCBvZiBzZWVrIGlmIGl0J3Mgbm90IGNsb3NlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVl ZGVkLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnNlZWtUaW1lckZpcmVkKToKKwogMjAxNC0xMS0yOSAg R3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIEZpeCBh IGJ1aWxkIHdhcm5pbmcgd2hlbiBDU1NfU0NST0xMX1NOQVAgaXMgZW5hYmxlZApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXggMWU3NWU1Yi4uZjUxNTE5YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC0yNDE0LDcgKzI0MTQs NyBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnNlZWtUaW1lckZpcmVkKCkKICNpZiBFTkFCTEUo TUVESUFfU09VUkNFKQogICAgIC8vIEFsd2F5cyBub3RpZnkgdGhlIG1lZGlhIGVuZ2luZSBvZiBh IHNlZWsgaWYgdGhlIHNvdXJjZSBpcyBub3QgY2xvc2VkLiBUaGlzIGVuc3VyZXMgdGhhdCB0aGUg c291cmNlIGlzCiAgICAgLy8gYWx3YXlzIGluIGEgZmx1c2hlZCBzdGF0ZSB3aGVuIHRoZSAnc2Vl a2luZycgZXZlbnQgZmlyZXMuCi0gICAgaWYgKG1fbWVkaWFTb3VyY2UgJiYgbV9tZWRpYVNvdXJj ZS0+aXNDbG9zZWQoKSkKKyAgICBpZiAobV9tZWRpYVNvdXJjZSAmJiAhbV9tZWRpYVNvdXJjZS0+ aXNDbG9zZWQoKSkKICAgICAgICAgbm9TZWVrUmVxdWlyZWQgPSBmYWxzZTsKICNlbmRpZgogCg==