139131 2014-12-01 08:20:09 -0800 Fix class was previously declared as a struct warnings 2014-12-02 05:34:13 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 evab.u-szeged evab.u-szeged clopez commit-queue ossy oldest_to_newest 1051450 0 evab.u-szeged 2014-12-01 08:20:09 -0800 warnings: ../../Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:56:1: warning: 'TextureMapperGLData' defined as a struct here but previously declared as a class [-Wmismatched-tags] struct TextureMapperGLData { ^ ../../Source/WebCore/platform/graphics/texmap/TextureMapperGL.h:34:1: note: did you mean struct here? class TextureMapperGLData; ^~~~~ struct 1 warning generated. ../../Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:32:1: warning: class 'CoordinatedGraphicsState' was previously declared as a struct [-Wmismatched-tags] class CoordinatedGraphicsState; ^ ../../Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:175:8: note: previous use is here struct CoordinatedGraphicsState { ^ ../../Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:32:1: note: did you mean struct here? class CoordinatedGraphicsState; ^~~~~ struct 1 warning generated. ../../Source/WebKit2/UIProcess/CoordinatedGraphics/WebViewClient.h:39:1: warning: class 'ViewportAttributes' was previously declared as a struct [-Wmismatched-tags] class ViewportAttributes; ^ ../../Source/WebCore/dom/ViewportArguments.h:45:8: note: previous use is here struct ViewportAttributes { ^ ../../Source/WebKit2/UIProcess/CoordinatedGraphics/WebViewClient.h:39:1: note: did you mean struct here? class ViewportAttributes; ^~~~~ struct 1 warning generated. --- TextureMapperGLData, CoordinatedGraphicsState and ViewportAttributes are structs, the noticed forward declarations incorrect, we should use struct instead of class. 1051451 1 242313 evab.u-szeged 2014-12-01 08:25:14 -0800 Created attachment 242313 Patch 1051795 2 242313 commit-queue 2014-12-02 04:54:34 -0800 Comment on attachment 242313 Patch Clearing flags on attachment: 242313 Committed r176632: <http://trac.webkit.org/changeset/176632> 1051796 3 commit-queue 2014-12-02 04:54:36 -0800 All reviewed patches have been landed. Closing bug. 1051809 4 clopez 2014-12-02 05:24:48 -0800 (In reply to comment #2) > Comment on attachment 242313 [details] > Patch > > Clearing flags on attachment: 242313 > > Committed r176632: <http://trac.webkit.org/changeset/176632> This made the ChangeLog files executables :\ diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog old mode 100644 new mode 100755 diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog old mode 100644 new mode 100755 1051812 5 ossy 2014-12-02 05:27:23 -0800 (In reply to comment #4) > (In reply to comment #2) > > Comment on attachment 242313 [details] > > Patch > > > > Clearing flags on attachment: 242313 > > > > Committed r176632: <http://trac.webkit.org/changeset/176632> > > > This made the ChangeLog files executables :\ > > > diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog > old mode 100644 > new mode 100755 > > > diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog > old mode 100644 > new mode 100755 OMG :-/ Style checker should have warn about it. :( Thanks for noticing it, let us fix it quickly. 1051814 6 ossy 2014-12-02 05:34:13 -0800 Fixed by https://trac.webkit.org/changeset/176633 242313 2014-12-01 08:25:14 -0800 2014-12-02 04:54:34 -0800 Patch bug-139131-20141201172541.patch text/plain 3085 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2NTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBt b2RlIDEwMDc1NQppbmRleCAwOTlkZDViNGUyM2QzMmRlODc0YTk5MDJlOTY2NjUwZjE0YjkyODQz Li5jNGIzZTQxN2NkMWZhYTRhMTdlYTE0MTNmODg0ZGE0MWVkODc1YzM3Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNCBAQAorMjAxNC0xMi0wMSAgRXZhIEJhbGF6c2ZhbHZpICA8ZXZhYi51LXN6ZWdlZEBwYXJ0 bmVyLnNhbXN1bmcuY29tPgorCisgICAgICAgIEZpeCBjbGFzcyB3YXMgcHJldmlvdXNseSBkZWNs YXJlZCBhcyBhIHN0cnVjdCB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM5MTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuaDoKKwogMjAxNC0xMS0yOSAgR3l1 eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIEZpeCBhIGJ1 aWxkIHdhcm5pbmcgd2hlbiBDU1NfU0NST0xMX1NOQVAgaXMgZW5hYmxlZApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCm9sZCBt b2RlIDEwMDY0NApuZXcgbW9kZSAxMDA3NTUKaW5kZXggNTM0Y2Q5NjgxYWViNDIwMmM5MGZiZjE1 N2QyYTBmMWZkN2Y1ZmI2MS4uZWRjOTkyY2Q3ZjZkNDVhOGIyNmIwZWE3ZGVjODc4ODZhMzMxMDYz NwotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMTItMDEgIEV2YSBCYWxhenNmYWx2aSAgPGV2 YWIudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggY2xhc3Mgd2Fz IHByZXZpb3VzbHkgZGVjbGFyZWQgYXMgYSBzdHJ1Y3Qgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTEzMQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0Nvb3JkaW5hdGVk R3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0UHJveHkuaDoKKyAgICAgICAgKiBVSVBy b2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3Q2xpZW50Lmg6CisKIDIwMTQtMTEtMzAg IEphZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBB ZGQgZWxkYnVzIHRvIHRoZSBsaWJyYXJ5IGxpc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuaAppbmRleCAwODI0 M2NiMWMyMGNkN2ViMTRkMGRhZDQ0ODAwZmViMTg4NWZiMzk4Li40MjQwN2ZiNDI4ZmIwNGViZDBi NjIwOGRhZjU2YTczODdhY2NiYjMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5oCkBAIC0zMSw3ICszMSw3 IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotY2xhc3MgVGV4dHVyZU1hcHBlckdMRGF0YTsK K3N0cnVjdCBUZXh0dXJlTWFwcGVyR0xEYXRhOwogY2xhc3MgVGV4dHVyZU1hcHBlclNoYWRlclBy b2dyYW07CiBjbGFzcyBGaWx0ZXJPcGVyYXRpb247CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9z dFByb3h5LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9D b29yZGluYXRlZExheWVyVHJlZUhvc3RQcm94eS5oCmluZGV4IGE3Zjk3YmU3NGY4YTA3NTU1NTQz ZTA0ZWM5OTMzMWIxNjk1Mzk0N2MuLjg2YWQ3ZmNmZmRjNDA0OWFiNzg0ZTg0ZjFhYThkNzllNmE3 Y2MyMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdy YXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdFByb3h5LmgKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0 UHJveHkuaApAQCAtMjksNyArMjksNyBAQAogI2luY2x1ZGUgPGZ1bmN0aW9uYWw+CiAKIG5hbWVz cGFjZSBXZWJDb3JlIHsKLWNsYXNzIENvb3JkaW5hdGVkR3JhcGhpY3NTdGF0ZTsKK3N0cnVjdCBD b29yZGluYXRlZEdyYXBoaWNzU3RhdGU7CiBjbGFzcyBJbnRTaXplOwogfQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3Q2xp ZW50LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJW aWV3Q2xpZW50LmgKaW5kZXggZTAwMWFkYWE2Y2YyOWUwN2EyZmRkYTc2NmE5OWI2ZWNhM2FkMDM4 OC4uZDY0ODZlYjg3YzY1MWMzNDA2NmRjYzQ1MGQyZjU1ODBhNmNlZjE3MSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlld0NsaWVu dC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dl YlZpZXdDbGllbnQuaApAQCAtMzYsNyArMzYsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBjbGFz cyBJbnRQb2ludDsKIGNsYXNzIEludFJlY3Q7CiBjbGFzcyBJbnRTaXplOwotY2xhc3MgVmlld3Bv cnRBdHRyaWJ1dGVzOworc3RydWN0IFZpZXdwb3J0QXR0cmlidXRlczsKIH0KIAogbmFtZXNwYWNl IEFQSSB7Cg==