139120 2014-11-30 22:38:45 -0800 [EFL] Add eldbus to the library list 2014-12-01 00:10:20 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 136355 1 ljaehun.lim ljaehun.lim commit-queue gyuyoung.kim lucas.de.marchi ryuan.choi oldest_to_newest 1051397 0 ljaehun.lim 2014-11-30 22:38:45 -0800 Fix undefined reference errors for eldbus APIs. ../../Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:139: error: undefined reference to 'eldbus_init' ../../Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:159: error: undefined reference to 'eldbus_shutdown' ../../Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:182: error: undefined reference to 'eldbus_shutdown' 1051398 1 242304 ljaehun.lim 2014-11-30 22:40:35 -0800 Created attachment 242304 Patch 1051399 2 242304 gyuyoung.kim 2014-11-30 22:49:34 -0800 Comment on attachment 242304 Patch I wonder why this build error didn't happen on Bug 136355's EFL EWS. 1051400 3 ryuan.choi 2014-11-30 23:22:31 -0800 (In reply to comment #1) > Created attachment 242304 [details] > Patch Thanks. Your patch is reasonable to me but I don't know why this is not happen on my PC. Do you use SHARED_CORE? 1051401 4 ljaehun.lim 2014-11-30 23:35:57 -0800 Yes, I used SHARED_CORE at that time. 1051402 5 242304 commit-queue 2014-11-30 23:36:21 -0800 Comment on attachment 242304 Patch Clearing flags on attachment: 242304 Committed r176590: <http://trac.webkit.org/changeset/176590> 1051403 6 commit-queue 2014-11-30 23:36:25 -0800 All reviewed patches have been landed. Closing bug. 1051404 7 gyuyoung.kim 2014-12-01 00:09:45 -0800 (In reply to comment #4) > Yes, I used SHARED_CORE at that time. Ah, that's why EFL EWS didn't detect this build break. EFL buildbots and EWS don't use SHARED_CORE option. 1051405 8 gyuyoung.kim 2014-12-01 00:10:20 -0800 (In reply to comment #7) > (In reply to comment #4) > > Yes, I used SHARED_CORE at that time. > > Ah, that's why EFL EWS didn't detect this build break. EFL buildbots and EWS > don't use SHARED_CORE option. It would be nicer if you mention this break occurs when SHARED_CORE is ON. 242304 2014-11-30 22:40:35 -0800 2014-11-30 23:36:21 -0800 Patch bug-139120-20141201154103.patch text/plain 1576 ljaehun.lim U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2NTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTI4MDNmYjUzNmFmOWFl NDMzZWQyMGNiY2I2NGVjZWNkOWE1ZDE0ZS4uMGZjYmE2MmM1NGZhYmZmZDE0OWIzNjY2ZGQzODc0 ZDBhZWYwZmMwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTExLTMwICBKYWVo dW4gTGltICA8bGphZWh1bi5saW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQWRkIGVs ZGJ1cyB0byB0aGUgbGlicmFyeSBsaXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzkxMjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggdW5kZWZpbmVkIHJlZmVyZW5jZSBlcnJvcnMgZm9yIGVsZGJ1 cyBBUElzLgorCisgICAgICAgICogUGxhdGZvcm1FZmwuY21ha2U6CisKIDIwMTQtMTEtMjkgIEFu ZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFzaCB3aGVu IGNhbGxpbmcgV0tQYWdlQ2xvc2Ugb24gdGhlIG9yaWdpbmF0ZWQgcGFnZSBmcm9tIHdpdGhpbiBj cmVhdGVOZXdQYWdlIGNhbGxiYWNrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9y bUVmbC5jbWFrZSBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IDczYWFi MTVjNDlhNzJkMzcwZThmODgyMWE4NGU5OThhYjkyNjJhZmMuLjAwMDRhY2I1ZDcwN2YyZTJhYmZj MzU4ODhmMDA2ODQ1Y2Q1ZTRjMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3Jt RWZsLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC0yNjgs MTQgKzI2OCwxMiBAQCBsaXN0KEFQUEVORCBXZWJLaXQyX0lOQ0xVREVfRElSRUNUT1JJRVMKICAg ICAke0VJTkFfSU5DTFVERV9ESVJTfQogICAgICR7RU9fSU5DTFVERV9ESVJTfQogICAgICR7RVZB U19JTkNMVURFX0RJUlN9CisgICAgJHtHTElCX0lOQ0xVREVfRElSU30KICAgICAke0hBUkZCVVpa X0lOQ0xVREVfRElSU30KICAgICAke0xJQlNPVVBfSU5DTFVERV9ESVJTfQogICAgICR7TElCWE1M Ml9JTkNMVURFX0RJUn0KICAgICAke0xJQlhTTFRfSU5DTFVERV9ESVJTfQogICAgICR7U1FMSVRF X0lOQ0xVREVfRElSU30KLSAgICAke0dMSUJfSU5DTFVERV9ESVJTfQotICAgICR7TElCU09VUF9J TkNMVURFX0RJUlN9Ci0gICAgJHtXVEZfRElSfQogKQogCiBsaXN0KEFQUEVORCBXZWJLaXQyX0xJ QlJBUklFUwpAQCAtNTYwLDMgKzU1OCw5IEBAIGlmIChFTkFCTEVfQUNDRVNTSUJJTElUWSkKICAg ICAgICAgJHtBVEtfTElCUkFSSUVTfQogICAgICkKIGVuZGlmICgpCisKK2lmIChFTkFCTEVfQkFU VEVSWV9TVEFUVVMpCisgICAgbGlzdChBUFBFTkQgV2ViS2l0Ml9MSUJSQVJJRVMKKyAgICAgICAg JHtFTERCVVNfTElCUkFSSUVTfQorICAgICkKK2VuZGlmICgpCg==