139081 2014-11-27 13:42:03 -0800 [WK2] SecComp buildfix after r176452 2016-05-10 08:12:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 139239 138963 1 ossy webkit-unassigned andersca commit-queue koivisto ossy oldest_to_newest 1051185 0 ossy 2014-11-27 13:42:03 -0800 https://trac.webkit.org/changeset/176452 broke the seccomp build: ../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp:208:9: error: no matching function for call to 'sendMessage' if (sendMessage(m_socket, encoder->buffer(), encoder->bufferSize()) < 0) ^~~~~~~~~~~ ../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp:71:16: note: candidate function not viable: no known conversion from 'const uint8_t *' (aka 'const unsigned char *') to 'void *' for 2nd argument static ssize_t sendMessage(int socket, void* data, size_t size, int fd = -1) ^ ../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp:343:13: error: no matching function for call to 'sendMessage' if (sendMessage(socket, encoder->buffer(), encoder->bufferSize(), fd) < 0) ^~~~~~~~~~~ ../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp:71:16: note: candidate function not viable: no known conversion from 'const uint8_t *' (aka 'const unsigned char *') to 'void *' for 2nd argument static ssize_t sendMessage(int socket, void* data, size_t size, int fd = -1) ^ 2 errors generated. 1051187 1 242258 ossy 2014-11-27 13:45:53 -0800 Created attachment 242258 Patch 1051223 2 242258 commit-queue 2014-11-28 01:10:25 -0800 Comment on attachment 242258 Patch Clearing flags on attachment: 242258 Committed r176559: <http://trac.webkit.org/changeset/176559> 1051224 3 commit-queue 2014-11-28 01:10:29 -0800 All reviewed patches have been landed. Closing bug. 1052330 4 commit-queue 2014-12-03 16:08:49 -0800 Re-opened since this is blocked by bug 139239 1191519 5 ossy 2016-05-10 08:12:54 -0700 There is no seccomp in WebKit anymore, let's close it. 242258 2014-11-27 13:45:53 -0800 2014-11-28 01:10:25 -0800 Patch bug-139081-20141127134617.patch text/plain 1913 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2NTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTU2Zjc0YmM0MjkyZWI1 NTFjNDYxMmY0ODIyY2Y3ZGUxMDU1ZTY5YS4uZTZiMDZiNDc0MTcwMjVkMzUxYjQxMTQ1MTkyMDVk YmUyNjlhNzcwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTExLTI3ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dLMl0gU2VjQ29t cCBidWlsZGZpeCBhZnRlciByMTc2NDUyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzkwODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNoYXJlZC9saW51eC9TZWNjb21wRmlsdGVycy9TZWNjb21wQnJv a2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6U2VjY29tcEJyb2tlckNsaWVudDo6ZGlzcGF0Y2gp OgorICAgICAgICAoV2ViS2l0OjpTZWNjb21wQnJva2VyOjpydW5Mb29wKToKKwogMjAxNC0xMS0y NSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92 ZSB1c2VyIGNvbnRlbnQgaGFuZGxpbmcgZnJvbSBQYWdlR3JvdXAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9saW51eC9TZWNjb21wRmlsdGVycy9TZWNjb21wQnJva2VyLmNwcCBi L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9saW51eC9TZWNjb21wRmlsdGVycy9TZWNjb21wQnJva2Vy LmNwcAppbmRleCA1OGU3M2Y5MWY3Y2JiNDUxZjI0YjQ5MWY1ZWQ3ZjliZmVkZmE5ZDBmLi4xNTNh MTkwNTMyNDBiYTNhZGRmNjNmNjIwYTkyYTFhZDY2YjIxZTBiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvbGludXgvU2VjY29tcEZpbHRlcnMvU2VjY29tcEJyb2tlci5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvU2hhcmVkL2xpbnV4L1NlY2NvbXBGaWx0ZXJzL1NlY2NvbXBCcm9r ZXIuY3BwCkBAIC0yMDUsNyArMjA1LDcgQEAgdm9pZCBTZWNjb21wQnJva2VyQ2xpZW50OjpkaXNw YXRjaChTeXNjYWxsKiBzeXNjYWxsKSBjb25zdAogCiAgICAgbV9zb2NrZXRMb2NrLmxvY2soKTsK IAotICAgIGlmIChzZW5kTWVzc2FnZShtX3NvY2tldCwgZW5jb2Rlci0+YnVmZmVyKCksIGVuY29k ZXItPmJ1ZmZlclNpemUoKSkgPCAwKQorICAgIGlmIChzZW5kTWVzc2FnZShtX3NvY2tldCwgcmVp bnRlcnByZXRfY2FzdDx2b2lkKj4oY29uc3RfY2FzdDx1aW50OF90Kj4oZW5jb2Rlci0+YnVmZmVy KCkpKSwgZW5jb2Rlci0+YnVmZmVyU2l6ZSgpKSA8IDApCiAgICAgICAgIENSQVNIKCk7CiAKICAg ICB3aGlsZSAodHJ1ZSkgewpAQCAtMzQwLDcgKzM0MCw3IEBAIE5PX1JFVFVSTiB2b2lkIFNlY2Nv bXBCcm9rZXI6OnJ1bkxvb3AoaW50IHNvY2tldCkKICAgICAgICAgaW50IGZkID0gYXR0YWNobWVu dHMuc2l6ZSgpID09IDEgPyBhdHRhY2htZW50c1swXS5maWxlRGVzY3JpcHRvcigpIDogLTE7CiAK ICAgICAgICAgLy8gVGhlIGNsaWVudCBpcyBkb3duLCB0aGUgYnJva2VyIHNob3VsZCBnbyBhd2F5 LgotICAgICAgICBpZiAoc2VuZE1lc3NhZ2Uoc29ja2V0LCBlbmNvZGVyLT5idWZmZXIoKSwgZW5j b2Rlci0+YnVmZmVyU2l6ZSgpLCBmZCkgPCAwKQorICAgICAgICBpZiAoc2VuZE1lc3NhZ2Uoc29j a2V0LCByZWludGVycHJldF9jYXN0PHZvaWQqPihjb25zdF9jYXN0PHVpbnQ4X3QqPihlbmNvZGVy LT5idWZmZXIoKSkpLCBlbmNvZGVyLT5idWZmZXJTaXplKCksIGZkKSA8IDApCiAgICAgICAgICAg ICBleGl0KEVYSVRfU1VDQ0VTUyk7CiAgICAgfQogfQo=