139080 2014-11-27 13:36:33 -0800 [WK2] SecComp buildfix after r168605 and r168999 2014-11-28 01:04:06 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 132808 133033 1 ossy ossy andersca bdakin cgarcia commit-queue gyuyoung.kim ossy sam oldest_to_newest 1051184 0 ossy 2014-11-27 13:36:33 -0800 https://trac.webkit.org/changeset/168605 removed localStorageDirectory from WebProcessCreationParameters and https://trac.webkit.org/changeset/168999 renamed databaseDirectory to webSQLDatabaseDirectory. ../../Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp:121:21: error: no member named 'databaseDirectory' in 'WebKit::WebProcessCreationParameters' if (!parameters.databaseDirectory.isEmpty()) ~~~~~~~~~~ ^ ../../Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp:122:63: error: no member named 'databaseDirectory' in 'WebKit::WebProcessCreationParameters' addDirectoryPermission(removeTrailingSlash(parameters.databaseDirectory), ReadAndWrite); ~~~~~~~~~~ ^ ../../Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp:123:21: error: no member named 'localStorageDirectory' in 'WebKit::WebProcessCreationParameters'; did you mean 'cookieStorageDirectory'? if (!parameters.localStorageDirectory.isEmpty()) ^~~~~~~~~~~~~~~~~~~~~ cookieStorageDirectory ../../Source/WebKit2/Shared/WebProcessCreationParameters.h:73:12: note: 'cookieStorageDirectory' declared here String cookieStorageDirectory; ^ ../../Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp:124:63: error: no member named 'localStorageDirectory' in 'WebKit::WebProcessCreationParameters'; did you mean 'cookieStorageDirectory'? addDirectoryPermission(removeTrailingSlash(parameters.localStorageDirectory), ReadAndWrite); ^~~~~~~~~~~~~~~~~~~~~ cookieStorageDirectory ../../Source/WebKit2/Shared/WebProcessCreationParameters.h:73:12: note: 'cookieStorageDirectory' declared here String cookieStorageDirectory; ^ 1 warning and 4 errors generated. 1051186 1 242257 ossy 2014-11-27 13:44:35 -0800 Created attachment 242257 Patch 1051219 2 242257 commit-queue 2014-11-28 01:04:01 -0800 Comment on attachment 242257 Patch Clearing flags on attachment: 242257 Committed r176557: <http://trac.webkit.org/changeset/176557> 1051220 3 commit-queue 2014-11-28 01:04:06 -0800 All reviewed patches have been landed. Closing bug. 242257 2014-11-27 13:44:35 -0800 2014-11-28 01:04:01 -0800 Patch bug-139080-20141127134459.patch text/plain 2062 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2NTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTU2Zjc0YmM0MjkyZWI1 NTFjNDYxMmY0ODIyY2Y3ZGUxMDU1ZTY5YS4uMTZiMGQ2ZDhkMDU4NzIxNTgzOGYzMzk0MGM3ZjYw ZDJiMmIzYzQ0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTExLTI3ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dLMl0gU2VjQ29t cCBidWlsZGZpeCBhZnRlciByMTY4NjA1IGFuZCByMTY4OTk5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzkwODAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9saW51eC9TZWNjb21wRmlsdGVy cy9TeXNjYWxsUG9saWN5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6U3lzY2FsbFBvbGljeTo6YWRk RGVmYXVsdFdlYlByb2Nlc3NQb2xpY3kpOgorCiAyMDE0LTExLTI1ICBBbmRlcnMgQ2FybHNzb24g IDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHVzZXIgY29udGVudCBoYW5k bGluZyBmcm9tIFBhZ2VHcm91cApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL2xp bnV4L1NlY2NvbXBGaWx0ZXJzL1N5c2NhbGxQb2xpY3kuY3BwIGIvU291cmNlL1dlYktpdDIvU2hh cmVkL2xpbnV4L1NlY2NvbXBGaWx0ZXJzL1N5c2NhbGxQb2xpY3kuY3BwCmluZGV4IDYzNjJlMjkx YmUxMzg5NDcxNzFmZmZmZTA3MzA2ZjU1MmUxNTlmMmEuLjE1Y2IyY2ZhYjFjNGUxYmE1ZjFkZTky M2U3NWM5ZDU2OWUyYmI3Y2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9saW51 eC9TZWNjb21wRmlsdGVycy9TeXNjYWxsUG9saWN5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvbGludXgvU2VjY29tcEZpbHRlcnMvU3lzY2FsbFBvbGljeS5jcHAKQEAgLTExOCwxMCAr MTE4LDggQEAgdm9pZCBTeXNjYWxsUG9saWN5OjphZGREZWZhdWx0V2ViUHJvY2Vzc1BvbGljeShj b25zdCBXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXIKICAgICAvLyBEaXJlY3RvcmllcyBzZXR0 aW5ncyBjb21pbmcgZnJvbSB0aGUgVUlQcm9jZXNzLgogICAgIGlmICghcGFyYW1ldGVycy5hcHBs aWNhdGlvbkNhY2hlRGlyZWN0b3J5LmlzRW1wdHkoKSkKICAgICAgICAgYWRkRGlyZWN0b3J5UGVy bWlzc2lvbihyZW1vdmVUcmFpbGluZ1NsYXNoKHBhcmFtZXRlcnMuYXBwbGljYXRpb25DYWNoZURp cmVjdG9yeSksIFJlYWRBbmRXcml0ZSk7Ci0gICAgaWYgKCFwYXJhbWV0ZXJzLmRhdGFiYXNlRGly ZWN0b3J5LmlzRW1wdHkoKSkKLSAgICAgICAgYWRkRGlyZWN0b3J5UGVybWlzc2lvbihyZW1vdmVU cmFpbGluZ1NsYXNoKHBhcmFtZXRlcnMuZGF0YWJhc2VEaXJlY3RvcnkpLCBSZWFkQW5kV3JpdGUp OwotICAgIGlmICghcGFyYW1ldGVycy5sb2NhbFN0b3JhZ2VEaXJlY3RvcnkuaXNFbXB0eSgpKQot ICAgICAgICBhZGREaXJlY3RvcnlQZXJtaXNzaW9uKHJlbW92ZVRyYWlsaW5nU2xhc2gocGFyYW1l dGVycy5sb2NhbFN0b3JhZ2VEaXJlY3RvcnkpLCBSZWFkQW5kV3JpdGUpOworICAgIGlmICghcGFy YW1ldGVycy53ZWJTUUxEYXRhYmFzZURpcmVjdG9yeS5pc0VtcHR5KCkpCisgICAgICAgIGFkZERp cmVjdG9yeVBlcm1pc3Npb24ocmVtb3ZlVHJhaWxpbmdTbGFzaChwYXJhbWV0ZXJzLndlYlNRTERh dGFiYXNlRGlyZWN0b3J5KSwgUmVhZEFuZFdyaXRlKTsKICAgICBpZiAoIXBhcmFtZXRlcnMuZGlz a0NhY2hlRGlyZWN0b3J5LmlzRW1wdHkoKSkKICAgICAgICAgYWRkRGlyZWN0b3J5UGVybWlzc2lv bihyZW1vdmVUcmFpbGluZ1NsYXNoKHBhcmFtZXRlcnMuZGlza0NhY2hlRGlyZWN0b3J5KSwgUmVh ZEFuZFdyaXRlKTsKICAgICBpZiAoIXBhcmFtZXRlcnMuY29va2llU3RvcmFnZURpcmVjdG9yeS5p c0VtcHR5KCkpCg==