139079 2014-11-27 13:12:53 -0800 Fix -Wc++11-narrowing error in SeccompFilters.cpp 2014-11-28 01:09:27 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy cgarcia commit-queue gyuyoung.kim ossy oldest_to_newest 1051181 0 ossy 2014-11-27 13:12:53 -0800 ../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:71:83: error: non-constant-expression cannot be narrowed from type 'long long' to 'scmp_datum_t' (aka 'unsigned long') in initializer list [-Wc++11-narrowing] ((struct scmp_arg_cmp){argNum1, static_cast<scmp_compare>(operator1), data1, 0}), ^~~~~ ../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:71:83: note: override this message by inserting an explicit cast ((struct scmp_arg_cmp){argNum1, static_cast<scmp_compare>(operator1), data1, 0}), ^~~~~ static_cast<scmp_datum_t>( ) ../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:72:83: error: non-constant-expression cannot be narrowed from type 'long long' to 'scmp_datum_t' (aka 'unsigned long') in initializer list [-Wc++11-narrowing] ((struct scmp_arg_cmp){argNum2, static_cast<scmp_compare>(operator2), data2, 0})); ^~~~~ ../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:72:83: note: override this message by inserting an explicit cast ((struct scmp_arg_cmp){argNum2, static_cast<scmp_compare>(operator2), data2, 0})); ^~~~~ static_cast<scmp_datum_t>( ) ../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:75:83: error: non-constant-expression cannot be narrowed from type 'long long' to 'scmp_datum_t' (aka 'unsigned long') in initializer list [-Wc++11-narrowing] ((struct scmp_arg_cmp){argNum1, static_cast<scmp_compare>(operator1), data1, 0})); ^~~~~ ../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:75:83: note: override this message by inserting an explicit cast ((struct scmp_arg_cmp){argNum1, static_cast<scmp_compare>(operator1), data1, 0})); ^~~~~ static_cast<scmp_datum_t>( ) 3 errors generated. 1051182 1 ossy 2014-11-27 13:21:15 -0800 seccomp.h: ----------- /** * Argument datum */ typedef uint64_t scmp_datum_t; scmp_datum_t is uint64_t, we should use uint64_t instead of long long to fix the build. 1051183 2 242256 ossy 2014-11-27 13:22:00 -0800 Created attachment 242256 Patch 1051221 3 242256 commit-queue 2014-11-28 01:09:23 -0800 Comment on attachment 242256 Patch Clearing flags on attachment: 242256 Committed r176558: <http://trac.webkit.org/changeset/176558> 1051222 4 commit-queue 2014-11-28 01:09:27 -0800 All reviewed patches have been landed. Closing bug. 242256 2014-11-27 13:22:00 -0800 2014-11-28 01:09:23 -0800 Patch bug-139079-20141127132224.patch text/plain 2979 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2NTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTU2Zjc0YmM0MjkyZWI1 NTFjNDYxMmY0ODIyY2Y3ZGUxMDU1ZTY5YS4uMDM4ZmVjY2NmNTcwOWRmODQwZWMzNjllNTVjMTUx NzliOTVjYmM2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTExLTI3ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IC1XYysrMTEt bmFycm93aW5nIGVycm9yIGluIFNlY2NvbXBGaWx0ZXJzLmNwcAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5MDc5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvbGludXgvU2VjY29tcEZpbHRl cnMvU2VjY29tcEZpbHRlcnMuY3BwOgorICAgICAgICAoV2ViS2l0OjpTZWNjb21wRmlsdGVyczo6 YWRkUnVsZSk6CisgICAgICAgICogU2hhcmVkL2xpbnV4L1NlY2NvbXBGaWx0ZXJzL1NlY2NvbXBG aWx0ZXJzLmg6CisKIDIwMTQtMTEtMjUgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxl LmNvbT4KIAogICAgICAgICBSZW1vdmUgdXNlciBjb250ZW50IGhhbmRsaW5nIGZyb20gUGFnZUdy b3VwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbGludXgvU2VjY29tcEZpbHRl cnMvU2VjY29tcEZpbHRlcnMuY3BwIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL2xpbnV4L1NlY2Nv bXBGaWx0ZXJzL1NlY2NvbXBGaWx0ZXJzLmNwcAppbmRleCA5NDkxYmQxNjdkMWQzMTgxOWE2Y2Fj YzRkMWJkYjAwZDUwYzNiYmE0Li40ZjkwZDMyNGJjYTQxNzI3ZTZiYzExNzgxYWEzNmU5NWE3NGU1 NjkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbGludXgvU2VjY29tcEZpbHRl cnMvU2VjY29tcEZpbHRlcnMuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9saW51eC9T ZWNjb21wRmlsdGVycy9TZWNjb21wRmlsdGVycy5jcHAKQEAgLTQyLDcgKzQyLDcgQEAgQ09NUElM RV9BU1NFUlQoU2VjY29tcEZpbHRlcnM6Ok5vdFNldCA9PSBzdGF0aWNfY2FzdDxTZWNjb21wRmls dGVyczo6T3BlcmF0b3I+KF8KIENPTVBJTEVfQVNTRVJUKFNlY2NvbXBGaWx0ZXJzOjpOb3RFcXVh bCA9PSBzdGF0aWNfY2FzdDxTZWNjb21wRmlsdGVyczo6T3BlcmF0b3I+KFNDTVBfQ01QX05FKSwg Tm90RXF1YWwpOwogQ09NUElMRV9BU1NFUlQoU2VjY29tcEZpbHRlcnM6OkVxdWFsID09IHN0YXRp Y19jYXN0PFNlY2NvbXBGaWx0ZXJzOjpPcGVyYXRvcj4oU0NNUF9DTVBfRVEpLCBFcXVhbCk7CiAK LUNPTVBJTEVfQVNTRVJUKHNpemVvZihzY21wX2RhdHVtX3QpID09IHNpemVvZihsb25nIGxvbmcp LCBzY21wX2RhdHVtX3QpOworQ09NUElMRV9BU1NFUlQoc2l6ZW9mKHNjbXBfZGF0dW1fdCkgPT0g c2l6ZW9mKHVpbnQ2NF90KSwgc2NtcF9kYXR1bV90KTsKIAogU2VjY29tcEZpbHRlcnM6OlNlY2Nv bXBGaWx0ZXJzKEFjdGlvbiBkZWZhdWx0QWN0aW9uKQogICAgIDogbV9jb250ZXh0KHNlY2NvbXBf aW5pdChkZWZhdWx0QWN0aW9uKSkKQEAgLTU4LDggKzU4LDggQEAgU2VjY29tcEZpbHRlcnM6On5T ZWNjb21wRmlsdGVycygpCiB9CiAKIHZvaWQgU2VjY29tcEZpbHRlcnM6OmFkZFJ1bGUoY29uc3Qg Y2hhciogc3lzY2FsbE5hbWUsIEFjdGlvbiBhY3Rpb24sCi0gICAgdW5zaWduZWQgYXJnTnVtMSwg T3BlcmF0b3Igb3BlcmF0b3IxLCBsb25nIGxvbmcgZGF0YTEsCi0gICAgdW5zaWduZWQgYXJnTnVt MiwgT3BlcmF0b3Igb3BlcmF0b3IyLCBsb25nIGxvbmcgZGF0YTIpCisgICAgdW5zaWduZWQgYXJn TnVtMSwgT3BlcmF0b3Igb3BlcmF0b3IxLCB1aW50NjRfdCBkYXRhMSwKKyAgICB1bnNpZ25lZCBh cmdOdW0yLCBPcGVyYXRvciBvcGVyYXRvcjIsIHVpbnQ2NF90IGRhdGEyKQogewogICAgIGludCBz eXNjYWxsID0gc2VjY29tcF9zeXNjYWxsX3Jlc29sdmVfbmFtZShzeXNjYWxsTmFtZSk7CiAgICAg aWYgKHN5c2NhbGwgPT0gX19OUl9TQ01QX0VSUk9SKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvU2hhcmVkL2xpbnV4L1NlY2NvbXBGaWx0ZXJzL1NlY2NvbXBGaWx0ZXJzLmggYi9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvbGludXgvU2VjY29tcEZpbHRlcnMvU2VjY29tcEZpbHRlcnMuaAppbmRl eCBkNDllMWZiNjJlNmQ4MDM2NWYxYTJhOTA2Yzk1NzRlZGFkZThmNGFmLi4xZTZhYjE1NGM0NTc0 YjEzNzIzMTljMWMyMDVhNjRlZWFhZDgxZWQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvbGludXgvU2VjY29tcEZpbHRlcnMvU2VjY29tcEZpbHRlcnMuaAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvbGludXgvU2VjY29tcEZpbHRlcnMvU2VjY29tcEZpbHRlcnMuaApAQCAt NTQsOCArNTQsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCogY29udGV4dCgpIHsgcmV0dXJuIG1fY29u dGV4dDsgfTsKIAogICAgIHZvaWQgYWRkUnVsZShjb25zdCBjaGFyKiBzeXNjYWxsTmFtZSwgQWN0 aW9uLAotICAgICAgICB1bnNpZ25lZCBhcmdOdW0xID0gMCwgT3BlcmF0b3Igb3BlcmF0b3IxID0g Tm90U2V0LCBsb25nIGxvbmcgZGF0YTEgPSAwLAotICAgICAgICB1bnNpZ25lZCBhcmdOdW0yID0g MCwgT3BlcmF0b3Igb3BlcmF0b3IyID0gTm90U2V0LCBsb25nIGxvbmcgZGF0YTIgPSAwKTsKKyAg ICAgICAgdW5zaWduZWQgYXJnTnVtMSA9IDAsIE9wZXJhdG9yIG9wZXJhdG9yMSA9IE5vdFNldCwg dWludDY0X3QgZGF0YTEgPSAwLAorICAgICAgICB1bnNpZ25lZCBhcmdOdW0yID0gMCwgT3BlcmF0 b3Igb3BlcmF0b3IyID0gTm90U2V0LCB1aW50NjRfdCBkYXRhMiA9IDApOwogCiAgICAgdm9pZCBp bml0aWFsaXplKCk7CiAK