139064 2014-11-26 07:20:53 -0800 [GStreamer] HTTP source element lacks SCHEDULING query support 2014-11-28 03:05:08 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned cgarcia pnormand oldest_to_newest 1051092 0 pnormand 2014-11-26 07:20:53 -0800 This is needed for adaptive streaming cases. 1051093 1 242229 pnormand 2014-11-26 07:25:20 -0800 Created attachment 242229 patch 1051094 2 242229 cgarcia 2014-11-26 08:06:05 -0800 Comment on attachment 242229 patch View in context: https://bugs.webkit.org/attachment.cgi?id=242229&action=review > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:589 > + gint minSize, maxSize, align; Nit: use int instead of gint here. > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:592 > + flags = static_cast<GstSchedulingFlags>(static_cast<unsigned>(flags) | GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED); Do you really need the unsigned cast too? can't this be flags |= GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED? 1051096 3 pnormand 2014-11-26 08:35:37 -0800 (In reply to comment #2) > Comment on attachment 242229 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=242229&action=review > > > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:589 > > + gint minSize, maxSize, align; > > Nit: use int instead of gint here. > ok :) > > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:592 > > + flags = static_cast<GstSchedulingFlags>(static_cast<unsigned>(flags) | GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED); > > Do you really need the unsigned cast too? can't this be flags |= > GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED? Fails to build here: ../../Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In function ‘gboolean webKitWebSrcQueryWithParent(GstPad*, GstObject*, GstQuery*)’: ../../Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:593:15: error: invalid conversion from ‘int’ to ‘GstSchedulingFlags’ [-fpermissive] flags |= GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED; 1051100 4 pnormand 2014-11-26 08:57:03 -0800 Ah well, not using a variable and doing a static_cast works. I think I'll land this tomorrow! 1051232 5 pnormand 2014-11-28 03:05:08 -0800 Committed r176561: <http://trac.webkit.org/changeset/176561> 242229 2014-11-26 07:25:20 -0800 2014-11-26 08:06:05 -0800 patch patch.patch text/plain 2306 pnormand RnJvbSBkYWIxOGUzNzRjYzllMGMzNGJmMzFkMDljODM3NzE4MjJiOGY3ZDE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDI2IE5vdiAyMDE0IDE2OjI1OjA4ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8IDE0ICsrKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvZ3N0cmVhbWVy L1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAgICAgICAgIHwgMTAgKysrKysrKysrKwogMiBm aWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDZiYWMwZjkuLjFh ZTUzZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNC0xMS0yNiAgUGhpbGlwcGUg Tm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gSFRU UCBzb3VyY2UgZWxlbWVudCBsYWNrcyBTQ0hFRFVMSU5HIHF1ZXJ5IHN1cHBvcnQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTA2NAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgY292 ZXJlZCBieSBodHRwL3Rlc3RzL21lZGlhL2hscy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAod2Vi S2l0V2ViU3JjUXVlcnlXaXRoUGFyZW50KTogTWFrZSB0aGUgZWxlbWVudCBoYW5kbGUgU0NIRURV TElORworICAgICAgICBxdWVyaWVzIHdpdGggdGhlIEJBTkRXSURUSF9MSU1JVEVEIGZsYWcuIFRo aXMgaGVscHMgdXJpZGVjb2RlYmluCisgICAgICAgIHRvIGNvbmZpZ3VyZSBpdHNlbGYgZm9yIGFk YXB0aXZlIHN0cmVhbWluZyBwbGF5YmFjayBzY2VuYXJpb3MuCisKIDIwMTQtMTEtMjUgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYSB1c2VyIGNv bnRlbnQgY29udHJvbGxlciB0byBXZWJWaWV3R3JvdXAgYW5kIHVzZSBpdCBmb3IgdXNlciBjb250 ZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCmluZGV4IDAw ZTBlM2UuLjlhMTkzZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFt ZXIuY3BwCkBAIC01ODQsNiArNTg0LDE2IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJLaXRXZWJTcmNR dWVyeVdpdGhQYXJlbnQoR3N0UGFkKiBwYWQsIEdzdE9iamVjdCogcGFyZW50LCBHc3RRCiAgICAg ICAgIHJlc3VsdCA9IFRSVUU7CiAgICAgICAgIGJyZWFrOwogICAgIH0KKyAgICBjYXNlIEdTVF9R VUVSWV9TQ0hFRFVMSU5HOiB7CisgICAgICAgIEdzdFNjaGVkdWxpbmdGbGFncyBmbGFnczsKKyAg ICAgICAgZ2ludCBtaW5TaXplLCBtYXhTaXplLCBhbGlnbjsKKworICAgICAgICBnc3RfcXVlcnlf cGFyc2Vfc2NoZWR1bGluZyhxdWVyeSwgJmZsYWdzLCAmbWluU2l6ZSwgJm1heFNpemUsICZhbGln bik7CisgICAgICAgIGZsYWdzID0gc3RhdGljX2Nhc3Q8R3N0U2NoZWR1bGluZ0ZsYWdzPihzdGF0 aWNfY2FzdDx1bnNpZ25lZD4oZmxhZ3MpIHwgR1NUX1NDSEVEVUxJTkdfRkxBR19CQU5EV0lEVEhf TElNSVRFRCk7CisgICAgICAgIGdzdF9xdWVyeV9zZXRfc2NoZWR1bGluZyhxdWVyeSwgZmxhZ3Ms IG1pblNpemUsIG1heFNpemUsIGFsaWduKTsKKyAgICAgICAgcmVzdWx0ID0gVFJVRTsKKyAgICAg ICAgYnJlYWs7CisgICAgfQogICAgIGRlZmF1bHQ6IHsKICAgICAgICAgR1JlZlB0cjxHc3RQYWQ+ IHRhcmdldCA9IGFkb3B0R1JlZihnc3RfZ2hvc3RfcGFkX2dldF90YXJnZXQoR1NUX0dIT1NUX1BB RF9DQVNUKHBhZCkpKTsKIAotLSAKMi4xLjM=