139056 2014-11-26 01:27:12 -0800 [jhBuild] cairo build error (-flto) 2014-12-29 04:53:30 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 fvallee webkit-unassigned berto clopez commit-queue gyuyoung.kim ltilve mrobinson nick.diego oldest_to_newest 1051054 0 fvallee 2014-11-26 01:27:12 -0800 Using jhbuild w/ GTK port (but EFL is very likely to have same issue). Cairo fails to build on Debian Testing using binutils (2.24.90.20141023-1) : using gnu-ld : CC cairo-boilerplate-svg.lo CC cairo-boilerplate-constructors.lo /usr/bin/ld: -f may not be used without -shared collect2: error: ld returned 1 exit status Makefile:1468: recipe for target 'any2ppm' failed make[4]: *** [any2ppm] Error 1 make[4]: *** Waiting for unfinished jobs.... using gold: CCLD any2ppm CC cairo-boilerplate-xcb.lo CC cairo-boilerplate-egl.lo CC cairo-boilerplate-glx.lo CC cairo-boilerplate-script.lo CC cairo-boilerplate-ps.lo CC cairo-boilerplate-pdf.lo CC cairo-boilerplate-svg.lo CC cairo-boilerplate-constructors.lo /usr/lib/gold-ld/ld: fatal error: -f/--auxiliary may not be used without -shared collect2: error: ld returned 1 exit status Makefile:1468: recipe for target 'any2ppm' failed make[4]: *** [any2ppm] Error 1 After investigation, it seems the error is related to LTO support. Cairo has been added some lto support here : http://cgit.freedesktop.org/cairo/commit/?id=d486ea30f1a58640a1178de74f705a73845b1cda This commit is included in cairo package used by jhbuild (http://www.cairographics.org/news/cairo-1.12.8 for gtk or 1.12.4 for ELF). The lto related commit has been amended here http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c and even reverted here http://cgit.freedesktop.org/cairo/commit/?id=c7ff9bb32e20679d6da4e8a2856be716e5bd9e12, however we don't have theses commits. Strange thing is that lto support is already supposed to be deactivated in cairo after http://trac.webkit.org/changeset/158866. But it doesn't seems to work using gcc 4.9.1 / binutils 2.24.90.20141023-1. 1051056 1 fvallee 2014-11-26 01:43:20 -0800 The issue can be fixed in Tools/gtk/jhbuild.modules updating the cairo section: - <autotools id="cairo" autogen-sh="configure" - autogenargs="--enable-gl=yes --enable-egl=yes --enable-glx=yes ac_cv_func_rsvg_pixbuf_from_file=no" - makeargs="CFLAGS=-fno-lto CXXFLAGS=-fno-lto LDFLAGS=-fno-lto"> + <autotools id="cairo" + autogenargs="--enable-gl=yes --enable-egl=yes --enable-glx=yes ac_cv_func_rsvg_pixbuf_from_file=no --disable-lto" + makeargs=""> <dependencies> <dep package="fontconfig"/> <dep package="pixman"/> @@ -71,6 +71,7 @@ repo="cairographics.org" hash="sha256:8fbb6fc66117ab4100bad830cb4479497e53c6f3facb98bf05c8d298554ebdd9" md5sum="8b3dcade859c44fb7e56fc68edfe9a45"> + <patch file="cairo-1.12.8-add_disable-lto.patch" strip="1"/> </branch> </autotools> 1) apply cairo commit "configure.ac: Add a --disable-lto configure option" http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c 2) add the --disable-lto to autogenargs 3) remove makeargs (CFLAGS=-fno-lto CXXFLAGS=-fno-lto LDFLAGS=-fno-lto) 4) remove autogen-sh="configure" to force the updated configure.ac to be reparsed I don't think the changes are good enough to be submitted as-is (but they are good enough to fix my build and are not breaking build w/ gcc 4.8.1 / ld 2.23.2). 1051103 2 ltilve 2014-11-26 09:46:51 -0800 I can confirm that I have applied these changes and they are also repairing my build. I think that it would be a good idea to format them and submit the patch. 1054088 3 243002 fvallee 2014-12-10 01:42:06 -0800 Created attachment 243002 Patch 1054089 4 fvallee 2014-12-10 01:45:43 -0800 uploaded patch "as-is", if anyone is willing to look at this issue, please feel free to review and/or amend and/or discard the patch and find another way to fix the build. Thanks. 1054126 5 berto 2014-12-10 05:59:31 -0800 It works fine, thanks! 1058084 6 243002 commit-queue 2014-12-29 04:53:26 -0800 Comment on attachment 243002 Patch Clearing flags on attachment: 243002 Committed r177789: <http://trac.webkit.org/changeset/177789> 1058085 7 commit-queue 2014-12-29 04:53:30 -0800 All reviewed patches have been landed. Closing bug. 243002 2014-12-10 01:42:06 -0800 2014-12-29 04:53:26 -0800 Patch bug-139056-20141210104246.patch text/plain 4246 fvallee ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4NDAy MzI1MGJmNGE2OWUwZWUwZWE5MTlmZjZjYWU1OTEzOWE5MWE4Li44ZWJmYTJlNWY5OTllYjcyODc3 Yzk2YzA1MTg0MjFjNmIxNTdjNjg5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTQtMTItMTAgIEZhYmllbiBWYWxs w6llICA8ZnZhbGxlZUBjb25uZWN0ZWQtbGFicy5jb20+CisKKyAgICAgICAgW2poQnVpbGRdIGNh aXJvIGJ1aWxkIGVycm9yICgtZmx0bykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzOTA1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGNhaXJvIGZhaWxzIHRvIGxpbmsgIHdpdGggZ2NjIDQuOSBkdWUgdG8g bHRvCisgICAgICAgIHJlbGF0ZWQgaXNzdWUuIFRoaXMgcHJvYmxlbSBoYXMgYmVlbiBwYXJ0aWFs bHkKKyAgICAgICAgYWRkcmVzc2VkIGJ5IGNhaXJvOgorICAgICAgICBodHRwOi8vY2dpdC5mcmVl ZGVza3RvcC5vcmcvY2Fpcm8vY29tbWl0Lz9pZD1jMzY0NWQ5N2ViZDI0YzZmN2FkODUwNzg1ZDU4 NWFlYmM3MDZhMTFjCisgICAgICAgIHVzZSB0aGUgY2Fpcm8gLS1kaXNhYmxlLWx0byBvcHRpb24g YW5kIHJlbW92ZSBqaGJ1aWxkCisgICAgICAgIG1ha2VhcmdzIGZpeGVzIHRoZSBpc3N1ZS4KKwor ICAgICAgICAqIGd0ay9qaGJ1aWxkLm1vZHVsZXM6CisgICAgICAgICogZ3RrL3BhdGNoZXMvY2Fp cm8tMS4xMi44LWFkZF9kaXNhYmxlLWx0by5wYXRjaDogQWRkZWQuCisKIDIwMTQtMTItMDcgIEd3 YW5nIFlvb24gSHdhbmcgIDx5b29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgVXBkYXRlIHN0eWxl IGNoZWNrZXIgdG8gZGVhbCB3aXRoICJjb25zdCBvdmVycmlkZSIKZGlmZiAtLWdpdCBhL1Rvb2xz L2d0ay9qaGJ1aWxkLm1vZHVsZXMgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzCmluZGV4IDY2 YTJkOTZmMzVlYjI1YWIxOTIzMDJmMjcyY2JkYjVmYjYxMzZlZTkuLmMxNzQ1MDhkMzYyNTA5Nzhj NzFjM2U2ZDJmMWRlYmQ0ZTcyM2IxNTEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1v ZHVsZXMKKysrIGIvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwpAQCAtNTksOSArNTksOSBAQAog ICAgICAgaHJlZj0iaHR0cDovL2Rvd25sb2FkLnNhdmFubmFoLmdudS5vcmcvcmVsZWFzZXMvIi8+ CiAKIAotICA8YXV0b3Rvb2xzIGlkPSJjYWlybyIgYXV0b2dlbi1zaD0iY29uZmlndXJlIgotICAg ICAgICAgICAgIGF1dG9nZW5hcmdzPSItLWVuYWJsZS1nbD15ZXMgLS1lbmFibGUtZWdsPXllcyAt LWVuYWJsZS1nbHg9eWVzIGFjX2N2X2Z1bmNfcnN2Z19waXhidWZfZnJvbV9maWxlPW5vIgotICAg ICAgICAgICAgIG1ha2VhcmdzPSJDRkxBR1M9LWZuby1sdG8gQ1hYRkxBR1M9LWZuby1sdG8gTERG TEFHUz0tZm5vLWx0byI+CisgIDxhdXRvdG9vbHMgaWQ9ImNhaXJvIgorICAgICAgICAgICAgIGF1 dG9nZW5hcmdzPSItLWVuYWJsZS1nbD15ZXMgLS1lbmFibGUtZWdsPXllcyAtLWVuYWJsZS1nbHg9 eWVzIGFjX2N2X2Z1bmNfcnN2Z19waXhidWZfZnJvbV9maWxlPW5vIC0tZGlzYWJsZS1sdG8iCisg ICAgICAgICAgICAgbWFrZWFyZ3M9IiI+CiAgICAgPGRlcGVuZGVuY2llcz4KICAgICAgIDxkZXAg cGFja2FnZT0iZm9udGNvbmZpZyIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJwaXhtYW4iLz4KQEAg LTcxLDYgKzcxLDcgQEAKICAgICAgICAgICAgIHJlcG89ImNhaXJvZ3JhcGhpY3Mub3JnIgogICAg ICAgICAgICAgaGFzaD0ic2hhMjU2OjhmYmI2ZmM2NjExN2FiNDEwMGJhZDgzMGNiNDQ3OTQ5N2U1 M2M2ZjNmYWNiOThiZjA1YzhkMjk4NTU0ZWJkZDkiCiAgICAgICAgICAgICBtZDVzdW09IjhiM2Rj YWRlODU5YzQ0ZmI3ZTU2ZmM2OGVkZmU5YTQ1Ij4KKyAgICAgIDxwYXRjaCBmaWxlPSJjYWlyby0x LjEyLjgtYWRkX2Rpc2FibGUtbHRvLnBhdGNoIiBzdHJpcD0iMSIvPgogICAgIDwvYnJhbmNoPgog ICA8L2F1dG90b29scz4KIApkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL3BhdGNoZXMvY2Fpcm8tMS4x Mi44LWFkZF9kaXNhYmxlLWx0by5wYXRjaCBiL1Rvb2xzL2d0ay9wYXRjaGVzL2NhaXJvLTEuMTIu OC1hZGRfZGlzYWJsZS1sdG8ucGF0Y2gKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZTc0MGM5OTU2YTI3ZGNiNjVkN2Yx ZjRiZDhhNDljY2QzMDg2MzBkMQotLS0gL2Rldi9udWxsCisrKyBiL1Rvb2xzL2d0ay9wYXRjaGVz L2NhaXJvLTEuMTIuOC1hZGRfZGlzYWJsZS1sdG8ucGF0Y2gKQEAgLTAsMCArMSw1MiBAQAorRnJv bSBjMzY0NWQ5N2ViZDI0YzZmN2FkODUwNzg1ZDU4NWFlYmM3MDZhMTFjIE1vbiBTZXAgMTcgMDA6 MDA6MDAgMjAwMQorRnJvbTogQnJ5Y2UgSGFycmluZ3RvbiA8Yi5oYXJyaW5ndG9uQHNhbXN1bmcu Y29tPgorRGF0ZTogVHVlLCA4IEp1bCAyMDE0IDEzOjE0OjIwIC0wNzAwCitTdWJqZWN0OiBjb25m aWd1cmUuYWM6IEFkZCBhIC0tZGlzYWJsZS1sdG8gY29uZmlndXJlIG9wdGlvbgorCitMaW5rLVRp bWUgT3B0aW1pemF0aW9uIHNlZW1zIHRvIGJlIHN0YWJsZSBlbm91Z2ggd2l0aCBnY2MgNC44IGFu ZCA0LjksCitidXQgaGFzIHByb3ZlbiB0byBiZSBhbiBpc3N1ZSBpbiB0aGUgcGFzdCBmb3IgbWFu eSBjYWlybyB1c2VycyAod2Via2l0LAorZWZsLCB1YnVudHUsIG9wZW5zdXNlLCBnZW50b28sIGFy Y2guLi4pIHdobyBjYXJyeSBwYXRjaGVzIHRvIGRpc2FibGUgaXQuCisKK0dlbnRvbydzIHBhdGNo WzFdIGFkZHMgYSAtLWRpc2FibGUtbHRvIG9wdGlvbiB0byBsZWF2ZSBpdCBlbmFibGVkIGJ5Citk ZWZhdWx0IGJ1dCBnaXZlIHVzZXJzIHRoZSBhYmlsaXR5IHRvIHdvcmsgYXJvdW5kIGx0byByZWxh dGVkIGJ1aWxkCitwcm9ibGVtcyAoYy5mLiBmZG8gIzc3MDYwKS4gIFBhdGNoIGFwcGVhcnMgdG8g aGF2ZSBiZWVuIGF1dGhvcmVkIGJ5CitBbGV4YW5kcmUgUm9zdG92dHNldlsyXS4KKworMTogc291 cmNlcy5nZW50b28ub3JnL2NnaS1iaW4vdmlld3ZjLmNnaS9nZW50b28teDg2L3gxMS1saWJzL2Nh aXJvL2ZpbGVzL2NhaXJvLTEuMTIuMTYtbHRvLW9wdGlvbmFsLnBhdGNoCisyOiBodHRwczovL2J1 Z3MuZ2VudG9vLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA5NTUyCisKK0ZpeGVzOiBodHRwczovL2J1 Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD02MDg1MgorU2lnbmVkLW9mZi1ieTog QnJ5Y2UgSGFycmluZ3RvbiA8Yi5oYXJyaW5ndG9uQHNhbXN1bmcuY29tPgorUmV2aWV3ZWQtYnk6 IFVsaSBTY2hsYWNodGVyIDxwc3ljaG9uQHpuYy5pbj4KKworZGlmZiAtLWdpdCBhL2J1aWxkL2Nv bmZpZ3VyZS5hYy53YXJuaW5ncyBiL2J1aWxkL2NvbmZpZ3VyZS5hYy53YXJuaW5ncworaW5kZXgg Zjk4NGViMi4uYTcyZDk0OCAxMDA2NDQKKy0tLSBhL2J1aWxkL2NvbmZpZ3VyZS5hYy53YXJuaW5n cworKysrIGIvYnVpbGQvY29uZmlndXJlLmFjLndhcm5pbmdzCitAQCAtMzgsMTMgKzM4LDE4IEBA IGRubCBvcHRpb25zLiAgTmFtZWx5LCB0aGUgZm9sbG93aW5nOgorIAorIGRubCAtZmx0byB3b3Jr aW5nIHJlYWxseSBuZWVkcyBhIHRlc3QgbGluaywgbm90IGp1c3QgYSBjb21waWxlCisgCistc2Fm ZV9NQVlCRV9XQVJOPSIkTUFZQkVfV0FSTiIKKy1NQVlCRV9XQVJOPSIkTUFZQkVfV0FSTiAtZmx0 byIKKy1BQ19UUllfTElOSyhbXSxbCisrQUNfQVJHX0VOQUJMRShsdG8sCisrICBBU19IRUxQX1NU UklORyhbLS1kaXNhYmxlLWx0b10sCisrICAgICAgICAgICAgICAgICBbRG8gbm90IHRyeSB0byB1 c2UgTGluay1UaW1lIE9wdGltaXphdGlvbl0pKQorK2lmIHRlc3QgIngkZW5hYmxlX2x0byIgIT0g InhubyI7IHRoZW4KKysgICBzYWZlX01BWUJFX1dBUk49IiRNQVlCRV9XQVJOIgorKyAgIE1BWUJF X1dBUk49IiRNQVlCRV9XQVJOIC1mbHRvIgorKyAgIEFDX1RSWV9MSU5LKFtdLFsKKyAJaW50IG1h aW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KSB7IHJldHVybiAwOyB9CistXSxbXSxbCisrICAgXSxb XSxbCisgCU1BWUJFX1dBUk49IiRzYWZlX01BWUJFX1dBUk4iCistXSkKKysgICBdKQorK2ZpCisg CisgTUFZQkVfV0FSTj0iJE1BWUJFX1dBUk4gLWZuby1zdHJpY3QtYWxpYXNpbmcgLWZuby1jb21t b24iCisgCistLSAKK2NnaXQgdjAuMTAuMgorCg==