139055 2014-11-26 00:51:55 -0800 [EFL] Add warning if CMake version is too old for building with ninja. 2014-11-28 01:50:01 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 b.gajda webkit-unassigned commit-queue gyuyoung.kim oldest_to_newest 1051052 0 b.gajda 2014-11-26 00:51:55 -0800 CMake 2.8.9 does not know CMAKE_NINJA_FORCE_RESPONSE_FILE, so it won't allow You to build WebKit using ninja. On Ubuntu 12.04 (which many people still use as it was previous LTS) doing 'apt-get install cmake' You do get 2.8.9. Apparently same situation occurs in 12.10 ( https://lists.webkit.org/pipermail/webkit-gtk/2014-March/001809.html ) I thought we might add small warning (and for 12.04 proposed solution), if such old version will be detected to inform developer at time, to save him searching. Opinions? 1051053 1 242220 b.gajda 2014-11-26 00:53:38 -0800 Created attachment 242220 proposed patch 1051200 2 242220 gyuyoung.kim 2014-11-27 18:02:14 -0800 Comment on attachment 242220 proposed patch LGTM. 1051225 3 242220 commit-queue 2014-11-28 01:49:58 -0800 Comment on attachment 242220 proposed patch Clearing flags on attachment: 242220 Committed r176560: <http://trac.webkit.org/changeset/176560> 1051226 4 commit-queue 2014-11-28 01:50:01 -0800 All reviewed patches have been landed. Closing bug. 242220 2014-11-26 00:53:38 -0800 2014-11-28 01:49:58 -0800 proposed patch proposed_patch_v1 text/plain 2090 b.gajda ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlNTVj MWNjLi4xNzE2ODM5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMTEtMjYgIEJhcnRsb21pZWogR2FqZGEgIDxi LmdhamRhQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIEFkZCB3YXJuaW5nIGlmIENNYWtl IHZlcnNpb24gaXMgdG9vIG9sZCBmb3IgYnVpbGRpbmcgd2l0aCBuaW5qYS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTA1NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENNYWtlIG5lZWQgdG8gYmUgPj0g Mi44LjEwIHRvIGJ1aWxkIFdlYktpdCB1c2luZyBuaW5qYSwgc29tZSByZXBvcyBkb24ndCBoYXZl CisgICAgICAgIHRoYXQgdmVyc2lvbiBpbiB0aGVpciByZXBvc2l0b3JpZXMuCisKKyAgICAgICAg KiBlZmwvaW5zdGFsbC1kZXBlbmRlbmNpZXM6CisKIDIwMTQtMTEtMjYgIEFrb3MgS2lzcyAgPGFr aXNzQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBbRUZMXVtHVEtdIEJ1bXAgdXAgRkRFIHJl bG9jYXRpb24gZml4aW5nIHBhdGNoIHRvIHZlcnNpb24gYWNjZXB0ZWQgdG8gTExWTSB0cnVuay4K ZGlmZiAtLWdpdCBhL1Rvb2xzL2VmbC9pbnN0YWxsLWRlcGVuZGVuY2llcyBiL1Rvb2xzL2VmbC9p bnN0YWxsLWRlcGVuZGVuY2llcwppbmRleCAwZTFlM2MzLi43YzIyYTZkIDEwMDc1NQotLS0gYS9U b29scy9lZmwvaW5zdGFsbC1kZXBlbmRlbmNpZXMKKysrIGIvVG9vbHMvZWZsL2luc3RhbGwtZGVw ZW5kZW5jaWVzCkBAIC0xNCwxMSArMTQsMzQgQEAgZnVuY3Rpb24gcHJpbnROb3RTdXBwb3J0ZWRN ZXNzYWdlQW5kRXhpdCgpIHsKICAgICBleGl0IDEKIH0KIAorZnVuY3Rpb24gY2hlY2tDbWFrZVZl cnNpb24oKSB7CisgICAgQ01BS0VfVkVSU0lPTj1gY21ha2UgLS12ZXJzaW9uYAorCisgICAgVkVS U0lPTj1gZWNobyAiJENNQUtFX1ZFUlNJT04iIHwgYXdrICd7c3BsaXQoJDMsbnVtLCIuIik7Cisg ICAgaWYgKCEobnVtWzFdPjIgfHwgbnVtWzJdPjggfHwgbnVtWzNdPj0xMCkpCisgICAgICAgIHBy aW50ZiAkM30nYAorCisgICAgaWYgWyAtbiAiJHtWRVJTSU9OfSIgXTsgdGhlbgorICAgICAgICBl Y2hvICJXYXJuaW5nOiBDTWFrZSB2ZXJzaW9uIGRldGVjdGVkICgke1ZFUlNJT059KSBpcyBsb3dl ciB0aGVuIDIuOC4xMC4iCisgICAgICAgIGVjaG8gIiAgVGhpcyB3aWxsIHByb2JhYmx5IGNhdXNl IGVycm9ycywgYXMgb2xkZXIgdmVyc2lvbiBkaWRuJ3Qgc3VwcG9ydCBDTUFLRV9OSU5KQV9GT1JD RV9SRVNQT05TRV9GSUxFLCIKKyAgICAgICAgZWNobyAiICB3aGljaCBpcyBuZWVkZWQgbm93IGZv ciBidWlsZGluZy4gKGxvb2sgYXQ6IGh0dHBzOi8vbGlzdHMud2Via2l0Lm9yZy9waXBlcm1haWwv d2Via2l0LWd0ay8yMDE0LU1hcmNoLzAwMTgwOS5odG1sICkiCisgICAgICAgIGVjaG8gIiIKKwor ICAgICAgICBpZiBbIC1mICIvZXRjL2lzc3VlIiBdOyB0aGVuCisgICAgICAgICAgICB1YnVudHVf dmVyc2lvbj1gY2F0IC9ldGMvaXNzdWVgCisgICAgICAgICAgICBpZiBbWyAkdWJ1bnR1X3ZlcnNp b24gPT0gKlVidW50dVwgMTIuMDQqIF1dOyB0aGVuCisgICAgICAgICAgICAgICAgZWNobyAiICBG b3IgVWJ1bnR1IDEyLjA0IG9yIDEyLjEwIFlvdSBtaWdodCBjb25zaWRlciBhZGRpbmcgcHBhIGZy b20gaHR0cHM6Ly9sYXVuY2hwYWQubmV0L35rYWxha3Jpcy8rYXJjaGl2ZS91YnVudHUvY21ha2Ui CisgICAgICAgICAgICBmaQorICAgICAgICBmaQorICAgIGZpCit9CisKIGZ1bmN0aW9uIGNoZWNr SW5zdGFsbGVyIHsKICAgICAjIGFwdC1nZXQgLSBEZWJpYW4gYmFzZWQgZGlzdHJpYnV0aW9ucwog ICAgIGFwdC1nZXQgLS12ZXJzaW9uICY+IC9kZXYvbnVsbAogICAgIGlmIFsgJD8gLWVxIDAgXTsg dGhlbgogICAgICAgICBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aEFwdAorICAgICAgICBjaGVja0Nt YWtlVmVyc2lvbjsKICAgICAgICAgZXhpdCAwCiAgICAgZmkKIAo=