139040 2014-11-25 03:05:46 -0800 [MSE] Rename highest presentation end timestamp to group end timestamp, per spec 2015-02-14 05:36:26 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 139265 P2 Normal --- 1 b.gajda webkit-unassigned calvaris commit-queue eric.carlson glenn jer.noble ltilve philipj sam sergio oldest_to_newest 1050977 0 b.gajda 2014-11-25 03:05:46 -0800 According to http://www.w3.org/TR/media-source/#revision-history 01 April 2014 : "Bug 24820 - Renamed highest presentation end timestamp to group end timestamp and fixed a few related issues." This does the rename part. 1050978 1 242193 b.gajda 2014-11-25 03:12:17 -0800 Created attachment 242193 patch v1 1050979 2 b.gajda 2014-11-25 03:24:32 -0800 Also according to spec Group End Timestamp should be intialized to 0, not to invalid time as it is now. Before 01.04.2014 revision there was line: "If highest presentation end timestamp is unset or frame end timestamp is greater than highest presentation ..." but now it's: "If frame end timestamp is greater than group end timestamp, then set group end timestmap..." Shall I add this to this change, or make another bug for it? 1051300 3 sam 2014-11-28 23:10:48 -0800 (In reply to comment #2) > Also according to spec Group End Timestamp should be intialized to 0, not to > invalid time as it is now. > > Before 01.04.2014 revision there was line: > > "If highest presentation end timestamp is unset or frame end timestamp is > greater than highest presentation ..." > > but now it's: > > "If frame end timestamp is greater than group end timestamp, then set group > end timestmap..." > > Shall I add this to this change, or make another bug for it? You could do all that in one change, but you would need a test case if you change behavior. 1053719 4 b.gajda 2014-12-09 02:25:07 -0800 *** This bug has been marked as a duplicate of bug 139265 *** 242193 2014-11-25 03:12:17 -0800 2015-02-14 05:36:26 -0800 patch v1 rename_patch.txt text/plain 4651 b.gajda ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNjVjNzNmLi42NTY1Yjg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMTEtMjUgIEJhcnRsb21pZWogR2FqZGEgIDxiLmdhamRhQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtNU0VdIFJlbmFtZSBoaWdoZXN0IHByZXNlbnRhdGlvbiBlbmQgdGltZXN0YW1w IHRvIGdyb3VwIGVuZCB0aW1lc3RhbXAsIHBlciBzcGVjLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5MDQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjb3JkaW5nIHRvIGNoYW5nZSBpbiBNU0Ugc3Bl YyBhZnRlciByZXZpc2lvbiAoMDEgQXByaWwgMjAxNCB0aGlzIHNob3VsZCBiZSByZW5hbWVkLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlh c291cmNlL1NvdXJjZUJ1ZmZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXI6 OlNvdXJjZUJ1ZmZlcik6CisgICAgICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXI6OnNvdXJjZUJ1 ZmZlclByaXZhdGVEaWRSZWNlaXZlU2FtcGxlKToKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc291 cmNlL1NvdXJjZUJ1ZmZlci5oOgorCiAyMDE0LTExLTI0ICBFdmEgQmFsYXpzZmFsdmkgIDxldmFi LnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CiAKICAgICAgICAgRml4IHVudXNlZCB2YXJp YWJsZSB3YXJuaW5nIGluIEJpcXVhZC5jcHAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFzb3VyY2UvU291cmNlQnVmZmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbWVkaWFzb3VyY2UvU291cmNlQnVmZmVyLmNwcAppbmRleCA5MjJmYWZkLi5iMTFlNDJhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZl ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZm ZXIuY3BwCkBAIC0xMTAsNyArMTEwLDcgQEAgU291cmNlQnVmZmVyOjpTb3VyY2VCdWZmZXIoUGFz c1JlZjxTb3VyY2VCdWZmZXJQcml2YXRlPiBzb3VyY2VCdWZmZXJQcml2YXRlLCBNZWQKICAgICAs IG1fc291cmNlKHNvdXJjZSkKICAgICAsIG1fYXN5bmNFdmVudFF1ZXVlKCp0aGlzKQogICAgICwg bV9hcHBlbmRCdWZmZXJUaW1lcigqdGhpcywgJlNvdXJjZUJ1ZmZlcjo6YXBwZW5kQnVmZmVyVGlt ZXJGaXJlZCkKLSAgICAsIG1faGlnaGVzdFByZXNlbnRhdGlvbkVuZFRpbWVzdGFtcChNZWRpYVRp bWU6OmludmFsaWRUaW1lKCkpCisgICAgLCBtX2dyb3VwRW5kVGltZXN0YW1wKE1lZGlhVGltZTo6 aW52YWxpZFRpbWUoKSkKICAgICAsIG1fYnVmZmVyZWQoVGltZVJhbmdlczo6Y3JlYXRlKCkpCiAg ICAgLCBtX2FwcGVuZFN0YXRlKFdhaXRpbmdGb3JTZWdtZW50KQogICAgICwgbV90aW1lT2ZCdWZm ZXJpbmdNb25pdG9yKG1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpKQpAQCAtMTIyNyw3ICsx MjI3LDcgQEAgdm9pZCBTb3VyY2VCdWZmZXI6OnNvdXJjZUJ1ZmZlclByaXZhdGVEaWRSZWNlaXZl U2FtcGxlKFNvdXJjZUJ1ZmZlclByaXZhdGUqLCBQYXMKICAgICAgICAgICAgIHx8IGFicyhkZWNv ZGVUaW1lc3RhbXAgLSB0cmFja0J1ZmZlci5sYXN0RGVjb2RlVGltZXN0YW1wKSA+ICh0cmFja0J1 ZmZlci5sYXN0RnJhbWVEdXJhdGlvbiAqIDIpKSkgewogICAgICAgICAgICAgLy8gMS43LjEgSWYg bW9kZSBlcXVhbHMgInNlZ21lbnRzIjoKICAgICAgICAgICAgIC8vIFNldCBoaWdoZXN0IHByZXNl bnRhdGlvbiBlbmQgdGltZXN0YW1wIHRvIHByZXNlbnRhdGlvbiB0aW1lc3RhbXAuCi0gICAgICAg ICAgICBtX2hpZ2hlc3RQcmVzZW50YXRpb25FbmRUaW1lc3RhbXAgPSBwcmVzZW50YXRpb25UaW1l c3RhbXA7CisgICAgICAgICAgICBtX2dyb3VwRW5kVGltZXN0YW1wID0gcHJlc2VudGF0aW9uVGlt ZXN0YW1wOwogCiAgICAgICAgICAgICAvLyBJZiBtb2RlIGVxdWFscyAic2VxdWVuY2UiOgogICAg ICAgICAgICAgLy8gU2V0IGdyb3VwIHN0YXJ0IHRpbWVzdGFtcCBlcXVhbCB0byB0aGUgaGlnaGVz dCBwcmVzZW50YXRpb24gZW5kIHRpbWVzdGFtcC4KQEAgLTE0MTIsOCArMTQxMiw4IEBAIHZvaWQg U291cmNlQnVmZmVyOjpzb3VyY2VCdWZmZXJQcml2YXRlRGlkUmVjZWl2ZVNhbXBsZShTb3VyY2VC dWZmZXJQcml2YXRlKiwgUGFzCiAKICAgICAgICAgLy8gMS4yMSBJZiBoaWdoZXN0IHByZXNlbnRh dGlvbiBlbmQgdGltZXN0YW1wIGlzIHVuc2V0IG9yIGZyYW1lIGVuZCB0aW1lc3RhbXAgaXMgZ3Jl YXRlciB0aGFuIGhpZ2hlc3QKICAgICAgICAgLy8gcHJlc2VudGF0aW9uIGVuZCB0aW1lc3RhbXAs IHRoZW4gc2V0IGhpZ2hlc3QgcHJlc2VudGF0aW9uIGVuZCB0aW1lc3RhbXAgZXF1YWwgdG8gZnJh bWUgZW5kIHRpbWVzdGFtcC4KLSAgICAgICAgaWYgKG1faGlnaGVzdFByZXNlbnRhdGlvbkVuZFRp bWVzdGFtcC5pc0ludmFsaWQoKSB8fCBmcmFtZUVuZFRpbWVzdGFtcCA+IG1faGlnaGVzdFByZXNl bnRhdGlvbkVuZFRpbWVzdGFtcCkKLSAgICAgICAgICAgIG1faGlnaGVzdFByZXNlbnRhdGlvbkVu ZFRpbWVzdGFtcCA9IGZyYW1lRW5kVGltZXN0YW1wOworICAgICAgICBpZiAobV9ncm91cEVuZFRp bWVzdGFtcC5pc0ludmFsaWQoKSB8fCBmcmFtZUVuZFRpbWVzdGFtcCA+IG1fZ3JvdXBFbmRUaW1l c3RhbXApCisgICAgICAgICAgICBtX2dyb3VwRW5kVGltZXN0YW1wID0gZnJhbWVFbmRUaW1lc3Rh bXA7CiAKICAgICAgICAgbV9idWZmZXJlZC0+YWRkKHByZXNlbnRhdGlvblRpbWVzdGFtcC50b0Rv dWJsZSgpLCAocHJlc2VudGF0aW9uVGltZXN0YW1wICsgZnJhbWVEdXJhdGlvbiArIG1pY3Jvc2Vj b25kKS50b0RvdWJsZSgpKTsKICAgICAgICAgbV9idWZmZXJlZFNpbmNlTGFzdE1vbml0b3IgKz0g ZnJhbWVEdXJhdGlvbi50b0RvdWJsZSgpOwpAQCAtMTQyNSw4ICsxNDI1LDggQEAgdm9pZCBTb3Vy Y2VCdWZmZXI6OnNvdXJjZUJ1ZmZlclByaXZhdGVEaWRSZWNlaXZlU2FtcGxlKFNvdXJjZUJ1ZmZl clByaXZhdGUqLCBQYXMKIAogICAgIC8vIDUuIElmIHRoZSBtZWRpYSBzZWdtZW50IGNvbnRhaW5z IGRhdGEgYmV5b25kIHRoZSBjdXJyZW50IGR1cmF0aW9uLCB0aGVuIHJ1biB0aGUgZHVyYXRpb24g Y2hhbmdlIGFsZ29yaXRobSB3aXRoIG5ldwogICAgIC8vIGR1cmF0aW9uIHNldCB0byB0aGUgbWF4 aW11bSBvZiB0aGUgY3VycmVudCBkdXJhdGlvbiBhbmQgdGhlIGhpZ2hlc3QgZW5kIHRpbWVzdGFt cCByZXBvcnRlZCBieSBIVE1MTWVkaWFFbGVtZW50LmJ1ZmZlcmVkLgotICAgIGlmIChoaWdoZXN0 UHJlc2VudGF0aW9uRW5kVGltZXN0YW1wKCkgPiBtX3NvdXJjZS0+ZHVyYXRpb24oKSkKLSAgICAg ICAgbV9zb3VyY2UtPnNldER1cmF0aW9uSW50ZXJuYWwoaGlnaGVzdFByZXNlbnRhdGlvbkVuZFRp bWVzdGFtcCgpKTsKKyAgICBpZiAoZ3JvdXBFbmRUaW1lc3RhbXAoKSA+IG1fc291cmNlLT5kdXJh dGlvbigpKQorICAgICAgICBtX3NvdXJjZS0+c2V0RHVyYXRpb25JbnRlcm5hbChncm91cEVuZFRp bWVzdGFtcCgpKTsKIH0KIAogYm9vbCBTb3VyY2VCdWZmZXI6Omhhc0F1ZGlvKCkgY29uc3QKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvU291cmNlQnVmZmVy LmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZlci5oCmlu ZGV4IDA2NjEwMzguLjk3ZjQyMDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv bWVkaWFzb3VyY2UvU291cmNlQnVmZmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t ZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXIuaApAQCAtNzksNyArNzksNyBAQCBwdWJsaWM6CiAKICAg ICB2b2lkIGFib3J0SWZVcGRhdGluZygpOwogICAgIHZvaWQgcmVtb3ZlZEZyb21NZWRpYVNvdXJj ZSgpOwotICAgIGNvbnN0IE1lZGlhVGltZSYgaGlnaGVzdFByZXNlbnRhdGlvbkVuZFRpbWVzdGFt cCgpIGNvbnN0IHsgcmV0dXJuIG1faGlnaGVzdFByZXNlbnRhdGlvbkVuZFRpbWVzdGFtcDsgfQor ICAgIGNvbnN0IE1lZGlhVGltZSYgZ3JvdXBFbmRUaW1lc3RhbXAoKSBjb25zdCB7IHJldHVybiBt X2dyb3VwRW5kVGltZXN0YW1wOyB9CiAgICAgdm9pZCBzZWVrVG9UaW1lKGNvbnN0IE1lZGlhVGlt ZSYpOwogCiAjaWYgRU5BQkxFKFZJREVPX1RSQUNLKQpAQCAtMTk0LDcgKzE5NCw3IEBAIHByaXZh dGU6CiAgICAgVmVjdG9yPEF0b21pY1N0cmluZz4gbV90ZXh0Q29kZWNzOwogCiAgICAgTWVkaWFU aW1lIG1fdGltZXN0YW1wT2Zmc2V0OwotICAgIE1lZGlhVGltZSBtX2hpZ2hlc3RQcmVzZW50YXRp b25FbmRUaW1lc3RhbXA7CisgICAgTWVkaWFUaW1lIG1fZ3JvdXBFbmRUaW1lc3RhbXA7CiAKICAg ICBIYXNoTWFwPEF0b21pY1N0cmluZywgVHJhY2tCdWZmZXI+IG1fdHJhY2tCdWZmZXJNYXA7CiAg ICAgUmVmUHRyPFRpbWVSYW5nZXM+IG1fYnVmZmVyZWQ7Cg==