139023 2014-11-24 02:58:45 -0800 [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view() 2014-11-24 03:18:46 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned berto commit-queue gustavo mrobinson pnormand svillar oldest_to_newest 1050827 0 cgarcia 2014-11-24 02:58:45 -0800 The WebKitWebContext is a construct only property, so it's always set to the default value when not provided, during the construction. When a related-view is used to create a new web view we should ensure that the same web context is used for the new web view, instead of the default. We should also ignore any web context given as construct parameter if a related view is alos provided. 1050828 1 242154 cgarcia 2014-11-24 03:03:01 -0800 Created attachment 242154 Patch 1050829 2 commit-queue 2014-11-24 03:05:49 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1050830 3 242154 svillar 2014-11-24 03:13:11 -0800 Comment on attachment 242154 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242154&action=review > Source/WebKit2/ChangeLog:13 > + context given as construct parameter if a related view is alos provided. Nit: alos->also 1050831 4 cgarcia 2014-11-24 03:18:46 -0800 Committed r176513: <http://trac.webkit.org/changeset/176513> 242154 2014-11-24 03:03:01 -0800 2014-11-24 03:13:11 -0800 Patch wk2-webview-context.diff text/plain 6181 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzMDdhZThlLi44NWQ1N2FmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTQtMTEtMjQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFdlYktpdFdlYlZpZXcgaXMgY3JlYXRlZCB3aXRoIHRoZSB3cm9u ZyB3ZWIgY29udGV4dCB3aGVuIHVzaW5nIHdlYmtpdF93ZWJfdmlld19uZXdfd2l0aF9yZWxhdGVk X3ZpZXcoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM5MDIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIFdlYktpdFdlYkNvbnRleHQgaXMgYSBjb25zdHJ1Y3Qgb25seSBwcm9wZXJ0eSwgc28gaXQn cyBhbHdheXMKKyAgICAgICAgc2V0IHRvIHRoZSBkZWZhdWx0IHZhbHVlIHdoZW4gbm90IHByb3Zp ZGVkLCBkdXJpbmcgdGhlCisgICAgICAgIGNvbnN0cnVjdGlvbi4gV2hlbiBhIHJlbGF0ZWQtdmll dyBpcyB1c2VkIHRvIGNyZWF0ZSBhIG5ldyB3ZWIgdmlldworICAgICAgICB3ZSBzaG91bGQgZW5z dXJlIHRoYXQgdGhlIHNhbWUgd2ViIGNvbnRleHQgaXMgdXNlZCBmb3IgdGhlIG5ldyB3ZWIKKyAg ICAgICAgdmlldywgaW5zdGVhZCBvZiB0aGUgZGVmYXVsdC4gV2Ugc2hvdWxkIGFsc28gaWdub3Jl IGFueSB3ZWIKKyAgICAgICAgY29udGV4dCBnaXZlbiBhcyBjb25zdHJ1Y3QgcGFyYW1ldGVyIGlm IGEgcmVsYXRlZCB2aWV3IGlzIGFsb3MgcHJvdmlkZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdDb25zdHJ1 Y3RlZCk6IERvIG5vdCBzZXQgdGhlIGNvbnRleHQgdG8gdGhlIGRlZmF1bHQKKyAgICAgICAgb25l IHdoZW4gbm90IGdpdmVuIGR1cmluZyBjb25zdHJ1Y3Rpb24uCisgICAgICAgICh3ZWJraXRXZWJW aWV3U2V0UHJvcGVydHkpOiBPbmx5IHVzZSB0aGUgZGVmYXVsdCB3ZWIgY29udGV4dCB3aGVuCisg ICAgICAgIG5vdCBwcm92aWRlZCBhcyBjb25zdHJ1Y3QgcGFyYW1ldGVyIGFuZCB0aGVyZSBpc24n dCBhIHJlbGF0ZWQgdmlldy4KKwogMjAxNC0xMS0yMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIEFQSSB0byBvdmVycmlkZSB0 aGUgZGVmYXVsdCBsb2NhbCBzdG9yYWdlIGRpcmVjdG9yeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcAppbmRleCBmYTY3MTgzLi45ODYy ZmFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX ZWJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX ZWJWaWV3LmNwcApAQCAtNTY0LDEzICs1NjQsMTcgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViVmll d0hhbmRsZURvd25sb2FkUmVxdWVzdChXZWJLaXRXZWJWaWV3QmFzZSogd2ViVmlld0Jhc2UsIEQK IAogc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0NvbnN0cnVjdGVkKEdPYmplY3QqIG9iamVjdCkK IHsKLSAgICBpZiAoR19PQkpFQ1RfQ0xBU1Mod2Via2l0X3dlYl92aWV3X3BhcmVudF9jbGFzcykt PmNvbnN0cnVjdGVkKQotICAgICAgICBHX09CSkVDVF9DTEFTUyh3ZWJraXRfd2ViX3ZpZXdfcGFy ZW50X2NsYXNzKS0+Y29uc3RydWN0ZWQob2JqZWN0KTsKKyAgICBHX09CSkVDVF9DTEFTUyh3ZWJr aXRfd2ViX3ZpZXdfcGFyZW50X2NsYXNzKS0+Y29uc3RydWN0ZWQob2JqZWN0KTsKIAogICAgIFdl YktpdFdlYlZpZXcqIHdlYlZpZXcgPSBXRUJLSVRfV0VCX1ZJRVcob2JqZWN0KTsKICAgICBXZWJL aXRXZWJWaWV3UHJpdmF0ZSogcHJpdiA9IHdlYlZpZXctPnByaXY7CisgICAgaWYgKHByaXYtPnJl bGF0ZWRWaWV3KQorICAgICAgICBwcml2LT5jb250ZXh0ID0gd2Via2l0X3dlYl92aWV3X2dldF9j b250ZXh0KHByaXYtPnJlbGF0ZWRWaWV3KTsKKyAgICBlbHNlIGlmICghcHJpdi0+Y29udGV4dCkK KyAgICAgICAgcHJpdi0+Y29udGV4dCA9IHdlYmtpdF93ZWJfY29udGV4dF9nZXRfZGVmYXVsdCgp OwogICAgIGlmICghcHJpdi0+c2V0dGluZ3MpCiAgICAgICAgIHByaXYtPnNldHRpbmdzID0gYWRv cHRHUmVmKHdlYmtpdF9zZXR0aW5nc19uZXcoKSk7CisKICAgICB3ZWJraXRXZWJDb250ZXh0Q3Jl YXRlUGFnZUZvcldlYlZpZXcocHJpdi0+Y29udGV4dCwgd2ViVmlldywgcHJpdi0+dXNlckNvbnRl bnRNYW5hZ2VyLmdldCgpLCBwcml2LT5yZWxhdGVkVmlldyk7CiAKICAgICBwcml2LT5sb2FkT2Jz ZXJ2ZXIgPSBzdGQ6Om1ha2VfdW5pcXVlPFBhZ2VMb2FkU3RhdGVPYnNlcnZlcj4od2ViVmlldyk7 CkBAIC02MDMsNyArNjA3LDcgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld1NldFByb3BlcnR5 KEdPYmplY3QqIG9iamVjdCwgZ3VpbnQgcHJvcElkLCBjb25zdCBHVmFsdWUKICAgICBzd2l0Y2gg KHByb3BJZCkgewogICAgIGNhc2UgUFJPUF9XRUJfQ09OVEVYVDogewogICAgICAgICBncG9pbnRl ciB3ZWJDb250ZXh0ID0gZ192YWx1ZV9nZXRfb2JqZWN0KHZhbHVlKTsKLSAgICAgICAgd2ViVmll dy0+cHJpdi0+Y29udGV4dCA9IHdlYkNvbnRleHQgPyBXRUJLSVRfV0VCX0NPTlRFWFQod2ViQ29u dGV4dCkgOiB3ZWJraXRfd2ViX2NvbnRleHRfZ2V0X2RlZmF1bHQoKTsKKyAgICAgICAgd2ViVmll dy0+cHJpdi0+Y29udGV4dCA9IHdlYkNvbnRleHQgPyBXRUJLSVRfV0VCX0NPTlRFWFQod2ViQ29u dGV4dCkgOiBudWxscHRyOwogICAgICAgICBicmVhazsKICAgICB9CiAgICAgY2FzZSBQUk9QX1JF TEFURURfVklFVzogewpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdl TG9nCmluZGV4IGNmOWI3YzguLjgyZmFlMDcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZwor KysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNC0xMS0yNCAgQ2FybG9z IEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gV2Vi S2l0V2ViVmlldyBpcyBjcmVhdGVkIHdpdGggdGhlIHdyb25nIHdlYiBjb250ZXh0IHdoZW4gdXNp bmcgd2Via2l0X3dlYl92aWV3X25ld193aXRoX3JlbGF0ZWRfdmlldygpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzkwMjMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW5hbWUgV2ViS2l0V2ViVmlldy9k ZWZhdWx0LWNvbnRleHQgYXMgV2ViS2l0V2ViVmlldy93ZWItY29udGV4dAorICAgICAgICBhbmQg Y2hlY2sgd2UgYXJlIGFsd2F5cyB1c2luZyB0aGUgcmlnaHQgY29udGV4dCBmb3IgbmV3IHdlYiB2 aWV3cy4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0V2Vi S2l0V2ViVmlldy5jcHA6CisgICAgICAgICh0ZXN0V2ViVmlld1dlYkNvbnRleHQpOgorICAgICAg ICAoYmVmb3JlQWxsKToKKyAgICAgICAgKHRlc3RXZWJWaWV3RGVmYXVsdENvbnRleHQpOiBEZWxl dGVkLgorCiAyMDE0LTExLTIzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgQVBJIHRvIG92ZXJyaWRlIHRoZSBkZWZhdWx0IGxv Y2FsIHN0b3JhZ2UgZGlyZWN0b3J5CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdDJHdGsvVGVzdFdlYktpdFdlYlZpZXcuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3RXZWJLaXRXZWJWaWV3LmNwcAppbmRleCA3NzU4MGE2Li5k NDJlZTAyIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsv VGVzdFdlYktpdFdlYlZpZXcuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0Mkd0ay9UZXN0V2ViS2l0V2ViVmlldy5jcHAKQEAgLTI0LDEzICsyNCwyMyBAQAogI2luY2x1 ZGUgPGdsaWIvZ3N0ZGlvLmg+CiAjaW5jbHVkZSA8d3RmL2dvYmplY3QvR1JlZlB0ci5oPgogCi1z dGF0aWMgdm9pZCB0ZXN0V2ViVmlld0RlZmF1bHRDb250ZXh0KFdlYlZpZXdUZXN0KiB0ZXN0LCBn Y29uc3Rwb2ludGVyKQorc3RhdGljIHZvaWQgdGVzdFdlYlZpZXdXZWJDb250ZXh0KFdlYlZpZXdU ZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQogewogICAgIGdfYXNzZXJ0KHdlYmtpdF93ZWJfdmll d19nZXRfY29udGV4dCh0ZXN0LT5tX3dlYlZpZXcpID09IHRlc3QtPm1fd2ViQ29udGV4dC5nZXQo KSk7CisgICAgZ19hc3NlcnQod2Via2l0X3dlYl9jb250ZXh0X2dldF9kZWZhdWx0KCkgIT0gdGVz dC0+bV93ZWJDb250ZXh0LmdldCgpKTsKIAogICAgIC8vIENoZWNrIHRoYXQgYSB3ZWIgdmlldyBj cmVhdGVkIHdpdGggZ19vYmplY3RfbmV3IGhhcyB0aGUgZGVmYXVsdCBjb250ZXh0LgotICAgIEdS ZWZQdHI8V2ViS2l0V2ViVmlldz4gd2ViVmlldyA9IFdFQktJVF9XRUJfVklFVyhnX29iamVjdF9u ZXcoV0VCS0lUX1RZUEVfV0VCX1ZJRVcsIE5VTEwpKTsKKyAgICBHUmVmUHRyPFdlYktpdFdlYlZp ZXc+IHdlYlZpZXcgPSBXRUJLSVRfV0VCX1ZJRVcoZ19vYmplY3RfbmV3KFdFQktJVF9UWVBFX1dF Ql9WSUVXLCBudWxscHRyKSk7CiAgICAgZ19hc3NlcnQod2Via2l0X3dlYl92aWV3X2dldF9jb250 ZXh0KHdlYlZpZXcuZ2V0KCkpID09IHdlYmtpdF93ZWJfY29udGV4dF9nZXRfZGVmYXVsdCgpKTsK KworICAgIC8vIENoZWNrIHRoYXQgYSB3ZWIgdmlldyBjcmVhdGVkIHdpdGggYSByZWxhdGVkIHZp ZXcgaGFzIHRoZSByZWxhdGVkIHZpZXcgY29udGV4dC4KKyAgICB3ZWJWaWV3ID0gV0VCS0lUX1dF Ql9WSUVXKHdlYmtpdF93ZWJfdmlld19uZXdfd2l0aF9yZWxhdGVkX3ZpZXcodGVzdC0+bV93ZWJW aWV3KSk7CisgICAgZ19hc3NlcnQod2Via2l0X3dlYl92aWV3X2dldF9jb250ZXh0KHdlYlZpZXcu Z2V0KCkpID09IHRlc3QtPm1fd2ViQ29udGV4dC5nZXQoKSk7CisKKyAgICAvLyBDaGVjayB0aGF0 IGEgd2ViIGNvbnRleHQgZ2l2ZW4gYXMgY29uc3RydWN0IHBhcmFtZXRlciBpcyBpZ25vcmVkIGlm IGEgcmVsYXRlZCB2aWV3IGlzIGFsc28gcHJvdmlkZWQuCisgICAgd2ViVmlldyA9IFdFQktJVF9X RUJfVklFVyhnX29iamVjdF9uZXcoV0VCS0lUX1RZUEVfV0VCX1ZJRVcsCisgICAgICAgICJ3ZWIt Y29udGV4dCIsIHdlYmtpdF93ZWJfY29udGV4dF9nZXRfZGVmYXVsdCgpLCAicmVsYXRlZC12aWV3 IiwgdGVzdC0+bV93ZWJWaWV3LCBudWxscHRyKSk7CisgICAgZ19hc3NlcnQod2Via2l0X3dlYl92 aWV3X2dldF9jb250ZXh0KHdlYlZpZXcuZ2V0KCkpID09IHRlc3QtPm1fd2ViQ29udGV4dC5nZXQo KSk7CiB9CiAKIHN0YXRpYyB2b2lkIHRlc3RXZWJWaWV3Q3VzdG9tQ2hhcnNldChXZWJWaWV3VGVz dCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKQEAgLTU3Myw3ICs1ODMsNyBAQCBzdGF0aWMgdm9pZCB0 ZXN0V2ViVmlld1NuYXBzaG90KFNuYXBzaG90V2ViVmlld1Rlc3QqIHRlc3QsIGdjb25zdHBvaW50 ZXIpCiAKIHZvaWQgYmVmb3JlQWxsKCkKIHsKLSAgICBXZWJWaWV3VGVzdDo6YWRkKCJXZWJLaXRX ZWJWaWV3IiwgImRlZmF1bHQtY29udGV4dCIsIHRlc3RXZWJWaWV3RGVmYXVsdENvbnRleHQpOwor ICAgIFdlYlZpZXdUZXN0OjphZGQoIldlYktpdFdlYlZpZXciLCAid2ViLWNvbnRleHQiLCB0ZXN0 V2ViVmlld1dlYkNvbnRleHQpOwogICAgIFdlYlZpZXdUZXN0OjphZGQoIldlYktpdFdlYlZpZXci LCAiY3VzdG9tLWNoYXJzZXQiLCB0ZXN0V2ViVmlld0N1c3RvbUNoYXJzZXQpOwogICAgIFdlYlZp ZXdUZXN0OjphZGQoIldlYktpdFdlYlZpZXciLCAic2V0dGluZ3MiLCB0ZXN0V2ViVmlld1NldHRp bmdzKTsKICAgICBXZWJWaWV3VGVzdDo6YWRkKCJXZWJLaXRXZWJWaWV3IiwgInpvb20tbGV2ZWwi LCB0ZXN0V2ViVmlld1pvb21MZXZlbCk7Cg==