139020 2014-11-23 20:51:02 -0800 Page previews should have titles 2014-11-23 22:55:24 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 conrad_shultz conrad_shultz andersca bdakin conrad_shultz mitz thorton webkit-bug-importer oldest_to_newest 1050795 0 conrad_shultz 2014-11-23 20:51:02 -0800 Page previews should have titles. 1050796 1 webkit-bug-importer 2014-11-23 20:51:44 -0800 <rdar://problem/19070840> 1050797 2 242142 conrad_shultz 2014-11-23 21:00:33 -0800 Created attachment 242142 Patch 1050798 3 242142 thorton 2014-11-23 21:08:16 -0800 Comment on attachment 242142 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242142&action=review Wonder if we should move these preview related things into their own file; they're growing fast! > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:164 > + [titleTextField setStringValue:title ? title : @""]; Is it going to magically collapse in this case? It seems like it might, and that's probably good. 1050799 4 242142 conrad_shultz 2014-11-23 21:12:57 -0800 Comment on attachment 242142 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242142&action=review >> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:164 >> + [titleTextField setStringValue:title ? title : @""]; > > Is it going to magically collapse in this case? It seems like it might, and that's probably good. Yes and no: the text field itself will, but we make no effort to resize the preview view; the title region remains a fixed previewViewTitleHeight points tall irrespective of title content. We could of course collapse the title region in such an event, but it would add unnecessary complexity at the moment. (The nil check on line 164 is really only there so we don't raise an exception by trying to set a nil stringValue). Thanks for the review! 1050800 5 conrad_shultz 2014-11-23 21:16:01 -0800 (In reply to comment #3) > Comment on attachment 242142 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=242142&action=review > > Wonder if we should move these preview related things into their own file; > they're growing fast! It's something we should probably consider, I agree. 1050801 6 conrad_shultz 2014-11-23 21:20:59 -0800 Committed r176511: <http://trac.webkit.org/changeset/176511> 1050808 7 242142 mitz 2014-11-23 22:49:51 -0800 Comment on attachment 242142 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242142&action=review > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:79 > @protocol WKPagePreviewViewControllerDelegate <NSObject> Not new to this patch, but it’s unconventional to have a delegate protocol with required methods. Classes should be able to function with the delegate being nil as well as not implementing all methods. > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:162 > + title = [_url absoluteString]; The URLS may change because of redirects and script-initiated navigation. It seems wrong (and sometimes considered to have security implications) to not update the URL (or URL-derived) in the UI a when the URL being shows changes. 1050809 8 conrad_shultz 2014-11-23 22:55:24 -0800 (In reply to comment #7) > Comment on attachment 242142 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=242142&action=review > > > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:79 > > @protocol WKPagePreviewViewControllerDelegate <NSObject> > > Not new to this patch, but it’s unconventional to have a delegate protocol > with required methods. Classes should be able to function with the delegate > being nil as well as not implementing all methods. For the moment, since this class is purely internal to this file, I don't think this is a major issue. If we move it out as discussed with Tim above then we should definitely do this (at least for this method, which is pretty optional on its face). > > > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:162 > > + title = [_url absoluteString]; > > The URLS may change because of redirects and script-initiated navigation. It > seems wrong (and sometimes considered to have security implications) to not > update the URL (or URL-derived) in the UI a when the URL being shows changes. Good point, I'll address this in a subsequent patch. 242142 2014-11-23 21:00:33 -0800 2014-11-23 21:08:16 -0800 Patch bug-139020-20141123210052.patch text/plain 6885 conrad_shultz U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2NDkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2RkZjVmNTg3OTYzZmVi N2FkYzZkNTU5ZjNhMTE5YWY4ZmI4NTEyZi4uNmJlNGIyMmUxNjM3NTVjMjhhMDFhMjA3YWE5N2Yy MDViZDkyMTgwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE0LTExLTIzICBDb25y YWQgU2h1bHR6ICA8Y29ucmFkX3NodWx0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUGFnZSBwcmV2 aWV3cyBzaG91bGQgaGF2ZSB0aXRsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzOTAyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ZpZXdQcml2YXRlLmg6Cisg ICAgICAgIERlY2xhcmUgLV90aXRsZUZvclByZXZpZXdPZlVSTDouCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL21hYy9XS1ZpZXcubW06CisgICAgICAgICgtW1dLVmlldyBfdGl0bGVGb3JQcmV2 aWV3T2ZVUkw6XSk6CisgICAgICAgIFN0dWIgaW1wbGVtZW50YXRpb24uCisKKyAgICAgICAgKiBV SVByb2Nlc3MvbWFjL1dLQWN0aW9uTWVudUNvbnRyb2xsZXIubW06CisgICAgICAgICgrW1dLUGFn ZVByZXZpZXdWaWV3Q29udHJvbGxlciBwcmV2aWV3UGFkZGluZ10pOgorICAgICAgICBBY2NvdW50 IGZvciB0aGUgdGl0bGUgaGVpZ2h0LgorICAgICAgICAoLVtXS1BhZ2VQcmV2aWV3Vmlld0NvbnRy b2xsZXIgbG9hZFZpZXddKToKKyAgICAgICAgU2V0IGNvcnJlY3QgYXV0b3Jlc2l6ZSBtYXNrcyBv biBzb21lIHZpZXdzOyBjcmVhdGUgYW5kIGNvbmZpZ3VyZSBhIHRpdGxlIHZpZXcgdGhhdCBpcwor ICAgICAgICBob3Jpem9udGFsbHkgYW5kIHZlcnRpY2FsbHkgY2VudGVyZWQuCisgICAgICAgICgt W1dLQWN0aW9uTWVudUNvbnRyb2xsZXIgcGFnZVByZXZpZXdWaWV3Q29udHJvbGxlcjp0aXRsZUZv clByZXZpZXdPZlVSTDpdKToKKyAgICAgICAgV0tQYWdlUHJldmlld1ZpZXdDb250cm9sbGVyRGVs ZWdhdGUgbWV0aG9kOyB3cmFwIC1bV0tWaWV3IF90aXRsZUZvclByZXZpZXdPZlVSTDpdLgorCiAy MDE0LTExLTIxICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgaU9TIGJ1aWxkIGZpeCBhZnRlciByMTc2NDUyLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ZpZXdQcml2YXRlLmggYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVmlld1ByaXZhdGUuaAppbmRleCBiYjA0NTNjMzUw OTI1MzcyNTFlNjc5YjdlNDRkY2M3NTc3ZWY2ZWViLi5jNmJhNGMxM2VmYWVjZDkzMDM4YmExMDli MDg1NGZiZDUwMzg0ZTNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLVmlld1ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLVmlld1ByaXZhdGUuaApAQCAtMTIzLDYgKzEyMyw3IEBACiAtIChOU0FycmF5ICop X2FjdGlvbk1lbnVJdGVtc0ZvckhpdFRlc3RSZXN1bHQ6KFdLSGl0VGVzdFJlc3VsdFJlZiloaXRU ZXN0UmVzdWx0IHdpdGhUeXBlOihfV0tBY3Rpb25NZW51VHlwZSl0eXBlIGRlZmF1bHRBY3Rpb25N ZW51SXRlbXM6KE5TQXJyYXkgKilkZWZhdWx0TWVudUl0ZW1zIHVzZXJEYXRhOihXS1R5cGVSZWYp dXNlckRhdGE7CiAKIC0gKE5TVmlldyAqKV92aWV3Rm9yUHJldmlld2luZ1VSTDooTlNVUkwgKil1 cmwgaW5pdGlhbEZyYW1lU2l6ZTooTlNTaXplKWluaXRpYWxGcmFtZVNpemU7CistIChOU1N0cmlu ZyAqKV90aXRsZUZvclByZXZpZXdPZlVSTDooTlNVUkwgKil1cmw7CiAtICh2b2lkKV9maW5pc2hQ cmV2aWV3aW5nVVJMOihOU1VSTCAqKXVybCB3aXRoUHJldmlld1ZpZXc6KE5TVmlldyAqKXByZXZp ZXdWaWV3OwogLSAodm9pZClfaGFuZGxlQ2xpY2tJblByZXZpZXdWaWV3OihOU1ZpZXcgKilwcmV2 aWV3VmlldyBVUkw6KE5TVVJMICopdXJsOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L21hYy9XS1ZpZXcubW0KaW5kZXggMzRiODkwOGE4Mjc1MDFmMTJmZDZjNGNlMTE5MjI3MjE5MjU0 ZDA1Yy4uMzUxMzVlYzg0MmViOTkwZTFkMzc2ZGYzMDQ4NjJkYTE5MjNkZjU5YSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQpAQCAtNDIxOSw2ICs0MjE5LDEx IEBAIHN0YXRpYyBOU1N0cmluZyAqcGF0aFdpdGhVbmlxdWVGaWxlbmFtZUZvclBhdGgoTlNTdHJp bmcgKnBhdGgpCiAgICAgcmV0dXJuIG5pbDsKIH0KIAorLSAoTlNTdHJpbmcgKilfdGl0bGVGb3JQ cmV2aWV3T2ZVUkw6KE5TVVJMICopdXJsCit7CisgICAgcmV0dXJuIG5pbDsKK30KKwogLSAodm9p ZClfZmluaXNoUHJldmlld2luZ1VSTDooTlNVUkwgKil1cmwgd2l0aFByZXZpZXdWaWV3OihOU1Zp ZXcgKilwcmV2aWV3VmlldwogewogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL21hYy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL21hYy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLm1tCmluZGV4IGEzZTQ3NTgwODJmMjM5ZGY4 Y2ViZmVkN2JjNWVjZjZkZDQ4NzFkZGIuLjc0YzhjN2UwNzBkYmM4N2E0NmZhNzc4MzMwZmNjOGNk OWNhNGE5YWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tBY3Rp b25NZW51Q29udHJvbGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dL QWN0aW9uTWVudUNvbnRyb2xsZXIubW0KQEAgLTcyLDExICs3MiwxMyBAQCB1c2luZyBuYW1lc3Bh Y2UgV2ViS2l0OwogI2lmIFdLX0FQSV9FTkFCTEVECiAKIHN0YXRpYyBjb25zdCBDR0Zsb2F0IHBy ZXZpZXdWaWV3SW5zZXQgPSAzOworc3RhdGljIGNvbnN0IENHRmxvYXQgcHJldmlld1ZpZXdUaXRs ZUhlaWdodCA9IDM0OwogCiBAY2xhc3MgV0tQYWdlUHJldmlld1ZpZXdDb250cm9sbGVyOwogCiBA cHJvdG9jb2wgV0tQYWdlUHJldmlld1ZpZXdDb250cm9sbGVyRGVsZWdhdGUgPE5TT2JqZWN0Pgog LSAoTlNWaWV3ICopcGFnZVByZXZpZXdWaWV3Q29udHJvbGxlcjooV0tQYWdlUHJldmlld1ZpZXdD b250cm9sbGVyICopcGFnZVByZXZpZXdWaWV3Q29udHJvbGxlciB2aWV3Rm9yUHJldmlld2luZ1VS TDooTlNVUkwgKil1cmwgaW5pdGlhbEZyYW1lU2l6ZTooTlNTaXplKWluaXRpYWxGcmFtZVNpemU7 CistIChOU1N0cmluZyAqKXBhZ2VQcmV2aWV3Vmlld0NvbnRyb2xsZXI6KFdLUGFnZVByZXZpZXdW aWV3Q29udHJvbGxlciAqKXBhZ2VQcmV2aWV3Vmlld0NvbnRyb2xsZXIgdGl0bGVGb3JQcmV2aWV3 T2ZVUkw6KE5TVVJMICopdXJsOwogLSAodm9pZClwYWdlUHJldmlld1ZpZXdDb250cm9sbGVyV2Fz Q2xpY2tlZDooV0tQYWdlUHJldmlld1ZpZXdDb250cm9sbGVyICopcGFnZVByZXZpZXdWaWV3Q29u dHJvbGxlcjsKIEBlbmQKIApAQCAtMTExLDcgKzExMyw3IEBAIHN0YXRpYyBjb25zdCBDR0Zsb2F0 IHByZXZpZXdWaWV3SW5zZXQgPSAzOwogCiArIChOU1NpemUpcHJldmlld1BhZGRpbmcKIHsKLSAg ICByZXR1cm4gTlNNYWtlU2l6ZSgyICogcHJldmlld1ZpZXdJbnNldCwgMiAqIHByZXZpZXdWaWV3 SW5zZXQpOworICAgIHJldHVybiBOU01ha2VTaXplKDIgKiBwcmV2aWV3Vmlld0luc2V0LCBwcmV2 aWV3Vmlld1RpdGxlSGVpZ2h0ICsgMiAqIHByZXZpZXdWaWV3SW5zZXQpOwogfQogCiAtICh2b2lk KWxvYWRWaWV3CkBAIC0xMzMsMTMgKzEzNSw0MyBAQCBzdGF0aWMgY29uc3QgQ0dGbG9hdCBwcmV2 aWV3Vmlld0luc2V0ID0gMzsKIAogICAgIE5TUmVjdCBwcmV2aWV3RnJhbWUgPSBbX3ByZXZpZXdW aWV3IGZyYW1lXTsKICAgICBOU1JlY3QgY29udGFpbmVyRnJhbWUgPSBwcmV2aWV3RnJhbWU7Ci0g ICAgY29udGFpbmVyRnJhbWUuc2l6ZS53aWR0aCArPSAyICogcHJldmlld1ZpZXdJbnNldDsKLSAg ICBjb250YWluZXJGcmFtZS5zaXplLmhlaWdodCArPSAyICogcHJldmlld1ZpZXdJbnNldDsKKyAg ICBOU1NpemUgdG90YWxQYWRkaW5nID0gW1tzZWxmIGNsYXNzXSBwcmV2aWV3UGFkZGluZ107Cisg ICAgY29udGFpbmVyRnJhbWUuc2l6ZS53aWR0aCArPSB0b3RhbFBhZGRpbmcud2lkdGg7CisgICAg Y29udGFpbmVyRnJhbWUuc2l6ZS5oZWlnaHQgKz0gdG90YWxQYWRkaW5nLmhlaWdodDsKICAgICBw cmV2aWV3RnJhbWUgPSBOU09mZnNldFJlY3QocHJldmlld0ZyYW1lLCBwcmV2aWV3Vmlld0luc2V0 LCBwcmV2aWV3Vmlld0luc2V0KTsKIAogICAgIFJldGFpblB0cjxOU1ZpZXc+IGNvbnRhaW5lclZp ZXcgPSBhZG9wdE5TKFtbTlNWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOmNvbnRhaW5lckZyYW1l XSk7CisgICAgW2NvbnRhaW5lclZpZXcgc2V0QXV0b3Jlc2l6aW5nTWFzazpOU1ZpZXdXaWR0aFNp emFibGUgfCBOU1ZpZXdIZWlnaHRTaXphYmxlXTsKICAgICBbY29udGFpbmVyVmlldyBhZGRTdWJ2 aWV3Ol9wcmV2aWV3Vmlldy5nZXQoKV07CiAgICAgW19wcmV2aWV3VmlldyBzZXRGcmFtZTpwcmV2 aWV3RnJhbWVdOworICAgIFtfcHJldmlld1ZpZXcgc2V0QXV0b3Jlc2l6aW5nTWFzazpOU1ZpZXdX aWR0aFNpemFibGUgfCBOU1ZpZXdIZWlnaHRTaXphYmxlXTsKKworICAgIFJldGFpblB0cjxOU1Rl eHRGaWVsZD4gdGl0bGVUZXh0RmllbGQgPSBhZG9wdE5TKFtbTlNUZXh0RmllbGQgYWxsb2NdIGlu aXRdKTsKKyAgICBbdGl0bGVUZXh0RmllbGQgc2V0V2FudHNMYXllcjpZRVNdOworICAgIFt0aXRs ZVRleHRGaWVsZCBzZXRBdXRvcmVzaXppbmdNYXNrOk5TVmlld1dpZHRoU2l6YWJsZSB8IE5TVmll d01pbllNYXJnaW5dOworICAgIFt0aXRsZVRleHRGaWVsZCBzZXRFZGl0YWJsZTpOT107CisgICAg W3RpdGxlVGV4dEZpZWxkIHNldEJlemVsZWQ6Tk9dOworICAgIFt0aXRsZVRleHRGaWVsZCBzZXRE cmF3c0JhY2tncm91bmQ6Tk9dOworICAgIFt0aXRsZVRleHRGaWVsZCBzZXRBbGlnbm1lbnQ6TlND ZW50ZXJUZXh0QWxpZ25tZW50XTsKKyAgICBbdGl0bGVUZXh0RmllbGQgc2V0VXNlc1NpbmdsZUxp bmVNb2RlOllFU107CisgICAgW3RpdGxlVGV4dEZpZWxkIHNldExpbmVCcmVha01vZGU6TlNMaW5l QnJlYWtCeVRydW5jYXRpbmdUYWlsXTsKKyAgICBbdGl0bGVUZXh0RmllbGQgc2V0VGV4dENvbG9y OltOU0NvbG9yIGxhYmVsQ29sb3JdXTsKKworICAgIE5TU3RyaW5nICp0aXRsZSA9IFtfZGVsZWdh dGUgcGFnZVByZXZpZXdWaWV3Q29udHJvbGxlcjpzZWxmIHRpdGxlRm9yUHJldmlld09mVVJMOl91 cmwuZ2V0KCldOworICAgIGlmICghdGl0bGUpCisgICAgICAgIHRpdGxlID0gW191cmwgYWJzb2x1 dGVTdHJpbmddOworCisgICAgW3RpdGxlVGV4dEZpZWxkIHNldFN0cmluZ1ZhbHVlOnRpdGxlID8g dGl0bGUgOiBAIiJdOworCisgICAgW3RpdGxlVGV4dEZpZWxkIHNpemVUb0ZpdF07CisgICAgTlNT aXplIHRpdGxlRml0dGluZ1NpemUgPSBbdGl0bGVUZXh0RmllbGQgZnJhbWVdLnNpemU7CisgICAg Q0dGbG9hdCB0ZXh0RmllbGRDZW50ZXJpbmdPZmZzZXQgPSAoTlNNYXhZKGNvbnRhaW5lckZyYW1l KSAtIE5TTWF4WShwcmV2aWV3RnJhbWUpIC0gdGl0bGVGaXR0aW5nU2l6ZS5oZWlnaHQpIC8gMjsK KworICAgIE5TUmVjdCB0aXRsZUZyYW1lID0gcHJldmlld0ZyYW1lOworICAgIHRpdGxlRnJhbWUu c2l6ZS5oZWlnaHQgPSB0aXRsZUZpdHRpbmdTaXplLmhlaWdodDsKKyAgICB0aXRsZUZyYW1lLm9y aWdpbi55ID0gTlNNYXhZKHByZXZpZXdGcmFtZSkgKyB0ZXh0RmllbGRDZW50ZXJpbmdPZmZzZXQ7 CisgICAgW3RpdGxlVGV4dEZpZWxkIHNldEZyYW1lOnRpdGxlRnJhbWVdOworICAgIFtjb250YWlu ZXJWaWV3IGFkZFN1YnZpZXc6dGl0bGVUZXh0RmllbGQuZ2V0KCldOwogCiAgICAgLy8gU2V0dGlu ZyB0aGUgd2ViVmlldyBib3VuZHMgd2lsbCBzY2FsZSBpdCB0byA3NSUgb2YgdGhlIF9tYWluVmll d1NpemUuCiAgICAgW19wcmV2aWV3VmlldyBzZXRCb3VuZHM6TlNNYWtlUmVjdCgwLCAwLCBfbWFp blZpZXdTaXplLndpZHRoIC8gX3BvcG92ZXJUb1ZpZXdTY2FsZSwgX21haW5WaWV3U2l6ZS5oZWln aHQgLyBfcG9wb3ZlclRvVmlld1NjYWxlKV07CkBAIC0xMDg3LDYgKzExMTksMTEgQEAgc3RhdGlj IE5TU3RyaW5nICpwYXRoVG9QaG90b09uRGlzayhOU1N0cmluZyAqc3VnZ2VzdGVkRmlsZW5hbWUp CiAgICAgcmV0dXJuIFtfd2tWaWV3IF92aWV3Rm9yUHJldmlld2luZ1VSTDp1cmwgaW5pdGlhbEZy YW1lU2l6ZTppbml0aWFsRnJhbWVTaXplXTsKIH0KIAorLSAoTlNTdHJpbmcgKilwYWdlUHJldmll d1ZpZXdDb250cm9sbGVyOihXS1BhZ2VQcmV2aWV3Vmlld0NvbnRyb2xsZXIgKilwYWdlUHJldmll d1ZpZXdDb250cm9sbGVyIHRpdGxlRm9yUHJldmlld09mVVJMOihOU1VSTCAqKXVybAoreworICAg IHJldHVybiBbX3drVmlldyBfdGl0bGVGb3JQcmV2aWV3T2ZVUkw6dXJsXTsKK30KKwogLSAodm9p ZClwYWdlUHJldmlld1ZpZXdDb250cm9sbGVyV2FzQ2xpY2tlZDooV0tQYWdlUHJldmlld1ZpZXdD b250cm9sbGVyICopcGFnZVByZXZpZXdWaWV3Q29udHJvbGxlcgogewogICAgIGlmIChOU1VSTCAq dXJsID0gcGFnZVByZXZpZXdWaWV3Q29udHJvbGxlci0+X3VybC5nZXQoKSkK