138989 2014-11-21 15:45:43 -0800 The preview action menu item should not have a title 2014-11-21 16:20:16 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin mitz thorton oldest_to_newest 1050613 0 bdakin 2014-11-21 15:45:43 -0800 The preview action menu item should not have a title rdar://problem/19061959 1050614 1 242088 bdakin 2014-11-21 15:48:56 -0800 Created attachment 242088 Patch 1050619 2 242088 mitz 2014-11-21 15:52:56 -0800 Comment on attachment 242088 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242088&action=review > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:-843 > - title = WEB_UI_STRING_KEY("Preview", "Preview (action menu item)", "action menu item"); Does this leave an unused key in the localizable strings file? 1050621 3 bdakin 2014-11-21 15:54:47 -0800 (In reply to comment #2) > Comment on attachment 242088 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=242088&action=review > > > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:-843 > > - title = WEB_UI_STRING_KEY("Preview", "Preview (action menu item)", "action menu item"); > > Does this leave an unused key in the localizable strings file? Not currently since we do still (intentionally) use the string in WK1. 1050633 4 bdakin 2014-11-21 16:20:16 -0800 Thanks! http://trac.webkit.org/changeset/176485 242088 2014-11-21 15:48:56 -0800 2014-11-21 15:49:49 -0800 Patch for-review.txt text/plain 1408 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjQ3OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTExLTIxICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBUaGUgcHJldmlldyBhY3Rpb24gbWVu dSBpdGVtIHNob3VsZCBub3QgaGF2ZSBhIHRpdGxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg5ODkKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5n LQorICAgICAgICByZGFyOi8vcHJvYmxlbS8xOTA2MTk1OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9XS0FjdGlvbk1lbnVD b250cm9sbGVyLm1tOgorICAgICAgICAoLVtXS0FjdGlvbk1lbnVDb250cm9sbGVyIF9jcmVhdGVB Y3Rpb25NZW51SXRlbUZvclRhZzpdKToKKwogMjAxNC0xMS0yMSAgVGltIEhvcnRvbiAgPHRpbW90 aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTc2MzUxKTogUGFy dHMgb2YgYXBwbGUuY29tL2NvbnRhY3QgYXJlbid0IExvb2t1cC1hYmxlCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLQWN0aW9uTWVudUNvbnRyb2xsZXIubW0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0FjdGlvbk1lbnVDb250cm9sbGVy Lm1tCShyZXZpc2lvbiAxNzY0MzApCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dL QWN0aW9uTWVudUNvbnRyb2xsZXIubW0JKHdvcmtpbmcgY29weSkKQEAgLTg0MCw3ICs4NDAsNyBA QCAtIChSZXRhaW5QdHI8TlNNZW51SXRlbT4pX2NyZWF0ZUFjdGlvbk1lCiAjaWYgV0tfQVBJX0VO QUJMRUQKICAgICBjYXNlIGtXS0NvbnRleHRBY3Rpb25JdGVtVGFnUHJldmlld0xpbms6CiAgICAg ICAgIHNlbGVjdG9yID0gQHNlbGVjdG9yKF9rZWVwUHJldmlld09wZW5Gcm9tQWN0aW9uTWVudTop OwotICAgICAgICB0aXRsZSA9IFdFQl9VSV9TVFJJTkdfS0VZKCJQcmV2aWV3IiwgIlByZXZpZXcg KGFjdGlvbiBtZW51IGl0ZW0pIiwgImFjdGlvbiBtZW51IGl0ZW0iKTsKKyAgICAgICAgdGl0bGUg PSBAIiI7CiAgICAgICAgIGltYWdlID0gW05TSW1hZ2UgaW1hZ2VOYW1lZDpAIk5TQWN0aW9uTWVu dVF1aWNrTG9vayJdOwogICAgICAgICBicmVhazsKICNlbmRpZgogCg==