138988 2014-11-21 15:29:02 -0800 Web Inspector: DOMExceptions do not show the error message string in Pause Reason section 2014-12-01 11:11:09 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1050598 0 joepeck 2014-11-21 15:29:02 -0800 * SUMMARY DOMExceptions do not show the error message string in Pause Reason section. * STEPS TO REPRODUCE 1. Inspect nytimes.com 2. Enable pause on all exceptions 3. Reload => When pausing due to a DOMException the message is just "DOMException" => Expected something better, like: "Error: SyntaxError: DOM Exception 12" 1050600 1 webkit-bug-importer 2014-11-21 15:29:34 -0800 <rdar://problem/19064068> 1050603 2 242084 joepeck 2014-11-21 15:31:57 -0800 Created attachment 242084 [PATCH] Proposed Fix 1051099 3 242084 commit-queue 2014-11-26 08:56:48 -0800 Comment on attachment 242084 [PATCH] Proposed Fix Rejecting attachment 242084 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 242084, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: t.org/repository/webkit/trunk ... Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Password for 'commit-queue@webkit.org': Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Username: Use of uninitialized value $username in chomp at /usr/share/git-core/perl/Git/SVN/Prompt.pm line 114. error: git-svn died of signal 11 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.appspot.com/results/6545376169426944 1051499 4 joepeck 2014-12-01 11:11:09 -0800 http://trac.webkit.org/changeset/176595 242084 2014-11-21 15:31:57 -0800 2014-11-26 08:56:48 -0800 [PATCH] Proposed Fix better-dom-exception.patch text/plain 3396 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwOTRlMzlhLi4yYzU1ZDgxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMTEt MjEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiBET01FeGNlcHRpb25zIGRvIG5vdCBzaG93IHRoZSBlcnJvciBtZXNzYWdlIHN0 cmluZyBpbiBQYXVzZSBSZWFzb24gc2VjdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4OTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZGVidWdnZXIvY29tbWFuZC1saW5lLWFw aS1leGNlcHRpb24tZXhwZWN0ZWQudHh0OgorCiAyMDE0LTExLTE5ICBKb3NlcGggUGVjb3Jhcm8g IDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogTGF5b3V0VGVz dHMvaW5zcGVjdG9yIHRlc3RzIGZhaWwgaW4gUHJvZHVjdGlvbiBidWlsZHMgZHVlIHRvIG1pc3Np bmcgdGVzdCByZXNvdXJjZXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1 Z2dlci9jb21tYW5kLWxpbmUtYXBpLWV4Y2VwdGlvbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvZGVidWdnZXIvY29tbWFuZC1saW5lLWFwaS1leGNlcHRpb24tZXhwZWN0ZWQu dHh0CmluZGV4IDZmNzcyOWIuLmU3MzlhNzEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3Bl Y3Rvci9kZWJ1Z2dlci9jb21tYW5kLWxpbmUtYXBpLWV4Y2VwdGlvbi1leHBlY3RlZC50eHQKKysr IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyL2NvbW1hbmQtbGluZS1hcGktZXhjZXB0 aW9uLWV4cGVjdGVkLnR4dApAQCAtMTYsNyArMTYsNyBAQCBCRUZPUkU6ICRleGNlcHRpb24gPT4g dW5kZWZpbmVkCiBQQVVTRSAjMTogJGV4Y2VwdGlvbiA9PiBUeXBlRXJyb3I6IHVuZGVmaW5lZCBp cyBub3QgYW4gb2JqZWN0IChldmFsdWF0aW5nICdbXS54LngnKQogUEFVU0UgIzI6ICRleGNlcHRp b24gPT4gUmVmZXJlbmNlRXJyb3I6IENhbid0IGZpbmQgdmFyaWFibGU6IHZhcmlhYmxlVGhhdERv ZXNOb3RFeGlzdAogUEFVU0UgIzM6ICRleGNlcHRpb24gPT4gU3ludGF4RXJyb3I6IFVuZXhwZWN0 ZWQgdG9rZW4gJyknCi1QQVVTRSAjNDogJGV4Y2VwdGlvbiA9PiBET01FeGNlcHRpb24KK1BBVVNF ICM0OiAkZXhjZXB0aW9uID0+IEVycm9yOiBJbmRleFNpemVFcnJvcjogRE9NIEV4Y2VwdGlvbiAx CiBQQVVTRSAjNTogJGV4Y2VwdGlvbiA9PiB0aHJvd24gc3RyaW5nCiBQQVVTRSAjNjogJGV4Y2Vw dGlvbiA9PiAxMjMuNDU2CiBQQVVTRSAjNzogJGV4Y2VwdGlvbiA9PiBudWxsCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggODRjNzE4MS4uMWE0ZWUyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTEx LTIxICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2Vi IEluc3BlY3RvcjogRE9NRXhjZXB0aW9ucyBkbyBub3Qgc2hvdyB0aGUgZXJyb3IgbWVzc2FnZSBz dHJpbmcgaW4gUGF1c2UgUmVhc29uIHNlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODk4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL1dlYkluamVjdGVkU2NyaXB0SG9zdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJJbmplY3RlZFNjcmlwdEhvc3Q6OnR5cGUpOgorICAg ICAgICBHaXZlIGFsbCBET00gRXhjZXB0aW9uIHR5cGVzIHRoZSAiZXJyb3IiIFJlbW90ZU9iamVj dCBzdWJ0eXBlLgorCiAyMDE0LTExLTE5ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBs ZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSlNDb250ZXh0IGluc3BlY3Rpb24gUmVz b3VyY2Ugc2VhcmNoIGRvZXMgbm90IHdvcmsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9XZWJJbmplY3RlZFNjcmlwdEhvc3QuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL1dlYkluamVjdGVkU2NyaXB0SG9zdC5jcHAKaW5kZXggMWUwMGMzOC4uZTRiMzU5ZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL1dlYkluamVjdGVkU2NyaXB0SG9zdC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL1dlYkluamVjdGVkU2NyaXB0SG9zdC5j cHAKQEAgLTI4LDYgKzI4LDggQEAKIAogI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAKKyNpbmNsdWRl ICJFeGNlcHRpb25IZWFkZXJzLmgiCisjaW5jbHVkZSAiRXhjZXB0aW9uSW50ZXJmYWNlcy5oIgog I2luY2x1ZGUgIkpTSFRNTEFsbENvbGxlY3Rpb24uaCIKICNpbmNsdWRlICJKU0hUTUxDb2xsZWN0 aW9uLmgiCiAjaW5jbHVkZSAiSlNOb2RlLmgiCkBAIC0zNiw2ICszOCwxMCBAQAogdXNpbmcgbmFt ZXNwYWNlIEpTQzsKIAogbmFtZXNwYWNlIFdlYkNvcmUgeworICAgIAorI2RlZmluZSBSRVRVUk5f RVJST1JfSUZfVkFMVUVfSU5IRVJJVFNfRVhDRVBUSU9OX1RZUEUoaW50ZXJmYWNlTmFtZSkgXAor ICAgIGlmICh2YWx1ZS5pbmhlcml0cyhKUyMjaW50ZXJmYWNlTmFtZTo6aW5mbygpKSkgXAorICAg ICAgICByZXR1cm4ganNOb250cml2aWFsU3RyaW5nKGV4ZWMsIEFTQ0lJTGl0ZXJhbCgiZXJyb3Ii KSk7CiAKIEpTVmFsdWUgV2ViSW5qZWN0ZWRTY3JpcHRIb3N0Ojp0eXBlKEpTQzo6RXhlY1N0YXRl KiBleGVjLCBKU0M6OkpTVmFsdWUgdmFsdWUpCiB7CkBAIC00NSw2ICs1MSw4IEBAIEpTVmFsdWUg V2ViSW5qZWN0ZWRTY3JpcHRIb3N0Ojp0eXBlKEpTQzo6RXhlY1N0YXRlKiBleGVjLCBKU0M6OkpT VmFsdWUgdmFsdWUpCiAgICAgICAgIHJldHVybiBqc05vbnRyaXZpYWxTdHJpbmcoZXhlYywgQVND SUlMaXRlcmFsKCJhcnJheSIpKTsKICAgICBpZiAodmFsdWUuaW5oZXJpdHMoSlNIVE1MQ29sbGVj dGlvbjo6aW5mbygpKSkKICAgICAgICAgcmV0dXJuIGpzTm9udHJpdmlhbFN0cmluZyhleGVjLCBB U0NJSUxpdGVyYWwoImFycmF5IikpOworICAgIAorICAgIERPTV9FWENFUFRJT05fSU5URVJGQUNF U19GT1JfRUFDSChSRVRVUk5fRVJST1JfSUZfVkFMVUVfSU5IRVJJVFNfRVhDRVBUSU9OX1RZUEUp CiAKICAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKIH0K