138982 2014-11-21 14:51:15 -0800 WebVideoFullscreenManagerProxy must clear pointers when invalidated 2014-11-21 16:55:39 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue glenn jer.noble philipj sergio oldest_to_newest 1050570 0 eric.carlson 2014-11-21 14:51:15 -0800 WebVideoFullscreenManagerProxy::invalidate is called when the page is about to close, so it should clear the WebVideoFullscreenModel and WebVideoFullscreenChangeObserver. 1050571 1 eric.carlson 2014-11-21 14:51:30 -0800 rdar://problem/18904411 1050573 2 242074 eric.carlson 2014-11-21 14:57:43 -0800 Created attachment 242074 Proposed patch. 1050641 3 242074 commit-queue 2014-11-21 16:55:34 -0800 Comment on attachment 242074 Proposed patch. Clearing flags on attachment: 242074 Committed r176487: <http://trac.webkit.org/changeset/176487> 1050642 4 commit-queue 2014-11-21 16:55:39 -0800 All reviewed patches have been landed. Closing bug. 242074 2014-11-21 14:57:43 -0800 2014-11-21 16:55:34 -0800 Proposed patch. exit_fullscreen_crash_patch_1.txt text/plain 1795 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjQ3MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTExLTIxICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFdlYlZpZGVvRnVsbHNj cmVlbk1hbmFnZXJQcm94eSBtdXN0IGNsZWFyIHBvaW50ZXJzIHdoZW4gaW52YWxpZGF0ZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODk4MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNz L2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyUHJveHkubW06CisgICAgICAgIChXZWJLaXQ6 OldlYlZpZGVvRnVsbHNjcmVlbk1hbmFnZXJQcm94eTo6fldlYlZpZGVvRnVsbHNjcmVlbk1hbmFn ZXJQcm94eSk6IENhbGwgaW52YWxpZGF0ZS4KKyAgICAgICAgKFdlYktpdDo6V2ViVmlkZW9GdWxs c2NyZWVuTWFuYWdlclByb3h5OjppbnZhbGlkYXRlKTogU2V0IFdlYlZpZGVvRnVsbHNjcmVlbk1v ZGVsIGFuZAorICAgICAgICAgICAgV2ViVmlkZW9GdWxsc2NyZWVuQ2hhbmdlT2JzZXJ2ZXIgdG8g TlVMTC4KKwogMjAxNC0xMS0yMSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNv bT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTc2MzUxKTogUGFydHMgb2YgYXBwbGUuY29tL2Nv bnRhY3QgYXJlbid0IExvb2t1cC1hYmxlCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv aW9zL1dlYlZpZGVvRnVsbHNjcmVlbk1hbmFnZXJQcm94eS5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dlYlZpZGVvRnVsbHNjcmVlbk1hbmFnZXJQcm94eS5t bQkocmV2aXNpb24gMTc2MjU4KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XZWJW aWRlb0Z1bGxzY3JlZW5NYW5hZ2VyUHJveHkubW0JKHdvcmtpbmcgY29weSkKQEAgLTY3LDEzICs2 NywxNiBAQCBXZWJWaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyUHJveHk6On5XZWJWaWRlCiB7CiAgICAg aWYgKCFtX3BhZ2UpCiAgICAgICAgIHJldHVybjsKLSAgICBtX3BhZ2UtPnByb2Nlc3MoKS5yZW1v dmVNZXNzYWdlUmVjZWl2ZXIoTWVzc2FnZXM6OldlYlZpZGVvRnVsbHNjcmVlbk1hbmFnZXJQcm94 eTo6bWVzc2FnZVJlY2VpdmVyTmFtZSgpLCBtX3BhZ2UtPnBhZ2VJRCgpKTsKKyAgICBpbnZhbGlk YXRlKCk7CiB9CiAKIHZvaWQgV2ViVmlkZW9GdWxsc2NyZWVuTWFuYWdlclByb3h5OjppbnZhbGlk YXRlKCkKIHsKICAgICBXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6aW52YWxpZGF0 ZSgpOwogCisgICAgc2V0V2ViVmlkZW9GdWxsc2NyZWVuTW9kZWwobnVsbHB0cik7CisgICAgc2V0 V2ViVmlkZW9GdWxsc2NyZWVuQ2hhbmdlT2JzZXJ2ZXIobnVsbHB0cik7CisKICAgICBtX3BhZ2Ut PnByb2Nlc3MoKS5yZW1vdmVNZXNzYWdlUmVjZWl2ZXIoTWVzc2FnZXM6OldlYlZpZGVvRnVsbHNj cmVlbk1hbmFnZXJQcm94eTo6bWVzc2FnZVJlY2VpdmVyTmFtZSgpLCBtX3BhZ2UtPnBhZ2VJRCgp KTsKICAgICBtX3BhZ2UgPSBudWxscHRyOwogCg==