138962 2014-11-21 05:36:35 -0800 [JSC] Disable verifyHeap 2014-11-21 07:26:03 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 138851 1 ossy ossy commit-queue ggaren mark.lam ossy oldest_to_newest 1050435 0 ossy 2014-11-21 05:36:35 -0800 [JSC] Disable verifyHeap 1050436 1 242042 ossy 2014-11-21 05:36:46 -0800 Created attachment 242042 Patch Disable verifyHeap, because it was enabled by mistake in r176424. 1050438 2 ossy 2014-11-21 05:39:23 -0800 In Bug138851 and in the changelog of http://trac.webkit.org/r176424 we can see clear that "The verification infrastructure code is always built in but disabled by default." So it seems it was enabled accidentally and should be disabled. I noticed it, because this change made 30 JSC tests timeout our ARM bots: - http://build.webkit.sed.hu/builders/EFL%20ARMv7%20Linux%20Release%20%28Build%29/builds/6996 - http://build.webkit.sed.hu/builders/EFL%20ARMv7%20Traditional%20Linux%20Release%20%28Build%29/builds/7745 1050447 3 242042 mark.lam 2014-11-21 06:48:08 -0800 Comment on attachment 242042 Patch r=me 1050448 4 242042 commit-queue 2014-11-21 07:25:59 -0800 Comment on attachment 242042 Patch Clearing flags on attachment: 242042 Committed r176446: <http://trac.webkit.org/changeset/176446> 1050449 5 commit-queue 2014-11-21 07:26:03 -0800 All reviewed patches have been landed. Closing bug. 242042 2014-11-21 05:36:46 -0800 2014-11-21 07:25:59 -0800 Patch bug-138962-20141121143755.patch text/plain 1243 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2NDQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NDY3NTkxZWQxOGIwYjVkOWIxYzMxMzVhODg1N2I0YmY1Mjc4MzdhLi4yNWIwYmQ1NGFiYWNhYWM0 ZjYxMGE4ODhlYzViZjdkMmZhNmY0NTNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNC0xMS0yMSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFtKU0NdIERpc2FibGUgdmVyaWZ5SGVhcAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4OTYyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL09wdGlvbnMuaDoKKwog MjAxNC0xMS0yMCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRk IHNvbWUgY29tbWVudHMgdG8gZGVzY3JpYmUgdGhlIERGRyBVc2VLaW5kIHJlcHJlc2VudGF0aW9u cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuaCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuaAppbmRleCBmMDVjZWE2ZDg2 YzE0ZDg0Y2RhMjY2N2Y4NjNlNDg1MTE0OWJmYTVkLi5mNmQwMzhkNjBkZDMwYjZhMThhMjBhMDJi ZDlmN2E3YTc0MTAzODFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9PcHRpb25zLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5o CkBAIC0yODcsNyArMjg3LDcgQEAgdHlwZWRlZiBjb25zdCBjaGFyKiBvcHRpb25TdHJpbmc7CiAg ICAgdihib29sLCBsb2dIZWFwU3RhdGlzdGljc0F0RXhpdCwgZmFsc2UpIFwKICAgICB2KGJvb2ws IGVuYWJsZVR5cGVQcm9maWxlciwgZmFsc2UpIFwKICAgICBcCi0gICAgdihib29sLCB2ZXJpZnlI ZWFwLCB0cnVlKSBcCisgICAgdihib29sLCB2ZXJpZnlIZWFwLCBmYWxzZSkgXAogICAgIHYodW5z aWduZWQsIG51bWJlck9mR0NDeWNsZXNUb1JlY29yZEZvclZlcmlmaWNhdGlvbiwgMykgXAogICAg IFwKICAgICB2KGJvb2wsIGVuYWJsZUV4Y2VwdGlvbkZ1enosIGZhbHNlKSBcCg==