<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>138957</bug_id>
          
          <creation_ts>2014-11-21 03:23:59 -0800</creation_ts>
          <short_desc>encodeWithURLEscapeSequences doesn&apos;t encode several chars</short_desc>
          <delta_ts>2014-11-21 16:17:41 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="cand">cand</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1050415</commentid>
    <comment_count>0</comment_count>
    <who name="cand">cand</who>
    <bug_when>2014-11-21 03:23:59 -0800</bug_when>
    <thetext>encodeWithURLEscapeSequences should URL-encode all needed chars. Currently it doesn&apos;t encode ?, #, +, &amp; at least, all of which cause trouble.

For example, try encoding the string &quot;c++ vector&quot;. It becomes &quot;c+++vector&quot;, which when sent to a page obviously becomes &quot;c   vector&quot;, not what the user intended.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1050632</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2014-11-21 16:17:41 -0800</bug_when>
    <thetext>I briefly looked into this in the past, and I think that the situation is substantially more complicated. Different parts of a URL need different escaping, so we need a more involved change than just adding more characters to this function.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>