138937 2014-11-20 14:50:11 -0800 WebPlugInClient::m_webPage can never be null, use a reference 2014-11-20 14:57:18 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1050265 0 andersca 2014-11-20 14:50:11 -0800 WebPlugInClient::m_webPage can never be null, use a reference 1050267 1 241987 andersca 2014-11-20 14:50:32 -0800 Created attachment 241987 Patch 1050269 2 241987 kling 2014-11-20 14:51:55 -0800 Comment on attachment 241987 Patch igp;r=me 1050271 3 andersca 2014-11-20 14:57:18 -0800 Committed r176420: <http://trac.webkit.org/changeset/176420> 241987 2014-11-20 14:50:32 -0800 2014-11-20 14:51:55 -0800 Patch bug-138937-20141120145048.patch text/plain 6679 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2NDA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzEwZTcyNWEwNzY3Yjdh YjExZTk2ODBjNzhkZjNiYmI5OWI4M2Y4NS4uZWUyNTYwYjIyMDFiNmJkMjc0MDM5NDRlY2I5OWVm ZDhhZGIwZTA0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE0LTExLTIwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViUGx1Z0luQ2xp ZW50OjptX3dlYlBhZ2UgY2FuIG5ldmVyIGJlIG51bGwsIHVzZSBhIHJlZmVyZW5jZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4OTM3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dl YkNvcmVTdXBwb3J0L1dlYlBsdWdJbkNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBs dWdJbkNsaWVudDo6V2ViUGx1Z0luQ2xpZW50KToKKyAgICAgICAgKFdlYktpdDo6V2ViUGx1Z0lu Q2xpZW50OjpzaG91bGRBdXRvU3RhcnRGcm9tT3JpZ2luKToKKyAgICAgICAgKiBXZWJQcm9jZXNz L1dlYkNvcmVTdXBwb3J0L1dlYlBsdWdJbkNsaWVudC5oOgorICAgICAgICAqIFdlYlByb2Nlc3Mv V2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6V2ViUGFnZSk6 CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViUHJvY2Vzczo6c2hvdWxkUGx1Z0luQXV0b1N0YXJ0RnJvbU9yaWdpbik6CisgICAgICAgICog V2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmg6CisKKzIwMTQtMTEtMjAgIEFuZGVycyBDYXJsc3NvbiAg PGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBBZGQgLVtXS1dlYlZpZXcgbG9hZERhdGE6 TUlNRVR5cGU6dGV4dEVuY29kaW5nTmFtZTpiYXNlVVJMOl0KICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODkyOQogICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMTg2ODM4MDI+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNv cmVTdXBwb3J0L1dlYlBsdWdJbkNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYkNvcmVTdXBwb3J0L1dlYlBsdWdJbkNsaWVudC5jcHAKaW5kZXggZTM1NTkzZTJlOGJhMGU4 ZmE3NWUxNTE4NWVkN2U4NzYyZmQxNzRjNy4uNjE0MWVlZmMyMWUwNDg5MThkYTBjYWFmODY3M2U1 MGJkMmNhMDdmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3Jl U3VwcG9ydC9XZWJQbHVnSW5DbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViQ29yZVN1cHBvcnQvV2ViUGx1Z0luQ2xpZW50LmNwcApAQCAtMzMsOCArMzMsOSBAQAog CiBuYW1lc3BhY2UgV2ViS2l0IHsKIAotV2ViUGx1Z0luQ2xpZW50OjpXZWJQbHVnSW5DbGllbnQo V2ViUGFnZSogcGFnZSkKLSAgICA6IG1fcGFnZShwYWdlKQorV2ViUGx1Z0luQ2xpZW50OjpXZWJQ bHVnSW5DbGllbnQoV2ViUGFnZSYgd2ViUGFnZSkKKyAgICA6IG1fd2ViUGFnZSh3ZWJQYWdlKQor CiB7CiB9CiAKQEAgLTQ5LDcgKzUwLDcgQEAgdm9pZCBXZWJQbHVnSW5DbGllbnQ6OnBhZ2VEZXN0 cm95ZWQoKQogCiBib29sIFdlYlBsdWdJbkNsaWVudDo6c2hvdWxkQXV0b1N0YXJ0RnJvbU9yaWdp bihjb25zdCBTdHJpbmcmIHBhZ2VPcmlnaW4sIGNvbnN0IFN0cmluZyYgcGx1Z2luT3JpZ2luLCBj b25zdCBTdHJpbmcmIG1pbWVUeXBlKQogewotICAgIHJldHVybiBXZWJQcm9jZXNzOjpzaGFyZWQo KS5zaG91bGRQbHVnSW5BdXRvU3RhcnRGcm9tT3JpZ2luKG1fcGFnZSwgcGFnZU9yaWdpbiwgcGx1 Z2luT3JpZ2luLCBtaW1lVHlwZSk7CisgICAgcmV0dXJuIFdlYlByb2Nlc3M6OnNoYXJlZCgpLnNo b3VsZFBsdWdJbkF1dG9TdGFydEZyb21PcmlnaW4obV93ZWJQYWdlLCBwYWdlT3JpZ2luLCBwbHVn aW5PcmlnaW4sIG1pbWVUeXBlKTsKIH0KIAogdm9pZCBXZWJQbHVnSW5DbGllbnQ6OmRpZFN0YXJ0 RnJvbU9yaWdpbihjb25zdCBTdHJpbmcmIHBhZ2VPcmlnaW4sIGNvbnN0IFN0cmluZyYgcGx1Z2lu T3JpZ2luLCBjb25zdCBTdHJpbmcmIG1pbWVUeXBlLCBXZWJDb3JlOjpTZXNzaW9uSUQgc2Vzc2lv bklEKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9y dC9XZWJQbHVnSW5DbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1 cHBvcnQvV2ViUGx1Z0luQ2xpZW50LmgKaW5kZXggMDJiOGFjZTdjMzkyM2ZlYjc1OTg1ZTViYzhh Y2ViYjhjN2JjOWIzNS4uNWU3NWEwMGZmYTM5YzU1Mjc1MmRjMGNhOGIzZjM4NmZiOWM1NTEzMyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJQ bHVnSW5DbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBw b3J0L1dlYlBsdWdJbkNsaWVudC5oCkBAIC0zNSwxNCArMzUsMTUgQEAgY2xhc3MgV2ViUGFnZTsK IAogY2xhc3MgV2ViUGx1Z0luQ2xpZW50IDogcHVibGljIFdlYkNvcmU6OlBsdWdJbkNsaWVudCB7 CiBwdWJsaWM6Ci0gICAgV2ViUGx1Z0luQ2xpZW50KFdlYlBhZ2UqKTsKKyAgICBleHBsaWNpdCBX ZWJQbHVnSW5DbGllbnQoV2ViUGFnZSYpOwogICAgIHZpcnR1YWwgfldlYlBsdWdJbkNsaWVudCgp OworCiBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBwYWdlRGVzdHJveWVkKCk7CiAgICAgdmly dHVhbCBib29sIHNob3VsZEF1dG9TdGFydEZyb21PcmlnaW4oY29uc3QgU3RyaW5nJiBwYWdlT3Jp Z2luLCBjb25zdCBTdHJpbmcmIHBsdWdpbk9yaWdpbiwgY29uc3QgU3RyaW5nJiBtaW1lVHlwZSk7 CiAgICAgdmlydHVhbCB2b2lkIGRpZFN0YXJ0RnJvbU9yaWdpbihjb25zdCBTdHJpbmcmIHBhZ2VP cmlnaW4sIGNvbnN0IFN0cmluZyYgcGx1Z2luT3JpZ2luLCBjb25zdCBTdHJpbmcmIG1pbWVUeXBl LCBXZWJDb3JlOjpTZXNzaW9uSUQpOwogCi0gICAgV2ViUGFnZSogbV9wYWdlOworICAgIFdlYlBh Z2UmIG1fd2ViUGFnZTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IDdlMWUzOTg0NjIyMjEw OTM4Mjk4NThhYWZlMGY2YzhhMTc5ZmFlNzEuLjc3MTFkNzM4MzBiNGUzNzllMzVjMjg4ZDAzNGU0 MWNhZWJlYTVjMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAKQEAgLTM1Niw3ICszNTYsNyBAQCBXZWJQYWdlOjpXZWJQYWdlKHVpbnQ2NF90IHBh Z2VJRCwgY29uc3QgV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycyYgcGFyYW1ldGVycykKICNpZiBV U0UoQVVUT0NPUlJFQ1RJT05fUEFORUwpCiAgICAgcGFnZUNsaWVudHMuYWx0ZXJuYXRpdmVUZXh0 Q2xpZW50ID0gbmV3IFdlYkFsdGVybmF0aXZlVGV4dENsaWVudCh0aGlzKTsKICNlbmRpZgotICAg IHBhZ2VDbGllbnRzLnBsdWdJbkNsaWVudCA9IG5ldyBXZWJQbHVnSW5DbGllbnQodGhpcyk7Cisg ICAgcGFnZUNsaWVudHMucGx1Z0luQ2xpZW50ID0gbmV3IFdlYlBsdWdJbkNsaWVudCgqdGhpcyk7 CiAgICAgcGFnZUNsaWVudHMubG9hZGVyQ2xpZW50Rm9yTWFpbkZyYW1lID0gbmV3IFdlYkZyYW1l TG9hZGVyQ2xpZW50OwogICAgIHBhZ2VDbGllbnRzLnByb2dyZXNzVHJhY2tlckNsaWVudCA9IG5l dyBXZWJQcm9ncmVzc1RyYWNrZXJDbGllbnQoKnRoaXMpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQcm9jZXNzLmNwcAppbmRleCA4NjY3ZGFiNzY2OGU0NGEzNmRmNTNkNGI2Yzg3MTZl MTVkZTBjMWM4Li43MWQ4NDc0NmNkYTFlZWE0M2ZkMTljNmUwMmRjYjZhZTM0NmEwYWJmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAKQEAgLTc2NSwyMSArNzY1LDIx IEBAIGJvb2wgV2ViUHJvY2Vzczo6aXNQbHVnSW5BdXRvU3RhcnRPcmlnaW5IYXNoKHVuc2lnbmVk IHBsdWdJbk9yaWdpbkhhc2gsIFNlc3Npb25JCiAgICAgcmV0dXJuIGN1cnJlbnRUaW1lKCkgPCBp dC0+dmFsdWU7CiB9CiAKLWJvb2wgV2ViUHJvY2Vzczo6c2hvdWxkUGx1Z0luQXV0b1N0YXJ0RnJv bU9yaWdpbihjb25zdCBXZWJQYWdlKiBwYWdlLCBjb25zdCBTdHJpbmcmIHBhZ2VPcmlnaW4sIGNv bnN0IFN0cmluZyYgcGx1Z2luT3JpZ2luLCBjb25zdCBTdHJpbmcmIG1pbWVUeXBlKQorYm9vbCBX ZWJQcm9jZXNzOjpzaG91bGRQbHVnSW5BdXRvU3RhcnRGcm9tT3JpZ2luKFdlYlBhZ2UmIHdlYlBh Z2UsIGNvbnN0IFN0cmluZyYgcGFnZU9yaWdpbiwgY29uc3QgU3RyaW5nJiBwbHVnaW5PcmlnaW4s IGNvbnN0IFN0cmluZyYgbWltZVR5cGUpCiB7CiAgICAgaWYgKCFwbHVnaW5PcmlnaW4uaXNFbXB0 eSgpICYmIG1fcGx1Z0luQXV0b1N0YXJ0T3JpZ2lucy5jb250YWlucyhwbHVnaW5PcmlnaW4pKQog ICAgICAgICByZXR1cm4gdHJ1ZTsKIAogI2lmZGVmIEVOQUJMRV9QUklNQVJZX1NOQVBTSE9UVEVE X1BMVUdJTl9IRVVSSVNUSUMKICAgICAvLyBUaGUgcGx1Z2luIHdhc24ndCBpbiB0aGUgZ2VuZXJh bCB3aGl0ZWxpc3QsIHNvIGNoZWNrIGlmIGl0IHNpbWlsYXIgdG8gdGhlIHByaW1hcnkgcGx1Z2lu IGZvciB0aGUgcGFnZSAoaWYgd2UndmUgZm91bmQgb25lKS4KLSAgICBpZiAocGFnZSAmJiBwYWdl LT5tYXRjaGVzUHJpbWFyeVBsdWdJbihwYWdlT3JpZ2luLCBwbHVnaW5PcmlnaW4sIG1pbWVUeXBl KSkKKyAgICBpZiAod2ViUGFnZS5tYXRjaGVzUHJpbWFyeVBsdWdJbihwYWdlT3JpZ2luLCBwbHVn aW5PcmlnaW4sIG1pbWVUeXBlKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAjZWxzZQogICAgIFVO VVNFRF9QQVJBTShwYWdlKTsKICNlbmRpZgogCiAgICAgLy8gTGFzdGx5IGNoZWNrIGFnYWluc3Qg dGhlIG1vcmUgZXhwbGljaXQgaGFzaCBsaXN0LgotICAgIHJldHVybiBpc1BsdWdJbkF1dG9TdGFy dE9yaWdpbkhhc2goaGFzaEZvclBsdWdJbk9yaWdpbihwYWdlT3JpZ2luLCBwbHVnaW5PcmlnaW4s IG1pbWVUeXBlKSwgcGFnZS0+c2Vzc2lvbklEKCkpOworICAgIHJldHVybiBpc1BsdWdJbkF1dG9T dGFydE9yaWdpbkhhc2goaGFzaEZvclBsdWdJbk9yaWdpbihwYWdlT3JpZ2luLCBwbHVnaW5Pcmln aW4sIG1pbWVUeXBlKSwgd2ViUGFnZS5zZXNzaW9uSUQoKSk7CiB9CiAKIHZvaWQgV2ViUHJvY2Vz czo6cGx1Z0luRGlkU3RhcnRGcm9tT3JpZ2luKGNvbnN0IFN0cmluZyYgcGFnZU9yaWdpbiwgY29u c3QgU3RyaW5nJiBwbHVnaW5PcmlnaW4sIGNvbnN0IFN0cmluZyYgbWltZVR5cGUsIFNlc3Npb25J RCBzZXNzaW9uSUQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBy b2Nlc3MuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5oCmluZGV4IGJj MDYwYWZkNjNmNDlmNTg0OWQ3MDczMGE4MTdjMTcxZDFmZmRiYTcuLmY5Mjc3YTA4OTRmZTY1YTY4 Yjg3ZGRiYjliMzI1ODVjZGMwNjZiMmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUHJvY2Vzcy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJv Y2Vzcy5oCkBAIC0xMjIsNyArMTIyLDcgQEAgcHVibGljOgogICAgIGJvb2wgbmVlZHNRdWlja0xv b2tSZXNvdXJjZUNhY2hpbmdRdWlya3MoKSBjb25zdCB7IHJldHVybiBtX25lZWRzUXVpY2tMb29r UmVzb3VyY2VDYWNoaW5nUXVpcmtzOyB9CiAjZW5kaWYKIAotICAgIGJvb2wgc2hvdWxkUGx1Z0lu QXV0b1N0YXJ0RnJvbU9yaWdpbihjb25zdCBXZWJQYWdlKiwgY29uc3QgU3RyaW5nJiBwYWdlT3Jp Z2luLCBjb25zdCBTdHJpbmcmIHBsdWdpbk9yaWdpbiwgY29uc3QgU3RyaW5nJiBtaW1lVHlwZSk7 CisgICAgYm9vbCBzaG91bGRQbHVnSW5BdXRvU3RhcnRGcm9tT3JpZ2luKFdlYlBhZ2UmLCBjb25z dCBTdHJpbmcmIHBhZ2VPcmlnaW4sIGNvbnN0IFN0cmluZyYgcGx1Z2luT3JpZ2luLCBjb25zdCBT dHJpbmcmIG1pbWVUeXBlKTsKICAgICB2b2lkIHBsdWdJbkRpZFN0YXJ0RnJvbU9yaWdpbihjb25z dCBTdHJpbmcmIHBhZ2VPcmlnaW4sIGNvbnN0IFN0cmluZyYgcGx1Z2luT3JpZ2luLCBjb25zdCBT dHJpbmcmIG1pbWVUeXBlLCBXZWJDb3JlOjpTZXNzaW9uSUQpOwogICAgIHZvaWQgcGx1Z0luRGlk UmVjZWl2ZVVzZXJJbnRlcmFjdGlvbihjb25zdCBTdHJpbmcmIHBhZ2VPcmlnaW4sIGNvbnN0IFN0 cmluZyYgcGx1Z2luT3JpZ2luLCBjb25zdCBTdHJpbmcmIG1pbWVUeXBlLCBXZWJDb3JlOjpTZXNz aW9uSUQpOwogCg==