138934 2014-11-20 14:09:54 -0800 Add some comments to describe the DFG UseKind representations. 2014-11-20 15:40:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren mmirman msaboff oldest_to_newest 1050239 0 mark.lam 2014-11-20 14:09:54 -0800 Also regrouped the UseKind enums by representation. 1050244 1 241980 mark.lam 2014-11-20 14:12:55 -0800 Created attachment 241980 the patch. 1050273 2 241980 ggaren 2014-11-20 15:13:43 -0800 Comment on attachment 241980 the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=241980&action=review > Source/JavaScriptCore/dfg/DFGUseKind.h:38 > UntypedUse, Which case is UntypedUse? (Seems like it should be JSValue, right?) > Source/JavaScriptCore/dfg/DFGUseKind.h:43 > + // in a FP register. "an" 1050274 3 241989 mark.lam 2014-11-20 15:16:11 -0800 Created attachment 241989 patch 2: addressed Geoff's feedback. 1050276 4 241989 fpizlo 2014-11-20 15:17:53 -0800 Comment on attachment 241989 patch 2: addressed Geoff's feedback. View in context: https://bugs.webkit.org/attachment.cgi?id=241989&action=review > Source/JavaScriptCore/dfg/DFGUseKind.h:54 > UntypedUse, This could be dangerous; I believe that UntypedUse is expected to be zero. 1050278 5 241989 fpizlo 2014-11-20 15:18:17 -0800 Comment on attachment 241989 patch 2: addressed Geoff's feedback. Please arrange to have UntypedUse be the first thing, as before. 1050281 6 241992 mark.lam 2014-11-20 15:23:34 -0800 Created attachment 241992 patch 3: UntypedUse is at enum 0 again, with extra comments. 1050288 7 241995 mark.lam 2014-11-20 15:31:45 -0800 Created attachment 241995 patch 4: don't like the comment about UntypedUse in last patch. Updated. 1050289 8 241995 fpizlo 2014-11-20 15:33:57 -0800 Comment on attachment 241995 patch 4: don't like the comment about UntypedUse in last patch. Updated. You could also have moved all of the other JS representations up with UntypedUse. That would make the most logical sense to me. 1050290 9 241996 mark.lam 2014-11-20 15:36:49 -0800 Created attachment 241996 patch 5: moved al the JSValue representation UseKinds up nelow UntypedUse as Filip suggested. 1050291 10 mark.lam 2014-11-20 15:40:25 -0800 Thanks for the review. Landed in r176425: <http://trac.webkit.org/r176425>. 241980 2014-11-20 14:12:55 -0800 2014-11-20 15:16:11 -0800 the patch. bug-138934.patch text/plain 1898 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc2NDA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTExLTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgc29tZSBjb21tZW50cyB0byBkZXNjcmliZSB0aGUgREZHIFVzZUtpbmQgcmVwcmVzZW50YXRp b25zLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTM4OTM0PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR1VzZUtpbmQuaDoK KyAgICAgICAgLSBBbHNvIHJlZ3JvdXBlZCB0aGUgVXNlS2luZCBlbnVtcyBieSByZXByZXNlbnRh dGlvbiB0byBiZSBtb3JlIHJlYWRhYmxlLgorCiAyMDE0LTExLTIwICBZdXN1a2UgU3V6dWtpICA8 dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFJlbmFtZSBTdHJpbmcucHJvdG90eXBl LmNvbnRhaW5zIHRvIFN0cmluZy5wcm90b3R5cGUuaW5jbHVkZXMKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHVXNlS2luZC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHVXNlS2luZC5oCShyZXZpc2lvbiAxNzY0MDgpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1VzZUtpbmQuaAkod29ya2luZyBjb3B5KQpAQCAtMzYsMTQgKzM2 LDI3IEBAIG5hbWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgREZHIHsKIAogZW51bSBVc2VLaW5kIHsK ICAgICBVbnR5cGVkVXNlLAorCisgICAgLy8gVGhlIERGRyBoYXMgMyByZXByZXNlbnRhdGlvbnMg b2YgdmFsdWVzIHVzZWQ6CisKKyAgICAvLyAxLiBUaGUgRG91YmxlIHJlcHJlc2VudGF0aW9uIGZv ciBhbiB1bmJveGVkIGRvdWJsZSB2YWx1ZSB0aGF0IG11c3QgYmUgc3RvcmVkCisgICAgLy8gICAg aW4gYSBGUCByZWdpc3Rlci4KKyAgICBEb3VibGVSZXBVc2UsCisgICAgRG91YmxlUmVwUmVhbFVz ZSwKKyAgICBEb3VibGVSZXBNYWNoaW5lSW50VXNlLAorCisgICAgLy8gMi4gVGhlIEludDUyIHJl cHJlc2VudGF0aW9uIGZvciBhbiB1bmJveGVkIGludGVnZXIgdmFsdWUgdGhhdCBtdXN0IGJlIHN0 b3JlZAorICAgIC8vICAgIGluIGEgR1AgcmVnaXN0ZXIuCisgICAgSW50NTJSZXBVc2UsCisKKyAg ICAvLyAzLiBUaGUgSlNWYWx1ZSByZXByZXNlbnRhdGlvbiBmb3IgYSBKU1ZhbHVlIHRoYXQgbXVz dCBiZSBzdG9yZWQgaW4gYSBHUAorICAgIC8vICAgIHJlZ2lzdGVyIChvciBhIEdQIHJlZ2lzdGVy IHBhaXIpLCBhbmQgZm9sbG93cyBydWxlcyBmb3IgYm94aW5nIGFuZCB1bmJveGluZworICAgIC8v ICAgIHRoYXQgYWxsb3cgdGhlIEpTVmFsdWUgdG8gYmUgc3RvcmVkIGFzIGVpdGhlciBmdWxseSBi b3hlZCBKU1ZhbHVlcywgb3IKKyAgICAvLyAgICB1bmJveGVkIEludDMyLCBCb29sZWFucywgQ2Vs bHMsIGV0Yy4gaW4gMzItYml0IGFzIGFwcHJvcHJpYXRlLgogICAgIEludDMyVXNlLAogICAgIEtu b3duSW50MzJVc2UsCi0gICAgSW50NTJSZXBVc2UsCiAgICAgTWFjaGluZUludFVzZSwKICAgICBO dW1iZXJVc2UsCi0gICAgRG91YmxlUmVwVXNlLAotICAgIERvdWJsZVJlcFJlYWxVc2UsCi0gICAg RG91YmxlUmVwTWFjaGluZUludFVzZSwKICAgICBCb29sZWFuVXNlLAogICAgIENlbGxVc2UsCiAg ICAgS25vd25DZWxsVXNlLAo= 241989 2014-11-20 15:16:11 -0800 2014-11-20 15:23:34 -0800 patch 2: addressed Geoff's feedback. bug-138934.patch text/plain 1898 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc2NDA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTExLTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgc29tZSBjb21tZW50cyB0byBkZXNjcmliZSB0aGUgREZHIFVzZUtpbmQgcmVwcmVzZW50YXRp b25zLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTM4OTM0PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR1VzZUtpbmQuaDoK KyAgICAgICAgLSBBbHNvIHJlZ3JvdXBlZCB0aGUgVXNlS2luZCBlbnVtcyBieSByZXByZXNlbnRh dGlvbiB0byBiZSBtb3JlIHJlYWRhYmxlLgorCiAyMDE0LTExLTIwICBZdXN1a2UgU3V6dWtpICA8 dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFJlbmFtZSBTdHJpbmcucHJvdG90eXBl LmNvbnRhaW5zIHRvIFN0cmluZy5wcm90b3R5cGUuaW5jbHVkZXMKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHVXNlS2luZC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHVXNlS2luZC5oCShyZXZpc2lvbiAxNzY0MDgpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1VzZUtpbmQuaAkod29ya2luZyBjb3B5KQpAQCAtMzUsMTUgKzM1 LDI3IEBACiBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIERGRyB7CiAKIGVudW0gVXNlS2luZCB7 CisgICAgLy8gVGhlIERGRyBoYXMgMyByZXByZXNlbnRhdGlvbnMgb2YgdmFsdWVzIHVzZWQ6CisK KyAgICAvLyAxLiBUaGUgRG91YmxlIHJlcHJlc2VudGF0aW9uIGZvciBhbiB1bmJveGVkIGRvdWJs ZSB2YWx1ZSB0aGF0IG11c3QgYmUgc3RvcmVkCisgICAgLy8gICAgaW4gYW4gRlAgcmVnaXN0ZXIu CisgICAgRG91YmxlUmVwVXNlLAorICAgIERvdWJsZVJlcFJlYWxVc2UsCisgICAgRG91YmxlUmVw TWFjaGluZUludFVzZSwKKworICAgIC8vIDIuIFRoZSBJbnQ1MiByZXByZXNlbnRhdGlvbiBmb3Ig YW4gdW5ib3hlZCBpbnRlZ2VyIHZhbHVlIHRoYXQgbXVzdCBiZSBzdG9yZWQKKyAgICAvLyAgICBp biBhIEdQIHJlZ2lzdGVyLgorICAgIEludDUyUmVwVXNlLAorCisgICAgLy8gMy4gVGhlIEpTVmFs dWUgcmVwcmVzZW50YXRpb24gZm9yIGEgSlNWYWx1ZSB0aGF0IG11c3QgYmUgc3RvcmVkIGluIGEg R1AKKyAgICAvLyAgICByZWdpc3RlciAob3IgYSBHUCByZWdpc3RlciBwYWlyKSwgYW5kIGZvbGxv d3MgcnVsZXMgZm9yIGJveGluZyBhbmQgdW5ib3hpbmcKKyAgICAvLyAgICB0aGF0IGFsbG93IHRo ZSBKU1ZhbHVlIHRvIGJlIHN0b3JlZCBhcyBlaXRoZXIgZnVsbHkgYm94ZWQgSlNWYWx1ZXMsIG9y CisgICAgLy8gICAgdW5ib3hlZCBJbnQzMiwgQm9vbGVhbnMsIENlbGxzLCBldGMuIGluIDMyLWJp dCBhcyBhcHByb3ByaWF0ZS4KICAgICBVbnR5cGVkVXNlLAogICAgIEludDMyVXNlLAogICAgIEtu b3duSW50MzJVc2UsCi0gICAgSW50NTJSZXBVc2UsCiAgICAgTWFjaGluZUludFVzZSwKICAgICBO dW1iZXJVc2UsCi0gICAgRG91YmxlUmVwVXNlLAotICAgIERvdWJsZVJlcFJlYWxVc2UsCi0gICAg RG91YmxlUmVwTWFjaGluZUludFVzZSwKICAgICBCb29sZWFuVXNlLAogICAgIENlbGxVc2UsCiAg ICAgS25vd25DZWxsVXNlLAo= 241992 2014-11-20 15:23:34 -0800 2014-11-20 15:31:45 -0800 patch 3: UntypedUse is at enum 0 again, with extra comments. bug-138934.patch text/plain 2193 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc2NDA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTExLTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgc29tZSBjb21tZW50cyB0byBkZXNjcmliZSB0aGUgREZHIFVzZUtpbmQgcmVwcmVzZW50YXRp b25zLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTM4OTM0PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR1VzZUtpbmQuaDoK KyAgICAgICAgLSBBbHNvIHJlZ3JvdXBlZCB0aGUgVXNlS2luZCBlbnVtcyBieSByZXByZXNlbnRh dGlvbiB0byBiZSBtb3JlIHJlYWRhYmxlLgorCiAyMDE0LTExLTIwICBZdXN1a2UgU3V6dWtpICA8 dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFJlbmFtZSBTdHJpbmcucHJvdG90eXBl LmNvbnRhaW5zIHRvIFN0cmluZy5wcm90b3R5cGUuaW5jbHVkZXMKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHVXNlS2luZC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHVXNlS2luZC5oCShyZXZpc2lvbiAxNzY0MDgpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1VzZUtpbmQuaAkod29ya2luZyBjb3B5KQpAQCAtMzUsMTUgKzM1 LDI4IEBACiBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIERGRyB7CiAKIGVudW0gVXNlS2luZCB7 Ci0gICAgVW50eXBlZFVzZSwKKyAgICAvLyBUaGUgREZHIGhhcyAzIHJlcHJlc2VudGF0aW9ucyBv ZiB2YWx1ZXMgdXNlZDoKKworICAgIFVudHlwZWRVc2UsIC8vIFVudHlwZWRVc2UgaXMgYSBKU1Zh bHVlIHJlcHJlc2VudGF0aW9uIGJ1dCBtdXN0IGNvbWUgZmlyc3QgKHZhbHVlIDApLgorCisgICAg Ly8gMS4gVGhlIERvdWJsZSByZXByZXNlbnRhdGlvbiBmb3IgYW4gdW5ib3hlZCBkb3VibGUgdmFs dWUgdGhhdCBtdXN0IGJlIHN0b3JlZAorICAgIC8vICAgIGluIGFuIEZQIHJlZ2lzdGVyLgorICAg IERvdWJsZVJlcFVzZSwKKyAgICBEb3VibGVSZXBSZWFsVXNlLAorICAgIERvdWJsZVJlcE1hY2hp bmVJbnRVc2UsCisKKyAgICAvLyAyLiBUaGUgSW50NTIgcmVwcmVzZW50YXRpb24gZm9yIGFuIHVu Ym94ZWQgaW50ZWdlciB2YWx1ZSB0aGF0IG11c3QgYmUgc3RvcmVkCisgICAgLy8gICAgaW4gYSBH UCByZWdpc3Rlci4KKyAgICBJbnQ1MlJlcFVzZSwKKworICAgIC8vIDMuIFRoZSBKU1ZhbHVlIHJl cHJlc2VudGF0aW9uIGZvciBhIEpTVmFsdWUgdGhhdCBtdXN0IGJlIHN0b3JlZCBpbiBhIEdQCisg ICAgLy8gICAgcmVnaXN0ZXIgKG9yIGEgR1AgcmVnaXN0ZXIgcGFpciksIGFuZCBmb2xsb3dzIHJ1 bGVzIGZvciBib3hpbmcgYW5kIHVuYm94aW5nCisgICAgLy8gICAgdGhhdCBhbGxvdyB0aGUgSlNW YWx1ZSB0byBiZSBzdG9yZWQgYXMgZWl0aGVyIGZ1bGx5IGJveGVkIEpTVmFsdWVzLCBvcgorICAg IC8vICAgIHVuYm94ZWQgSW50MzIsIEJvb2xlYW5zLCBDZWxscywgZXRjLiBpbiAzMi1iaXQgYXMg YXBwcm9wcmlhdGUuCiAgICAgSW50MzJVc2UsCiAgICAgS25vd25JbnQzMlVzZSwKLSAgICBJbnQ1 MlJlcFVzZSwKICAgICBNYWNoaW5lSW50VXNlLAogICAgIE51bWJlclVzZSwKLSAgICBEb3VibGVS ZXBVc2UsCi0gICAgRG91YmxlUmVwUmVhbFVzZSwKLSAgICBEb3VibGVSZXBNYWNoaW5lSW50VXNl LAogICAgIEJvb2xlYW5Vc2UsCiAgICAgQ2VsbFVzZSwKICAgICBLbm93bkNlbGxVc2UsCkBAIC02 MCw2ICs3Myw3IEBAIGVudW0gVXNlS2luZCB7CiAgICAgTm90Q2VsbFVzZSwKICAgICBPdGhlclVz ZSwKICAgICBNaXNjVXNlLAorCiAgICAgTGFzdFVzZUtpbmQgLy8gTXVzdCBhbHdheXMgYmUgdGhl IGxhc3QgZW50cnkgaW4gdGhlIGVudW0sIGFzIGl0IGlzIHVzZWQgdG8gZGVub3RlIHRoZSBudW1i ZXIgb2YgZW51bSBlbGVtZW50cy4KIH07CiAK 241995 2014-11-20 15:31:45 -0800 2014-11-20 15:36:49 -0800 patch 4: don't like the comment about UntypedUse in last patch. Updated. bug-138934.patch text/plain 2194 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc2NDA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTExLTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgc29tZSBjb21tZW50cyB0byBkZXNjcmliZSB0aGUgREZHIFVzZUtpbmQgcmVwcmVzZW50YXRp b25zLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTM4OTM0PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR1VzZUtpbmQuaDoK KyAgICAgICAgLSBBbHNvIHJlZ3JvdXBlZCB0aGUgVXNlS2luZCBlbnVtcyBieSByZXByZXNlbnRh dGlvbiB0byBiZSBtb3JlIHJlYWRhYmxlLgorCiAyMDE0LTExLTIwICBZdXN1a2UgU3V6dWtpICA8 dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFJlbmFtZSBTdHJpbmcucHJvdG90eXBl LmNvbnRhaW5zIHRvIFN0cmluZy5wcm90b3R5cGUuaW5jbHVkZXMKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHVXNlS2luZC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHVXNlS2luZC5oCShyZXZpc2lvbiAxNzY0MDgpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1VzZUtpbmQuaAkod29ya2luZyBjb3B5KQpAQCAtMzUsMTUgKzM1 LDI4IEBACiBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIERGRyB7CiAKIGVudW0gVXNlS2luZCB7 Ci0gICAgVW50eXBlZFVzZSwKKyAgICAvLyBUaGUgREZHIGhhcyAzIHJlcHJlc2VudGF0aW9ucyBv ZiB2YWx1ZXMgdXNlZDoKKworICAgIFVudHlwZWRVc2UsIC8vIFVudHlwZWRVc2UgaXMgb2YgSlNW YWx1ZSByZXByZXNlbnRhdGlvbiBidXQgbXVzdCBjb21lIGZpcnN0ICh2YWx1ZSAwKS4KKworICAg IC8vIDEuIFRoZSBEb3VibGUgcmVwcmVzZW50YXRpb24gZm9yIGFuIHVuYm94ZWQgZG91YmxlIHZh bHVlIHRoYXQgbXVzdCBiZSBzdG9yZWQKKyAgICAvLyAgICBpbiBhbiBGUCByZWdpc3Rlci4KKyAg ICBEb3VibGVSZXBVc2UsCisgICAgRG91YmxlUmVwUmVhbFVzZSwKKyAgICBEb3VibGVSZXBNYWNo aW5lSW50VXNlLAorCisgICAgLy8gMi4gVGhlIEludDUyIHJlcHJlc2VudGF0aW9uIGZvciBhbiB1 bmJveGVkIGludGVnZXIgdmFsdWUgdGhhdCBtdXN0IGJlIHN0b3JlZAorICAgIC8vICAgIGluIGEg R1AgcmVnaXN0ZXIuCisgICAgSW50NTJSZXBVc2UsCisKKyAgICAvLyAzLiBUaGUgSlNWYWx1ZSBy ZXByZXNlbnRhdGlvbiBmb3IgYSBKU1ZhbHVlIHRoYXQgbXVzdCBiZSBzdG9yZWQgaW4gYSBHUAor ICAgIC8vICAgIHJlZ2lzdGVyIChvciBhIEdQIHJlZ2lzdGVyIHBhaXIpLCBhbmQgZm9sbG93cyBy dWxlcyBmb3IgYm94aW5nIGFuZCB1bmJveGluZworICAgIC8vICAgIHRoYXQgYWxsb3cgdGhlIEpT VmFsdWUgdG8gYmUgc3RvcmVkIGFzIGVpdGhlciBmdWxseSBib3hlZCBKU1ZhbHVlcywgb3IKKyAg ICAvLyAgICB1bmJveGVkIEludDMyLCBCb29sZWFucywgQ2VsbHMsIGV0Yy4gaW4gMzItYml0IGFz IGFwcHJvcHJpYXRlLgogICAgIEludDMyVXNlLAogICAgIEtub3duSW50MzJVc2UsCi0gICAgSW50 NTJSZXBVc2UsCiAgICAgTWFjaGluZUludFVzZSwKICAgICBOdW1iZXJVc2UsCi0gICAgRG91Ymxl UmVwVXNlLAotICAgIERvdWJsZVJlcFJlYWxVc2UsCi0gICAgRG91YmxlUmVwTWFjaGluZUludFVz ZSwKICAgICBCb29sZWFuVXNlLAogICAgIENlbGxVc2UsCiAgICAgS25vd25DZWxsVXNlLApAQCAt NjAsNiArNzMsNyBAQCBlbnVtIFVzZUtpbmQgewogICAgIE5vdENlbGxVc2UsCiAgICAgT3RoZXJV c2UsCiAgICAgTWlzY1VzZSwKKwogICAgIExhc3RVc2VLaW5kIC8vIE11c3QgYWx3YXlzIGJlIHRo ZSBsYXN0IGVudHJ5IGluIHRoZSBlbnVtLCBhcyBpdCBpcyB1c2VkIHRvIGRlbm90ZSB0aGUgbnVt YmVyIG9mIGVudW0gZWxlbWVudHMuCiB9OwogCg== 241996 2014-11-20 15:36:49 -0800 2014-11-20 15:37:18 -0800 patch 5: moved al the JSValue representation UseKinds up nelow UntypedUse as Filip suggested. bug-138934.patch text/plain 2160 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc2NDA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTExLTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgc29tZSBjb21tZW50cyB0byBkZXNjcmliZSB0aGUgREZHIFVzZUtpbmQgcmVwcmVzZW50YXRp b25zLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTM4OTM0PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR1VzZUtpbmQuaDoK KyAgICAgICAgLSBBbHNvIHJlZ3JvdXBlZCB0aGUgVXNlS2luZCBlbnVtcyBieSByZXByZXNlbnRh dGlvbiB0byBiZSBtb3JlIHJlYWRhYmxlLgorCiAyMDE0LTExLTIwICBZdXN1a2UgU3V6dWtpICA8 dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFJlbmFtZSBTdHJpbmcucHJvdG90eXBl LmNvbnRhaW5zIHRvIFN0cmluZy5wcm90b3R5cGUuaW5jbHVkZXMKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHVXNlS2luZC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHVXNlS2luZC5oCShyZXZpc2lvbiAxNzY0MDgpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1VzZUtpbmQuaAkod29ya2luZyBjb3B5KQpAQCAtMzUsMTUgKzM1 LDE3IEBACiBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIERGRyB7CiAKIGVudW0gVXNlS2luZCB7 Ci0gICAgVW50eXBlZFVzZSwKKyAgICAvLyBUaGUgREZHIGhhcyAzIHJlcHJlc2VudGF0aW9ucyBv ZiB2YWx1ZXMgdXNlZDoKKworICAgIC8vIDEuIFRoZSBKU1ZhbHVlIHJlcHJlc2VudGF0aW9uIGZv ciBhIEpTVmFsdWUgdGhhdCBtdXN0IGJlIHN0b3JlZCBpbiBhIEdQCisgICAgLy8gICAgcmVnaXN0 ZXIgKG9yIGEgR1AgcmVnaXN0ZXIgcGFpciksIGFuZCBmb2xsb3dzIHJ1bGVzIGZvciBib3hpbmcg YW5kIHVuYm94aW5nCisgICAgLy8gICAgdGhhdCBhbGxvdyB0aGUgSlNWYWx1ZSB0byBiZSBzdG9y ZWQgYXMgZWl0aGVyIGZ1bGx5IGJveGVkIEpTVmFsdWVzLCBvcgorICAgIC8vICAgIHVuYm94ZWQg SW50MzIsIEJvb2xlYW5zLCBDZWxscywgZXRjLiBpbiAzMi1iaXQgYXMgYXBwcm9wcmlhdGUuCisg ICAgVW50eXBlZFVzZSwgLy8gVW50eXBlZFVzZSBtdXN0IGNvbWUgZmlyc3QgKHZhbHVlIDApLgog ICAgIEludDMyVXNlLAogICAgIEtub3duSW50MzJVc2UsCi0gICAgSW50NTJSZXBVc2UsCiAgICAg TWFjaGluZUludFVzZSwKICAgICBOdW1iZXJVc2UsCi0gICAgRG91YmxlUmVwVXNlLAotICAgIERv dWJsZVJlcFJlYWxVc2UsCi0gICAgRG91YmxlUmVwTWFjaGluZUludFVzZSwKICAgICBCb29sZWFu VXNlLAogICAgIENlbGxVc2UsCiAgICAgS25vd25DZWxsVXNlLApAQCAtNjAsNiArNjIsMTcgQEAg ZW51bSBVc2VLaW5kIHsKICAgICBOb3RDZWxsVXNlLAogICAgIE90aGVyVXNlLAogICAgIE1pc2NV c2UsCisKKyAgICAvLyAyLiBUaGUgRG91YmxlIHJlcHJlc2VudGF0aW9uIGZvciBhbiB1bmJveGVk IGRvdWJsZSB2YWx1ZSB0aGF0IG11c3QgYmUgc3RvcmVkCisgICAgLy8gICAgaW4gYW4gRlAgcmVn aXN0ZXIuCisgICAgRG91YmxlUmVwVXNlLAorICAgIERvdWJsZVJlcFJlYWxVc2UsCisgICAgRG91 YmxlUmVwTWFjaGluZUludFVzZSwKKworICAgIC8vIDMuIFRoZSBJbnQ1MiByZXByZXNlbnRhdGlv biBmb3IgYW4gdW5ib3hlZCBpbnRlZ2VyIHZhbHVlIHRoYXQgbXVzdCBiZSBzdG9yZWQKKyAgICAv LyAgICBpbiBhIEdQIHJlZ2lzdGVyLgorICAgIEludDUyUmVwVXNlLAorCiAgICAgTGFzdFVzZUtp bmQgLy8gTXVzdCBhbHdheXMgYmUgdGhlIGxhc3QgZW50cnkgaW4gdGhlIGVudW0sIGFzIGl0IGlz IHVzZWQgdG8gZGVub3RlIHRoZSBudW1iZXIgb2YgZW51bSBlbGVtZW50cy4KIH07CiAK