138922 2014-11-20 02:15:03 -0800 Cancel DataDetectors menu earlier if we know it can't be presented 2014-11-20 14:19:40 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca bdakin oldest_to_newest 1050097 0 thorton 2014-11-20 02:15:03 -0800 Cancel DataDetectors menu earlier if we know it can't be presented 1050098 1 241935 thorton 2014-11-20 02:15:31 -0800 Created attachment 241935 Patch 1050099 2 thorton 2014-11-20 02:17:04 -0800 <rdar://problem/18950441> 1050100 3 thorton 2014-11-20 02:19:55 -0800 Oh WebKit1. 1050102 4 241936 thorton 2014-11-20 02:24:00 -0800 Created attachment 241936 Patch 1050248 5 thorton 2014-11-20 14:19:40 -0800 http://trac.webkit.org/changeset/176415 241935 2014-11-20 02:15:31 -0800 2014-11-20 02:23:57 -0800 Patch bug-138922-20141120021546.patch text/plain 2421 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2Mzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTE1YTFmMzRlMWRiZGUy YWQxOTUyNThjZjUxNzE3MWM4Mjk2MTZmNC4uYjY0YWMxNGI3MWVhY2ViMzNhOTAxNTAwMjM0MWI4 ZjQ0NWMwN2RkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE0LTExLTIwICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCisgICAgICAgIENhbmNlbCBEYXRh RGV0ZWN0b3JzIG1lbnUgZWFybGllciBpZiB3ZSBrbm93IGl0IGNhbid0IGJlIHByZXNlbnRlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4OTIyCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xODk1MDQ0MT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tBY3Rpb25NZW51Q29u dHJvbGxlci5tbToKKyAgICAgICAgKC1bV0tBY3Rpb25NZW51Q29udHJvbGxlciB3aWxsT3Blbk1l bnU6d2l0aEV2ZW50Ol0pOgorICAgICAgICBJZiB3ZSBlbmQgdXAgd2l0aCBhIG1lbnUgd2l0aCBu byBpdGVtcywgZG9uJ3QgY2hhbmdlIHNlbGVjdGlvbiBvciBhbnl0aGluZy4KKworICAgICAgICAo LVtXS0FjdGlvbk1lbnVDb250cm9sbGVyIG1lbnVOZWVkc1VwZGF0ZTpdKToKKyAgICAgICAgTW92 ZSBvdXIgY2FsbCB0byBzaG91bGRVc2VBY3Rpb25zV2l0aENvbnRleHQgZWFybGllciwgdG8gbWVu dU5lZWRzVXBkYXRlLAorICAgICAgICBhbmQgdXNlIGEgYmlnZ2VyIGhhbW1lciAocmVtb3ZlQWxs SXRlbXMpLgorCisyMDE0LTExLTIwICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUu Y29tPgorCiAgICAgICAgIFRleHRJbmRpY2F0b3Igc2hvdWxkIGhhdmUgZ2V0dGVycyBmb3IgVGV4 dEluZGljYXRvcjo6RGF0YSBwcm9wZXJ0aWVzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg5MjAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL21hYy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLm1tIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL21hYy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLm1tCmluZGV4IDhiNjIyZjVjZmVh M2IyODI1NGYyNmY1ZDA5NGE2Nzc2ZWNmNjAwZjguLjg5M2MwODIzNWU3NzU5MDQyN2Y1YjE0MWRm ZmQ3ZjVmYTIzNWJiNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMv V0tBY3Rpb25NZW51Q29udHJvbGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv bWFjL1dLQWN0aW9uTWVudUNvbnRyb2xsZXIubW0KQEAgLTE5MiwxMSArMTkyLDEwIEBAIHVzaW5n IG5hbWVzcGFjZSBXZWJLaXQ7CiAgICAgaWYgKG1lbnUgIT0gX3drVmlldy5hY3Rpb25NZW51KQog ICAgICAgICByZXR1cm47CiAKKyAgICBpZiAoIW1lbnUubnVtYmVyT2ZJdGVtcykKKyAgICAgICAg cmV0dXJuOworCiAgICAgaWYgKF90eXBlID09IGtXS0FjdGlvbk1lbnVEYXRhRGV0ZWN0ZWRJdGVt KSB7Ci0gICAgICAgIGlmIChfY3VycmVudEFjdGlvbkNvbnRleHQgJiYgIVtnZXREREFjdGlvbnNN YW5hZ2VyQ2xhc3MoKSBzaG91bGRVc2VBY3Rpb25zV2l0aENvbnRleHQ6X2N1cnJlbnRBY3Rpb25D b250ZXh0LmdldCgpXSkgewotICAgICAgICAgICAgW21lbnUgY2FuY2VsVHJhY2tpbmddOwotICAg ICAgICAgICAgcmV0dXJuOwotICAgICAgICB9CiAgICAgICAgIGlmIChtZW51Lm51bWJlck9mSXRl bXMgPT0gMSkKICAgICAgICAgICAgIF9wYWdlLT5jbGVhclNlbGVjdGlvbigpOwogICAgICAgICBl bHNlCkBAIC03MjYsNiArNzI1LDExIEBAIHN0YXRpYyBOU1N0cmluZyAqcGF0aFRvUGhvdG9PbkRp c2soTlNTdHJpbmcgKnN1Z2dlc3RlZEZpbGVuYW1lKQogCiAgICAgaWYgKF9zdGF0ZSAhPSBBY3Rp b25NZW51U3RhdGU6OlJlYWR5KQogICAgICAgICBbc2VsZiBfdXBkYXRlQWN0aW9uTWVudUl0ZW1z XTsKKworICAgIGlmIChfdHlwZSA9PSBrV0tBY3Rpb25NZW51RGF0YURldGVjdGVkSXRlbSAmJiBf Y3VycmVudEFjdGlvbkNvbnRleHQgJiYgIVtnZXREREFjdGlvbnNNYW5hZ2VyQ2xhc3MoKSBzaG91 bGRVc2VBY3Rpb25zV2l0aENvbnRleHQ6X2N1cnJlbnRBY3Rpb25Db250ZXh0LmdldCgpXSkgewor ICAgICAgICBbbWVudSBjYW5jZWxUcmFja2luZ107CisgICAgICAgIFttZW51IHJlbW92ZUFsbEl0 ZW1zXTsKKyAgICB9CiB9CiAKIC0gKHZvaWQpbWVudTooTlNNZW51ICopbWVudSB3aWxsSGlnaGxp Z2h0SXRlbTooTlNNZW51SXRlbSAqKWl0ZW0K 241936 2014-11-20 02:24:00 -0800 2014-11-20 11:36:41 -0800 Patch bug-138922-20141120022415.patch text/plain 4740 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2Mzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggMGVmNzc5Yzkw OTllNTFlZTQ2NTljNzI3NGQ1ZmE1YTg0Mjg4M2FiZC4uYTcwZGFjMDM0ODg2ZmYwODg5ZWVjYzlm MzMxMjgxYzlmNmFiZmQ4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0 LTExLTIwICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAg IENhbmNlbCBEYXRhRGV0ZWN0b3JzIG1lbnUgZWFybGllciBpZiB3ZSBrbm93IGl0IGNhbid0IGJl IHByZXNlbnRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM4OTIyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xODk1MDQ0MT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlZpZXcvV2ViQWN0aW9u TWVudUNvbnRyb2xsZXIubW06CisgICAgICAgICgtW1dlYkFjdGlvbk1lbnVDb250cm9sbGVyIHBy ZXBhcmVGb3JNZW51OndpdGhFdmVudDpdKToKKyAgICAgICAgTW92ZSBvdXIgY2FsbCB0byBzaG91 bGRVc2VBY3Rpb25zV2l0aENvbnRleHQgZWFybGllciwgdG8gbWVudU5lZWRzVXBkYXRlLAorICAg ICAgICBhbmQgdXNlIGEgYmlnZ2VyIGhhbW1lciAocmVtb3ZlQWxsSXRlbXMpLgorCisgICAgICAg ICgtW1dlYkFjdGlvbk1lbnVDb250cm9sbGVyIHdpbGxPcGVuTWVudTp3aXRoRXZlbnQ6XSk6Cisg ICAgICAgIElmIHdlIGVuZCB1cCB3aXRoIGEgbWVudSB3aXRoIG5vIGl0ZW1zLCBkb24ndCBjaGFu Z2Ugc2VsZWN0aW9uIG9yIGFueXRoaW5nLgorCiAyMDE0LTExLTE5ICBCZXRoIERha2luICA8YmRh a2luQGFwcGxlLmNvbT4KIAogICAgICAgICBJbnZva2luZyBhbiBhY3Rpb24gbWVudSBvbiBhIHNl bGVjdGlvbiBzaG91bGQgcmVzdWx0IGluIHRoZSB0ZXh0IG1lbnUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBhMTVh MWYzNGUxZGJkZTJhZDE5NTI1OGNmNTE3MTcxYzgyOTYxNmY0Li5iNjRhYzE0YjcxZWFjZWIzM2E5 MDE1MDAyMzQxYjhmNDQ1YzA3ZGQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTQt MTEtMjAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKKyAgICAgICAg Q2FuY2VsIERhdGFEZXRlY3RvcnMgbWVudSBlYXJsaWVyIGlmIHdlIGtub3cgaXQgY2FuJ3QgYmUg cHJlc2VudGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzg5MjIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE4OTUwNDQxPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9XS0Fj dGlvbk1lbnVDb250cm9sbGVyLm1tOgorICAgICAgICAoLVtXS0FjdGlvbk1lbnVDb250cm9sbGVy IHdpbGxPcGVuTWVudTp3aXRoRXZlbnQ6XSk6CisgICAgICAgIElmIHdlIGVuZCB1cCB3aXRoIGEg bWVudSB3aXRoIG5vIGl0ZW1zLCBkb24ndCBjaGFuZ2Ugc2VsZWN0aW9uIG9yIGFueXRoaW5nLgor CisgICAgICAgICgtW1dLQWN0aW9uTWVudUNvbnRyb2xsZXIgbWVudU5lZWRzVXBkYXRlOl0pOgor ICAgICAgICBNb3ZlIG91ciBjYWxsIHRvIHNob3VsZFVzZUFjdGlvbnNXaXRoQ29udGV4dCBlYXJs aWVyLCB0byBtZW51TmVlZHNVcGRhdGUsCisgICAgICAgIGFuZCB1c2UgYSBiaWdnZXIgaGFtbWVy IChyZW1vdmVBbGxJdGVtcykuCisKKzIwMTQtMTEtMjAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hv cnRvbkBhcHBsZS5jb20+CisKICAgICAgICAgVGV4dEluZGljYXRvciBzaG91bGQgaGF2ZSBnZXR0 ZXJzIGZvciBUZXh0SW5kaWNhdG9yOjpEYXRhIHByb3BlcnRpZXMKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODkyMAogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkFjdGlvbk1lbnVDb250cm9sbGVyLm1tIGIvU291cmNl L1dlYktpdC9tYWMvV2ViVmlldy9XZWJBY3Rpb25NZW51Q29udHJvbGxlci5tbQppbmRleCA2ZDk2 Nzg4MTc2Mjk0ZDAxOTRlZWIzZmU4NDkzMmJlOGRkZTViMmFkLi4zYWYyM2I1MWI1MmI1YmJhMGZl NzRjMDNmNmVhNzU2Njg3ZjNiMjQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJW aWV3L1dlYkFjdGlvbk1lbnVDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL1dl YlZpZXcvV2ViQWN0aW9uTWVudUNvbnRyb2xsZXIubW0KQEAgLTE1MCw2ICsxNTAsMTEgQEAgc3Ry dWN0IERpY3Rpb25hcnlQb3B1cEluZm8gewogCiAgICAgZm9yIChOU01lbnVJdGVtICppdGVtIGlu IG1lbnVJdGVtcykKICAgICAgICAgW2FjdGlvbk1lbnUgYWRkSXRlbTppdGVtXTsKKworICAgIGlm IChfdHlwZSA9PSBXZWJBY3Rpb25NZW51RGF0YURldGVjdGVkSXRlbSAmJiBfY3VycmVudEFjdGlv bkNvbnRleHQgJiYgIVtnZXREREFjdGlvbnNNYW5hZ2VyQ2xhc3MoKSBzaG91bGRVc2VBY3Rpb25z V2l0aENvbnRleHQ6X2N1cnJlbnRBY3Rpb25Db250ZXh0LmdldCgpXSkgeworICAgICAgICBbbWVu dSBjYW5jZWxUcmFja2luZ107CisgICAgICAgIFttZW51IHJlbW92ZUFsbEl0ZW1zXTsKKyAgICB9 CiB9CiAKIC0gKEJPT0wpaXNNZW51Rm9yVGV4dENvbnRlbnQKQEAgLTE4MiwxMiArMTg3LDEwIEBA IHN0cnVjdCBEaWN0aW9uYXJ5UG9wdXBJbmZvIHsKICAgICBpZiAobWVudSAhPSBfd2ViVmlldy5h Y3Rpb25NZW51KQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAoX3R5cGUgPT0gV2ViQWN0aW9u TWVudURhdGFEZXRlY3RlZEl0ZW0pIHsKLSAgICAgICAgaWYgKCFbZ2V0RERBY3Rpb25zTWFuYWdl ckNsYXNzKCkgc2hvdWxkVXNlQWN0aW9uc1dpdGhDb250ZXh0Ol9jdXJyZW50QWN0aW9uQ29udGV4 dC5nZXQoKV0pIHsKLSAgICAgICAgICAgIFttZW51IGNhbmNlbFRyYWNraW5nXTsKLSAgICAgICAg ICAgIHJldHVybjsKLSAgICAgICAgfQorICAgIGlmICghbWVudS5udW1iZXJPZkl0ZW1zKQorICAg ICAgICByZXR1cm47CiAKKyAgICBpZiAoX3R5cGUgPT0gV2ViQWN0aW9uTWVudURhdGFEZXRlY3Rl ZEl0ZW0pIHsKICAgICAgICAgaWYgKG1lbnUubnVtYmVyT2ZJdGVtcyA9PSAxKQogICAgICAgICAg ICAgW1tfd2ViVmlldyBfc2VsZWN0ZWRPck1haW5GcmFtZV0gX2NsZWFyU2VsZWN0aW9uXTsKICAg ICAgICAgZWxzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0Fj dGlvbk1lbnVDb250cm9sbGVyLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0Fj dGlvbk1lbnVDb250cm9sbGVyLm1tCmluZGV4IDhiNjIyZjVjZmVhM2IyODI1NGYyNmY1ZDA5NGE2 Nzc2ZWNmNjAwZjguLjg5M2MwODIzNWU3NzU5MDQyN2Y1YjE0MWRmZmQ3ZjVmYTIzNWJiNjQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tBY3Rpb25NZW51Q29udHJv bGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLQWN0aW9uTWVudUNv bnRyb2xsZXIubW0KQEAgLTE5MiwxMSArMTkyLDEwIEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7 CiAgICAgaWYgKG1lbnUgIT0gX3drVmlldy5hY3Rpb25NZW51KQogICAgICAgICByZXR1cm47CiAK KyAgICBpZiAoIW1lbnUubnVtYmVyT2ZJdGVtcykKKyAgICAgICAgcmV0dXJuOworCiAgICAgaWYg KF90eXBlID09IGtXS0FjdGlvbk1lbnVEYXRhRGV0ZWN0ZWRJdGVtKSB7Ci0gICAgICAgIGlmIChf Y3VycmVudEFjdGlvbkNvbnRleHQgJiYgIVtnZXREREFjdGlvbnNNYW5hZ2VyQ2xhc3MoKSBzaG91 bGRVc2VBY3Rpb25zV2l0aENvbnRleHQ6X2N1cnJlbnRBY3Rpb25Db250ZXh0LmdldCgpXSkgewot ICAgICAgICAgICAgW21lbnUgY2FuY2VsVHJhY2tpbmddOwotICAgICAgICAgICAgcmV0dXJuOwot ICAgICAgICB9CiAgICAgICAgIGlmIChtZW51Lm51bWJlck9mSXRlbXMgPT0gMSkKICAgICAgICAg ICAgIF9wYWdlLT5jbGVhclNlbGVjdGlvbigpOwogICAgICAgICBlbHNlCkBAIC03MjYsNiArNzI1 LDExIEBAIHN0YXRpYyBOU1N0cmluZyAqcGF0aFRvUGhvdG9PbkRpc2soTlNTdHJpbmcgKnN1Z2dl c3RlZEZpbGVuYW1lKQogCiAgICAgaWYgKF9zdGF0ZSAhPSBBY3Rpb25NZW51U3RhdGU6OlJlYWR5 KQogICAgICAgICBbc2VsZiBfdXBkYXRlQWN0aW9uTWVudUl0ZW1zXTsKKworICAgIGlmIChfdHlw ZSA9PSBrV0tBY3Rpb25NZW51RGF0YURldGVjdGVkSXRlbSAmJiBfY3VycmVudEFjdGlvbkNvbnRl eHQgJiYgIVtnZXREREFjdGlvbnNNYW5hZ2VyQ2xhc3MoKSBzaG91bGRVc2VBY3Rpb25zV2l0aENv bnRleHQ6X2N1cnJlbnRBY3Rpb25Db250ZXh0LmdldCgpXSkgeworICAgICAgICBbbWVudSBjYW5j ZWxUcmFja2luZ107CisgICAgICAgIFttZW51IHJlbW92ZUFsbEl0ZW1zXTsKKyAgICB9CiB9CiAK IC0gKHZvaWQpbWVudTooTlNNZW51ICopbWVudSB3aWxsSGlnaGxpZ2h0SXRlbTooTlNNZW51SXRl bSAqKWl0ZW0K