138914 2014-11-20 00:14:47 -0800 Crash when destroying a Document that has a throttled timer still running 2014-11-20 12:28:42 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 138292 1 cdumez cdumez barraclough benjamin commit-queue ggaren kling koivisto oldest_to_newest 1050063 0 cdumez 2014-11-20 00:14:47 -0800 Crash when destroying a Document that has a throttled timer still running: 0 com.apple.WebCore 0x00007fff9403d8d4 WebCore::Document::view() const + 4 1 com.apple.WebCore 0x00007fff94189e33 WebCore::DOMTimer::~DOMTimer() + 67 2 com.apple.WebCore 0x00007fff94189dde WebCore::DOMTimer::~DOMTimer() + 14 3 com.apple.WebCore 0x00007fff940c7396 WebCore::ScriptExecutionContext::~ScriptExecutionContext() + 534 4 com.apple.WebCore 0x00007fff940c59c0 WebCore::Document::~Document() + 5104 5 com.apple.WebCore 0x00007fff9461924e WebCore::HTMLDocument::~HTMLDocument() + 14 6 com.apple.WebCore 0x00007fff940c42dc WebCore::Node::~Node() + 172 7 com.apple.WebCore 0x00007fff9418275a WebCore::HTMLScriptElement::~HTMLScriptElement() + 26 8 com.apple.WebCore 0x00007fff941825df WebCore::JSNodeOwner::finalize(JSC::Handle<JSC::Unknown>, Radar: <rdar://problem/19040156> 1050065 1 241929 cdumez 2014-11-20 00:23:07 -0800 Created attachment 241929 Patch 1050072 2 241929 cdumez 2014-11-20 00:35:07 -0800 Comment on attachment 241929 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241929&action=review > LayoutTests/fast/dom/resources/frame-with-throttled-timer.html:3 > +<iframe id="testFrame"></iframe> This extra iframe is needed to work around: https://bugs.webkit.org/show_bug.cgi?id=138915 1050163 3 241929 benjamin 2014-11-20 10:04:15 -0800 Comment on attachment 241929 Patch rs=me 1050179 4 241929 commit-queue 2014-11-20 10:44:03 -0800 Comment on attachment 241929 Patch Clearing flags on attachment: 241929 Committed r176402: <http://trac.webkit.org/changeset/176402> 1050180 5 commit-queue 2014-11-20 10:44:08 -0800 All reviewed patches have been landed. Closing bug. 1050199 6 241929 benjamin 2014-11-20 11:21:05 -0800 Comment on attachment 241929 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241929&action=review > LayoutTests/fast/dom/throttled-timer-running-on-document-destruction.html:18 > +setTimeout(removeFrame, 300); Can't this be shorter? Maybe wait for the onload of the frame and do a short timer (100ms)? 1050212 7 cdumez 2014-11-20 12:28:42 -0800 (In reply to comment #6) > Comment on attachment 241929 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241929&action=review > > > LayoutTests/fast/dom/throttled-timer-running-on-document-destruction.html:18 > > +setTimeout(removeFrame, 300); > > Can't this be shorter? > > Maybe wait for the onload of the frame and do a short timer (100ms)? Yes, that works. I updated the test in https://bugs.webkit.org/show_bug.cgi?id=138915. 241929 2014-11-20 00:23:07 -0800 2014-11-20 10:44:03 -0800 Patch bug-138914-20141120002321.patch text/plain 6488 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2Mzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjJiZGFlMzEzZTU0NDNk NTFlYmZkNDBmN2JlZmE2N2ZjN2MwNTQxNi4uMGNhMDI0OWNhOTU2MmYyMGE1ZTc5ZTMzMTAzNTNi ZGJjNGJlZTBmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDE0LTExLTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggd2hlbiBkZXN0cm95 aW5nIGEgRG9jdW1lbnQgdGhhdCBoYXMgYSB0aHJvdHRsZWQgdGltZXIgc3RpbGwgcnVubmluZwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4OTE0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBvbiBkZXN0 cnVjdGlvbiwgYSB0aHJvdHRsZWQgRE9NVGltZXIgd2hvc2UgaW50ZXJ2YWwgZGVwZW5kcyBvbgor ICAgICAgICB2aWV3cG9ydCBjaGFuZ2VzIHdpbGwgdHJ5IHRvIHVucmVnaXN0ZXIgaXRzZWxmIGZy b20gdGhlIHZpZXcuIEl0IGdldHMKKyAgICAgICAgdGhlIHZpZXcgcG9pbnRlciBmcm9tIGl0cyBE b2N1bWVudC4gSG93ZXZlciwgc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpCisgICAgICAgIGNhbiBy ZXR1cm4gbnVsbCBpZiB0aGUgRG9jdW1lbnQgaXMgYmVpbmcgZGVzdHJveWVkIChpLmUuIH5ET01U aW1lcigpCisgICAgICAgIGlzIGNhbGxlZCBmcm9tIH5TY3JpcHRFeGVjdXRpb25Db250ZXh0KCks IGFzIHRoZSBTY3JpcHRFeGVjdXRpb25Db250ZXh0CisgICAgICAgIG93bnMgdGhlIERPTVRpbWVy KS4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgYSBudWxsIGNoZWNrIGZvciBzY3JpcHRFeGVj dXRpb25Db250ZXh0KCkgaW4gdGhlCisgICAgICAgIERPTVRpbWVyIGRlc3RydWN0b3IgdG8gYXZv aWQgdGhpcyBpc3N1ZS4KKworICAgICAgICBUZXN0OiBmYXN0L2RvbS90aHJvdHRsZWQtdGltZXIt cnVubmluZy1vbi1kb2N1bWVudC1kZXN0cnVjdGlvbi5odG1sCisKKyAgICAgICAgKiBwYWdlL0RP TVRpbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTVRpbWVyOjp+RE9NVGltZXIpOgorCisg ICAgICAgIChXZWJDb3JlOjpET01UaW1lcjo6dW5yZWdpc3RlckZvclZpZXdwb3J0Q2hhbmdlcyk6 CisgICAgICAgIEFkZCBhc3NlcnRpb24gdG8gbWFrZSBzdXJlIHNjcmlwdEV4ZWN1dGlvbkNvbnRl eHQoKSBkb2VzIG5vdCByZXR1cm4KKyAgICAgICAgbnVsbC4KKworICAgICAgICAoV2ViQ29yZTo6 RE9NVGltZXJGaXJlU3RhdGU6OnNldENoYW5nZWRTdHlsZU9mRWxlbWVudE91dHNpZGVWaWV3cG9y dCk6IERlbGV0ZWQuCisgICAgICAgIEtpbGxlZCB0aGlzIGZ1bmN0aW9uIGFzIHRoaXMgd2FzIGRl YWQgY29kZS4KKwogMjAxNC0xMS0xOSAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+ CiAKICAgICAgICAgUmVtb3ZlICJkb2N1bWVudCBoYXMgbm8gOjpiZWZvcmUgYW5kL29yIDo6YWZ0 ZXIgcnVsZXMiIG9wdGltaXphdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RE9NVGltZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01UaW1lci5jcHAKaW5kZXggZTNj MWFkMjc0OGJkYmJmNWU4YmNlYzc0YmE2ZDE3ZmQ3NGEyNmMwMy4uYjQzNjJjZTFmMThmYzFhYjdi NTFlYzU2OWFkMjYxODQ0NjE0YTRlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9E T01UaW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01UaW1lci5jcHAKQEAgLTk5 LDExICs5OSw2IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIGRvY3VtZW50ICYmIGRvY3VtZW50 LT5kb21UcmVlVmVyc2lvbigpICE9IG1faW5pdGlhbERPTVRyZWVWZXJzaW9uOwogICAgIH0KIAot ICAgIHZvaWQgc2V0Q2hhbmdlZFN0eWxlT2ZFbGVtZW50T3V0c2lkZVZpZXdwb3J0KFN0eWxlZEVs ZW1lbnQmIGVsZW1lbnQpCi0gICAgewotICAgICAgICBtX2VsZW1lbnRzQ2hhbmdlZE91dHNpZGVW aWV3cG9ydC5hZGQoJmVsZW1lbnQpOwotICAgIH0KLQogICAgIHZvaWQgZWxlbWVudHNDaGFuZ2Vk T3V0c2lkZVZpZXdwb3J0KFZlY3RvcjxSZWZQdHI8U3R5bGVkRWxlbWVudD4+JiBlbGVtZW50cykg Y29uc3QKICAgICB7CiAgICAgICAgIGNvcHlUb1ZlY3RvcihtX2VsZW1lbnRzQ2hhbmdlZE91dHNp ZGVWaWV3cG9ydCwgZWxlbWVudHMpOwpAQCAtMjA5LDcgKzIwNCw5IEBAIERPTVRpbWVyOjpET01U aW1lcihTY3JpcHRFeGVjdXRpb25Db250ZXh0JiBjb250ZXh0LCBzdGQ6OnVuaXF1ZV9wdHI8U2No ZWR1bGVkQWN0CiAKIERPTVRpbWVyOjp+RE9NVGltZXIoKQogewotICAgIGlmIChpc0ludGVydmFs RGVwZW5kZW50T25WaWV3cG9ydCgpKQorICAgIC8vIElmIHRoZSBTY3JpcHRFeGVjdXRpb25Db250 ZXh0IGhhcyBhbHJlYWR5IGJlZW4gZGVzdHJveWVkLCB0aGVyZSBpcworICAgIC8vIG5vIG5lZWQg dG8gc3RvcCBsaXN0ZW5pbmcgZm9yIHZpZXdwb3J0IGNoYW5nZXMuCisgICAgaWYgKHNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQoKSAmJiBpc0ludGVydmFsRGVwZW5kZW50T25WaWV3cG9ydCgpKQogICAg ICAgICB1bnJlZ2lzdGVyRm9yVmlld3BvcnRDaGFuZ2VzKCk7CiB9CiAKQEAgLTQ0Myw2ICs0NDAs NyBAQCB2b2lkIERPTVRpbWVyOjpyZWdpc3RlckZvclZpZXdwb3J0Q2hhbmdlcygpCiAKIHZvaWQg RE9NVGltZXI6OnVucmVnaXN0ZXJGb3JWaWV3cG9ydENoYW5nZXMoKQogeworICAgIEFTU0VSVChz Y3JpcHRFeGVjdXRpb25Db250ZXh0KCkpOwogICAgIGlmIChhdXRvKiBmcmFtZVZpZXcgPSBkb3du Y2FzdDxEb2N1bWVudD4oKnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSkudmlldygpKQogICAgICAg ICBmcmFtZVZpZXctPnVucmVnaXN0ZXJUaHJvdHRsZWRET01UaW1lcih0aGlzKTsKIApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IDAwYjBiM2EyZTU4MzNmZGYwNDAwMmNiNWU3MmZiOTZiYjM5ZjA5YzMuLmMwMjc5N2E0NzUyYmQy YjQyZTk4NzJmOGM4MGE4ZDc2MzRmZWQ3YjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNC0x MS0yMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIHdo ZW4gZGVzdHJveWluZyBhIERvY3VtZW50IHRoYXQgaGFzIGEgdGhyb3R0bGVkIHRpbWVyIHN0aWxs IHJ1bm5pbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzODkxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBhIGxheW91dCB0ZXN0IHRvIHRlc3QgdGhlIGNhc2Ugd2hlcmUgYSBEb2N1bWVudCBnZXRz IGRlc3Ryb3llZCB3aGlsZQorICAgICAgICB0aHJvdHRsZWQgdGltZXIgaXMgc3RpbGwgcnVubmlu Zy4KKworICAgICAgICAqIGZhc3QvZG9tL3Jlc291cmNlcy9mcmFtZS13aXRoLXRocm90dGxlZC10 aW1lci5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS90aHJvdHRsZWQtdGltZXItcnVu bmluZy1vbi1kb2N1bWVudC1kZXN0cnVjdGlvbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvZG9tL3Rocm90dGxlZC10aW1lci1ydW5uaW5nLW9uLWRvY3VtZW50LWRlc3RydWN0 aW9uLmh0bWw6IEFkZGVkLgorCiAyMDE0LTExLTE5ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhm aWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgW09TIFhdIFVwcmlnaHQgdmVydGljYWwgdGV4dCBp cyBjb21wbGV0ZWx5IGJyb2tlbiBmb3IgbXVsdGktY29kZS11bml0IGNvZGVwb2ludHMKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3Jlc291cmNlcy9mcmFtZS13aXRoLXRocm90dGxl ZC10aW1lci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vcmVzb3VyY2VzL2ZyYW1lLXdpdGgt dGhyb3R0bGVkLXRpbWVyLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZWYzMmRhZDI3YTMyOGE4MGZkOWI3Y2Jk OGJkZTBhZjYwNWIxYjA0OQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9t L3Jlc291cmNlcy9mcmFtZS13aXRoLXRocm90dGxlZC10aW1lci5odG1sCkBAIC0wLDAgKzEsMTQg QEAKKzwhRE9DVFlQRSBodG1sPgorPGJvZHk+Cis8aWZyYW1lIGlkPSJ0ZXN0RnJhbWUiPjwvaWZy YW1lPgorPHNjcmlwdD4KK2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0ZXN0RnJhbWUnKS5jb250 ZW50RG9jdW1lbnQuYm9keS5pbm5lckhUTUwgPSAiPGRpdiBpZD0ndGVzdEVsZW1lbnQnIHN0eWxl PSdkaXNwbGF5OiBub25lJz5URVNUPC9kaXY+IgorCitzZXRJbnRlcnZhbChmdW5jdGlvbigpIHsK KyAgLy8gQ2hhbmdlIHRoZSBzdHlsZSBvZiBhIGRpc3BsYXk6bm9uZSBlbGVtZW50LgorICB2YXIg dGVzdEZyYW1lID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RGcmFtZSIpOworICB2YXIg dGVzdEVsZW1lbnQgPSB0ZXN0RnJhbWUuY29udGVudERvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0 ZXN0RWxlbWVudCIpOworICB0ZXN0RWxlbWVudC5zdHlsZVsibGVmdCJdID0gIiIgKyBNYXRoLmZs b29yKChNYXRoLnJhbmRvbSgpICogMTApICsgMSkgKyAicHgiOworfSwgNSk7Cis8L3NjcmlwdD4K KzwvYm9keT4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3Rocm90dGxlZC10aW1l ci1ydW5uaW5nLW9uLWRvY3VtZW50LWRlc3RydWN0aW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL2Zhc3QvZG9tL3Rocm90dGxlZC10aW1lci1ydW5uaW5nLW9uLWRvY3VtZW50LWRlc3RydWN0 aW9uLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43NmI3OWM3YWNjZjk1MTAwZWE5Y2NjYmVkNGM3 YTlmM2NlZjE2MjViCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vdGhy b3R0bGVkLXRpbWVyLXJ1bm5pbmctb24tZG9jdW1lbnQtZGVzdHJ1Y3Rpb24tZXhwZWN0ZWQudHh0 CkBAIC0wLDAgKzEsMTAgQEAKK1Rlc3QgdGhhdCB3ZSBkb24ndCBjcmFzaCBpZiBhIHRocm90dGxl ZCB0aW1lciBpcyBzdGlsbCBydW5uaW5nIHdoZW4gdGhlIGRvY3VtZW50IGlzIGRlc3Ryb3llZC4K KworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywg Zm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgRGlkIG5vdCBjcmFzaC4KK1BB U1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS90aHJvdHRsZWQtdGltZXItcnVubmluZy1vbi1kb2N1 bWVudC1kZXN0cnVjdGlvbi5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vdGhyb3R0bGVkLXRp bWVyLXJ1bm5pbmctb24tZG9jdW1lbnQtZGVzdHJ1Y3Rpb24uaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iMjhm ZGU0NDAwN2RhYzczZGMwMDZhZGZiZWI5NmZhMzA2YzNiYzI3Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9kb20vdGhyb3R0bGVkLXRpbWVyLXJ1bm5pbmctb24tZG9jdW1lbnQt ZGVzdHJ1Y3Rpb24uaHRtbApAQCAtMCwwICsxLDIyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxib2R5 PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+ Cis8aWZyYW1lIGlkPSJ0ZXN0RnJhbWUiIHNyYz0icmVzb3VyY2VzL2ZyYW1lLXdpdGgtdGhyb3R0 bGVkLXRpbWVyLmh0bWwiPjwvaWZyYW1lPgorCis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRlc3Qg dGhhdCB3ZSBkb24ndCBjcmFzaCBpZiBhIHRocm90dGxlZCB0aW1lciBpcyBzdGlsbCBydW5uaW5n IHdoZW4gdGhlIGRvY3VtZW50IGlzIGRlc3Ryb3llZC4iKTsKK2pzVGVzdElzQXN5bmMgPSB0cnVl OworCitmdW5jdGlvbiByZW1vdmVGcmFtZSgpCit7CisgIGRvY3VtZW50LmJvZHkucmVtb3ZlQ2hp bGQoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RGcmFtZSIpKTsKKyAgZ2MoKTsKKyAgdGVz dFBhc3NlZCgiRGlkIG5vdCBjcmFzaC4iKTsKKyAgZmluaXNoSlNUZXN0KCk7Cit9CisKK3NldFRp bWVvdXQocmVtb3ZlRnJhbWUsIDMwMCk7CisKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4u L3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5Pgo=