<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>138913</bug_id>
          
          <creation_ts>2014-11-20 00:11:05 -0800</creation_ts>
          <short_desc>FrameSelection::selectionBounds rarely matches the painted selection highlight rect</short_desc>
          <delta_ts>2017-10-12 14:12:10 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=178232</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>178032</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Horton">thorton</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bdakin</cc>
    
    <cc>enrica</cc>
    
    <cc>hyatt</cc>
    
    <cc>sam</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1050062</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2014-11-20 00:11:05 -0800</bug_when>
    <thetext>There are a number of places between selection painting and the rect returned by FrameSelection::selectionBounds where rounding is applied inconsistently, resulting in a rect that doesn&apos;t precisely match the painted pixels.

For example, RenderView::subtreeSelectionBounds does a &apos;enclosingBoundingBox&apos;, and InlineTextBox::localSelectionRect does a &apos;enclosingIntRect&apos; instead of &apos;snapRectToDevicePixelsWithWritingDirection&apos; (which is what happens in the painting code).

This means that FrameSnapshotting::snapshotSelection often returns a snapshot that doesn&apos;t precisely match the blue highlight. This also breaks TextIndicator&apos;s BounceAndCrossfade animation, which depends on that being true.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1050075</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2014-11-20 00:37:50 -0800</bug_when>
    <thetext>&lt;rdar://problem/19041871&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>