138902 2014-11-19 17:42:39 -0800 Remove "document has no sibling rules" optimization. 2014-11-20 00:43:19 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue koivisto oldest_to_newest 1050016 0 kling 2014-11-19 17:42:39 -0800 Nobody checks if usesSiblingRules() is either true or false. 1050017 1 241915 kling 2014-11-19 17:43:15 -0800 Created attachment 241915 Patch 1050078 2 241915 commit-queue 2014-11-20 00:43:16 -0800 Comment on attachment 241915 Patch Clearing flags on attachment: 241915 Committed r176388: <http://trac.webkit.org/changeset/176388> 1050079 3 commit-queue 2014-11-20 00:43:19 -0800 All reviewed patches have been landed. Closing bug. 241915 2014-11-19 17:43:15 -0800 2014-11-20 00:43:16 -0800 Patch bug-138902.diff text/plain 6122 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMmJkYWUzLi5mN2Y4YTQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzAg QEAKIDIwMTQtMTEtMTkgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIFJlbW92ZSAiZG9jdW1lbnQgaGFzIG5vIHNpYmxpbmcgcnVsZXMiIG9wdGltaXphdGlvbi4K KyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzODkwMj4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSB3ZXJlIGtlZXBpbmcgYSBkb2N1bWVu dC1sZXZlbCBmbGFnIHRvIHRyYWNrIHdoZXRoZXIgdGhlcmUgYXJlIGFueQorICAgICAgICBzaWJs aW5nIHJ1bGVzIGluIGFueSBhY3RpdmUgc3R5bGUgc2hlZXRzLgorCisgICAgICAgIFRoaXMgaW5m b3JtYXRpb24gd2FzIHVzZWQgdG8gZG8uLiBub3RoaW5nLgorCisgICAgICAgICogY3NzL1N0eWxl UmVzb2x2ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUmVzb2x2ZXI6OnVzZXNTaWJsaW5n UnVsZXMpOiBEZWxldGVkLgorICAgICAgICAqIGRvbS9Eb2N1bWVudFN0eWxlU2hlZXRDb2xsZWN0 aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50U3R5bGVTaGVldENvbGxlY3Rpb246 OkRvY3VtZW50U3R5bGVTaGVldENvbGxlY3Rpb24pOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1l bnRTdHlsZVNoZWV0Q29sbGVjdGlvbjo6Y29tYmluZUNTU0ZlYXR1cmVGbGFncyk6CisgICAgICAg IChXZWJDb3JlOjpEb2N1bWVudFN0eWxlU2hlZXRDb2xsZWN0aW9uOjpyZXNldENTU0ZlYXR1cmVG bGFncyk6CisgICAgICAgICogZG9tL0RvY3VtZW50U3R5bGVTaGVldENvbGxlY3Rpb24uaDoKKyAg ICAgICAgKFdlYkNvcmU6OkRvY3VtZW50U3R5bGVTaGVldENvbGxlY3Rpb246OnVzZXNTaWJsaW5n UnVsZXMpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnRTdHlsZVNoZWV0Q29s bGVjdGlvbjo6c2V0VXNlc1NpYmxpbmdSdWxlc092ZXJyaWRlKTogRGVsZXRlZC4KKyAgICAgICAg KiBtYXRobWwvTWF0aE1MTWF0aEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWF0aE1M TWF0aEVsZW1lbnQ6Omluc2VydGVkSW50byk6IERlbGV0ZWQuCisgICAgICAgICogbWF0aG1sL01h dGhNTE1hdGhFbGVtZW50Lmg6CisKKzIwMTQtMTEtMTkgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdA YXBwbGUuY29tPgorCiAgICAgICAgIFJlbW92ZSAiZG9jdW1lbnQgaGFzIG5vIDo6YmVmb3JlIGFu ZC9vciA6OmFmdGVyIHJ1bGVzIiBvcHRpbWl6YXRpb24uCiAgICAgICAgIDxodHRwczovL3dlYmtp dC5vcmcvYi8xMzg4OTc+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJl c29sdmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5oCmluZGV4IGE3YTVh YzIuLmM5OTU4ZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVy LmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuaApAQCAtMjI5LDcgKzIy OSw2IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgY2hlY2tSZWdpb25TdHlsZShFbGVtZW50KiByZWdp b25FbGVtZW50KTsKIAotICAgIGJvb2wgdXNlc1NpYmxpbmdSdWxlcygpIGNvbnN0IHsgcmV0dXJu ICFtX3J1bGVTZXRzLmZlYXR1cmVzKCkuc2libGluZ1J1bGVzLmlzRW1wdHkoKTsgfQogICAgIGJv b2wgdXNlc0ZpcnN0TGluZVJ1bGVzKCkgY29uc3QgeyByZXR1cm4gbV9ydWxlU2V0cy5mZWF0dXJl cygpLnVzZXNGaXJzdExpbmVSdWxlczsgfQogICAgIGJvb2wgdXNlc0ZpcnN0TGV0dGVyUnVsZXMo KSBjb25zdCB7IHJldHVybiBtX3J1bGVTZXRzLmZlYXR1cmVzKCkudXNlc0ZpcnN0TGV0dGVyUnVs ZXM7IH0KICAgICAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudFN0eWxl U2hlZXRDb2xsZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudFN0eWxlU2hl ZXRDb2xsZWN0aW9uLmNwcAppbmRleCAyNDQ4YTNlLi4wNjYyNDg0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnRTdHlsZVNoZWV0Q29sbGVjdGlvbi5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50U3R5bGVTaGVldENvbGxlY3Rpb24uY3BwCkBAIC01Niw4 ICs1Niw2IEBAIERvY3VtZW50U3R5bGVTaGVldENvbGxlY3Rpb246OkRvY3VtZW50U3R5bGVTaGVl dENvbGxlY3Rpb24oRG9jdW1lbnQmIGRvY3VtZW50KQogICAgICwgbV9pbmplY3RlZFN0eWxlU2hl ZXRDYWNoZVZhbGlkKGZhbHNlKQogICAgICwgbV9oYWRBY3RpdmVMb2FkaW5nU3R5bGVzaGVldChm YWxzZSkKICAgICAsIG1fcGVuZGluZ1VwZGF0ZVR5cGUoTm9VcGRhdGUpCi0gICAgLCBtX3VzZXNT aWJsaW5nUnVsZXMoZmFsc2UpCi0gICAgLCBtX3VzZXNTaWJsaW5nUnVsZXNPdmVycmlkZShmYWxz ZSkKICAgICAsIG1fdXNlc0ZpcnN0TGluZVJ1bGVzKGZhbHNlKQogICAgICwgbV91c2VzRmlyc3RM ZXR0ZXJSdWxlcyhmYWxzZSkKICAgICAsIG1fdXNlc1JlbVVuaXRzKGZhbHNlKQpAQCAtNjgsNyAr NjYsNiBAQCB2b2lkIERvY3VtZW50U3R5bGVTaGVldENvbGxlY3Rpb246OmNvbWJpbmVDU1NGZWF0 dXJlRmxhZ3MoKQogewogICAgIC8vIERlbGF5IHJlc2V0dGluZyB0aGUgZmxhZ3MgdW50aWwgYWZ0 ZXIgbmV4dCBzdHlsZSByZWNhbGMgc2luY2UgdW5hcHBseWluZyB0aGUgc3R5bGUgbWF5IG5vdCB3 b3JrIHdpdGhvdXQgdGhlc2Ugc2V0ICh0aGlzIGlzIHRydWUgYXQgbGVhc3Qgd2l0aCBiZWZvcmUv YWZ0ZXIpLgogICAgIGNvbnN0IFN0eWxlUmVzb2x2ZXImIHN0eWxlUmVzb2x2ZXIgPSBtX2RvY3Vt ZW50LmVuc3VyZVN0eWxlUmVzb2x2ZXIoKTsKLSAgICBtX3VzZXNTaWJsaW5nUnVsZXMgPSBtX3Vz ZXNTaWJsaW5nUnVsZXMgfHwgc3R5bGVSZXNvbHZlci51c2VzU2libGluZ1J1bGVzKCk7CiAgICAg bV91c2VzRmlyc3RMaW5lUnVsZXMgPSBtX3VzZXNGaXJzdExpbmVSdWxlcyB8fCBzdHlsZVJlc29s dmVyLnVzZXNGaXJzdExpbmVSdWxlcygpOwogICAgIG1fdXNlc0ZpcnN0TGV0dGVyUnVsZXMgPSBt X3VzZXNGaXJzdExldHRlclJ1bGVzIHx8IHN0eWxlUmVzb2x2ZXIudXNlc0ZpcnN0TGV0dGVyUnVs ZXMoKTsKIH0KQEAgLTc2LDcgKzczLDYgQEAgdm9pZCBEb2N1bWVudFN0eWxlU2hlZXRDb2xsZWN0 aW9uOjpjb21iaW5lQ1NTRmVhdHVyZUZsYWdzKCkKIHZvaWQgRG9jdW1lbnRTdHlsZVNoZWV0Q29s bGVjdGlvbjo6cmVzZXRDU1NGZWF0dXJlRmxhZ3MoKQogewogICAgIGNvbnN0IFN0eWxlUmVzb2x2 ZXImIHN0eWxlUmVzb2x2ZXIgPSBtX2RvY3VtZW50LmVuc3VyZVN0eWxlUmVzb2x2ZXIoKTsKLSAg ICBtX3VzZXNTaWJsaW5nUnVsZXMgPSBzdHlsZVJlc29sdmVyLnVzZXNTaWJsaW5nUnVsZXMoKTsK ICAgICBtX3VzZXNGaXJzdExpbmVSdWxlcyA9IHN0eWxlUmVzb2x2ZXIudXNlc0ZpcnN0TGluZVJ1 bGVzKCk7CiAgICAgbV91c2VzRmlyc3RMZXR0ZXJSdWxlcyA9IHN0eWxlUmVzb2x2ZXIudXNlc0Zp cnN0TGV0dGVyUnVsZXMoKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudFN0eWxlU2hlZXRDb2xsZWN0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRT dHlsZVNoZWV0Q29sbGVjdGlvbi5oCmluZGV4IDU4NmQ0ZTcuLjNkMjMyNmQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudFN0eWxlU2hlZXRDb2xsZWN0aW9uLmgKKysrIGIv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50U3R5bGVTaGVldENvbGxlY3Rpb24uaApAQCAtMTAx LDggKzEwMSw2IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgaGFzUGVuZGluZ1NoZWV0cygpIGNvbnN0 IHsgcmV0dXJuIG1fcGVuZGluZ1N0eWxlc2hlZXRzID4gMDsgfQogCi0gICAgYm9vbCB1c2VzU2li bGluZ1J1bGVzKCkgY29uc3QgeyByZXR1cm4gbV91c2VzU2libGluZ1J1bGVzIHx8IG1fdXNlc1Np YmxpbmdSdWxlc092ZXJyaWRlOyB9Ci0gICAgdm9pZCBzZXRVc2VzU2libGluZ1J1bGVzT3ZlcnJp ZGUoYm9vbCBiKSB7IG1fdXNlc1NpYmxpbmdSdWxlc092ZXJyaWRlID0gYjsgfQogICAgIGJvb2wg dXNlc0ZpcnN0TGluZVJ1bGVzKCkgY29uc3QgeyByZXR1cm4gbV91c2VzRmlyc3RMaW5lUnVsZXM7 IH0KICAgICBib29sIHVzZXNGaXJzdExldHRlclJ1bGVzKCkgY29uc3QgeyByZXR1cm4gbV91c2Vz Rmlyc3RMZXR0ZXJSdWxlczsgfQogICAgIGJvb2wgdXNlc1JlbVVuaXRzKCkgY29uc3QgeyByZXR1 cm4gbV91c2VzUmVtVW5pdHM7IH0KQEAgLTE1Niw4ICsxNTQsNiBAQCBwcml2YXRlOgogICAgIFN0 cmluZyBtX3ByZWZlcnJlZFN0eWxlc2hlZXRTZXROYW1lOwogICAgIFN0cmluZyBtX3NlbGVjdGVk U3R5bGVzaGVldFNldE5hbWU7CiAKLSAgICBib29sIG1fdXNlc1NpYmxpbmdSdWxlczsKLSAgICBi b29sIG1fdXNlc1NpYmxpbmdSdWxlc092ZXJyaWRlOwogICAgIGJvb2wgbV91c2VzRmlyc3RMaW5l UnVsZXM7CiAgICAgYm9vbCBtX3VzZXNGaXJzdExldHRlclJ1bGVzOwogICAgIGJvb2wgbV91c2Vz UmVtVW5pdHM7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9tYXRobWwvTWF0aE1MTWF0aEVs ZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvbWF0aG1sL01hdGhNTE1hdGhFbGVtZW50LmNwcApp bmRleCA4MmIzY2ZkLi4zNzlhMmZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9tYXRobWwv TWF0aE1MTWF0aEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL21hdGhtbC9NYXRoTUxN YXRoRWxlbWVudC5jcHAKQEAgLTQzLDE0ICs0Myw2IEBAIFBhc3NSZWZQdHI8TWF0aE1MTWF0aEVs ZW1lbnQ+IE1hdGhNTE1hdGhFbGVtZW50OjpjcmVhdGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgdGFn CiAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBNYXRoTUxNYXRoRWxlbWVudCh0YWdOYW1lLCBkb2N1 bWVudCkpOwogfQogCi1Ob2RlOjpJbnNlcnRpb25Ob3RpZmljYXRpb25SZXF1ZXN0IE1hdGhNTE1h dGhFbGVtZW50OjppbnNlcnRlZEludG8oQ29udGFpbmVyTm9kZSYgaW5zZXJ0aW9uUG9pbnQpCi17 Ci0gICAgLy8gVGhlcmUgYXJlIHNpYmxpbmcgcnVsZXMgaW4gdGhlIE1hdGhNTCBkZWZhdWx0IHN0 eWxlLgotICAgIGlmIChpbnNlcnRpb25Qb2ludC5pbkRvY3VtZW50KCkpCi0gICAgICAgIGRvY3Vt ZW50KCkuc3R5bGVTaGVldENvbGxlY3Rpb24oKS5zZXRVc2VzU2libGluZ1J1bGVzT3ZlcnJpZGUo dHJ1ZSk7Ci0gICAgcmV0dXJuIE1hdGhNTElubGluZUNvbnRhaW5lckVsZW1lbnQ6Omluc2VydGVk SW50byhpbnNlcnRpb25Qb2ludCk7Ci19Ci0KIFJlbmRlclB0cjxSZW5kZXJFbGVtZW50PiBNYXRo TUxNYXRoRWxlbWVudDo6Y3JlYXRlRWxlbWVudFJlbmRlcmVyKFBhc3NSZWY8UmVuZGVyU3R5bGU+ IHN0eWxlKQogewogICAgIHJldHVybiBjcmVhdGVSZW5kZXJlcjxSZW5kZXJNYXRoTUxNYXRoPigq dGhpcywgV1RGOjptb3ZlKHN0eWxlKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9tYXRo bWwvTWF0aE1MTWF0aEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL21hdGhtbC9NYXRoTUxNYXRo RWxlbWVudC5oCmluZGV4IDIzODczZTkuLjJiMTI5NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL21hdGhtbC9NYXRoTUxNYXRoRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL21hdGht bC9NYXRoTUxNYXRoRWxlbWVudC5oCkBAIC0zOSw3ICszOSw2IEBAIHB1YmxpYzoKIHByaXZhdGU6 CiAgICAgTWF0aE1MTWF0aEVsZW1lbnQoY29uc3QgUXVhbGlmaWVkTmFtZSYgdGFnTmFtZSwgRG9j dW1lbnQmKTsKIAotICAgIHZpcnR1YWwgSW5zZXJ0aW9uTm90aWZpY2F0aW9uUmVxdWVzdCBpbnNl cnRlZEludG8oQ29udGFpbmVyTm9kZSYpIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgUmVuZGVyUHRy PFJlbmRlckVsZW1lbnQ+IGNyZWF0ZUVsZW1lbnRSZW5kZXJlcihQYXNzUmVmPFJlbmRlclN0eWxl Pikgb3ZlcnJpZGU7CiB9OwogICAgIAo=