138887 2014-11-19 14:49:27 -0800 Data detected results with no menu items should not fall through to regular text action menus 2014-11-19 15:01:00 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin thorton oldest_to_newest 1049926 0 bdakin 2014-11-19 14:49:27 -0800 Data detected results with no menu items should not fall through to regular text action menus rdar://problem/18971616 1049929 1 241892 bdakin 2014-11-19 14:55:21 -0800 Created attachment 241892 Patch 1049932 2 bdakin 2014-11-19 15:01:00 -0800 http://trac.webkit.org/changeset/176351 241892 2014-11-19 14:55:21 -0800 2014-11-19 14:57:30 -0800 Patch for-review.txt text/plain 3328 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjM0OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTExLTE5ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBEYXRhIGRldGVjdGVkIHJlc3VsdHMg d2l0aCBubyBtZW51IGl0ZW1zIHNob3VsZCBub3QgZmFsbCB0aHJvdWdoIHRvIHJlZ3VsYXIgdGV4 dCAKKyAgICAgICAgYWN0aW9uIG1lbnVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzg4ODcKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAg ICAgICByZGFyOi8vcHJvYmxlbS8xODk3MTYxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9XS0FjdGlvbk1lbnVDb250cm9s bGVyLm1tOgorICAgICAgICAoLVtXS0FjdGlvbk1lbnVDb250cm9sbGVyIF9kZWZhdWx0TWVudUl0 ZW1zXSk6CisKIDIwMTQtMTEtMTkgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgog CiAgICAgICAgIFtpT1NdIE1ha2UgV2ViS2l0IGJ1aWxkIHdpdGggcHVibGljIGlPUyBTREsKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tBY3Rpb25NZW51Q29udHJvbGxlci5t bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLQWN0aW9uTWVu dUNvbnRyb2xsZXIubW0JKHJldmlzaW9uIDE3NjMwOSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9tYWMvV0tBY3Rpb25NZW51Q29udHJvbGxlci5tbQkod29ya2luZyBjb3B5KQpAQCAtOTIw LDcgKzkyMCwxMiBAQCAtIChOU0FycmF5ICopX2RlZmF1bHRNZW51SXRlbXMKIAogICAgIGlmICho aXRUZXN0UmVzdWx0LT5pc1RleHROb2RlKCkpIHsKICAgICAgICAgTlNBcnJheSAqZGF0YURldGVj dG9yTWVudUl0ZW1zID0gW3NlbGYgX2RlZmF1bHRNZW51SXRlbXNGb3JEYXRhRGV0ZWN0ZWRUZXh0 XTsKLSAgICAgICAgaWYgKGRhdGFEZXRlY3Rvck1lbnVJdGVtcy5jb3VudCkgeworICAgICAgICBp ZiAoX2N1cnJlbnRBY3Rpb25Db250ZXh0KSB7CisgICAgICAgICAgICAvLyBJZiB0aGlzIGlzIGEg ZGF0YSBkZXRlY3RlZCBpdGVtIHdpdGggbm8gbWVudSBpdGVtcywgd2Ugc2hvdWxkIG5vdCBmYWxs IGJhY2sgdG8gcmVndWxhciB0ZXh0IG9wdGlvbnMuCisgICAgICAgICAgICBpZiAoIWRhdGFEZXRl Y3Rvck1lbnVJdGVtcy5jb3VudCkgeworICAgICAgICAgICAgICAgIF90eXBlID0ga1dLQWN0aW9u TWVudU5vbmU7CisgICAgICAgICAgICAgICAgcmV0dXJuIEBbIF07CisgICAgICAgICAgICB9CiAg ICAgICAgICAgICBfdHlwZSA9IGtXS0FjdGlvbk1lbnVEYXRhRGV0ZWN0ZWRJdGVtOwogICAgICAg ICAgICAgcmV0dXJuIGRhdGFEZXRlY3Rvck1lbnVJdGVtczsKICAgICAgICAgfQpJbmRleDogU291 cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFj L0NoYW5nZUxvZwkocmV2aXNpb24gMTc2MzQ4KQorKysgU291cmNlL1dlYktpdC9tYWMvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMTEtMTkgIEJldGggRGFr aW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIERhdGEgZGV0ZWN0ZWQgcmVzdWx0cyB3 aXRoIG5vIG1lbnUgaXRlbXMgc2hvdWxkIG5vdCBmYWxsIHRocm91Z2ggdG8gcmVndWxhciB0ZXh0 IAorICAgICAgICBhY3Rpb24gbWVudXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzODg4NworICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAg ICAgIHJkYXI6Ly9wcm9ibGVtLzE4OTcxNjE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkFjdGlvbk1lbnVDb250cm9sbGVyLm1t OgorICAgICAgICAoLVtXZWJBY3Rpb25NZW51Q29udHJvbGxlciBfZGVmYXVsdE1lbnVJdGVtc10p OgorCiAyMDE0LTExLTE5ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAg ICAgICBbaU9TXSBNYWtlIFdlYktpdCBidWlsZCB3aXRoIHB1YmxpYyBpT1MgU0RLCkluZGV4OiBT b3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkFjdGlvbk1lbnVDb250cm9sbGVyLm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViQWN0aW9uTWVudUNvbnRyb2xs ZXIubW0JKHJldmlzaW9uIDE3NjMwOSkKKysrIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2Vi QWN0aW9uTWVudUNvbnRyb2xsZXIubW0JKHdvcmtpbmcgY29weSkKQEAgLTg1Miw3ICs4NTIsMTIg QEAgLSAoTlNBcnJheSAqKV9kZWZhdWx0TWVudUl0ZW1zCiAgICAgTm9kZSogbm9kZSA9IF9oaXRU ZXN0UmVzdWx0LmlubmVyTm9kZSgpOwogICAgIGlmIChub2RlICYmIG5vZGUtPmlzVGV4dE5vZGUo KSkgewogICAgICAgICBOU0FycmF5ICpkYXRhRGV0ZWN0b3JNZW51SXRlbXMgPSBbc2VsZiBfZGVm YXVsdE1lbnVJdGVtc0ZvckRhdGFEZXRlY3RlZFRleHRdOwotICAgICAgICBpZiAoZGF0YURldGVj dG9yTWVudUl0ZW1zLmNvdW50KSB7CisgICAgICAgIGlmIChfY3VycmVudEFjdGlvbkNvbnRleHQp IHsKKyAgICAgICAgICAgIC8vIElmIHRoaXMgaXMgYSBkYXRhIGRldGVjdGVkIGl0ZW0gd2l0aCBu byBtZW51IGl0ZW1zLCB3ZSBzaG91bGQgbm90IGZhbGwgYmFjayB0byByZWd1bGFyIHRleHQgb3B0 aW9ucy4KKyAgICAgICAgICAgIGlmICghZGF0YURldGVjdG9yTWVudUl0ZW1zLmNvdW50KSB7Cisg ICAgICAgICAgICAgICAgX3R5cGUgPSBXZWJBY3Rpb25NZW51Tm9uZTsKKyAgICAgICAgICAgICAg ICByZXR1cm4gQFsgXTsKKyAgICAgICAgICAgIH0KICAgICAgICAgICAgIF90eXBlID0gV2ViQWN0 aW9uTWVudURhdGFEZXRlY3RlZEl0ZW07CiAgICAgICAgICAgICByZXR1cm4gZGF0YURldGVjdG9y TWVudUl0ZW1zOwogICAgICAgICB9Cg==