138881 2014-11-19 13:28:49 -0800 Add APIs for customizing the user agent 2014-11-19 14:07:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 1049889 0 andersca 2014-11-19 13:28:49 -0800 Add APIs for customizing the user agent 1049890 1 241882 andersca 2014-11-19 13:29:28 -0800 Created attachment 241882 Patch 1049891 2 commit-queue 2014-11-19 13:30:51 -0800 Attachment 241882 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:181: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1049909 3 andersca 2014-11-19 14:07:14 -0800 Committed r176340: <http://trac.webkit.org/changeset/176340> 241882 2014-11-19 13:29:28 -0800 2014-11-19 13:58:59 -0800 Patch bug-138881-20141119132942.patch text/plain 7154 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2MzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWYxMmE5NzkwZmU2NWY5 Njc2MWU0OThlMTVkODlhZDMwN2Y4NmE4ZC4uZmYwNzBmNjE1ZWNlYzdhMzVjMGQwNWY1MDVkYzdm ZTliNmUwZjQ1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE0LTExLTE5ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIEFQSXMgZm9y IGN1c3RvbWl6aW5nIHRoZSB1c2VyIGFnZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg4ODEKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMTcyMzM5 ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1dlYlZpZXcubW06CisgICAgICAgICgtW1dLV2ViVmlldyBpbml0V2l0aEZyYW1lOmNv bmZpZ3VyYXRpb246XSk6CisgICAgICAgICgtW1dLV2ViVmlldyBjdXN0b21Vc2VyQWdlbnRdKToK KyAgICAgICAgKC1bV0tXZWJWaWV3IHNldEN1c3RvbVVzZXJBZ2VudDpdKToKKyAgICAgICAgKC1b V0tXZWJWaWV3IF9jdXN0b21Vc2VyQWdlbnRdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9zZXRD dXN0b21Vc2VyQWdlbnQ6XSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZp ZXdDb25maWd1cmF0aW9uLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZp ZXdDb25maWd1cmF0aW9uLm1tOgorICAgICAgICAoTGF6eUluaXRpYWxpemVkOjpzZXQpOgorICAg ICAgICAoLVtXS1dlYlZpZXdDb25maWd1cmF0aW9uIGNvcHlXaXRoWm9uZTpdKToKKyAgICAgICAg KGRlZmF1bHRBcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdlbnQpOgorICAgICAgICAoLVtXS1dlYlZp ZXdDb25maWd1cmF0aW9uIGFwcGxpY2F0aW9uTmFtZUZvclVzZXJBZ2VudF0pOgorICAgICAgICAo LVtXS1dlYlZpZXdDb25maWd1cmF0aW9uIHNldEFwcGxpY2F0aW9uTmFtZUZvclVzZXJBZ2VudDpd KToKKwogMjAxNC0xMS0xOSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dUS10gRXJyb3IgaW4gZG9jdW1lbnRhdGlvbiBvZiB3ZWJraXRfcHJp bnRfb3BlcmF0aW9uX2dldF9wYWdlX3NldHVwKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0NvY29hL1dLV2ViVmlldy5oCmluZGV4IDRiODBmOGU2ZmUwNjQ3YWZjZDVhMmU2ZDdj YTBhZWVhNDc0N2ZhMjkuLjE5YTFjYWQ1NTM2ZGYxOWUyOTg4ZDAyZGU3ZmIxZGI3OGI4YTJkYTcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3 LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcuaApA QCAtMjA5LDYgKzIwOSwxMCBAQCBXS19DTEFTU19BVkFJTEFCTEUoMTBfMTAsIDhfMCkKICAqLwog QHByb3BlcnR5IChub25hdG9taWMpIEJPT0wgYWxsb3dzQmFja0ZvcndhcmROYXZpZ2F0aW9uR2Vz dHVyZXM7CiAKKy8qISBAYWJzdHJhY3QgVGhlIGN1c3RvbSB1c2VyIGFnZW50IHN0cmluZyBvciBu aWwgaWYgbm8gY3VzdG9tIHVzZXIgYWdlbnQgc3RyaW5nIGhhcyBiZWVuIHNldC4KKyovCitAcHJv cGVydHkgKG5vbmF0b21pYywgY29weSkgTlNTdHJpbmcgKmN1c3RvbVVzZXJBZ2VudCBXS19BVkFJ TEFCTEUoV0tfTUFDX1RCQSwgV0tfSU9TX1RCQSk7CisKICNpZiBUQVJHRVRfT1NfSVBIT05FCiAv KiEgQGFic3RyYWN0IFRoZSBzY3JvbGwgdmlldyBhc3NvY2lhdGVkIHdpdGggdGhlIHdlYiB2aWV3 LgogICovCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dL V2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3 Lm1tCmluZGV4IGFiNWQ4MmZmYjc3NzFlYzYwMTdlYjQ5NmM4MTkyMDA2NjY2YmMyMzIuLjMwNTQ4 MjE3ZGVjODYwMmExZjkzNTBiMDY5Zjg3ZTJkN2MzMGJjYzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCkBAIC0zMDAsNyArMzAwLDYgQEAg c3RhdGljIGludDMyX3QgZGV2aWNlT3JpZW50YXRpb24oKQogICAgIF9jb250ZW50VmlldyA9IGFk b3B0TlMoW1tXS0NvbnRlbnRWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOmJvdW5kcyBjb250ZXh0 OmNvbnRleHQgY29uZmlndXJhdGlvbjpXVEY6Om1vdmUod2ViUGFnZUNvbmZpZ3VyYXRpb24pIHdl YlZpZXc6c2VsZl0pOwogCiAgICAgX3BhZ2UgPSBbX2NvbnRlbnRWaWV3IHBhZ2VdOwotICAgIF9w YWdlLT5zZXRBcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdlbnQoW0AiTW9iaWxlLyIgc3RyaW5nQnlB cHBlbmRpbmdTdHJpbmc6W1VJRGV2aWNlIGN1cnJlbnREZXZpY2VdLmJ1aWxkVmVyc2lvbl0pOwog ICAgIF9wYWdlLT5zZXREZXZpY2VPcmllbnRhdGlvbihkZXZpY2VPcmllbnRhdGlvbigpKTsKIAog ICAgIFtfY29udGVudFZpZXcgbGF5ZXJdLmFuY2hvclBvaW50ID0gQ0dQb2ludFplcm87CkBAIC0z MzcsNiArMzM2LDkgQEAgc3RhdGljIGludDMyX3QgZGV2aWNlT3JpZW50YXRpb24oKQogCiAgICAg X3BhZ2UtPnNldEJhY2tncm91bmRFeHRlbmRzQmV5b25kUGFnZSh0cnVlKTsKIAorICAgIGlmIChO U1N0cmluZyAqYXBwbGljYXRpb25OYW1lRm9yVXNlckFnZW50ID0gY29uZmlndXJhdGlvbi5hcHBs aWNhdGlvbk5hbWVGb3JVc2VyQWdlbnQpCisgICAgICAgIF9wYWdlLT5zZXRBcHBsaWNhdGlvbk5h bWVGb3JVc2VyQWdlbnQoYXBwbGljYXRpb25OYW1lRm9yVXNlckFnZW50KTsKKwogICAgIF9uYXZp Z2F0aW9uU3RhdGUgPSBzdGQ6Om1ha2VfdW5pcXVlPFdlYktpdDo6TmF2aWdhdGlvblN0YXRlPihz ZWxmKTsKICAgICBfcGFnZS0+c2V0UG9saWN5Q2xpZW50KF9uYXZpZ2F0aW9uU3RhdGUtPmNyZWF0 ZVBvbGljeUNsaWVudCgpKTsKICAgICBfcGFnZS0+c2V0TG9hZGVyQ2xpZW50KF9uYXZpZ2F0aW9u U3RhdGUtPmNyZWF0ZUxvYWRlckNsaWVudCgpKTsKQEAgLTU5MSw2ICs1OTMsMTYgQEAgc3RhdGlj IFdLRXJyb3JDb2RlIGNhbGxiYWNrRXJyb3JDb2RlKFdlYktpdDo6Q2FsbGJhY2tCYXNlOjpFcnJv ciBlcnJvcikKICAgICB9KTsKIH0KIAorLSAoTlNTdHJpbmcgKiljdXN0b21Vc2VyQWdlbnQKK3sK KyAgICByZXR1cm4gX3BhZ2UtPmN1c3RvbVVzZXJBZ2VudCgpOworfQorCistICh2b2lkKXNldEN1 c3RvbVVzZXJBZ2VudDooTlNTdHJpbmcgKiljdXN0b21Vc2VyQWdlbnQKK3sKKyAgICBfcGFnZS0+ c2V0Q3VzdG9tVXNlckFnZW50KGN1c3RvbVVzZXJBZ2VudCk7Cit9CisKICNwcmFnbWEgbWFyayBp T1Mtc3BlY2lmaWMgbWV0aG9kcwogCiAjaWYgUExBVEZPUk0oSU9TKQpAQCAtMTY1OSwxMiArMTY3 MSwxMyBAQCBzdGF0aWMgV2ViQ29yZTo6RmxvYXRQb2ludCBjb25zdHJhaW5Db250ZW50T2Zmc2V0 KFdlYkNvcmU6OkZsb2F0UG9pbnQgY29udGVudE9mZgogCiAtIChOU1N0cmluZyAqKV9jdXN0b21V c2VyQWdlbnQKIHsKLSAgICByZXR1cm4gX3BhZ2UtPmN1c3RvbVVzZXJBZ2VudCgpOworICAgIHJl dHVybiBzZWxmLmN1c3RvbVVzZXJBZ2VudDsKKwogfQogCi0tICh2b2lkKV9zZXRDdXN0b21Vc2Vy QWdlbnQ6KE5TU3RyaW5nICopX2N1c3RvbVVzZXJBZ2VudAorLSAodm9pZClfc2V0Q3VzdG9tVXNl ckFnZW50OihOU1N0cmluZyAqKWN1c3RvbVVzZXJBZ2VudAogewotICAgIF9wYWdlLT5zZXRDdXN0 b21Vc2VyQWdlbnQoX2N1c3RvbVVzZXJBZ2VudCk7CisgICAgc2VsZi5jdXN0b21Vc2VyQWdlbnQg PSBjdXN0b21Vc2VyQWdlbnQ7CiB9CiAKIC0gKHBpZF90KV93ZWJQcm9jZXNzSWRlbnRpZmllcgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdD b25maWd1cmF0aW9uLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi Vmlld0NvbmZpZ3VyYXRpb24uaAppbmRleCA2MDYzNTQwOTU4NTc0NDkwODE3Y2NhZThlYTU3MTIy MGI2NTdlODRhLi4wNjdkZTc3MTU4NjJlODg0NjU5MGY1MjI2YzE1NDUwNmU4Y2YzZWM3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0NvbmZp Z3VyYXRpb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi Vmlld0NvbmZpZ3VyYXRpb24uaApAQCAtNzcsNiArNzcsMTAgQEAgV0tfQ0xBU1NfQVZBSUxBQkxF KDEwXzEwLCA4XzApCiAgKi8KIEBwcm9wZXJ0eSAobm9uYXRvbWljKSBCT09MIHN1cHByZXNzZXNJ bmNyZW1lbnRhbFJlbmRlcmluZzsKIAorLyohIEBhYnN0cmFjdCBUaGUgbmFtZSBvZiB0aGUgYXBw bGljYXRpb24gYXMgdXNlZCBpbiB0aGUgdXNlciBhZ2VudCBzdHJpbmcuCisqLworQHByb3BlcnR5 IChub25hdG9taWMsIGNvcHkpIE5TU3RyaW5nICphcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdlbnQg V0tfQVZBSUxBQkxFKFdLX01BQ19UQkEsIFdLX0lPU19UQkEpOworCiAjaWYgVEFSR0VUX09TX0lQ SE9ORQogLyohIEBhYnN0cmFjdCBBIEJvb2xlYW4gdmFsdWUgaW5kaWNhdGluZyB3aGV0aGVyIEhU TUw1IHZpZGVvcyBwbGF5IGlubGluZQogIChZRVMpIG9yIHVzZSB0aGUgbmF0aXZlIGZ1bGwtc2Ny ZWVuIGNvbnRyb2xsZXIgKE5PKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQppbmRleCBkNTM0Zjcw ZjU2YWJkZjc1NDMwMTMyNGU4ZGE4OTU1N2JjZTAwMDg0Li4wNmVkODgyOGFmYjNhZDc4MjBhYWUw ODc4MTE3OTc2M2YwMTU3ZWMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRpb24ubW0KKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdDb25maWd1cmF0aW9uLm1tCkBAIC01Niw2ICs1 NiwxMiBAQCBwdWJsaWM6CiAgICAgICAgIG1faXNJbml0aWFsaXplZCA9IHRydWU7CiAgICAgfQog CisgICAgdm9pZCBzZXQoUmV0YWluUHRyPFQ+JiYgdCkKKyAgICB7CisgICAgICAgIG1fdmFsdWUg PSBXVEY6Om1vdmUodCk7CisgICAgICAgIG1faXNJbml0aWFsaXplZCA9IHRydWU7CisgICAgfQor CiAgICAgVCogcGVlaygpCiAgICAgewogICAgICAgICByZXR1cm4gbV92YWx1ZS5nZXQoKTsKQEAg LTc1LDYgKzgxLDggQEAgcHJpdmF0ZToKICAgICBXZWJLaXQ6OldlYWtPYmpDUHRyPFdLV2ViVmll dz4gX3JlbGF0ZWRXZWJWaWV3OwogICAgIFdlYktpdDo6V2Vha09iakNQdHI8V0tXZWJWaWV3PiBf YWx0ZXJuYXRlV2ViVmlld0Zvck5hdmlnYXRpb25HZXN0dXJlczsKICAgICBSZXRhaW5QdHI8TlNT dHJpbmc+IF9ncm91cElkZW50aWZpZXI7CisgICAgTGF6eUluaXRpYWxpemVkPE5TU3RyaW5nPiBf YXBwbGljYXRpb25OYW1lRm9yVXNlckFnZW50OworCiAjaWYgUExBVEZPUk0oSU9TKQogICAgIExh enlJbml0aWFsaXplZDxXS1dlYlZpZXdDb250ZW50UHJvdmlkZXJSZWdpc3RyeT4gX2NvbnRlbnRQ cm92aWRlclJlZ2lzdHJ5OwogICAgIEJPT0wgX2FsbG93c0FsdGVybmF0ZUZ1bGxzY3JlZW47CkBA IC0xMTYsNiArMTI0LDggQEAgcHJpdmF0ZToKICNlbmRpZgogCiAgICAgY29uZmlndXJhdGlvbi0+ X3N1cHByZXNzZXNJbmNyZW1lbnRhbFJlbmRlcmluZyA9IHNlbGYtPl9zdXBwcmVzc2VzSW5jcmVt ZW50YWxSZW5kZXJpbmc7CisgICAgY29uZmlndXJhdGlvbi5hcHBsaWNhdGlvbk5hbWVGb3JVc2Vy QWdlbnQgPSBzZWxmLmFwcGxpY2F0aW9uTmFtZUZvclVzZXJBZ2VudDsKKwogI2lmIFBMQVRGT1JN KElPUykKICAgICBjb25maWd1cmF0aW9uLT5fYWxsb3dzSW5saW5lTWVkaWFQbGF5YmFjayA9IHNl bGYtPl9hbGxvd3NJbmxpbmVNZWRpYVBsYXliYWNrOwogICAgIGNvbmZpZ3VyYXRpb24tPl9hbGxv d3NBbHRlcm5hdGVGdWxsc2NyZWVuID0gc2VsZi0+X2FsbG93c0FsdGVybmF0ZUZ1bGxzY3JlZW47 CkBAIC0xNTcsNiArMTY3LDI1IEBAIHByaXZhdGU6CiAgICAgX3VzZXJDb250ZW50Q29udHJvbGxl ci5zZXQodXNlckNvbnRlbnRDb250cm9sbGVyKTsKIH0KIAorc3RhdGljIE5TU3RyaW5nICpkZWZh dWx0QXBwbGljYXRpb25OYW1lRm9yVXNlckFnZW50KCkKK3sKKyNpZiBQTEFURk9STShJT1MpCisg ICAgcmV0dXJuIFtAIk1vYmlsZS8iIHN0cmluZ0J5QXBwZW5kaW5nU3RyaW5nOltVSURldmljZSBj dXJyZW50RGV2aWNlXS5idWlsZFZlcnNpb25dOworI2Vsc2UKKyAgICByZXR1cm4gbmlsOworI2Vu ZGlmCit9CisKKy0gKE5TU3RyaW5nICopYXBwbGljYXRpb25OYW1lRm9yVXNlckFnZW50Cit7Cisg ICAgcmV0dXJuIF9hcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdlbnQuZ2V0KFtdIHsgcmV0dXJuIGRl ZmF1bHRBcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdlbnQoKTsgfSk7Cit9CisKKy0gKHZvaWQpc2V0 QXBwbGljYXRpb25OYW1lRm9yVXNlckFnZW50OihOU1N0cmluZyAqKWFwcGxpY2F0aW9uTmFtZUZv clVzZXJBZ2VudAoreworICAgIF9hcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdlbnQuc2V0KGFkb3B0 TlMoW2FwcGxpY2F0aW9uTmFtZUZvclVzZXJBZ2VudCBjb3B5XSkpOworfQorCiAtIChfV0tWaXNp dGVkTGlua1Byb3ZpZGVyICopX3Zpc2l0ZWRMaW5rUHJvdmlkZXIKIHsKICAgICByZXR1cm4gX3Zp c2l0ZWRMaW5rUHJvdmlkZXIuZ2V0KFtdIHsgcmV0dXJuIGFkb3B0TlMoW1tfV0tWaXNpdGVkTGlu a1Byb3ZpZGVyIGFsbG9jXSBpbml0XSk7IH0pOwo=