138872 2014-11-19 07:58:36 -0800 [CMake] Build failure against GStreamer git master 2014-11-28 07:27:39 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned cgarcia ossy pnormand oldest_to_newest 1049779 0 pnormand 2014-11-19 07:58:36 -0800 In current GStreamer git master gstversion.h was moved to a different directory but our CMake build looks for it in the first include directory reported by pkg-config. I think there's a great deal of cruft in FindGStreamer.cmake. It does weird version checks and it's unable to handle a library with multiple include directories... 1050133 1 pnormand 2014-11-20 07:55:27 -0800 Must have been a mix of gst versions in my jhbuild sysroot... 1050477 2 pnormand 2014-11-21 09:15:34 -0800 Now it appears again, perhaps ccache tricked me last time... 1050816 3 242147 pnormand 2014-11-24 00:47:54 -0800 Created attachment 242147 patch 1051249 4 pnormand 2014-11-28 06:33:40 -0800 Ossy, would you like to review this patch? 1051251 5 242147 ossy 2014-11-28 06:53:46 -0800 Comment on attachment 242147 patch looks good, r=me. 1051254 6 pnormand 2014-11-28 07:27:39 -0800 Committed r176565: <http://trac.webkit.org/changeset/176565> 242147 2014-11-24 00:47:54 -0800 2014-11-28 06:53:46 -0800 patch patch.patch text/plain 5586 pnormand RnJvbSBhNjFhOGI1NDcwZDY1NDlhYjZhODQyZWRkYmU2YTUyOWY3YTVkYjUzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDE5IE5vdiAyMDE0IDE3OjUxOjA2ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cGF0Y2gKCi0tLQogQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgfCAxMiArKysrKysr KysKIFNvdXJjZS9jbWFrZS9GaW5kR1N0cmVhbWVyLmNtYWtlIHwgNTYgKysrKysrKysrKysrLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyOSBpbnNlcnRpb25z KCspLCAzOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cK aW5kZXggODk1ZjQ0Ni4uMTljOTQ0YSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTExLTI0ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5v cm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbQ01ha2VdIEJ1aWxkIGZhaWx1cmUgYWdhaW5z dCBHU3RyZWFtZXIgZ2l0IG1hc3RlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM4ODcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmluZEdTdHJlYW1lci5jbWFrZTogU2ltcGxp ZmllZCB0aGUKKyAgICAgICAgRklORF9HU1RSRUFNRVJfQ09NUE9ORU5UIG1hY3JvLiBUcnVzdCBw a2ctY29uZmlnIGZvciBpbmNsdWRlCisgICAgICAgIGhlYWRlcnMgbG9va3VwLCB0aGVyZSdzIG5v IG5lZWQgdG8gZG8gdGhpcyBtYW51YWxseS4gQWxzbworICAgICAgICBleHBsaWNpdGVseSBjaGVj ayB0aGUgdmVyc2lvbiBzcGVjaWZpZWQgaW4gR1N0cmVhbWVyX0ZJTkRfVkVSU0lPTi4KKwogMjAx NC0xMS0yMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAg IFtDTWFrZV0gVXNlIGxkLmdvbGQgaWYgaXQgaXMgYXZhaWxhYmxlIHRvIHNwZWVkdXAgYnVpbGRz CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmluZEdTdHJlYW1lci5jbWFrZSBiL1NvdXJjZS9j bWFrZS9GaW5kR1N0cmVhbWVyLmNtYWtlCmluZGV4IDc4MDU1ODguLjc0NDQ3NjAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9jbWFrZS9GaW5kR1N0cmVhbWVyLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9G aW5kR1N0cmVhbWVyLmNtYWtlCkBAIC01MiwxNiArNTIsMTYgQEAgZmluZF9wYWNrYWdlKFBrZ0Nv bmZpZykKICMgSGVscGVyIG1hY3JvIHRvIGZpbmQgYSBHU3RyZWFtZXIgcGx1Z2luIChvciBHU3Ry ZWFtZXIgaXRzZWxmKQogIyAgIF9jb21wb25lbnRfcHJlZml4IGlzIHByZXBlbmRlZCB0byB0aGUg X0lOQ0xVREVfRElSUyBhbmQgX0xJQlJBUklFUyB2YXJpYWJsZXMgKGVnLiAiR1NUUkVBTUVSX0FV RElPIikKICMgICBfcGtnY29uZmlnX25hbWUgaXMgdGhlIGNvbXBvbmVudCdzIHBrZy1jb25maWcg bmFtZSAoZWcuICJnc3RyZWFtZXItMS4wIiwgb3IgImdzdHJlYW1lci12aWRlby0xLjAiKS4KLSMg ICBfaGVhZGVyIGlzIHRoZSBjb21wb25lbnQncyBoZWFkZXIsIHJlbGF0aXZlIHRvIHRoZSBnc3Ry ZWFtZXItMS4wIGRpcmVjdG9yeSAoZWcuICJnc3QvZ3N0LmgiKS4KICMgICBfbGlicmFyeSBpcyB0 aGUgY29tcG9uZW50J3MgbGlicmFyeSBuYW1lIChlZy4gImdzdHJlYW1lci0xLjAiIG9yICJnc3R2 aWRlby0xLjAiKQotbWFjcm8oRklORF9HU1RSRUFNRVJfQ09NUE9ORU5UIF9jb21wb25lbnRfcHJl Zml4IF9wa2djb25maWdfbmFtZSBfaGVhZGVyIF9saWJyYXJ5KQotICAgIHBrZ19jaGVja19tb2R1 bGVzKFBDXyR7X2NvbXBvbmVudF9wcmVmaXh9IFFVSUVUICR7X3BrZ2NvbmZpZ19uYW1lfSkKK21h Y3JvKEZJTkRfR1NUUkVBTUVSX0NPTVBPTkVOVCBfY29tcG9uZW50X3ByZWZpeCBfcGtnY29uZmln X25hbWUgX2xpYnJhcnkpCiAKLSAgICBmaW5kX3BhdGgoJHtfY29tcG9uZW50X3ByZWZpeH1fSU5D TFVERV9ESVJTCi0gICAgICAgIE5BTUVTICR7X2hlYWRlcn0KLSAgICAgICAgSElOVFMgJHtQQ18k e19jb21wb25lbnRfcHJlZml4fV9JTkNMVURFX0RJUlN9ICR7UENfJHtfY29tcG9uZW50X3ByZWZp eH1fSU5DTFVERURJUn0KLSAgICAgICAgUEFUSF9TVUZGSVhFUyBnc3RyZWFtZXItMS4wCi0gICAg KQorICAgIHN0cmluZyhSRUdFWCBNQVRDSCAiKC4qKT49KC4qKSIgX2R1bW15ICIke19wa2djb25m aWdfbmFtZX0iKQorICAgIGlmICgiJHtDTUFLRV9NQVRDSF8yfSIgU1RSRVFVQUwgIiIpCisgICAg ICAgIHBrZ19jaGVja19tb2R1bGVzKFBDXyR7X2NvbXBvbmVudF9wcmVmaXh9ICIke19wa2djb25m aWdfbmFtZX0gPj0gJHtHU3RyZWFtZXJfRklORF9WRVJTSU9OfSIpCisgICAgZWxzZSAoKQorICAg ICAgICBwa2dfY2hlY2tfbW9kdWxlcyhQQ18ke19jb21wb25lbnRfcHJlZml4fSAke19wa2djb25m aWdfbmFtZX0pCisgICAgZW5kaWYgKCkKKyAgICBzZXQoJHtfY29tcG9uZW50X3ByZWZpeH1fSU5D TFVERV9ESVJTICR7UENfJHtfY29tcG9uZW50X3ByZWZpeH1fSU5DTFVERV9ESVJTfSkKIAogICAg IGZpbmRfbGlicmFyeSgke19jb21wb25lbnRfcHJlZml4fV9MSUJSQVJJRVMKICAgICAgICAgTkFN RVMgJHtfbGlicmFyeX0KQEAgLTc0LDQyICs3NCwyMCBAQCBlbmRtYWNybygpCiAjIC0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQogCiAjIDEuMS4gRmluZCBoZWFkZXJzIGFuZCBsaWJyYXJpZXMKLUZJ TkRfR1NUUkVBTUVSX0NPTVBPTkVOVChHU1RSRUFNRVIgZ3N0cmVhbWVyLTEuMCBnc3QvZ3N0Lmgg Z3N0cmVhbWVyLTEuMCkKLUZJTkRfR1NUUkVBTUVSX0NPTVBPTkVOVChHU1RSRUFNRVJfQkFTRSBn c3RyZWFtZXItYmFzZS0xLjAgZ3N0L2Jhc2UvZ3N0YWRhcHRlci5oIGdzdGJhc2UtMS4wKQotCi0j IDEuMi4gQ2hlY2sgR1N0cmVhbWVyIHZlcnNpb24KLWlmIChHU1RSRUFNRVJfSU5DTFVERV9ESVJT KQotICAgIGlmIChFWElTVFMgIiR7R1NUUkVBTUVSX0lOQ0xVREVfRElSU30vZ3N0L2dzdHZlcnNp b24uaCIpCi0gICAgICAgIGZpbGUoUkVBRCAiJHtHU1RSRUFNRVJfSU5DTFVERV9ESVJTfS9nc3Qv Z3N0dmVyc2lvbi5oIiBHU1RSRUFNRVJfVkVSU0lPTl9DT05URU5UUykKLQotICAgICAgICBzdHJp bmcoUkVHRVggTUFUQ0ggIiNkZWZpbmUgK0dTVF9WRVJTSU9OX01BSk9SICtcXCgoWzAtOV0rKVxc KSIgX2R1bW15ICIke0dTVFJFQU1FUl9WRVJTSU9OX0NPTlRFTlRTfSIpCi0gICAgICAgIHNldChH U1RSRUFNRVJfVkVSU0lPTl9NQUpPUiAiJHtDTUFLRV9NQVRDSF8xfSIpCi0KLSAgICAgICAgc3Ry aW5nKFJFR0VYIE1BVENIICIjZGVmaW5lICtHU1RfVkVSU0lPTl9NSU5PUiArXFwoKFswLTldKylc XCkiIF9kdW1teSAiJHtHU1RSRUFNRVJfVkVSU0lPTl9DT05URU5UU30iKQotICAgICAgICBzZXQo R1NUUkVBTUVSX1ZFUlNJT05fTUlOT1IgIiR7Q01BS0VfTUFUQ0hfMX0iKQotCi0gICAgICAgIHN0 cmluZyhSRUdFWCBNQVRDSCAiI2RlZmluZSArR1NUX1ZFUlNJT05fTUlDUk8gK1xcKChbMC05XSsp XFwpIiBfZHVtbXkgIiR7R1NUUkVBTUVSX1ZFUlNJT05fQ09OVEVOVFN9IikKLSAgICAgICAgc2V0 KEdTVFJFQU1FUl9WRVJTSU9OX01JQ1JPICIke0NNQUtFX01BVENIXzF9IikKLQotICAgICAgICBz ZXQoR1NUUkVBTUVSX1ZFUlNJT04gIiR7R1NUUkVBTUVSX1ZFUlNJT05fTUFKT1J9LiR7R1NUUkVB TUVSX1ZFUlNJT05fTUlOT1J9LiR7R1NUUkVBTUVSX1ZFUlNJT05fTUlDUk99IikKLSAgICBlbmRp ZiAoKQotZW5kaWYgKCkKLQotaWYgKCIke0dTdHJlYW1lcl9GSU5EX1ZFUlNJT059IiBWRVJTSU9O X0dSRUFURVIgIiR7R1NUUkVBTUVSX1ZFUlNJT059IikKLSAgICBtZXNzYWdlKEZBVEFMX0VSUk9S ICJSZXF1aXJlZCB2ZXJzaW9uICgiICR7R1N0cmVhbWVyX0ZJTkRfVkVSU0lPTn0gIikgaXMgaGln aGVyIHRoYW4gZm91bmQgdmVyc2lvbiAoIiAke0dTVFJFQU1FUl9WRVJTSU9OfSAiKSIpCi1lbmRp ZiAoKQorRklORF9HU1RSRUFNRVJfQ09NUE9ORU5UKEdTVFJFQU1FUiBnc3RyZWFtZXItMS4wIGdz dHJlYW1lci0xLjApCitGSU5EX0dTVFJFQU1FUl9DT01QT05FTlQoR1NUUkVBTUVSX0JBU0UgZ3N0 cmVhbWVyLWJhc2UtMS4wIGdzdGJhc2UtMS4wKQogCiAjIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0KICMgMi4gRmluZCBHU3RyZWFtZXIgcGx1Z2lucwogIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCiAKLUZJTkRfR1NUUkVBTUVSX0NPTVBPTkVOVChHU1RSRUFNRVJfQVBQIGdzdHJlYW1lci1h cHAtMS4wIGdzdC9hcHAvZ3N0YXBwc2luay5oIGdzdGFwcC0xLjApCi1GSU5EX0dTVFJFQU1FUl9D T01QT05FTlQoR1NUUkVBTUVSX0FVRElPIGdzdHJlYW1lci1hdWRpby0xLjAgZ3N0L2F1ZGlvL2F1 ZGlvLmggZ3N0YXVkaW8tMS4wKQotRklORF9HU1RSRUFNRVJfQ09NUE9ORU5UKEdTVFJFQU1FUl9G RlQgZ3N0cmVhbWVyLWZmdC0xLjAgZ3N0L2ZmdC9nc3RmZnQuaCBnc3RmZnQtMS4wKQotRklORF9H U1RSRUFNRVJfQ09NUE9ORU5UKEdTVFJFQU1FUl9NUEVHVFMgZ3N0cmVhbWVyLW1wZWd0cy0xLjA+ PTEuNC4wIGdzdC9tcGVndHMvbXBlZ3RzLmggZ3N0bXBlZ3RzLTEuMCkKLUZJTkRfR1NUUkVBTUVS X0NPTVBPTkVOVChHU1RSRUFNRVJfUEJVVElMUyBnc3RyZWFtZXItcGJ1dGlscy0xLjAgZ3N0L3Bi dXRpbHMvcGJ1dGlscy5oIGdzdHBidXRpbHMtMS4wKQotRklORF9HU1RSRUFNRVJfQ09NUE9ORU5U KEdTVFJFQU1FUl9UQUcgZ3N0cmVhbWVyLXRhZy0xLjAgZ3N0L3RhZy90YWcuaCBnc3R0YWctMS4w KQotRklORF9HU1RSRUFNRVJfQ09NUE9ORU5UKEdTVFJFQU1FUl9WSURFTyBnc3RyZWFtZXItdmlk ZW8tMS4wIGdzdC92aWRlby92aWRlby5oIGdzdHZpZGVvLTEuMCkKK0ZJTkRfR1NUUkVBTUVSX0NP TVBPTkVOVChHU1RSRUFNRVJfQVBQIGdzdHJlYW1lci1hcHAtMS4wIGdzdGFwcC0xLjApCitGSU5E X0dTVFJFQU1FUl9DT01QT05FTlQoR1NUUkVBTUVSX0FVRElPIGdzdHJlYW1lci1hdWRpby0xLjAg Z3N0YXVkaW8tMS4wKQorRklORF9HU1RSRUFNRVJfQ09NUE9ORU5UKEdTVFJFQU1FUl9GRlQgZ3N0 cmVhbWVyLWZmdC0xLjAgZ3N0ZmZ0LTEuMCkKK0ZJTkRfR1NUUkVBTUVSX0NPTVBPTkVOVChHU1RS RUFNRVJfTVBFR1RTIGdzdHJlYW1lci1tcGVndHMtMS4wPj0xLjQuMCBnc3RtcGVndHMtMS4wKQor RklORF9HU1RSRUFNRVJfQ09NUE9ORU5UKEdTVFJFQU1FUl9QQlVUSUxTIGdzdHJlYW1lci1wYnV0 aWxzLTEuMCBnc3RwYnV0aWxzLTEuMCkKK0ZJTkRfR1NUUkVBTUVSX0NPTVBPTkVOVChHU1RSRUFN RVJfVEFHIGdzdHJlYW1lci10YWctMS4wIGdzdHRhZy0xLjApCitGSU5EX0dTVFJFQU1FUl9DT01Q T05FTlQoR1NUUkVBTUVSX1ZJREVPIGdzdHJlYW1lci12aWRlby0xLjAgZ3N0dmlkZW8tMS4wKQog CiAjIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogIyAz LiBQcm9jZXNzIHRoZSBDT01QT05FTlRTIHBhc3NlZCB0byBGSU5EX1BBQ0tBR0UKLS0gCjIuMS4z