138870 2014-11-19 07:09:28 -0800 [WinCairo] Compile error when CSS_SELECTORS_LEVEL4 is not enabled. 2014-11-19 16:21:07 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned alex.christensen benjamin bfulgham commit-queue kling oldest_to_newest 1049771 0 peavo 2014-11-19 07:09:28 -0800 WebCore/css/CSSSelector.cpp has some compile errors when CSS_SELECTORS_LEVEL4 is not enabled. 1049772 1 241858 peavo 2014-11-19 07:16:52 -0800 Created attachment 241858 Patch 1049785 2 alex.christensen 2014-11-19 08:44:50 -0800 It looks like this was forgotten in https://bugs.webkit.org/show_bug.cgi?id=138822 1049792 3 241858 commit-queue 2014-11-19 09:23:05 -0800 Comment on attachment 241858 Patch Clearing flags on attachment: 241858 Committed r176319: <http://trac.webkit.org/changeset/176319> 1049793 4 commit-queue 2014-11-19 09:23:09 -0800 All reviewed patches have been landed. Closing bug. 1049842 5 peavo 2014-11-19 11:02:05 -0800 (In reply to comment #2) > It looks like this was forgotten in > https://bugs.webkit.org/show_bug.cgi?id=138822 Thanks for the review :) 1049980 6 benjamin 2014-11-19 16:21:07 -0800 Arg, sorry. Thanks for fixing! 241858 2014-11-19 07:16:52 -0800 2014-11-19 09:23:05 -0800 Patch bug-138870-20141119161653.patch text/plain 1378 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjMxNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTExLTE5ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29t cGlsZSBlcnJvciB3aGVuIENTU19TRUxFQ1RPUlNfTEVWRUw0IGlzIG5vdCBlbmFibGVkLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4ODcwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjc3MvQ1NTU2Vs ZWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6c2ltcGxlU2VsZWN0b3JTcGVjaWZpY2l0eUlu dGVybmFsKToKKwogMjAxNC0xMS0xOSAgRGhpIEF1cnJhaG1hbiAgPGRpb3JhaG1hbkByb2NreWJh cnMuY29tPgogCiAgICAgICAgIEFkZCBzZWxlY3RvciBjaGVja2VyIGZvciA6bGFuZyBwc2V1ZG8g Y2xhc3MgaW4gU2VsZWN0b3JzIGxldmVsIDQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NT ZWxlY3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9y LmNwcAkocmV2aXNpb24gMTc2MzE1KQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9y LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTExLDggKzExMSw4IEBAIHN0YXRpYyB1bnNpZ25lZCBz aW1wbGVTZWxlY3RvclNwZWNpZmljaXQKICAgICAgICAgfQogICAgICAgICBGQUxMVEhST1VHSDsK ICNlbHNlCi0gICAgICAgIGlmIChwc2V1ZG9DbGFzc1R5cGUoKSA9PSBQc2V1ZG9DbGFzc05vdCAm JiBzZWxlY3Rvckxpc3QoKSkKLSAgICAgICAgICAgIHJldHVybiBzZWxlY3Rvckxpc3QoKS0+Zmly c3QoKS0+c2ltcGxlU2VsZWN0b3JTcGVjaWZpY2l0eSgpOworICAgICAgICBpZiAoc2ltcGxlU2Vs ZWN0b3IucHNldWRvQ2xhc3NUeXBlKCkgPT0gQ1NTU2VsZWN0b3I6OlBzZXVkb0NsYXNzTm90ICYm IHNpbXBsZVNlbGVjdG9yLnNlbGVjdG9yTGlzdCgpKQorICAgICAgICAgICAgcmV0dXJuIHNpbXBs ZVNlbGVjdG9yLnNlbGVjdG9yTGlzdCgpLT5maXJzdCgpLT5zaW1wbGVTZWxlY3RvclNwZWNpZmlj aXR5KCk7CiAgICAgICAgIEZBTExUSFJPVUdIOwogI2VuZGlmCiAgICAgY2FzZSBDU1NTZWxlY3Rv cjo6RXhhY3Q6Cg==