138867 2014-11-19 03:52:18 -0800 Missing NULL-check in VideoTrack::setLanguage 2014-11-19 09:53:41 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand calvaris commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble philipj sergio oldest_to_newest 1049755 0 pnormand 2014-11-19 03:52:18 -0800 Here media/track/track-in-band-duplicate-tracks-when-source-changes.html crashes: #0 0x00007f0ccdfc220b in WebCore::HTMLMediaElement::videoTracks() () from /home/phil/dev/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 (gdb) bt #0 0x00007f0ccdfc220b in WebCore::HTMLMediaElement::videoTracks() () from /home/phil/dev/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #1 0x00007f0cce80eabc in WebCore::VideoTrack::setLanguage(WTF::AtomicString const&) () from /home/phil/dev/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #2 0x00007f0cce87e929 in WebCore::TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged() () from /home/phil/dev/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #3 0x00007f0cceecf5fd in WTF::GThreadSafeMainLoopSource::voidCallback() () from /home/phil/dev/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #4 0x00007f0ccbc6ce1a in WTF::GMainLoopSource::voidSourceCallback(WTF::GMainLoopSource*) () from /home/phil/dev/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #5 0x00007f0cc93127ed in g_main_dispatch (context=0x10ff820) at gmain.c:3064 #6 g_main_context_dispatch (context=context@entry=0x10ff820) at gmain.c:3663 #7 0x00007f0cc9312b88 in g_main_context_iterate (context=0x10ff820, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3734 #8 0x00007f0cc9312ea2 in g_main_loop_run (loop=0x16a0130) at gmain.c:3928 #9 0x00007f0ccdb07771 in WebProcessMainUnix () from /home/phil/dev/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #10 0x00007f0ccbfbdb45 in __libc_start_main (main=0x400730 <main>, argc=2, argv=0x7fffbed03068, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffbed03058) at libc-start.c:287 #11 0x0000000000400784 in _start () 1049756 1 pnormand 2014-11-19 03:52:57 -0800 ::videoTracks() can indeed return 0 if the video track feature is not enabled at runtime. 1049757 2 241853 pnormand 2014-11-19 04:08:58 -0800 Created attachment 241853 Patch 1049810 3 pnormand 2014-11-19 09:53:41 -0800 Committed r176322: <http://trac.webkit.org/changeset/176322> 241853 2014-11-19 04:08:58 -0800 2014-11-19 08:08:07 -0800 Patch bug-138867-20141119130911.patch text/plain 1480 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2MzExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTNjMGY5MWQ5MDk5YjI0 OTgzN2U0OGIyYzExNjI3MjRiZTBmYjUxOS4uZjA2OTk4MGQwNWFmNzJhYTM1M2E1MDVhZjNlNTVi MmNlOGNiMjc0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTExLTE5ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBNaXNzaW5nIE5V TEwtY2hlY2sgaW4gVmlkZW9UcmFjazo6c2V0TGFuZ3VhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODg2NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC90cmFjay9WaWRlb1RyYWNrLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlZpZGVvVHJhY2s6OnNldExhbmd1YWdlKTogUHJldmVudCBjaGFu Z2UgZXZlbnQgY3JlYXRpb24KKyAgICAgICAgb24gYW4gZW1wdHkgdmlkZW8gdHJhY2sgbGlzdC4K KwogMjAxNC0xMS0xOCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAK ICAgICAgICAgc3RhcnQvc3RvcCBtZXRob2QgZm9yIEF1ZGlvQnVmZmVyU291cmNlTm9kZXMgYW5k IE9zY2lsbGF0b3JOb2RlcyBjYW4gdGFrZSBubyBhcmdzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL3RyYWNrL1ZpZGVvVHJhY2suY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC90cmFj ay9WaWRlb1RyYWNrLmNwcAppbmRleCBiYmRjOTBkZGZiYzEzYzEyZGRiMWIzOGQxMTI4OThiOTFi MTEzOTMzLi45NzRlNDk3ODc3NTczZDJlOTdlN2Y0ZDNkNmNiNGQ4YzY5ZDA3ZWExIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1ZpZGVvVHJhY2suY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvdHJhY2svVmlkZW9UcmFjay5jcHAKQEAgLTIxNyw3ICsyMTcsOCBAQCB2 b2lkIFZpZGVvVHJhY2s6OnNldExhbmd1YWdlKGNvbnN0IEF0b21pY1N0cmluZyYgbGFuZ3VhZ2Up CiAKICAgICAvLyA0LiBRdWV1ZSBhIHRhc2sgdG8gZmlyZSBhIHNpbXBsZSBldmVudCBuYW1lZCBj aGFuZ2UgYXQgdGhlIFZpZGVvVHJhY2tMaXN0IG9iamVjdCByZWZlcmVuY2VkIGJ5CiAgICAgLy8g dGhlIHZpZGVvVHJhY2tzIGF0dHJpYnV0ZSBvbiB0aGUgSFRNTE1lZGlhRWxlbWVudC4KLSAgICBt ZWRpYUVsZW1lbnQoKS0+dmlkZW9UcmFja3MoKS0+c2NoZWR1bGVDaGFuZ2VFdmVudCgpOworICAg IGlmIChtZWRpYUVsZW1lbnQoKS0+dmlkZW9UcmFja3MoKSkKKyAgICAgICAgbWVkaWFFbGVtZW50 KCktPnZpZGVvVHJhY2tzKCktPnNjaGVkdWxlQ2hhbmdlRXZlbnQoKTsKIH0KICNlbmRpZgogCg==