138865 2014-11-19 02:42:38 -0800 [EFL] REGRESSION(176066): It made all performance tests fail 2014-11-24 12:48:39 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Blocker --- 138245 1 ossy ryuan.choi commit-queue gyuyoung.kim ossy ryuan.choi oldest_to_newest 1049752 0 ossy 2014-11-19 02:42:38 -0800 before: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2%20%28Perf%29/builds/3764 after: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2%20%28Perf%29/builds/3765 After https://trac.webkit.org/changeset/176066 performance tests fail with EFL 1.11 and 1.12 too. ( https://trac.webkit.org/changeset/176196 bumped EFL version to 1.12 ) 1050440 1 ossy 2014-11-21 05:41:59 -0800 Any idea what is the problem with r176066 and how to fix it? 1050442 2 gyuyoung.kim 2014-11-21 05:59:36 -0800 (In reply to comment #1) > Any idea what is the problem with r176066 and how to fix it? If we can't find it now, I think we have to revert it. 1050445 3 ossy 2014-11-21 06:02:32 -0800 (In reply to comment #2) > (In reply to comment #1) > > Any idea what is the problem with r176066 and how to fix it? > If we can't find it now, I think we have to revert it. Unfortunaltely bumping EFL to 1.12 depends on r176066, so we should try to avoid reverting them. 1050446 4 gyuyoung.kim 2014-11-21 06:19:45 -0800 (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > Any idea what is the problem with r176066 and how to fix it? > > If we can't find it now, I think we have to revert it. > > Unfortunaltely bumping EFL to 1.12 depends on r176066, > so we should try to avoid reverting them. ok, Ryuan's patch might be reason of test failures. Ryuan, can you check it ? 1050852 5 gyuyoung.kim 2014-11-24 07:49:05 -0800 When I run performance test locally using below command, all tests are failures regardless of r176066. I will run performance test without EFL 1.12. $> ./Tools/Scripts/run-perf-tests --platform=efl --release --webkit-test-runner Running Bindings/document-implementation.html (4 of 141) error: Bindings/document-implementation.html ERR<23647>:evas_main lib/evas/canvas/evas_gl.c:42 evas_gl_new() Evas GL engine not available. ERR<23657>: lib/eina/eina_module.c:263 eina_module_new() safety check failed: len > 0 is false ERR<23647>:efreet_cache lib/efreet/efreet_cache.c:1108 on_send_register() org.freedesktop.DBus.Error.ServiceUnknown The name org.enlightenment.Efreet was not provided by any .service files FAILED Finished: 6.731030 s 1050853 6 ossy 2014-11-24 07:52:27 -0800 (In reply to comment #5) > When I run performance test locally using below command, all tests are > failures regardless of r176066. I will run performance test without EFL 1.12. > > > $> ./Tools/Scripts/run-perf-tests --platform=efl --release > --webkit-test-runner > > Running Bindings/document-implementation.html (4 of 141) > error: Bindings/document-implementation.html > ERR<23647>:evas_main lib/evas/canvas/evas_gl.c:42 evas_gl_new() Evas GL > engine not available. > ERR<23657>: lib/eina/eina_module.c:263 eina_module_new() safety check > failed: len > 0 is false > ERR<23647>:efreet_cache lib/efreet/efreet_cache.c:1108 on_send_register() > org.freedesktop.DBus.Error.ServiceUnknown The name org.enlightenment.Efreet > was not provided by any .service files > > FAILED > Finished: 6.731030 s Have you set the hacky symlinks to make it work? ( bug134023 ) 1050860 7 242165 ryuan.choi 2014-11-24 08:46:26 -0800 Created attachment 242165 Patch 1050861 8 ryuan.choi 2014-11-24 08:48:32 -0800 (In reply to comment #0) > before: > https://build.webkit.org/builders/EFL%20Linux%2064- > bit%20Release%20WK2%20%28Perf%29/builds/3764 > after: > https://build.webkit.org/builders/EFL%20Linux%2064- > bit%20Release%20WK2%20%28Perf%29/builds/3765 > > After https://trac.webkit.org/changeset/176066 performance tests fail with > EFL 1.11 and 1.12 too. > ( https://trac.webkit.org/changeset/176196 bumped EFL version to 1.12 ) Sorry, I was little bit busy. It's because of destruction order between Evas_GL and Evas_GL_Surface. 1050862 9 ryuan.choi 2014-11-24 08:50:31 -0800 (In reply to comment #6) > (In reply to comment #5) > > When I run performance test locally using below command, all tests are > > failures regardless of r176066. I will run performance test without EFL 1.12. > > > > > > $> ./Tools/Scripts/run-perf-tests --platform=efl --release > > --webkit-test-runner > > > > Running Bindings/document-implementation.html (4 of 141) > > error: Bindings/document-implementation.html > > ERR<23647>:evas_main lib/evas/canvas/evas_gl.c:42 evas_gl_new() Evas GL > > engine not available. > > ERR<23657>: lib/eina/eina_module.c:263 eina_module_new() safety check > > failed: len > 0 is false > > ERR<23647>:efreet_cache lib/efreet/efreet_cache.c:1108 on_send_register() > > org.freedesktop.DBus.Error.ServiceUnknown The name org.enlightenment.Efreet > > was not provided by any .service files > > > > FAILED > > Finished: 6.731030 s > > Have you set the hacky symlinks to make it work? ( bug134023 ) Or, below might be required to run run-perf-tests in a local. export DISABLE_XVFB_DRIVER=1 1050872 10 242165 ossy 2014-11-24 12:10:57 -0800 Comment on attachment 242165 Patch rs=me 1050878 11 242165 commit-queue 2014-11-24 12:48:35 -0800 Comment on attachment 242165 Patch Clearing flags on attachment: 242165 Committed r176522: <http://trac.webkit.org/changeset/176522> 1050879 12 commit-queue 2014-11-24 12:48:39 -0800 All reviewed patches have been landed. Closing bug. 242165 2014-11-24 08:46:26 -0800 2014-11-24 12:48:35 -0800 Patch bug-138865-20141125014642.patch text/plain 1366 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2MzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjNjNmJiZDk1MDU2MjZk NTMyYjAzZGIwYjlkNjU3ZTJkYTM0MTQxMi4uZjA5OTg3NTNjODJiMjAzYjI5ZWJjNzc5ODYzZmIx ZDUyYjI0Mzg1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTExLTI0ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtFRkxdIFJFR1JF U1NJT04oMTc2MDY2KTogSXQgbWFkZSBhbGwgcGVyZm9ybWFuY2UgdGVzdHMgZmFpbAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4ODY1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgcjE3NjA2Niwg dGhlcmUgYXJlIGNyYXNoIGJlY2F1c2UgZXZhc19nbF9zdXJmYWNlIGlzIGRlc3Ryb3llZCB3aXRo CisgICAgICAgIGludmFsaWQgZXZhc19nbCBpbnN0YW5jZSBhZnRlciBldmFzX2dsIGlzIGRlc3Ry b3llZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwOgorICAgICAg ICAoRXdrVmlldzo6fkV3a1ZpZXcpOgorCiAyMDE0LTExLTE5ICBNYXJrIFJvd2UgIDxtcm93ZUBh cHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGFuIHVudXNlZCBmaWxlLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcAppbmRleCAxZGIzMTkwNGU0MzdmZTM0 OTE1M2EwMGU5ZjNkNTQwODYxNzE1YzJjLi43ZmYyY2ZmNzRhM2EzYzg3NzBjNTI4YjJhOGEzNzA1 Y2Q1NWFmMzM4IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9F d2tWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3 LmNwcApAQCAtMzUzLDYgKzM1Myw5IEBAIEV3a1ZpZXc6On5Fd2tWaWV3KCkKICAgICBBU1NFUlQo d2tQYWdlVG9FdmFzT2JqZWN0TWFwKCkuZ2V0KHdrUGFnZSgpKSA9PSBtX2V2YXNPYmplY3QpOwog ICAgIHdrUGFnZVRvRXZhc09iamVjdE1hcCgpLnJlbW92ZSh3a1BhZ2UoKSk7CiAKKyAgICBtX2V2 YXNHTFN1cmZhY2UgPSBudWxscHRyOworICAgIG1fZXZhc0dMQ29udGV4dCA9IG51bGxwdHI7CisK ICAgICBpZiAobV9ldmFzR0wpCiAgICAgICAgIGV2YXNfZ2xfZnJlZShtX2V2YXNHTCk7CiB9Cg==