138853 2014-11-18 16:39:29 -0800 REGRESSION: Invoking dictionary lookup on text in some search fields searches for incorrect item 2014-11-18 16:50:31 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin thorton oldest_to_newest 1049650 0 bdakin 2014-11-18 16:39:29 -0800 Applies to the Google search field and the search field on nytimes.com rdar://problem/18912505 1049652 1 241833 bdakin 2014-11-18 16:44:31 -0800 Created attachment 241833 Patch 1049653 2 bdakin 2014-11-18 16:44:55 -0800 This regression was caused by http://trac.webkit.org/changeset/175376 1049655 3 241833 bdakin 2014-11-18 16:46:41 -0800 Comment on attachment 241833 Patch Wrong patch! :P 1049656 4 241834 bdakin 2014-11-18 16:47:18 -0800 Created attachment 241834 Patch 1049658 5 bdakin 2014-11-18 16:50:31 -0800 Thank you! http://trac.webkit.org/changeset/176296 241833 2014-11-18 16:44:31 -0800 2014-11-18 16:46:41 -0800 Patch for-review.txt text/plain 1843 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjIzNikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTExLTE3ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBQcmV2aWV3IGlzIHNvbWV0aW1lcyBk aXNtaXNzZWQgdG9vIGVhcmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzg4MTEKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICBy ZGFyOi8vcHJvYmxlbS8xODkwMDgzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIERvbuKAmXQgbWFrZSB0aGUgcG9wb3ZlciB0cmFuc2llbnQgdW50aWwg ZGlkQ2xvc2VNZW51OiB0aW1lLgorICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tBY3Rpb25NZW51 Q29udHJvbGxlci5tbToKKyAgICAgICAgKC1bV0tBY3Rpb25NZW51Q29udHJvbGxlciBkaWRDbG9z ZU1lbnU6d2l0aEV2ZW50Ol0pOgorICAgICAgICAoLVtXS0FjdGlvbk1lbnVDb250cm9sbGVyIF9j cmVhdGVQcmV2aWV3UG9wb3ZlckZvclVSTDpvcmlnaW5SZWN0Ol0pOgorCiAyMDE0LTExLTE3ICBE YW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBy b2xsaW5nIG91dCByMTc2MjMyLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9X S0FjdGlvbk1lbnVDb250cm9sbGVyLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9tYWMvV0tBY3Rpb25NZW51Q29udHJvbGxlci5tbQkocmV2aXNpb24gMTc2MjIwKQor KysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLm1t CSh3b3JraW5nIGNvcHkpCkBAIC0yMzEsNiArMjMxLDcgQEAgLSAodm9pZClkaWRDbG9zZU1lbnU6 KE5TTWVudSAqKW1lbnUgd2l0aAogICAgICAgICAgICAgW2dldEREQWN0aW9uc01hbmFnZXJDbGFz cygpIGRpZFVzZUFjdGlvbnNdOwogICAgIH0KIAorICAgIFtfcHJldmlld1BvcG92ZXIgc2V0QmVo YXZpb3I6TlNQb3BvdmVyQmVoYXZpb3JUcmFuc2llbnRdOwogICAgIGlmICghX3Nob3VsZEtlZXBQ cmV2aWV3UG9wb3Zlck9wZW4pCiAgICAgICAgIFtzZWxmIF9jbGVhclByZXZpZXdQb3BvdmVyXTsK IApAQCAtMzM4LDcgKzMzOSw3IEBAIC0gKHZvaWQpX2NyZWF0ZVByZXZpZXdQb3BvdmVyRm9yVVJM OihOU1UKICAgICBfcHJldmlld1ZpZXdDb250cm9sbGVyLT5fZGVsZWdhdGUgPSBzZWxmOwogCiAg ICAgX3ByZXZpZXdQb3BvdmVyID0gYWRvcHROUyhbW05TUG9wb3ZlciBhbGxvY10gaW5pdF0pOwot ICAgIFtfcHJldmlld1BvcG92ZXIgc2V0QmVoYXZpb3I6TlNQb3BvdmVyQmVoYXZpb3JUcmFuc2ll bnRdOworICAgIFtfcHJldmlld1BvcG92ZXIgc2V0QmVoYXZpb3I6TlNQb3BvdmVyQmVoYXZpb3JB cHBsaWNhdGlvbkRlZmluZWRdOwogICAgIFtfcHJldmlld1BvcG92ZXIgc2V0Q29udGVudFNpemU6 cG9wb3ZlclNpemVdOwogICAgIFtfcHJldmlld1BvcG92ZXIgc2V0Q29udGVudFZpZXdDb250cm9s bGVyOl9wcmV2aWV3Vmlld0NvbnRyb2xsZXIuZ2V0KCldOwogICAgIFtfcHJldmlld1BvcG92ZXIg c2V0RGVsZWdhdGU6c2VsZl07Cg== 241834 2014-11-18 16:47:18 -0800 2014-11-18 16:48:46 -0800 Patch for-review.txt text/plain 1739 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjI5NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTExLTE4ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBJbnZva2luZyBk aWN0aW9uYXJ5IGxvb2t1cCBvbiB0ZXh0IGluIHNvbWUgc2VhcmNoIGZpZWxkcyBzZWFyY2hlcyBm b3IgCisgICAgICAgIGluY29ycmVjdCBpdGVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg4NTMKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQor ICAgICAgICByZGFyOi8vcHJvYmxlbS8xODkxMjUwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEdldCB0aGUgdmlzaWJsZSBwb3NpdGlvbiBiYXNlZCBv biB0aGUgZnJhbWUsIG5vdCBqdXN0IHRoZSByZW5kZXJlci4KKyAgICAgICAgKiBlZGl0aW5nL21h Yy9EaWN0aW9uYXJ5TG9va3VwLm1tOgorICAgICAgICAoV2ViQ29yZTo6cmFuZ2VGb3JEaWN0aW9u YXJ5TG9va3VwQXRIaXRUZXN0UmVzdWx0KToKKwogMjAxNC0xMS0xOCAgRGF2aWQgSHlhdHQgIDxo eWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjE2NzIxMCk6IEludmFsaWQg Y2FzdCBpbiBXZWJDb3JlOjpSZW5kZXJCbG9jazo6YmxvY2tTZWxlY3Rpb25HYXBzCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hYy9EaWN0aW9uYXJ5TG9va3VwLm1tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFjL0RpY3Rpb25hcnlMb29rdXAubW0JKHJldmlz aW9uIDE3NjIzOSkKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFjL0RpY3Rpb25hcnlMb29r dXAubW0JKHdvcmtpbmcgY29weSkKQEAgLTEzNywxMCArMTM3LDExIEBAIFBhc3NSZWZQdHI8UmFu Z2U+IHJhbmdlRm9yRGljdGlvbmFyeUxvb2sKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAKICAg ICAvLyBEb24ndCBkbyBhbnl0aGluZyBpZiB0aGVyZSBpcyBubyBjaGFyYWN0ZXIgYXQgdGhlIHBv aW50LgotICAgIGlmICghZnJhbWUtPnJhbmdlRm9yUG9pbnQoaGl0VGVzdFJlc3VsdC5yb3VuZGVk UG9pbnRJbklubmVyTm9kZUZyYW1lKCkpKQorICAgIEludFBvaW50IGZyYW1lUG9pbnQgPSBoaXRU ZXN0UmVzdWx0LnJvdW5kZWRQb2ludEluSW5uZXJOb2RlRnJhbWUoKTsKKyAgICBpZiAoIWZyYW1l LT5yYW5nZUZvclBvaW50KGZyYW1lUG9pbnQpKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAot ICAgIFZpc2libGVQb3NpdGlvbiBwb3NpdGlvbiA9IHJlbmRlcmVyLT5wb3NpdGlvbkZvclBvaW50 KGhpdFRlc3RSZXN1bHQubG9jYWxQb2ludCgpLCBudWxscHRyKTsKKyAgICBWaXNpYmxlUG9zaXRp b24gcG9zaXRpb24gPSBmcmFtZS0+dmlzaWJsZVBvc2l0aW9uRm9yUG9pbnQoZnJhbWVQb2ludCk7 CiAgICAgaWYgKHBvc2l0aW9uLmlzTnVsbCgpKQogICAgICAgICBwb3NpdGlvbiA9IGZpcnN0UG9z aXRpb25Jbk9yQmVmb3JlTm9kZShub2RlKTsKIAo=