138848 2014-11-18 15:54:33 -0800 Don't let web process go to suspended state if there is active network request. 2014-11-19 21:49:52 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified NEW InRadar P2 Normal --- 138582 1 yongjun_zhang webkit-unassigned ap ddkilzer mitz sam thorton oldest_to_newest 1049620 0 yongjun_zhang 2014-11-18 15:54:33 -0800 <rdar://problem/18846532> 1049638 1 241829 yongjun_zhang 2014-11-18 16:25:23 -0800 Created attachment 241829 Also acquire the activity token when we have active network requests on progress. 1049645 2 241829 thorton 2014-11-18 16:35:19 -0800 Comment on attachment 241829 Also acquire the activity token when we have active network requests on progress. It seems very wrong to keep the Web process from going to sleep for very long XHR/etc., seems like this will just result in a lot of very awake processes consuming all of your power, no? 1049651 3 yongjun_zhang 2014-11-18 16:41:23 -0800 (In reply to comment #2) > Comment on attachment 241829 [details] > Also acquire the activity token when we have active network requests on > progress. > > It seems very wrong to keep the Web process from going to sleep for very > long XHR/etc., seems like this will just result in a lot of very awake > processes consuming all of your power, no? With the changes in https://bugs.webkit.org/show_bug.cgi?id=138582, we won't track long XHR or sub-resources after the main frame has loaded, and these sub-resources won't keep the process awake. 1049719 4 ap 2014-11-18 22:24:16 -0800 It may be worth re-titling the bug for accuracy, "active network request" may not be the best description for what progress tracker does. 1050055 5 yongjun_zhang 2014-11-19 21:49:52 -0800 This patch has the risk of holding web process too long if there is a long lasting XHR that has started before main frame has loaded. I will look at a different approach. 241829 2014-11-18 16:25:23 -0800 2014-11-18 16:35:19 -0800 Also acquire the activity token when we have active network requests on progress. activity_token.patch text/plain 3851 yongjun_zhang Y29tbWl0IDVmMzEzOGRiYmQ5NjQ2NjUzMDZiNjAzZmRmNWJhYThhNjhjOWUyZTMKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBUdWUgTm92IDE4 IDE1OjMzOjQwIDIwMTQgLTA4MDAKCiAgICBEb24ndCBsZXQgd2ViIHByb2Nlc3MgZ28gdG8gc3Vz cGVuZGVkIHN0YXRlIGlmIHRoZXJlIGlzIGFjdGl2ZSBuZXR3b3JrIHJlcXVlc3QuCiAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4ODQ4CiAgICAKICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogICAgCiAgICBBbHNvIGFjcXVpcmUgdGhlIGJhY2tncm91 bmQgYWN0aXZpdHkgdG9rZW4gaWYgdGhlcmUgYXJlIG5ldHdvcmsgcmVxdWVzdHMgaW4gcHJvZ3Jl c3MuIFRoaXMKICAgIHByZXZlbnRzIGJhY2tncm91bmQgcHJvY2VzcyBnZXR0aW5nIHN1c3BlbmRl ZCB3aGVuIHRoZXJlIGFyZSBhY3RpdmUgbmV0d29yayByZXF1ZXN0cyBpbiBwcm9ncmVzcy4KICAg IAogICAgKiBVSVByb2Nlc3MvQ29jb2EvTmF2aWdhdGlvblN0YXRlLmg6IEFkZCBhIGhlbHBlciBt ZXRob2QgdXBkYXRlQWN0aXZpdHlUb2tlbigpLgogICAgKiBVSVByb2Nlc3MvQ29jb2EvTmF2aWdh dGlvblN0YXRlLm1tOgogICAgKFdlYktpdDo6TmF2aWdhdGlvblN0YXRlOjp1cGRhdGVBY3Rpdml0 eVRva2VuKToKICAgIChXZWJLaXQ6Ok5hdmlnYXRpb25TdGF0ZTo6ZGlkQ2hhbmdlSXNMb2FkaW5n KTogQWNxdWlyZSB0aGUgdG9rZW4gaWYgd2UgYXJlIHRyYW5zaXRpb24gdG8KICAgICAgICBsb2Fk aW5nIHN0YXRlIG9yIGlmIHdlIGhhdmUgbmV0d29yayByZXF1ZXN0cyBpbiBwcm9ncmVzcy4KICAg IChXZWJLaXQ6Ok5hdmlnYXRpb25TdGF0ZTo6ZGlkQ2hhbmdlTmV0d29ya1JlcXVlc3RzSW5Qcm9n cmVzcyk6IERpdHRvLgoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAxNmQyNWJjLi45ODI4YTJhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMjAgQEAKKzIwMTQtMTEtMTggIFlvbmdqdW4gWmhhbmcgIDx5b25nanVuX3po YW5nQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBsZXQgd2ViIHByb2Nlc3MgZ28gdG8gc3Vz cGVuZGVkIHN0YXRlIGlmIHRoZXJlIGlzIGFjdGl2ZSBuZXR3b3JrIHJlcXVlc3QuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg4NDgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbHNvIGFjcXVpcmUgdGhl IGJhY2tncm91bmQgYWN0aXZpdHkgdG9rZW4gaWYgdGhlcmUgYXJlIG5ldHdvcmsgcmVxdWVzdHMg aW4gcHJvZ3Jlc3MuIFRoaXMKKyAgICAgICAgcHJldmVudHMgYmFja2dyb3VuZCBwcm9jZXNzIGdl dHRpbmcgc3VzcGVuZGVkIHdoZW4gdGhlcmUgYXJlIGFjdGl2ZSBuZXR3b3JrIHJlcXVlc3RzIGlu IHByb2dyZXNzLgorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0ZS5o OiBBZGQgYSBoZWxwZXIgbWV0aG9kIHVwZGF0ZUFjdGl2aXR5VG9rZW4oKS4KKyAgICAgICAgKiBV SVByb2Nlc3MvQ29jb2EvTmF2aWdhdGlvblN0YXRlLm1tOgorICAgICAgICAoV2ViS2l0OjpOYXZp Z2F0aW9uU3RhdGU6OnVwZGF0ZUFjdGl2aXR5VG9rZW4pOgorICAgICAgICAoV2ViS2l0OjpOYXZp Z2F0aW9uU3RhdGU6OmRpZENoYW5nZUlzTG9hZGluZyk6IEFjcXVpcmUgdGhlIHRva2VuIGlmIHdl IGFyZSB0cmFuc2l0aW9uIHRvCisgICAgICAgICAgICBsb2FkaW5nIHN0YXRlIG9yIGlmIHdlIGhh dmUgbmV0d29yayByZXF1ZXN0cyBpbiBwcm9ncmVzcy4KKyAgICAgICAgKFdlYktpdDo6TmF2aWdh dGlvblN0YXRlOjpkaWRDaGFuZ2VOZXR3b3JrUmVxdWVzdHNJblByb2dyZXNzKTogRGl0dG8uCisK IDIwMTQtMTEtMTggIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZW1vdmVkIHRoZSBjdXN0b20gYWxsb2NhdG9yIGZvciBMaXN0SGFzaFNldCBub2RlcwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0ZS5o IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0ZS5oCmluZGV4 IDEwMTc5ZDIuLmNiYmI1NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9D b2NvYS9OYXZpZ2F0aW9uU3RhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29j b2EvTmF2aWdhdGlvblN0YXRlLmgKQEAgLTE4NCw2ICsxODQsOCBAQCBwcml2YXRlOgogICAgICAg ICBib29sIHdlYlZpZXdEaWRVcGRhdGVIaXN0b3J5VGl0bGVGb3JVUkwgOiAxOwogICAgIH0gbV9o aXN0b3J5RGVsZWdhdGVNZXRob2RzOwogCisgICAgdm9pZCB1cGRhdGVBY3Rpdml0eVRva2VuKCk7 CisKICNpZiBQTEFURk9STShJT1MpCiAgICAgc3RkOjp1bmlxdWVfcHRyPFByb2Nlc3NUaHJvdHRs ZXI6OkJhY2tncm91bmRBY3Rpdml0eVRva2VuPiBtX2FjdGl2aXR5VG9rZW47CiAjZW5kaWYKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUu bW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvTmF2aWdhdGlvblN0YXRlLm1tCmlu ZGV4IDVhNmI3MTQuLjJmMjliYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0NvY29hL05hdmlnYXRpb25TdGF0ZS5tbQpAQCAtODI0LDE1ICs4MjQsMTkgQEAgdm9pZCBOYXZp Z2F0aW9uU3RhdGU6OndpbGxDaGFuZ2VJc0xvYWRpbmcoKQogICAgIFttX3dlYlZpZXcgd2lsbENo YW5nZVZhbHVlRm9yS2V5OkAibG9hZGluZyJdOwogfQogCi12b2lkIE5hdmlnYXRpb25TdGF0ZTo6 ZGlkQ2hhbmdlSXNMb2FkaW5nKCkKK3ZvaWQgTmF2aWdhdGlvblN0YXRlOjp1cGRhdGVBY3Rpdml0 eVRva2VuKCkKIHsKICNpZiBQTEFURk9STShJT1MpCi0gICAgaWYgKG1fd2ViVmlldy0+X3BhZ2Ut PnBhZ2VMb2FkU3RhdGUoKS5pc0xvYWRpbmcoKSkKKyAgICBpZiAobV93ZWJWaWV3LT5fcGFnZS0+ cGFnZUxvYWRTdGF0ZSgpLmlzTG9hZGluZygpIHx8IG1fd2ViVmlldy0+X3BhZ2UtPnBhZ2VMb2Fk U3RhdGUoKS5uZXR3b3JrUmVxdWVzdHNJblByb2dyZXNzKCkpCiAgICAgICAgIG1fYWN0aXZpdHlU b2tlbiA9IHN0ZDo6bWFrZV91bmlxdWU8UHJvY2Vzc1Rocm90dGxlcjo6QmFja2dyb3VuZEFjdGl2 aXR5VG9rZW4+KG1fd2ViVmlldy0+X3BhZ2UtPnByb2Nlc3MoKS50aHJvdHRsZXIoKSk7CiAgICAg ZWxzZQogICAgICAgICBtX2FjdGl2aXR5VG9rZW4gPSBudWxscHRyOwogI2VuZGlmCit9CiAKK3Zv aWQgTmF2aWdhdGlvblN0YXRlOjpkaWRDaGFuZ2VJc0xvYWRpbmcoKQoreworICAgIHVwZGF0ZUFj dGl2aXR5VG9rZW4oKTsKICAgICBbbV93ZWJWaWV3IGRpZENoYW5nZVZhbHVlRm9yS2V5OkAibG9h ZGluZyJdOwogfQogCkBAIC05MDMsNiArOTA3LDcgQEAgdm9pZCBOYXZpZ2F0aW9uU3RhdGU6Ondp bGxDaGFuZ2VOZXR3b3JrUmVxdWVzdHNJblByb2dyZXNzKCkKIAogdm9pZCBOYXZpZ2F0aW9uU3Rh dGU6OmRpZENoYW5nZU5ldHdvcmtSZXF1ZXN0c0luUHJvZ3Jlc3MoKQogeworICAgIHVwZGF0ZUFj dGl2aXR5VG9rZW4oKTsKICAgICBbbV93ZWJWaWV3IGRpZENoYW5nZVZhbHVlRm9yS2V5OkAiX25l dHdvcmtSZXF1ZXN0c0luUHJvZ3Jlc3MiXTsKIH0KIAo=