138846 2014-11-18 14:34:30 -0800 REGRESSION(r152313): Inline-block element doesn't wrap properly 2014-11-18 14:52:08 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt commit-queue esprehn+autocc glenn kondapallykalyan mmaxfield oldest_to_newest 1049597 0 hyatt 2014-11-18 14:34:30 -0800 Inline-block element doesn't wrap properly because of regression regarding empty inline break position testing. 1049598 1 241814 hyatt 2014-11-18 14:37:07 -0800 Created attachment 241814 Patch 1049599 2 241814 simon.fraser 2014-11-18 14:39:12 -0800 Comment on attachment 241814 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241814&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). OOPS! > LayoutTests/fast/inline-block/inline-block-empty-spans-expected.html:4 > + <META http-equiv="Content-Type" content="text/html; charset=UTF-8"> No need for this. > LayoutTests/fast/inline-block/inline-block-empty-spans-expected.html:5 > + <title>FileInput</title> Or this. > LayoutTests/fast/inline-block/inline-block-empty-spans-expected.html:17 > + table { > + width: 130px; > + border-collapse:collapse; > + } > + .button { > + display: inline-block; > + padding: 5px; > + margin: 3px; > + background: green; > + min-width: 100px; > + } Weird spacing. > LayoutTests/fast/inline-block/inline-block-empty-spans-expected.html:31 > + <td> > + <div> > + <span class="button">One</span> > + <span class="button">Two</span> > + <span class="button">Three</span> > + </div> > + </td> > + </tr> Weird whitespace. Tabs? > LayoutTests/fast/inline-block/inline-block-empty-spans.html:5 > + <META http-equiv="Content-Type" content="text/html; charset=UTF-8"> > + <title>FileInput</title> Boo > LayoutTests/fast/inline-block/inline-block-empty-spans.html:17 > + table { > + width: 130px; > + border-collapse:collapse; > + } > + .button { > + display: inline-block; > + padding: 5px; > + margin: 3px; > + background: green; > + min-width: 100px; > + } Weird spacing. > LayoutTests/fast/inline-block/inline-block-empty-spans.html:29 > + <tr> > + <td> > + <div> > + <span class="button">One</span><span class="button">Two</span><span class="button">Three</span><span> </span> > + </div> > + </td> > + </tr> Yeah. 1049600 3 commit-queue 2014-11-18 14:40:12 -0800 Attachment 241814 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1049604 4 hyatt 2014-11-18 14:52:08 -0800 Fixed in r176287. 241814 2014-11-18 14:37:07 -0800 2014-11-18 14:39:12 -0800 Patch patch.txt text/plain 4456 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjI4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTExLTE4ICBEYXZpZCBI eWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIxNTIzMTMpOiBJ bmxpbmUtYmxvY2sgZWxlbWVudCBkb2Vzbid0IHdyYXAgcHJvcGVybHkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODg0NiAtIDxyZGFyOi8vcHJvYmxl bS8xODgzODcwMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAqIHJlbmRlcmluZy9saW5lL0Jy ZWFraW5nQ29udGV4dElubGluZUhlYWRlcnMuaDoKKyAgICAgICAgKFdlYkNvcmU6OkJyZWFraW5n Q29udGV4dDo6Y2FuQnJlYWtBdFRoaXNQb3NpdGlvbik6CisKIDIwMTQtMTEtMTggIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBET01UaW1lcnMgc29tZXRpbWVzIGRv bid0IGdldCB1bnRocm90dGxlZCBvbiBzY3JvbGxpbmcKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9saW5lL0JyZWFraW5nQ29udGV4dElubGluZUhlYWRlcnMuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvbGluZS9CcmVha2luZ0NvbnRleHRJbmxpbmVIZWFk ZXJzLmgJKHJldmlzaW9uIDE3NjI2MSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9saW5l L0JyZWFraW5nQ29udGV4dElubGluZUhlYWRlcnMuaAkod29ya2luZyBjb3B5KQpAQCAtOTMxLDgg KzkzMSw4IEBAIGlubGluZSBib29sIEJyZWFraW5nQ29udGV4dDo6Y2FuQnJlYWtBdFQKICAgICBp ZiAoaXM8UmVuZGVySW5saW5lPigqbV9jdXJyZW50LnJlbmRlcmVyKCkpICYmIGlzRW1wdHlJbmxp bmUoZG93bmNhc3Q8UmVuZGVySW5saW5lPigqbV9jdXJyZW50LnJlbmRlcmVyKCkpKSkKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogCi0gICAgLy8gQXZvaWQgYnJlYWtpbmcgYmVmb3JlIGVtcHR5IGlu bGluZXMuCi0gICAgaWYgKGlzPFJlbmRlcklubGluZT4obV9uZXh0T2JqZWN0KSAmJiBpc0VtcHR5 SW5saW5lKGRvd25jYXN0PFJlbmRlcklubGluZT4oKm1fbmV4dE9iamVjdCkpKQorICAgIC8vIEF2 b2lkIGJyZWFraW5nIGJlZm9yZSBlbXB0eSBpbmxpbmVzIChhcyBsb25nIGFzIHRoZSBjdXJyZW50 IG9iamVjdCBpc24ndCByZXBsYWNlZCkuCisgICAgaWYgKCFtX2N1cnJlbnQucmVuZGVyZXIoKS0+ aXNSZXBsYWNlZCgpICYmIGlzPFJlbmRlcklubGluZT4obV9uZXh0T2JqZWN0KSAmJiBpc0VtcHR5 SW5saW5lKGRvd25jYXN0PFJlbmRlcklubGluZT4oKm1fbmV4dE9iamVjdCkpKQogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAKICAgICAvLyBSZXR1cm4gZWFybHkgaWYgd2UgYXV0b3dyYXAgYW5kIHRo ZSBjdXJyZW50IGNoYXJhY3RlciBpcyBhIHNwYWNlIGFzIHdlIHdpbGwgYWx3YXlzIHdhbnQgdG8g YnJlYWsgYXQgc3VjaCBhIHBvc2l0aW9uLgpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTc2Mjg0KQorKysg TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIw MTQtMTEtMTggIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JF U1NJT04ocjE1MjMxMyk6IElubGluZS1ibG9jayBlbGVtZW50IGRvZXNuJ3Qgd3JhcCBwcm9wZXJs eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4ODQ2 IC0gPHJkYXI6Ly9wcm9ibGVtLzE4ODM4NzAzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9pbmxpbmUtYmxvY2svaW5saW5lLWJsb2NrLWVt cHR5LXNwYW5zLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvaW5saW5lLWJs b2NrL2lubGluZS1ibG9jay1lbXB0eS1zcGFucy5odG1sOiBBZGRlZC4KKwogMjAxNC0xMS0xOCAg Q2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIERPTVRpbWVycyBzb21l dGltZXMgZG9uJ3QgZ2V0IHVudGhyb3R0bGVkIG9uIHNjcm9sbGluZwpJbmRleDogTGF5b3V0VGVz dHMvZmFzdC9pbmxpbmUtYmxvY2svaW5saW5lLWJsb2NrLWVtcHR5LXNwYW5zLWV4cGVjdGVkLmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9pbmxpbmUtYmxvY2svaW5saW5lLWJs b2NrLWVtcHR5LXNwYW5zLWV4cGVjdGVkLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9mYXN0L2lubGluZS1ibG9jay9pbmxpbmUtYmxvY2stZW1wdHktc3BhbnMtZXhwZWN0ZWQuaHRt bAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDM2IEBACis8IURPQ1RZUEUgSFRNTD4NCis8aHRt bD4NCis8aGVhZD4NCisgIDxNRVRBIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PVVURi04Ij4NCisgIDx0aXRsZT5GaWxlSW5wdXQ8L3RpdGxlPg0K KyAgPHN0eWxlIHR5cGU9InRleHQvY3NzIj4NCisgICAgdGFibGUgew0KKyAgICAJd2lkdGg6IDEz MHB4Ow0KKyAgICAJYm9yZGVyLWNvbGxhcHNlOmNvbGxhcHNlOw0KKyAgICB9DQorICAgIC5idXR0 b24gew0KKyAgICAJZGlzcGxheTogaW5saW5lLWJsb2NrOw0KKyAgICAgIHBhZGRpbmc6IDVweDsN CisgICAgICBtYXJnaW46IDNweDsNCisgICAgICBiYWNrZ3JvdW5kOiBncmVlbjsNCisgICAgICBt aW4td2lkdGg6IDEwMHB4Ow0KKyAgICB9DQorICAgPC9zdHlsZT4NCis8L2hlYWQ+DQorPGJvZHk+ DQorPHRhYmxlPg0KKwk8dGJvZHk+DQorCQk8dHI+DQorCQkJPHRkPg0KKwkJCSAgPGRpdj4NCisJ CQkgICAgPHNwYW4gY2xhc3M9ImJ1dHRvbiI+T25lPC9zcGFuPg0KKyAgICAgICAgICAgICAgICA8 c3BhbiBjbGFzcz0iYnV0dG9uIj5Ud288L3NwYW4+DQorICAgICAgICAgICAgICAgIDxzcGFuIGNs YXNzPSJidXR0b24iPlRocmVlPC9zcGFuPg0KKwkJCSAgPC9kaXY+DQorCQkJPC90ZD4NCisJCTwv dHI+DQorCTwvdGJvZHk+DQorPC90YWJsZT4NCisNCis8L2JvZHk+DQorPC9odG1sPg0KSW5kZXg6 IExheW91dFRlc3RzL2Zhc3QvaW5saW5lLWJsb2NrL2lubGluZS1ibG9jay1lbXB0eS1zcGFucy5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaW5saW5lLWJsb2NrL2lubGluZS1i bG9jay1lbXB0eS1zcGFucy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9p bmxpbmUtYmxvY2svaW5saW5lLWJsb2NrLWVtcHR5LXNwYW5zLmh0bWwJKHdvcmtpbmcgY29weSkK QEAgLTAsMCArMSwzNCBAQAorPCFET0NUWVBFIEhUTUw+DQorPGh0bWw+DQorPGhlYWQ+DQorICA8 TUVUQSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsgY2hhcnNl dD1VVEYtOCI+DQorICA8dGl0bGU+RmlsZUlucHV0PC90aXRsZT4NCisgIDxzdHlsZSB0eXBlPSJ0 ZXh0L2NzcyI+DQorICAgIHRhYmxlIHsNCisgICAgCXdpZHRoOiAxMzBweDsNCisgICAgCWJvcmRl ci1jb2xsYXBzZTpjb2xsYXBzZTsNCisgICAgfQ0KKyAgICAuYnV0dG9uIHsNCisgICAgCWRpc3Bs YXk6IGlubGluZS1ibG9jazsNCisgICAgICBwYWRkaW5nOiA1cHg7DQorICAgICAgbWFyZ2luOiAz cHg7DQorICAgICAgYmFja2dyb3VuZDogZ3JlZW47DQorICAgICAgbWluLXdpZHRoOiAxMDBweDsN CisgICAgfQ0KKyAgIDwvc3R5bGU+DQorPC9oZWFkPg0KKzxib2R5Pg0KKzx0YWJsZT4NCisJPHRi b2R5Pg0KKwkJPHRyPg0KKwkJCTx0ZD4NCisJCQkgIDxkaXY+DQorCQkJICAgIDxzcGFuIGNsYXNz PSJidXR0b24iPk9uZTwvc3Bhbj48c3BhbiBjbGFzcz0iYnV0dG9uIj5Ud288L3NwYW4+PHNwYW4g Y2xhc3M9ImJ1dHRvbiI+VGhyZWU8L3NwYW4+PHNwYW4+IDwvc3Bhbj4NCisJCQkgIDwvZGl2Pg0K KwkJCTwvdGQ+DQorCQk8L3RyPg0KKwk8L3Rib2R5Pg0KKzwvdGFibGU+DQorDQorPC9ib2R5Pg0K KzwvaHRtbD4NCg==