138840 2014-11-18 11:39:03 -0800 Incorrect detection of toolchain support for Cortex-A53 erratum 835769 workaround 2015-04-29 04:21:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 akiss webkit-unassigned berto commit-queue ossy oldest_to_newest 1049543 0 akiss 2014-11-18 11:39:03 -0800 If the compiler already implements the workaround for the erratum but the linker still does not, the build fails with /usr/bin/ld: unrecognized option '--fix-cortex-a53-835769' The current code in OptionsCommon.cmake only checks for the compilation to work but does not try to link. 1049545 1 241797 akiss 2014-11-18 11:46:31 -0800 Created attachment 241797 Proposed patch. 1049741 2 241797 ossy 2014-11-19 00:26:52 -0800 Comment on attachment 241797 Proposed patch. r=me 1049744 3 241797 commit-queue 2014-11-19 01:06:28 -0800 Comment on attachment 241797 Proposed patch. Clearing flags on attachment: 241797 Committed r176314: <http://trac.webkit.org/changeset/176314> 1049745 4 commit-queue 2014-11-19 01:06:43 -0800 All reviewed patches have been landed. Closing bug. 1089919 5 berto 2015-04-29 00:51:45 -0700 This fails in Debian, likely because of the -fuse-ld=gold flag: /usr/bin/c++ -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -Wall -DENABLE_YARR_JIT=0 -DENABLE_ASSEMBLER=0 -DNDEBUG -std=c++11 -mfix-cortex-a53-835769 -fno-exceptions -fno-strict-aliasing -fno-rtti -Wl,-z,relro -Wl,--as-needed -fuse-ld=gold -Wl,--disable-new-dtags CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o -o ../../bin/LLIntOffsetsExtractor -rdynamic ../../lib/libWTFGTK.a -ldl ../../lib/libbmalloc.a -licui18n -licuuc -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lpthread -lz /usr/bin/ld.gold: --fix-cortex-a53-835769: unknown option /usr/bin/ld.gold: use the --help option for usage information collect2: error: ld returned 1 exit status Full log here: https://buildd.debian.org/status/fetch.php?pkg=webkit2gtk&arch=arm64&ver=2.8.1%2Bdfsg1-1&stamp=1430218110 1089930 6 ossy 2015-04-29 01:33:35 -0700 Thanks for the report, I'll check and try to fix it soon. 1089934 7 berto 2015-04-29 01:46:36 -0700 I guess something like this might be enough: --- a/Source/cmake/OptionsCommon.cmake +++ b/Source/cmake/OptionsCommon.cmake @@ -57,6 +57,7 @@ if (WTF_CPU_ARM64_CORTEXA53) set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -mfix-cortex-a53-835769") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mfix-cortex-a53-835769") message(STATUS "Enabling Cortex-A53 workaround for compiler") + set(USE_LD_GOLD OFF) endif () endif () 1089937 8 ossy 2015-04-29 02:01:52 -0700 I think I found the root of the problem. This errata detection is placed before the gold linker detection. It tries to detect if the default system linker supports --fix-cortex-a53-835769 and later uses gold linker for the real build. Do we know why only the BFD linker supports this errata fix? Is there a gold linker version which supports it? 1089958 9 ossy 2015-04-29 04:21:03 -0700 new bug report for this issue: bug144382 241797 2014-11-18 11:46:31 -0800 2014-11-19 01:06:28 -0800 Proposed patch. fix-a53-workaround-detection-v1.patch text/plain 1645 akiss ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBmNjUyMTYwLi40NzIwYzUy IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTQtMTEtMTggIEFrb3MgS2lzcyAgPGFraXNzQGluZi51LXN6ZWdlZC5odT4KKworICAgICAg ICBGaXggdGhlIGRldGVjdGlvbiBvZiB0b29sY2hhaW4gc3VwcG9ydCBmb3IgQ29ydGV4LUE1MyBl cnJhdHVtIDgzNTc2OSB3b3JrYXJvdW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzg4NDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlOgorCiAy MDE0LTExLTEzICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAg ICAgUmVtb3ZlIFNvdXJjZS9QbGF0Zm9ybSBjcnVmdApkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtl L09wdGlvbnNDb21tb24uY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQpp bmRleCAwNDVmZGNmLi5jNzZhYTkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0Nv bW1vbi5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQpAQCAtNTEs MTMgKzUxLDEyIEBAIGlmIChXVEZfQ1BVX0FSTTY0X0NPUlRFWEE1MykKICAgICBpZiAoTk9UIFdU Rl9DUFVfQVJNNjQpCiAgICAgICAgIG1lc3NhZ2UoRkFUQUxfRVJST1IgIldURl9DUFVfQVJNNjRf Q09SVEVYQTUzIHNldCB3aXRob3V0IFdURl9DUFVfQVJNNjQiKQogICAgIGVuZGlmICgpCi0gICAg bWVzc2FnZSgiQ2hlY2tpbmcgaWYgY29tcGlsZXIgc3VwcG9ydHMgLW1maXgtY29ydGV4LWE1My04 MzU3NjkiKQotICAgIGV4ZWN1dGVfcHJvY2VzcyhDT01NQU5EICR7Q01BS0VfQ19DT01QSUxFUn0g LW1maXgtY29ydGV4LWE1My04MzU3NjkgRVJST1JfVkFSSUFCTEUgQ09NUElMRVJfT1VUUFVUKQot ICAgIGlmICgoTk9UICIke0NPTVBJTEVSX09VVFBVVH0iIE1BVENIRVMgInVucmVjb2duaXplZCBj b21tYW5kIGxpbmUgb3B0aW9uIikKLSAgICAgICAgQU5EIChOT1QgIiR7Q09NUElMRVJfT1VUUFVU fSIgTUFUQ0hFUyAidW5rbm93biBhcmd1bWVudCIpKQorICAgIGluY2x1ZGUoVGVzdENYWEFjY2Vw dHNGbGFnKQorICAgIENIRUNLX0NYWF9BQ0NFUFRTX0ZMQUcoLW1maXgtY29ydGV4LWE1My04MzU3 NjkgQ1hYX0FDQ0VQVFNfTUZJWF9DT1JURVhfQTUzXzgzNTc2OSkKKyAgICBpZiAoQ1hYX0FDQ0VQ VFNfTUZJWF9DT1JURVhfQTUzXzgzNTc2OSkKICAgICAgICAgc2V0KENNQUtFX0NfRkxBR1MgIiR7 Q01BS0VfQ19GTEFHU30gLW1maXgtY29ydGV4LWE1My04MzU3NjkiKQogICAgICAgICBzZXQoQ01B S0VfQ1hYX0ZMQUdTICIke0NNQUtFX0NYWF9GTEFHU30gLW1maXgtY29ydGV4LWE1My04MzU3Njki KQotICAgICAgICBtZXNzYWdlKCJFbmFibGluZyBDb3J0ZXgtQTUzIHdvcmthcm91bmQgZm9yIGNv bXBpbGVyIikKKyAgICAgICAgbWVzc2FnZShTVEFUVVMgIkVuYWJsaW5nIENvcnRleC1BNTMgd29y a2Fyb3VuZCBmb3IgY29tcGlsZXIiKQogICAgIGVuZGlmICgpCiBlbmRpZiAoKQogCg==