138839 2014-11-18 11:32:54 -0800 Web Inspector: Debugger should not mutate variable when hovering mouse over ++n expression 2014-11-19 10:34:18 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1049539 0 joepeck 2014-11-18 11:32:54 -0800 * SUMMARY When debugging javascript paused in the debugger, hovering over a line of the form ++n actually mutates the value of n. n++ does not have this behavior. * TEST <script type="text/javascript"> function test() { debugger; var n = 0; console.log(n); // Hover over next line. n shouldn't change n++; console.log(n); // Hover over next line. n changes but shouldn't ++n; console.log(n); } document.onload = test(); </script> * STEPS TO REPRODUCE 1. Inspect test case 2. Reload or type test() into the console 3. Test hovering over n++ and see it doesn't mutate 4. Test hovering over ++n and see that it mutates n every time you hover over it 1049540 1 webkit-bug-importer 2014-11-18 11:33:10 -0800 <rdar://problem/19018280> 1049541 2 241796 joepeck 2014-11-18 11:36:57 -0800 Created attachment 241796 [PATCH] Proposed Fix 1049542 3 joepeck 2014-11-18 11:37:53 -0800 <rdar://problem/18995374> 1049546 4 241796 timothy 2014-11-18 11:51:02 -0800 Comment on attachment 241796 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=241796&action=review > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTokenTrackingController.js:490 > + if (isExpression && token.string === "++") What about --? 1049551 5 joepeck 2014-11-18 12:03:50 -0800 (In reply to comment #4) > Comment on attachment 241796 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241796&action=review > > > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTokenTrackingController.js:490 > > + if (isExpression && token.string === "++") > > What about --? Doh! Tim also caught other operators, like: n+=n; I'll put up another patch. 1049581 6 241810 joepeck 2014-11-18 14:01:06 -0800 Created attachment 241810 [PATCH] Proposed Fix 1049812 7 241810 timothy 2014-11-19 09:54:02 -0800 Comment on attachment 241810 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=241810&action=review > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTokenTrackingController.js:492 > + // Disallow operators. We want the hovered expression to be just a single operand. > + // Also, some operators can modify values, such as pre-increment and assignment operators. > + if (isExpression && token.type.contains("operator")) > + break; Nice! 1049831 8 241810 commit-queue 2014-11-19 10:34:15 -0800 Comment on attachment 241810 [PATCH] Proposed Fix Clearing flags on attachment: 241810 Committed r176325: <http://trac.webkit.org/changeset/176325> 1049832 9 commit-queue 2014-11-19 10:34:18 -0800 All reviewed patches have been landed. Closing bug. 241796 2014-11-18 11:36:57 -0800 2014-11-18 14:01:06 -0800 [PATCH] Proposed Fix pre-increment.patch text/plain 2344 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDlmZmRkYzQuLjg5NWExNjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTExLTE4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRGVidWdn ZXIgc2hvdWxkIG5vdCBtdXRhdGUgdmFyaWFibGUgd2hlbiBob3ZlcmluZyBtb3VzZSBvdmVyICsr biBleHByZXNzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzg4MzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ29kZU1pcnJvclRva2VuVHJhY2tpbmdD b250cm9sbGVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUb2tlblRyYWNr aW5nQ29udHJvbGxlci5wcm90b3R5cGUuX3Byb2Nlc3NKYXZhU2NyaXB0RXhwcmVzc2lvbik6CisK IDIwMTQtMTEtMTcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBQcm92aWRlICRleGNlcHRpb24gaW4gdGhlIGNvbnNvbGUgZm9y IHRoZSB0aHJvd24gZXhjZXB0aW9uIHZhbHVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9yVG9rZW5UcmFja2luZ0Nv bnRyb2xsZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9s bGVycy9Db2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXIuanMKaW5kZXggMWFhMTg3NS4u ZWM4NWQ4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Q29udHJvbGxlcnMvQ29kZU1pcnJvclRva2VuVHJhY2tpbmdDb250cm9sbGVyLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JU b2tlblRyYWNraW5nQ29udHJvbGxlci5qcwpAQCAtNDc3LDExICs0NzcsMTkgQEAgV2ViSW5zcGVj dG9yLkNvZGVNaXJyb3JUb2tlblRyYWNraW5nQ29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAgICAg ICAgIHZhciBleHByZXNzaW9uID0gdGhpcy5faG92ZXJlZFRva2VuSW5mby50b2tlbi5zdHJpbmc7 CiAgICAgICAgIHZhciBleHByZXNzaW9uU3RhcnRQb3NpdGlvbiA9IHtsaW5lOiB0aGlzLl9ob3Zl cmVkVG9rZW5JbmZvLnBvc2l0aW9uLmxpbmUsIGNoOiB0aGlzLl9ob3ZlcmVkVG9rZW5JbmZvLnRv a2VuLnN0YXJ0fTsKICAgICAgICAgd2hpbGUgKHRydWUpIHsKLSAgICAgICAgICAgIHZhciB0b2tl biA9IHRoaXMuX2NvZGVNaXJyb3IuZ2V0VG9rZW5BdChleHByZXNzaW9uU3RhcnRQb3NpdGlvbik7 Ci0gICAgICAgICAgICB2YXIgaXNEb3QgPSB0b2tlbiAmJiAhdG9rZW4udHlwZSAmJiB0b2tlbi5z dHJpbmcgPT09ICIuIjsKLSAgICAgICAgICAgIHZhciBpc0V4cHJlc3Npb24gPSB0b2tlbiAmJiB0 b2tlbi50eXBlICYmIHRva2VuLnR5cGUuaW5kZXhPZigibS1qYXZhc2NyaXB0IikgIT09IC0xOwor ICAgICAgICAgICAgdmFyIHRva2VuID0gdGhpcy5fY29kZU1pcnJvci5nZXRUb2tlbkF0KGV4cHJl c3Npb25TdGFydFBvc2l0aW9uKTsgICAgICAgICAgICAKKyAgICAgICAgICAgIGlmICghdG9rZW4p CisgICAgICAgICAgICAgICAgYnJlYWs7CisKKyAgICAgICAgICAgIHZhciBpc0RvdCA9ICF0b2tl bi50eXBlICYmIHRva2VuLnN0cmluZyA9PT0gIi4iOworICAgICAgICAgICAgdmFyIGlzRXhwcmVz c2lvbiA9IHRva2VuLnR5cGUgJiYgdG9rZW4udHlwZS5pbmRleE9mKCJtLWphdmFzY3JpcHQiKSAh PT0gLTE7CiAgICAgICAgICAgICBpZiAoIWlzRG90ICYmICFpc0V4cHJlc3Npb24pCiAgICAgICAg ICAgICAgICAgYnJlYWs7CisKKyAgICAgICAgICAgIC8vIERpc2FsbG93IHN1YiBleHByZXNzaW9u IHRva2VucyB0aGF0IHdvdWxkIG1vZGlmeSBzdGF0ZXMuCisgICAgICAgICAgICBpZiAoaXNFeHBy ZXNzaW9uICYmIHRva2VuLnN0cmluZyA9PT0gIisrIikKKyAgICAgICAgICAgICAgICBicmVhazsK KwogICAgICAgICAgICAgZXhwcmVzc2lvbiA9IHRva2VuLnN0cmluZyArIGV4cHJlc3Npb247CiAg ICAgICAgICAgICBleHByZXNzaW9uU3RhcnRQb3NpdGlvbi5jaCA9IHRva2VuLnN0YXJ0OwogICAg ICAgICB9Cg== 241810 2014-11-18 14:01:06 -0800 2014-11-19 10:34:15 -0800 [PATCH] Proposed Fix bestest.patch text/plain 2475 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDlmZmRkYzQuLjg5NWExNjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTExLTE4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRGVidWdn ZXIgc2hvdWxkIG5vdCBtdXRhdGUgdmFyaWFibGUgd2hlbiBob3ZlcmluZyBtb3VzZSBvdmVyICsr biBleHByZXNzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzg4MzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ29kZU1pcnJvclRva2VuVHJhY2tpbmdD b250cm9sbGVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUb2tlblRyYWNr aW5nQ29udHJvbGxlci5wcm90b3R5cGUuX3Byb2Nlc3NKYXZhU2NyaXB0RXhwcmVzc2lvbik6CisK IDIwMTQtMTEtMTcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBQcm92aWRlICRleGNlcHRpb24gaW4gdGhlIGNvbnNvbGUgZm9y IHRoZSB0aHJvd24gZXhjZXB0aW9uIHZhbHVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9yVG9rZW5UcmFja2luZ0Nv bnRyb2xsZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9s bGVycy9Db2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXIuanMKaW5kZXggMWFhMTg3NS4u ZGQ2OTlmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Q29udHJvbGxlcnMvQ29kZU1pcnJvclRva2VuVHJhY2tpbmdDb250cm9sbGVyLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JU b2tlblRyYWNraW5nQ29udHJvbGxlci5qcwpAQCAtNDc3LDExICs0NzcsMjAgQEAgV2ViSW5zcGVj dG9yLkNvZGVNaXJyb3JUb2tlblRyYWNraW5nQ29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAgICAg ICAgIHZhciBleHByZXNzaW9uID0gdGhpcy5faG92ZXJlZFRva2VuSW5mby50b2tlbi5zdHJpbmc7 CiAgICAgICAgIHZhciBleHByZXNzaW9uU3RhcnRQb3NpdGlvbiA9IHtsaW5lOiB0aGlzLl9ob3Zl cmVkVG9rZW5JbmZvLnBvc2l0aW9uLmxpbmUsIGNoOiB0aGlzLl9ob3ZlcmVkVG9rZW5JbmZvLnRv a2VuLnN0YXJ0fTsKICAgICAgICAgd2hpbGUgKHRydWUpIHsKLSAgICAgICAgICAgIHZhciB0b2tl biA9IHRoaXMuX2NvZGVNaXJyb3IuZ2V0VG9rZW5BdChleHByZXNzaW9uU3RhcnRQb3NpdGlvbik7 Ci0gICAgICAgICAgICB2YXIgaXNEb3QgPSB0b2tlbiAmJiAhdG9rZW4udHlwZSAmJiB0b2tlbi5z dHJpbmcgPT09ICIuIjsKLSAgICAgICAgICAgIHZhciBpc0V4cHJlc3Npb24gPSB0b2tlbiAmJiB0 b2tlbi50eXBlICYmIHRva2VuLnR5cGUuaW5kZXhPZigibS1qYXZhc2NyaXB0IikgIT09IC0xOwor ICAgICAgICAgICAgdmFyIHRva2VuID0gdGhpcy5fY29kZU1pcnJvci5nZXRUb2tlbkF0KGV4cHJl c3Npb25TdGFydFBvc2l0aW9uKTsgICAgICAgICAgICAKKyAgICAgICAgICAgIGlmICghdG9rZW4p CisgICAgICAgICAgICAgICAgYnJlYWs7CisKKyAgICAgICAgICAgIHZhciBpc0RvdCA9ICF0b2tl bi50eXBlICYmIHRva2VuLnN0cmluZyA9PT0gIi4iOworICAgICAgICAgICAgdmFyIGlzRXhwcmVz c2lvbiA9IHRva2VuLnR5cGUgJiYgdG9rZW4udHlwZS5jb250YWlucygibS1qYXZhc2NyaXB0Iik7 CiAgICAgICAgICAgICBpZiAoIWlzRG90ICYmICFpc0V4cHJlc3Npb24pCiAgICAgICAgICAgICAg ICAgYnJlYWs7CisKKyAgICAgICAgICAgIC8vIERpc2FsbG93IG9wZXJhdG9ycy4gV2Ugd2FudCB0 aGUgaG92ZXJlZCBleHByZXNzaW9uIHRvIGJlIGp1c3QgYSBzaW5nbGUgb3BlcmFuZC4KKyAgICAg ICAgICAgIC8vIEFsc28sIHNvbWUgb3BlcmF0b3JzIGNhbiBtb2RpZnkgdmFsdWVzLCBzdWNoIGFz IHByZS1pbmNyZW1lbnQgYW5kIGFzc2lnbm1lbnQgb3BlcmF0b3JzLgorICAgICAgICAgICAgaWYg KGlzRXhwcmVzc2lvbiAmJiB0b2tlbi50eXBlLmNvbnRhaW5zKCJvcGVyYXRvciIpKQorICAgICAg ICAgICAgICAgIGJyZWFrOworCiAgICAgICAgICAgICBleHByZXNzaW9uID0gdG9rZW4uc3RyaW5n ICsgZXhwcmVzc2lvbjsKICAgICAgICAgICAgIGV4cHJlc3Npb25TdGFydFBvc2l0aW9uLmNoID0g dG9rZW4uc3RhcnQ7CiAgICAgICAgIH0K