138823 2014-11-17 22:36:21 -0800 crypto: Use sequence<> instead of KeyUsage[] in IDL 2014-11-18 10:14:31 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shiva.jm webkit-unassigned ap commit-queue darin gyuyoung.kim pnormand rniwa oldest_to_newest 1049402 0 shiva.jm 2014-11-17 22:36:21 -0800 Use sequence<> instead of KeyUsage[] in crypto IDL as per spec: https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#SubtleCrypto-method-generateKey 1049405 1 241766 shiva.jm 2014-11-17 22:54:45 -0800 Created attachment 241766 Patch Use sequence<KeyUsage> instead of KeyUsage[] in crypto IDL as per spec: https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#SubtleCrypto-method-generateKey 1049503 2 241766 commit-queue 2014-11-18 09:44:58 -0800 Comment on attachment 241766 Patch Clearing flags on attachment: 241766 Committed r176261: <http://trac.webkit.org/changeset/176261> 1049504 3 commit-queue 2014-11-18 09:45:02 -0800 All reviewed patches have been landed. Closing bug. 1049521 4 ap 2014-11-18 10:14:31 -0800 Is KeyUsage[] exactly the same thing as sequence<KeyUsage>? Otherwise, the change may be wrong, as it only changes description in IDL, but does not change what WebKit actually does. 241766 2014-11-17 22:54:45 -0800 2014-11-18 09:44:58 -0800 Patch bug-138823.patch text/plain 2715 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjI1MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTExLTE3ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgY3J5cHRvOiBVc2Ugc2Vx dWVuY2U8PiBpbnN0ZWFkIG9mIEtleVVzYWdlW10gaW4gSURMLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4ODIzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHNlcXVlbmNlPEtleVVzYWdlPiBpbnN0 ZWFkIG9mIEtleVVzYWdlW10gaW4gY3J5cHRvIElETCBhcyBwZXIgc3BlYzogaHR0cHM6Ly9kdmNz LnczLm9yZy9oZy93ZWJjcnlwdG8tYXBpL3Jhdy1maWxlL3RpcC9zcGVjLworICAgICAgICBPdmVy dmlldy5odG1sI1N1YnRsZUNyeXB0by1tZXRob2QtZ2VuZXJhdGVLZXkKKworICAgICAgICBObyBu ZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGNyeXB0by9TdWJ0bGVD cnlwdG8uaWRsOgorCiAyMDE0LTExLTE3ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBw bGUuY29tPgogCiAgICAgICAgIEZpeCBhIHNtYWxsIGluZGVudGF0aW9uIG1pc3Rha2UgaW4gU2Vs ZWN0b3JDb2RlR2VuZXJhdG9yOjpnZW5lcmF0ZU50aEZpbHRlclRlc3QKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2NyeXB0by9TdWJ0bGVDcnlwdG8uaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2NyeXB0by9TdWJ0bGVDcnlwdG8uaWRsCShyZXZpc2lvbiAxNzYyNTEpCisrKyBTb3VyY2Uv V2ViQ29yZS9jcnlwdG8vU3VidGxlQ3J5cHRvLmlkbAkod29ya2luZyBjb3B5KQpAQCAtMzQsOSAr MzQsOSBAQAogICAgIFtDdXN0b21dIFByb21pc2Ugc2lnbihBbGdvcml0aG1JZGVudGlmaWVyIGFs Z29yaXRobSwgS2V5IGtleSwgc2VxdWVuY2U8Q3J5cHRvT3BlcmF0aW9uRGF0YT4gZGF0YSk7CiAg ICAgW0N1c3RvbV0gUHJvbWlzZSB2ZXJpZnkoQWxnb3JpdGhtSWRlbnRpZmllciBhbGdvcml0aG0s IEtleSBrZXksIENyeXB0b09wZXJhdGlvbkRhdGEgc2lnbmF0dXJlLCBzZXF1ZW5jZTxDcnlwdG9P cGVyYXRpb25EYXRhPiBkYXRhKTsKICAgICBbQ3VzdG9tXSBQcm9taXNlIGRpZ2VzdChBbGdvcml0 aG1JZGVudGlmaWVyIGFsZ29yaXRobSwgc2VxdWVuY2U8Q3J5cHRvT3BlcmF0aW9uRGF0YT4gZGF0 YSk7Ci0gICAgW0N1c3RvbV0gUHJvbWlzZSBnZW5lcmF0ZUtleShBbGdvcml0aG1JZGVudGlmaWVy IGFsZ29yaXRobSwgb3B0aW9uYWwgYm9vbGVhbiBleHRyYWN0YWJsZSwgb3B0aW9uYWwgS2V5VXNh Z2VbXSBrZXlVc2FnZXMpOwotICAgIFtDdXN0b21dIFByb21pc2UgaW1wb3J0S2V5KEtleUZvcm1h dCBmb3JtYXQsIENyeXB0b09wZXJhdGlvbkRhdGEga2V5RGF0YSwgQWxnb3JpdGhtSWRlbnRpZmll cj8gYWxnb3JpdGhtLCBvcHRpb25hbCBib29sZWFuIGV4dHJhY3RhYmxlLCBvcHRpb25hbCBLZXlV c2FnZVtdIGtleVVzYWdlcyk7CisgICAgW0N1c3RvbV0gUHJvbWlzZSBnZW5lcmF0ZUtleShBbGdv cml0aG1JZGVudGlmaWVyIGFsZ29yaXRobSwgb3B0aW9uYWwgYm9vbGVhbiBleHRyYWN0YWJsZSwg b3B0aW9uYWwgc2VxdWVuY2U8S2V5VXNhZ2U+IGtleVVzYWdlcyk7CisgICAgW0N1c3RvbV0gUHJv bWlzZSBpbXBvcnRLZXkoS2V5Rm9ybWF0IGZvcm1hdCwgQ3J5cHRvT3BlcmF0aW9uRGF0YSBrZXlE YXRhLCBBbGdvcml0aG1JZGVudGlmaWVyPyBhbGdvcml0aG0sIG9wdGlvbmFsIGJvb2xlYW4gZXh0 cmFjdGFibGUsIG9wdGlvbmFsIHNlcXVlbmNlPEtleVVzYWdlPiBrZXlVc2FnZXMpOwogICAgIFtD dXN0b21dIFByb21pc2UgZXhwb3J0S2V5KEtleUZvcm1hdCBmb3JtYXQsIEtleSBrZXkpOwogICAg IFtDdXN0b21dIFByb21pc2Ugd3JhcEtleShLZXlGb3JtYXQgZm9ybWF0LCBLZXkga2V5LCBLZXkg d3JhcHBpbmdLZXksIEFsZ29yaXRobUlkZW50aWZpZXIgd3JhcEFsZ29yaXRobSk7Ci0gICAgW0N1 c3RvbV0gUHJvbWlzZSB1bndyYXBLZXkoS2V5Rm9ybWF0IGZvcm1hdCwgQ3J5cHRvT3BlcmF0aW9u RGF0YSB3cmFwcGVkS2V5LCBLZXkgdW53cmFwcGluZ0tleSwgQWxnb3JpdGhtSWRlbnRpZmllciB1 bndyYXBBbGdvcml0aG0sIEFsZ29yaXRobUlkZW50aWZpZXI/IHVud3JhcHBlZEtleUFsZ29yaXRo bSwgb3B0aW9uYWwgYm9vbGVhbiBleHRyYWN0YWJsZSwgb3B0aW9uYWwgS2V5VXNhZ2VbXSBrZXlV c2FnZXMpOworICAgIFtDdXN0b21dIFByb21pc2UgdW53cmFwS2V5KEtleUZvcm1hdCBmb3JtYXQs IENyeXB0b09wZXJhdGlvbkRhdGEgd3JhcHBlZEtleSwgS2V5IHVud3JhcHBpbmdLZXksIEFsZ29y aXRobUlkZW50aWZpZXIgdW53cmFwQWxnb3JpdGhtLCBBbGdvcml0aG1JZGVudGlmaWVyPyB1bndy YXBwZWRLZXlBbGdvcml0aG0sIG9wdGlvbmFsIGJvb2xlYW4gZXh0cmFjdGFibGUsIG9wdGlvbmFs IHNlcXVlbmNlPEtleVVzYWdlPiBrZXlVc2FnZXMpOwogfTsK