138806 2014-11-17 13:49:56 -0800 media/track/track-in-band-cues-added-once.html fails sometimes 2015-01-29 16:04:41 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=123498 https://bugs.webkit.org/show_bug.cgi?id=132715 https://bugs.webkit.org/show_bug.cgi?id=138908 InRadar P2 Normal --- 1 ap eric.carlson commit-queue eric.carlson webkit-bug-importer oldest_to_newest 1049302 0 ap 2014-11-17 13:49:56 -0800 I'm seeing these failures again: @@ -24,5 +24,10 @@ EVENT(seeked) EXPECTED (inbandTrack1.cues.length > '0') OK RUN(video.pause()) +Found unexpected cue starting at 0.2 FAIL +Found unexpected cue starting at 1.0008333333333332 FAIL +Found unexpected cue starting at 1.7682333333333333 FAIL +Found unexpected cue starting at 2.4355333333333333 FAIL +Found unexpected cue starting at 2.769233333333333 FAIL END OF TEST 1049303 1 webkit-bug-importer 2014-11-17 13:50:29 -0800 <rdar://problem/19006312> 1049305 2 ap 2014-11-17 13:52:27 -0800 Marked as flaky in <http://trac.webkit.org/r176228>. 1065325 3 eric.carlson 2015-01-29 13:05:11 -0800 As with bug 140974, it looks like this happens when AVFoundation doesn't deliver the first cue when playback starts - presumably because of startup latency. 1065353 4 245652 eric.carlson 2015-01-29 14:48:43 -0800 Created attachment 245652 Proposed patch. 1065364 5 245652 bfulgham 2015-01-29 15:02:36 -0800 Comment on attachment 245652 Proposed patch. r=me 1065399 6 245652 commit-queue 2015-01-29 16:04:37 -0800 Comment on attachment 245652 Proposed patch. Clearing flags on attachment: 245652 Committed r179378: <http://trac.webkit.org/changeset/179378> 1065400 7 commit-queue 2015-01-29 16:04:41 -0800 All reviewed patches have been landed. Closing bug. 245652 2015-01-29 14:48:43 -0800 2015-01-29 16:04:37 -0800 Proposed patch. patch_2.txt text/plain 6715 eric.carlson SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE3OTM2NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAxLTI5ICBFcmljIENhcmxzb24gIDxl cmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIG1lZGlhL3RyYWNrL3RyYWNrLWluLWJh bmQtY3Vlcy1hZGRlZC1vbmNlLmh0bWwgZmFpbHMgc29tZXRpbWVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg4MDYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG1lZGlhL3RyYWNrL3RyYWNrLWluLWJh bmQtY3Vlcy1hZGRlZC1vbmNlLWV4cGVjdGVkLnR4dDogVXBkYXRlIHJlc3VsdHMuCisgICAgICAg ICogbWVkaWEvdHJhY2svdHJhY2staW4tYmFuZC1jdWVzLWFkZGVkLW9uY2UuaHRtbDogU2VlayBi ZWZvcmUgYmVnaW5uaW5nIHBsYXliYWNrIHNvCisgICAgICAgICAgICB0aGUgbWVkaWEgZW5naW5l IGlzIG1vcmUgbGlrZWx5IHRvIGJ1ZmZlciBhbmQgcHJvY2VzcyB0aGUgaW5pdGlhbCBjdWUuCisg ICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6IFVuc2tpcCB0cmFjay1pbi1i YW5kLWN1ZXMtYWRkZWQtb25jZS5odG1sLgorCiAyMDE1LTAxLTIwICBEYXZpZCBIeWF0dCAgPGh5 YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBKYXBhbmVzZSBsaW5lIGJyZWFraW5nIHJ1bGVzIG5l ZWQgdG8gYmUgcmVzcGVjdGVkIGJlZm9yZSBhbmQgYWZ0ZXIgUnVieS4KSW5kZXg6IExheW91dFRl c3RzL21lZGlhL3RyYWNrL3RyYWNrLWluLWJhbmQtY3Vlcy1hZGRlZC1vbmNlLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1pbi1iYW5kLWN1 ZXMtYWRkZWQtb25jZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDE3OTI2NykKKysrIExheW91dFRl c3RzL21lZGlhL3RyYWNrL3RyYWNrLWluLWJhbmQtY3Vlcy1hZGRlZC1vbmNlLWV4cGVjdGVkLnR4 dAkod29ya2luZyBjb3B5KQpAQCAtMTUsMTIgKzE1LDEyIEBAIEVYUEVDVEVEIChpbmJhbmRUcmFj azEubGFuZ3VhZ2UgPT0gJ2VuJykKIEVYUEVDVEVEIChpbmJhbmRUcmFjazEua2luZCA9PSAnY2Fw dGlvbnMnKSBPSwogCiBSVU4oaW5iYW5kVHJhY2sxLm1vZGUgPSAnc2hvd2luZycpCitFVkVOVChj aGFuZ2UpCiBSVU4odmlkZW8ucGxheSgpKQorCiBSVU4odmlkZW8ucGF1c2UoKSkKLVJVTih2aWRl by5jdXJyZW50VGltZSA9IDApCiBSVU4odmlkZW8ucGxheSgpKQogCi1FVkVOVChzZWVrZWQpCiBS VU4odmlkZW8ucGF1c2UoKSkKIEVORCBPRiBURVNUCiAKSW5kZXg6IExheW91dFRlc3RzL21lZGlh L3RyYWNrL3RyYWNrLWluLWJhbmQtY3Vlcy1hZGRlZC1vbmNlLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2staW4tYmFuZC1jdWVzLWFkZGVkLW9uY2UuaHRt bAkocmV2aXNpb24gMTc5MjY3KQorKysgTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2staW4t YmFuZC1jdWVzLWFkZGVkLW9uY2UuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMjcsNDQgKzI3LDYz IEBACiAKICAgICAgICAgICAgIGZ1bmN0aW9uIHBvbGxQcm9ncmVzcygpCiAgICAgICAgICAgICB7 Ci0gICAgICAgICAgICAgICAgaWYgKHZpZGVvLmN1cnJlbnRUaW1lIDwgMikKLSAgICAgICAgICAg ICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgICAgIHN3aXRjaCAoc2Vla2VkQ291bnQpIHsK KyAgICAgICAgICAgICAgICBjYXNlIDE6CisgICAgICAgICAgICAgICAgICAgIHZpZGVvLmN1cnJl bnRUaW1lID0gMDsKKyAgICAgICAgICAgICAgICAgICAgcnVuKCJ2aWRlby5wbGF5KCkiKTsKKyAg ICAgICAgICAgICAgICAgICAgY29uc29sZVdyaXRlKCIiKTsKKyAgICAgICAgICAgICAgICAgICAg YnJlYWs7CisKKyAgICAgICAgICAgICAgICBjYXNlIDI6CisgICAgICAgICAgICAgICAgICAgIGlm ICh2aWRlby5jdXJyZW50VGltZSA8IDIgfHwgaW5iYW5kVHJhY2sxLmN1ZXMubGVuZ3RoIDw9IDUp CisgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgICAgICAgICBpZiAo IXNlZWtlZENvdW50ICYmIGluYmFuZFRyYWNrMS5jdWVzLmxlbmd0aCA+PSA1KSB7CiAgICAgICAg ICAgICAgICAgICAgIC8vIENvbGxlY3QgdGhlIHN0YXJ0IHRpbWVzIG9mIGFsbCBjdWVzLCBzZWVr IGJhY2sgdG8gdGhlIGJlZ2lubmluZyBhbmQgcGxheQogICAgICAgICAgICAgICAgICAgICAvLyB0 aGUgc2FtZSBzZWdtZW50IG9mIHRoZSB2aWRlbyBmaWxlLgogICAgICAgICAgICAgICAgICAgICBy dW4oInZpZGVvLnBhdXNlKCkiKTsKICAgICAgICAgICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7 IGkgPCBpbmJhbmRUcmFjazEuY3Vlcy5sZW5ndGg7ICsraSkKICAgICAgICAgICAgICAgICAgICAg ICAgIGN1ZXNTdGFydHMucHVzaChpbmJhbmRUcmFjazEuY3Vlc1tpXS5zdGFydFRpbWUpOwotICAg ICAgICAgICAgICAgICAgICBydW4oInZpZGVvLmN1cnJlbnRUaW1lID0gMCIpOworICAgICAgICAg ICAgICAgICAgICB2aWRlby5jdXJyZW50VGltZSA9IDA7CiAgICAgICAgICAgICAgICAgICAgIHJ1 bigidmlkZW8ucGxheSgpIik7CiAgICAgICAgICAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiIik7 Ci0gICAgICAgICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgICAgICAgICB9CisgICAgICAg ICAgICAgICAgICAgIGJyZWFrOwogCi0gICAgICAgICAgICAgICAgaWYgKGluYmFuZFRyYWNrMS5j dWVzLmxlbmd0aCA8IGN1ZXNTdGFydHMubGVuZ3RoKQotICAgICAgICAgICAgICAgICAgICByZXR1 cm47Ci0KLSAgICAgICAgICAgICAgICBydW4oInZpZGVvLnBhdXNlKCkiKTsKLSAgICAgICAgICAg ICAgICB2YXIgZmFpbHVyZSA9IGZhbHNlOwotICAgICAgICAgICAgICAgIGZvciAodmFyIGkgPSAw OyBpIDwgY3Vlc1N0YXJ0cy5sZW5ndGg7ICsraSkgewotICAgICAgICAgICAgICAgICAgICBpZiAo Y3Vlc1N0YXJ0c1tpXSAhPSBpbmJhbmRUcmFjazEuY3Vlc1tpXS5zdGFydFRpbWUpIHsKLSAgICAg ICAgICAgICAgICAgICAgICAgIGZhaWx1cmUgPSB0cnVlOworICAgICAgICAgICAgICAgIGNhc2Ug MzoKKyAgICAgICAgICAgICAgICAgICAgaWYgKGluYmFuZFRyYWNrMS5jdWVzLmxlbmd0aCA8IGN1 ZXNTdGFydHMubGVuZ3RoKQogICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAg ICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICB9Ci0KLSAgICAgICAgICAgICAgICBpZiAo ZmFpbHVyZSkgewotICAgICAgICAgICAgICAgICAgICBjb25zb2xlV3JpdGUoIjxicj48aT4qKiBG QUlMPCIgKyAiL2k+Iik7CisgICAgCisgICAgICAgICAgICAgICAgICAgIHJ1bigidmlkZW8ucGF1 c2UoKSIpOworICAgICAgICAgICAgICAgICAgICB2YXIgZmFpbHVyZSA9IGZhbHNlOwogICAgICAg ICAgICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGN1ZXNTdGFydHMubGVuZ3RoOyArK2kp IHsKLSAgICAgICAgICAgICAgICAgICAgICAgIHZhciBvbGRTdGFydCA9IGN1ZXNTdGFydHNbaV07 Ci0gICAgICAgICAgICAgICAgICAgICAgICB2YXIgbmV3U3RhcnQgPSBpbmJhbmRUcmFjazEuY3Vl c1tpXS5zdGFydFRpbWU7Ci0gICAgICAgICAgICAgICAgICAgICAgICBjb25zb2xlV3JpdGUoIkN1 ZSAiICsgaSArICIgc3RhcnQgdGltZSB3YXM6ICIgKyBvbGRTdGFydCArICIsIGlzIG5vdzogIiAr IG5ld1N0YXJ0KTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGlmIChjdWVzU3RhcnRzW2ldICE9 IGluYmFuZFRyYWNrMS5jdWVzW2ldLnN0YXJ0VGltZSkgeworICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGZhaWx1cmUgPSB0cnVlOworICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFr OworICAgICAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgICAgICB9Ci0gICAg ICAgICAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiIik7CisgICAgCisgICAgICAgICAgICAgICAg ICAgIGlmIChmYWlsdXJlKSB7CisgICAgICAgICAgICAgICAgICAgICAgICBjb25zb2xlV3JpdGUo Ijxicj48aT4qKiBGQUlMPCIgKyAiL2k+Iik7CisgICAgICAgICAgICAgICAgICAgICAgICBmb3Ig KHZhciBpID0gMDsgaSA8IGN1ZXNTdGFydHMubGVuZ3RoOyArK2kpIHsKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICB2YXIgb2xkU3RhcnQgPSBjdWVzU3RhcnRzW2ldOworICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHZhciBuZXdTdGFydCA9IGluYmFuZFRyYWNrMS5jdWVzW2ldLnN0YXJ0 VGltZTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zb2xlV3JpdGUoIkN1ZSAiICsg aSArICIgc3RhcnQgdGltZSB3YXM6ICIgKyBvbGRTdGFydCArICIsIGlzIG5vdzogIiArIG5ld1N0 YXJ0KTsKKyAgICAgICAgICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICAgICAgICAg IGNvbnNvbGVXcml0ZSgiIik7CisgICAgICAgICAgICAgICAgICAgIH0KKyAgICAKKyAgICAgICAg ICAgICAgICAgICAgZW5kVGVzdCgpOworICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgICAgICAgICB9CisgICAgICAgICAgICB9CiAKLSAgICAgICAgICAgICAgICBlbmRUZXN0KCk7 CisgICAgICAgICAgICBmdW5jdGlvbiB0cmFja3NDaGFuZ2VkKCkKKyAgICAgICAgICAgIHsKKyAg ICAgICAgICAgICAgICBzZXRJbnRlcnZhbChwb2xsUHJvZ3Jlc3MsIDEwMCk7CisgICAgICAgICAg ICAgICAgCisgICAgICAgICAgICAgICAgLy8gV2Ugc2VlayB0byB0aW1lIDAuMSBhbmQgdGhlbiBi YWNrIHRvIDAgYmVmb3JlIHN0YXJ0aW5nIHBsYXliYWNrIHRvIG1ha2UgaXQgbW9yZSBsaWtlbHkK KyAgICAgICAgICAgICAgICAvLyB0aGF0IHRoZSBtZWRpYSBlbmdpbmUgd2lsbCBwcm9jZXNzIHRo ZSBpbml0aWFsIG1lZGlhIHNhbXBsZXMgYW5kIGRlbGl2ZXIgdGhlIGZpcnN0CisgICAgICAgICAg ICAgICAgLy8gaW5iYW5kIGN1ZXMgdG8gV2ViS2l0LgorICAgICAgICAgICAgICAgIHZpZGVvLmN1 cnJlbnRUaW1lID0gMC4xOwogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBmdW5jdGlvbiBj YW5wbGF5dGhyb3VnaCgpCkBAIC03OCwxNCArOTcsMTIgQEAKICAgICAgICAgICAgICAgICB0ZXN0 RXhwZWN0ZWQoImluYmFuZFRyYWNrMS5jdWVzIiwgbnVsbCk7CiAgICAgICAgICAgICAgICAgdGVz dEV4cGVjdGVkKCJpbmJhbmRUcmFjazEubGFuZ3VhZ2UiLCAiZW4iKTsKICAgICAgICAgICAgICAg ICB0ZXN0RXhwZWN0ZWQoImluYmFuZFRyYWNrMS5raW5kIiwgImNhcHRpb25zIik7Ci0KKyAgICAg ICAgICAgICAgICB3YWl0Rm9yRXZlbnRPbih2aWRlby50ZXh0VHJhY2tzLCAnY2hhbmdlJywgdHJh Y2tzQ2hhbmdlZCk7CiAKICAgICAgICAgICAgICAgICBjb25zb2xlV3JpdGUoIiIpOwogCi0gICAg ICAgICAgICAgICAgd2FpdEZvckV2ZW50KCdzZWVrZWQnLCBmdW5jdGlvbigpIHsgKytzZWVrZWRD b3VudDsgfSk7Ci0gICAgICAgICAgICAgICAgc2V0SW50ZXJ2YWwocG9sbFByb2dyZXNzLCAxMDAp OworICAgICAgICAgICAgICAgIHZpZGVvLmFkZEV2ZW50TGlzdGVuZXIoInNlZWtlZCIsIGZ1bmN0 aW9uKCkgeyArK3NlZWtlZENvdW50OyB9KTsKICAgICAgICAgICAgICAgICBydW4oImluYmFuZFRy YWNrMS5tb2RlID0gJ3Nob3dpbmcnIik7Ci0gICAgICAgICAgICAgICAgcnVuKCJ2aWRlby5wbGF5 KCkiKTsKICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgZnVuY3Rpb24gc2V0dXAoKQpJbmRl eDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDE3 OTI2NykKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMTkwLDggKzExOTAsNiBAQCB3ZWJraXQub3JnL2IvMTM3NTA1IFsgTWF2 ZXJpY2tzKyBdIG1lZGlhCiAjIFdlIHNob3VsZCBsYW5kIHVwZGF0ZWQgcmVzdWx0cyBpZiB3ZSBj YW4ndCBnZXQgdGhpcyBidWcgZml4ZWQgaW4gdGltZS4KIFsgWW9zZW1pdGUrIF0gaHR0cC90ZXN0 cy94bWxodHRwcmVxdWVzdC9jYWNoZS1vdmVycmlkZS5odG1sIFsgRmFpbHVyZSBdCiAKLXdlYmtp dC5vcmcvYi8xMzg4MDYgWyBZb3NlbWl0ZSsgXSBtZWRpYS90cmFjay90cmFjay1pbi1iYW5kLWN1 ZXMtYWRkZWQtb25jZS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLQogIyBGSVhNRTogTmVlZHMgYnVn emlsbGEgKDxyZGFyOi8vcHJvYmxlbS8xNjgwMjkwMD4pCiBbIFlvc2VtaXRlKyBdIGZhc3QvZm9y bXMvc2VsZWN0LWluaXRpYWwtcG9zaXRpb24uaHRtbCBbIEZhaWx1cmUgXQogCg==