<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>138795</bug_id>
          
          <creation_ts>2014-11-17 07:13:24 -0800</creation_ts>
          <short_desc>[WinCairo] Compile error, CoreGraphics header file included.</short_desc>
          <delta_ts>2014-11-17 10:58:57 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>peavo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>alex.christensen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mmaxfield</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1049187</commentid>
    <comment_count>0</comment_count>
    <who name="">peavo</who>
    <bug_when>2014-11-17 07:13:24 -0800</bug_when>
    <thetext>CoreGraphics is not available on WinCairo.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1049190</commentid>
    <comment_count>1</comment_count>
      <attachid>241710</attachid>
    <who name="">peavo</who>
    <bug_when>2014-11-17 07:18:55 -0800</bug_when>
    <thetext>Created attachment 241710
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1049195</commentid>
    <comment_count>2</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2014-11-17 07:39:23 -0800</bug_when>
    <thetext>Unofficial r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1049198</commentid>
    <comment_count>3</comment_count>
      <attachid>241710</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-11-17 07:52:15 -0800</bug_when>
    <thetext>Comment on attachment 241710
Patch

R=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1049208</commentid>
    <comment_count>4</comment_count>
    <who name="">peavo</who>
    <bug_when>2014-11-17 08:37:42 -0800</bug_when>
    <thetext>Thanks for reviewing :)

Does the patch also need a r+, or will it be committed anyway?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1049231</commentid>
    <comment_count>5</comment_count>
      <attachid>241710</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-11-17 10:21:20 -0800</bug_when>
    <thetext>Comment on attachment 241710
Patch

Grumble. I reviewed from my phone, and I guess I lost the r+ when I set the cq+. Setting both again!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1049235</commentid>
    <comment_count>6</comment_count>
    <who name="">peavo</who>
    <bug_when>2014-11-17 10:25:50 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; Comment on attachment 241710 [details]
&gt; Patch
&gt; 
&gt; Grumble. I reviewed from my phone, and I guess I lost the r+ when I set the
&gt; cq+. Setting both again!

Thanks :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1049250</commentid>
    <comment_count>7</comment_count>
      <attachid>241710</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-11-17 10:58:52 -0800</bug_when>
    <thetext>Comment on attachment 241710
Patch

Clearing flags on attachment: 241710

Committed r176210: &lt;http://trac.webkit.org/changeset/176210&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1049251</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-11-17 10:58:57 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>241710</attachid>
            <date>2014-11-17 07:18:55 -0800</date>
            <delta_ts>2014-11-17 10:58:52 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-138795-20141117161901.patch</filename>
            <type>text/plain</type>
            <size>1298</size>
            <attacher>peavo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjIwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTExLTE3ICBwZWF2b0Bv
dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29t
cGlsZSBlcnJvciwgQ29yZUdyYXBoaWNzIGhlYWRlciBmaWxlIGluY2x1ZGVkLgorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4Nzk1CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29yZUdyYXBoaWNzIGlzIG5v
dCBhdmFpbGFibGUgb24gV2luQ2Fpcm8uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93
aW4vRm9udENhY2hlV2luLmNwcDoKKwogMjAxNC0xMS0xNyAgRXJpYyBDYXJsc29uICA8ZXJpYy5j
YXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBhbGxvdyBob3N0IGFwcGxpY2F0aW9u
IHRvIG9wdC1vdXQgb2YgYWx0ZXJuYXRlIGZ1bGxzY3JlZW4KSW5kZXg6IFNvdXJjZS9XZWJDb3Jl
L3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9Gb250Q2FjaGVXaW4uY3BwCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv
dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9Gb250Q2FjaGVXaW4uY3BwCShyZXZp
c2lvbiAxNzYyMDApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vRm9u
dENhY2hlV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjcsNyArMjcsNiBAQAogICovCiAKICNp
bmNsdWRlICJjb25maWcuaCIKLSNpbmNsdWRlICJDb3JlR3JhcGhpY3NTUEkuaCIKICNpbmNsdWRl
IDx3aW5zb2NrMi5oPgogI2luY2x1ZGUgIkZvbnRDYWNoZS5oIgogI2luY2x1ZGUgIkZvbnQuaCIK
QEAgLTQyLDYgKzQxLDcgQEAKICNpbmNsdWRlIDx3dGYvd2luL0dESU9iamVjdC5oPgogCiAjaWYg
VVNFKENHKQorI2luY2x1ZGUgIkNvcmVHcmFwaGljc1NQSS5oIgogI2luY2x1ZGUgPEFwcGxpY2F0
aW9uU2VydmljZXMvQXBwbGljYXRpb25TZXJ2aWNlcy5oPgogI2luY2x1ZGUgPFdlYktpdFN5c3Rl
bUludGVyZmFjZS9XZWJLaXRTeXN0ZW1JbnRlcmZhY2UuaD4KICNlbmRpZgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>