138776 2014-11-16 04:57:03 -0800 AX: [ATK] REGRESSION(r166288): Accessible values are no longer accessible via AT-SPI2 2014-11-16 09:13:22 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Major --- 1 jdiggs jdiggs aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig mario samuel_white webkit-bug-importer oldest_to_newest 1049053 0 jdiggs 2014-11-16 04:57:03 -0800 This commit http://trac.webkit.org/changeset/166288 was a bit too enthusiastic: #if ATK_CHECK_VERSION(2,11,92) (new API) #else (old API) #end Turns out that AT-SPI2 doesn't yet support the new AtkValue API. [1] As a result, r166288 broke access to all WebKitGtk value widgets for AT-SPI2 ATs. :( [1] https://bugzilla.gnome.org/show_bug.cgi?id=740207 1049054 1 241681 jdiggs 2014-11-16 05:16:05 -0800 Created attachment 241681 Patch 1049055 2 webkit-bug-importer 2014-11-16 05:16:17 -0800 <rdar://problem/18995904> 1049056 3 webkit-bug-importer 2014-11-16 05:16:22 -0800 <rdar://problem/18995905> 1049064 4 241681 commit-queue 2014-11-16 09:13:17 -0800 Comment on attachment 241681 Patch Clearing flags on attachment: 241681 Committed r176163: <http://trac.webkit.org/changeset/176163> 1049065 5 commit-queue 2014-11-16 09:13:22 -0800 All reviewed patches have been landed. Closing bug. 241681 2014-11-16 05:16:05 -0800 2014-11-16 09:13:17 -0800 Patch bug-138776-20141116081615.patch text/plain 2954 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2MTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWMwODc5OGQ1ZjlkNWZk ZDc5MDg3M2Q0NWU1NTg3OGZkMTVlMjA1YS4uNzBjNzYzNzBhYjI0OWNiNDFhMGQ4NjNmODczZDRj MGZkMDZmNzU0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTExLTE2ICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBBWDogW0FUS10gUkVH UkVTU0lPTihyMTY2Mjg4KTogQWNjZXNzaWJsZSB2YWx1ZXMgYXJlIG5vIGxvbmdlciBhY2Nlc3Np YmxlIHZpYSBBVC1TUEkyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzg3NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICByMTY2Mjg4IHVzZWQgI2lmLi4uI2Vsc2UgaW5zdGVhZCBvZiAjaWYuLi4jZW5kaWYs IHRodXMgZGlzYWJsaW5nIHRoZSBvbGQKKyAgICAgICAgQXRrVmFsdWUgc3VwcG9ydC4gVW5mb3J0 dW5hdGVseSBBVC1TUEkyIGRvZXNuJ3QgeWV0IGhhdmUgc3VwcG9ydCBmb3IgdGhlCisgICAgICAg IG5ldyBBdGtWYWx1ZSBBUEkuIFRodXMgcjE2NjI4OCBicm9rZSBhY2Nlc3MgdG8gdmFsdWUtaG9s ZGluZyBlbGVtZW50cyBmb3IKKyAgICAgICAgQVQtU1BJMiBhc3Npc3RpdmUgdGVjaG5vbG9naWVz LiBSZXBsYWNpbmcgI2Vsc2Ugd2l0aCAjZW5kaWYgZml4ZXMgdGhpbmdzLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cyBiZWNhdXNlIGNhdGNoaW5nIHRoaXMgcmVncmVzc2lvbiB3b3VsZCByZXF1aXJl IEFULVNQSTIuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxl SW50ZXJmYWNlVmFsdWUuY3BwOgorICAgICAgICAod2Via2l0QWNjZXNzaWJsZVZhbHVlR2V0TWlu aW11bUluY3JlbWVudCk6CisgICAgICAgICh3ZWJraXRBY2Nlc3NpYmxlVmFsdWVJbnRlcmZhY2VJ bml0KToKKwogMjAxNC0xMS0xNSAgSm9hbm1hcmllIERpZ2dzICA8amRpZ2dzQGlnYWxpYS5jb20+ CiAKICAgICAgICAgQVg6IFtBVEtdIExpc3RzIHdpdGggc2VsZWN0YWJsZSBjaGlsZHJlbiBzaG91 bGQgaGF2ZSBBVEtfUk9MRV9MSVNUX0JPWApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFjZVZhbHVlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VWYWx1 ZS5jcHAKaW5kZXggMTg0ZWQ0YmY3MzkxMzllZWFjMTA2YmMxMDkxYmE4MGFkMDFhNGE4ZC4uYWM1 ODJmYTY2OTdkOTk0YjlmZGQ4YjVlZjI1NzkwMGFlZTYwZGRlYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFjZVZhbHVl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3Np YmxlSW50ZXJmYWNlVmFsdWUuY3BwCkBAIC0xMTQsNyArMTE0LDcgQEAgc3RhdGljIEF0a1Jhbmdl KiB3ZWJraXRBY2Nlc3NpYmxlR2V0UmFuZ2UoQXRrVmFsdWUqIHZhbHVlKQogICAgIGdjaGFyKiB2 YWx1ZURlc2NyaXB0aW9uID0gZ19zdHJkdXBfcHJpbnRmKCIlcyIsIGNvcmVPYmplY3QtPnZhbHVl RGVzY3JpcHRpb24oKS51dGY4KCkuZGF0YSgpKTsKICAgICByZXR1cm4gYXRrX3JhbmdlX25ldyht aW5WYWx1ZSwgbWF4VmFsdWUsIHZhbHVlRGVzY3JpcHRpb24pOwogfQotI2Vsc2UKKyNlbmRpZgog c3RhdGljIHZvaWQgd2Via2l0QWNjZXNzaWJsZVZhbHVlR2V0Q3VycmVudFZhbHVlKEF0a1ZhbHVl KiB2YWx1ZSwgR1ZhbHVlKiBnVmFsdWUpCiB7CiAgICAgZ19yZXR1cm5faWZfZmFpbChBVEtfVkFM VUUodmFsdWUpKTsKQEAgLTE4NCw3ICsxODQsNiBAQCBzdGF0aWMgdm9pZCB3ZWJraXRBY2Nlc3Np YmxlVmFsdWVHZXRNaW5pbXVtSW5jcmVtZW50KEF0a1ZhbHVlKiB2YWx1ZSwgR1ZhbHVlKiBnVgog ICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIGNvcmVPYmplY3QgPSBjb3JlKHZhbHVlKTsKICAgICBn X3ZhbHVlX3NldF9mbG9hdChnVmFsdWUsIHdlYmtpdEFjY2Vzc2libGVHZXRJbmNyZW1lbnRWYWx1 ZShjb3JlT2JqZWN0KSk7CiB9Ci0jZW5kaWYKIAogdm9pZCB3ZWJraXRBY2Nlc3NpYmxlVmFsdWVJ bnRlcmZhY2VJbml0KEF0a1ZhbHVlSWZhY2UqIGlmYWNlKQogewpAQCAtMTkzLDEzICsxOTIsMTIg QEAgdm9pZCB3ZWJraXRBY2Nlc3NpYmxlVmFsdWVJbnRlcmZhY2VJbml0KEF0a1ZhbHVlSWZhY2Uq IGlmYWNlKQogICAgIGlmYWNlLT5nZXRfaW5jcmVtZW50ID0gd2Via2l0QWNjZXNzaWJsZUdldElu Y3JlbWVudDsKICAgICBpZmFjZS0+c2V0X3ZhbHVlID0gd2Via2l0QWNjZXNzaWJsZVNldFZhbHVl OwogICAgIGlmYWNlLT5nZXRfcmFuZ2UgPSB3ZWJraXRBY2Nlc3NpYmxlR2V0UmFuZ2U7Ci0jZWxz ZQorI2VuZGlmCiAgICAgaWZhY2UtPmdldF9jdXJyZW50X3ZhbHVlID0gd2Via2l0QWNjZXNzaWJs ZVZhbHVlR2V0Q3VycmVudFZhbHVlOwogICAgIGlmYWNlLT5nZXRfbWF4aW11bV92YWx1ZSA9IHdl YmtpdEFjY2Vzc2libGVWYWx1ZUdldE1heGltdW1WYWx1ZTsKICAgICBpZmFjZS0+Z2V0X21pbmlt dW1fdmFsdWUgPSB3ZWJraXRBY2Nlc3NpYmxlVmFsdWVHZXRNaW5pbXVtVmFsdWU7CiAgICAgaWZh Y2UtPnNldF9jdXJyZW50X3ZhbHVlID0gd2Via2l0QWNjZXNzaWJsZVZhbHVlU2V0Q3VycmVudFZh bHVlOwogICAgIGlmYWNlLT5nZXRfbWluaW11bV9pbmNyZW1lbnQgPSB3ZWJraXRBY2Nlc3NpYmxl VmFsdWVHZXRNaW5pbXVtSW5jcmVtZW50OwotI2VuZGlmCiB9CiAKICNlbmRpZgo=