138746 2014-11-14 11:08:42 -0800 URLs for some videos are not valid URLs, should not be exposed to action menu 2014-11-14 11:13:22 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned andersca bdakin thorton oldest_to_newest 1048795 0 bdakin 2014-11-14 11:08:42 -0800 URLs for some videos are not valid URLs, should not be exposed to action menu rdar://problem/18941927 1048796 1 241599 bdakin 2014-11-14 11:10:36 -0800 Created attachment 241599 Patch 1048797 2 bdakin 2014-11-14 11:13:22 -0800 http://trac.webkit.org/changeset/176131 Thank you! 241599 2014-11-14 11:10:36 -0800 2014-11-14 11:11:53 -0800 Patch for-review.txt text/plain 3313 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjEzMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTExLTE0ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBVUkxzIGZvciBzb21lIHZpZGVvcyBh cmUgbm90IHZhbGlkIFVSTHMsIHNob3VsZCBub3QgYmUgZXhwb3NlZCB0byBhY3Rpb24gbWVudQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NzQ2Cisg ICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMTg5NDE5 MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiB0 aGUgdmlkZW8gY2Fubm90IGJlIGRvd25sb2FkZWQsIHRoYXQgaXMgYWxzbyBhbiBpbmRpY2F0aW9u IHRoYXQgdGhlIFVSTCBvZiB0aGUgCisgICAgICAgIHZpZGVvIHdpbGwgbm90IGJlIHZhbGlkIG9u IGl0cyBvd24uIEluIHRoZXNlIGNhc2VzLCB3ZSBzaG91bGQgc2hhcmUgb3IgY29weSB0aGUgCisg ICAgICAgIG1haW4gcGFnZeKAmXMgVVJMLgorICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tBY3Rp b25NZW51Q29udHJvbGxlci5tbToKKyAgICAgICAgKC1bV0tBY3Rpb25NZW51Q29udHJvbGxlciBf ZGVmYXVsdE1lbnVJdGVtc0ZvclZpZGVvXSk6CisgICAgICAgICgtW1dLQWN0aW9uTWVudUNvbnRy b2xsZXIgX2NvcHlWaWRlb1VSTDpdKToKKwogMjAxNC0xMS0xNCAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1NPVVBdIEVuY29kZS9EZWNvZGUg YWxsb3dDb29raWVzIGluIFJlc291cmNlUmVxdWVzdApJbmRleDogU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL21hYy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tBY3Rpb25NZW51Q29udHJvbGxlci5tbQkocmV2aXNp b24gMTc2MTE1KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0FjdGlvbk1lbnVD b250cm9sbGVyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00MjMsMTcgKzQyMywxOCBAQCAtIChOU0Fy cmF5ICopX2RlZmF1bHRNZW51SXRlbXNGb3JWaWRlbwogewogICAgIFJldGFpblB0cjxOU01lbnVJ dGVtPiBjb3B5VmlkZW9VUkxJdGVtID0gW3NlbGYgX2NyZWF0ZUFjdGlvbk1lbnVJdGVtRm9yVGFn OmtXS0NvbnRleHRBY3Rpb25JdGVtVGFnQ29weVZpZGVvVVJMXTsKIAotICAgIFJldGFpblB0cjxO U01lbnVJdGVtPiBzYXZlVG9Eb3dubG9hZHNJdGVtOwogICAgIFJlZlB0cjxXZWJIaXRUZXN0UmVz dWx0PiBoaXRUZXN0UmVzdWx0ID0gW3NlbGYgX3dlYkhpdFRlc3RSZXN1bHRdOwotICAgIGlmICho aXRUZXN0UmVzdWx0LT5pc0Rvd25sb2FkYWJsZU1lZGlhKCkpCi0gICAgICAgIHNhdmVUb0Rvd25s b2Fkc0l0ZW0gPSBbc2VsZiBfY3JlYXRlQWN0aW9uTWVudUl0ZW1Gb3JUYWc6a1dLQ29udGV4dEFj dGlvbkl0ZW1UYWdTYXZlVmlkZW9Ub0Rvd25sb2Fkc107Ci0gICAgZWxzZQotICAgICAgICBzYXZl VG9Eb3dubG9hZHNJdGVtID0gW05TTWVudUl0ZW0gc2VwYXJhdG9ySXRlbV07Ci0KKyAgICBSZXRh aW5QdHI8TlNNZW51SXRlbT4gc2F2ZVRvRG93bmxvYWRzSXRlbSA9IFtzZWxmIF9jcmVhdGVBY3Rp b25NZW51SXRlbUZvclRhZzprV0tDb250ZXh0QWN0aW9uSXRlbVRhZ1NhdmVWaWRlb1RvRG93bmxv YWRzXTsKICAgICBSZXRhaW5QdHI8TlNNZW51SXRlbT4gc2hhcmVJdGVtID0gW3NlbGYgX2NyZWF0 ZUFjdGlvbk1lbnVJdGVtRm9yVGFnOmtXS0NvbnRleHRBY3Rpb25JdGVtVGFnU2hhcmVWaWRlb107 Ci0gICAgU3RyaW5nIHZpZGVvVVJMID0gaGl0VGVzdFJlc3VsdC0+YWJzb2x1dGVNZWRpYVVSTCgp OwotICAgIGlmICghdmlkZW9VUkwuaXNFbXB0eSgpKSB7Ci0gICAgICAgIF9zaGFyaW5nU2Vydmlj ZVBpY2tlciA9IGFkb3B0TlMoW1tOU1NoYXJpbmdTZXJ2aWNlUGlja2VyIGFsbG9jXSBpbml0V2l0 aEl0ZW1zOkBbIHZpZGVvVVJMIF1dKTsKKworICAgIFN0cmluZyB1cmxUb1NoYXJlID0gaGl0VGVz dFJlc3VsdC0+YWJzb2x1dGVNZWRpYVVSTCgpOworICAgIGlmICghaGl0VGVzdFJlc3VsdC0+aXNE b3dubG9hZGFibGVNZWRpYSgpKSB7CisgICAgICAgIFtzYXZlVG9Eb3dubG9hZHNJdGVtIHNldEVu YWJsZWQ6Tk9dOworICAgICAgICB1cmxUb1NoYXJlID0gX3BhZ2UtPm1haW5GcmFtZSgpLT51cmwo KTsKKyAgICB9CisKKyAgICBpZiAoIXVybFRvU2hhcmUuaXNFbXB0eSgpKSB7CisgICAgICAgIF9z aGFyaW5nU2VydmljZVBpY2tlciA9IGFkb3B0TlMoW1tOU1NoYXJpbmdTZXJ2aWNlUGlja2VyIGFs bG9jXSBpbml0V2l0aEl0ZW1zOkBbIHVybFRvU2hhcmUgXV0pOwogICAgICAgICBbX3NoYXJpbmdT ZXJ2aWNlUGlja2VyIHNldERlbGVnYXRlOnNlbGZdOwogICAgICAgICBbc2hhcmVJdGVtIHNldFN1 Ym1lbnU6W19zaGFyaW5nU2VydmljZVBpY2tlciBtZW51XV07CiAgICAgfQpAQCAtNDQ0LDkgKzQ0 NSwxMiBAQCAtIChOU0FycmF5ICopX2RlZmF1bHRNZW51SXRlbXNGb3JWaWRlbwogLSAodm9pZClf Y29weVZpZGVvVVJMOihpZClzZW5kZXIKIHsKICAgICBSZWZQdHI8V2ViSGl0VGVzdFJlc3VsdD4g aGl0VGVzdFJlc3VsdCA9IFtzZWxmIF93ZWJIaXRUZXN0UmVzdWx0XTsKKyAgICBTdHJpbmcgdXJs VG9Db3B5ID0gaGl0VGVzdFJlc3VsdC0+YWJzb2x1dGVNZWRpYVVSTCgpOworICAgIGlmICghaGl0 VGVzdFJlc3VsdC0+aXNEb3dubG9hZGFibGVNZWRpYSgpKQorICAgICAgICB1cmxUb0NvcHkgPSBf cGFnZS0+bWFpbkZyYW1lKCktPnVybCgpOwogCiAgICAgW1tOU1Bhc3RlYm9hcmQgZ2VuZXJhbFBh c3RlYm9hcmRdIGNsZWFyQ29udGVudHNdOwotICAgIFtbTlNQYXN0ZWJvYXJkIGdlbmVyYWxQYXN0 ZWJvYXJkXSB3cml0ZU9iamVjdHM6QFsgaGl0VGVzdFJlc3VsdC0+YWJzb2x1dGVNZWRpYVVSTCgp IF1dOworICAgIFtbTlNQYXN0ZWJvYXJkIGdlbmVyYWxQYXN0ZWJvYXJkXSB3cml0ZU9iamVjdHM6 QFsgdXJsVG9Db3B5IF1dOwogfQogCiAtICh2b2lkKV9zYXZlVmlkZW9Ub0Rvd25sb2FkczooaWQp c2VuZGVyCg==